Re: [RESEND][PATCH] Add /proc/mempool to display mempool usage

2008-11-29 Thread Greg KH
On Sun, Nov 30, 2008 at 12:42:07AM +0300, Alexey Dobriyan wrote: On Sat, Nov 29, 2008 at 06:44:49PM +0100, Remi Colinet wrote: This patch add a new /proc/mempool file in order to display mempool usage. The feature can be disabled with CONFIG_PROC_MEMPOOL=N during kernel configuration.

Re: [PATCH 3/3] p9auth: add p9auth driver

2010-04-20 Thread Greg KH
On Tue, Apr 20, 2010 at 08:29:08PM -0500, Serge E. Hallyn wrote: This is a driver that adds Plan 9 style capability device implementation. See Documentation/p9auth.txt for a description of how to use this. Hm, you didn't originally write this driver, so it would be good to get some original

Re: [PATCH v1 00/12] netoops support

2010-11-03 Thread Greg KH
On Tue, Nov 02, 2010 at 08:37:42PM -0700, Mike Waychison wrote: On Tue, Nov 2, 2010 at 7:34 PM, Greg KH g...@kroah.com wrote: On Tue, Nov 02, 2010 at 06:29:25PM -0700, Mike Waychison wrote: This patchset applies to v2.6.36. The following series implements support for 'netoops', a simple

Re: [PATCH v2 12/23] netpoll: Introduce netpoll_target configs

2010-11-09 Thread Greg KH
On Tue, Nov 09, 2010 at 05:06:45PM +0800, Am??rico Wang wrote: On Tue, Nov 09, 2010 at 12:34:24AM -0800, Mike Waychison wrote: On Mon, Nov 8, 2010 at 8:27 PM, Am??rico Wang xiyou.wangc...@gmail.com wrote: On Tue, Nov 09, 2010 at 11:30:24AM +0800, Am??rico Wang wrote: So, either

Re: [PATCH v1 2/5] firmware: Basic dmi-sysfs support

2011-02-17 Thread Greg KH
Overall, this looks great, just a few minor comments below: On Thu, Feb 17, 2011 at 01:28:05PM -0800, Mike Waychison wrote: +config DMI_SYSFS + tristate DMI table support in sysfs + depends on SYSFS DMI + default X86 Huh? Default should be 'N' for any new feature, unless it

Re: [PATCH v2 2/5] firmware: Basic dmi-sysfs support

2011-02-25 Thread Greg KH
On Wed, Feb 23, 2011 at 01:29:46PM -0800, Tony Luck wrote: On Wed, Feb 23, 2011 at 12:28 PM, Mike Waychison mi...@google.com wrote: Ya, I don't think there is anything that guarantees that dmi_header is aligned.   The access is probably the struct copy I did here:        /* Set the key */

Re: [PATCH v2 0/5] Exporting DMI entries via sysfs

2011-02-25 Thread Greg KH
On Tue, Feb 22, 2011 at 05:53:07PM -0800, Mike Waychison wrote: This patchset applies to v2.6.38-rc6. The following series exports information the DMI / SMBIOS tables via sysfs under the path /sys/firmware/dmi. Looks good, all queued up now, thanks for following through with this. greg k-h

Re: [PATCH v2 6/5] Fix unaligned memory accesses in dmi-sysfs

2011-02-25 Thread Greg KH
On Fri, Feb 25, 2011 at 03:06:25PM -0800, Mike Waychison wrote: DMI entries are arranged in memory back to back with no alignment guarantees. This means that the struct dmi_header passed to callbacks from dmi_walk() itself isn't byte aligned. This causes problems on architectures that expect

Re: [PATCH v3] introduce sys_syncfs to sync a single file system

2011-03-12 Thread Greg KH
On Fri, Mar 11, 2011 at 08:10:01PM -0600, Jonathan Nieder wrote: Indan Zupancic wrote: I'm not pushing for any official convention, just what seems good taste. In cases like this, conventions (consistency and best practices) are very important. Less code added, less bloat.

Re: [PATCH 1/1] posix-timers: Show clock ID in proc file

2013-05-17 Thread Greg KH
On Fri, May 17, 2013 at 02:12:03AM +0400, Pavel Tikhomirov wrote: Expand information about posix-timers in /proc/pid/timers by adding info about clock, with which the timer was created. I.e. in the forth line of timer info after notify: line go ClockID: clock_id. Signed-off-by: Pavel

Re: [PATCH] Change userspace MKDEV, MAJOR, MINOR-macros from 8+8 bit, to 12+20 bit layout

2014-09-14 Thread Greg KH
On Sun, Sep 14, 2014 at 07:35:28PM +0200, Stephan Müller wrote: Delete old userspace-only versions (8+8 bit). Instead expose the kernel-space definitions (12+20 bit). Signed-off-by: Stephan Mueller frukto...@gmail.com --- Browsing some code I found that user-space and kernel-space macros

Re: [PATCH v3 4/6] tpm: TPM 2.0 sysfs attributes

2014-10-16 Thread Greg KH
On Wed, Oct 15, 2014 at 01:35:14PM +0200, Jarkko Sakkinen wrote: +int tpm2_sysfs_add_device(struct tpm_chip *chip) +{ + struct pcr_bank *pcr_bank; + struct kobject *pcrs_kobj; + struct device *dev = chip-dev; + int rc; + + rc =

Re: [PATCH 00/12] Add kdbus implementation

2014-10-29 Thread Greg KH
On Wed, Oct 29, 2014 at 03:00:44PM -0700, Greg Kroah-Hartman wrote: kdbus is a kernel-level IPC implementation that aims for resemblance to the the protocol layer with the existing userspace D-Bus daemon while enabling some features that couldn't be implemented before in userspace. {sigh}

Re: [RFC PATCH 0/5] kdbus: add support for lsm

2014-11-07 Thread Greg KH
On Fri, Oct 31, 2014 at 05:36:32PM +0100, Karol Lewandowski wrote: This is set of EXPERIMENTAL patches adding lsm support to kdbus. (Rebased on top of v3.17.) From least to most invasive: - (1) kdbus: extend structures with security pointer for lsm Trivial. Applicable as-is. -

Re: [PATCH 1/5] kdbus: extend structures with security pointer for lsm

2014-11-17 Thread Greg KH
On Mon, Nov 17, 2014 at 02:47:32AM +0100, Karol Lewandowski wrote: On Fri, Oct 31, 2014 at 05:36:33PM +0100, Karol Lewandowski wrote: Signed-off-by: Karol Lewandowski k.lewando...@samsung.com --- drivers/misc/kdbus/bus.h| 2 ++ drivers/misc/kdbus/connection.h | 2 ++

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread Greg KH
On Mon, Nov 24, 2014 at 08:05:10AM -0800, Josh Triplett wrote: On Mon, Nov 24, 2014 at 10:49:31AM +0100, Pieter Smith wrote: On Sun, Nov 23, 2014 at 03:23:02PM -0800, Josh Triplett wrote: On Sun, Nov 23, 2014 at 11:29:08PM +0100, Richard Weinberger wrote: On Sun, Nov 23, 2014 at 3:20 PM,

Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice

2014-11-24 Thread Greg KH
On Mon, Nov 24, 2014 at 12:14:50PM -0800, j...@joshtriplett.org wrote: I would, again, argue that stuff like __splice_p() not be implemented at all please. It will only cause a huge proliferation of stuff like this that will not make any sense, and only cause a trivial, if any, amount of

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-25 Thread Greg KH
On Tue, Nov 25, 2014 at 08:16:58PM +0800, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. Signed-off-by: Chunyan Zhang chunyan.zh...@spreadtrum.com Signed-off-by: Orson Zhai

Re: selftests: question about git repos containing selftest.

2014-12-09 Thread Greg KH
On Tue, Dec 09, 2014 at 02:22:42PM -0500, Young, David wrote: Greetings, I'm trying out the new kernel selftests and was looking for the bleeding edge repository to clone. According to the wiki https://kselftest.wiki.kernel.org/ this is the appropriate repo:

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-07 Thread Greg KH
On Fri, Feb 06, 2015 at 03:41:58PM +, Bryn M. Reeves wrote: On Fri, Feb 06, 2015 at 04:59:16AM -0800, Greg KH wrote: On Fri, Feb 06, 2015 at 12:20:53AM +, Seymour, Shane M wrote: The current patch that implements tape statistics is here: http://marc.info/?l=linux-scsim

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-06 Thread Greg KH
On Fri, Feb 06, 2015 at 09:13:55AM +, Bryn M. Reeves wrote: The sysfs documentation says that files should contain one item per file (with some small exceptions): Attributes should be ASCII text files, preferably with only one value per file. It is noted that it may not be

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-06 Thread Greg KH
On Fri, Feb 06, 2015 at 12:20:53AM +, Seymour, Shane M wrote: Hello linux-api'ers There has been some ongoing discussion about the best way to implement tape statistics. The original method suggested a long time ago used a single file in sysfs similar to block statistics in sysfs. That

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-07 Thread Greg KH
On Sat, Feb 07, 2015 at 09:27:05PM -0500, Laurence Oberman wrote: Hello Its not going to be tens of thousands of devices. That count was an aggregate based on 1000's of servers. In reality its unlikely to ever be more than 100 tapes drives per individual Linux kernel instance. Therefore

Re: [PATCH v8 0/2] Add Spreadtrum SoC bindings and serial driver support

2015-01-27 Thread Greg KH
On Tue, Jan 27, 2015 at 02:24:02PM +0100, Arnd Bergmann wrote: On Tuesday 27 January 2015 15:56:45 Chunyan Zhang wrote: This patch-set split the last version, and addressed the review comments from last version on serial driver code. Changes from v7: * Addressed review comments from

Re: [PATCH v4 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-09 Thread Greg KH
On Thu, Dec 04, 2014 at 07:34:20PM +0800, Chunyan Zhang wrote: --- a/include/uapi/linux/serial_core.h +++ b/include/uapi/linux/serial_core.h @@ -247,4 +247,7 @@ /* MESON */ #define PORT_MESON 109 +/* SPRD SERIAL */ +#define PORT_SPRD 110 Please use a tab here, like all other

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-10 Thread Greg KH
On Tue, Feb 10, 2015 at 02:27:20PM +, Bryn M. Reeves wrote: On Sat, Feb 07, 2015 at 12:07:43PM +0800, Greg KH wrote: $ cat /sys/fs/selinux/avc/cache_stats lookups hits misses allocations reclaims frees 18938916 18921707 17209 17209 17328 22215 38164283 38146514 17769 17769 16800 19049

Re: [PATCH] add support for Freescale's MMA8653FC 10 bit accelerometer

2015-03-17 Thread Greg KH
On Tue, Mar 17, 2015 at 06:09:06PM +0100, Martin Kepplinger wrote: From: Martin Kepplinger martin.kepplin...@theobroma-systems.com Signed-off-by: Martin Kepplinger martin.kepplin...@theobroma-systems.com Signed-off-by: Christoph Muellner christoph.muell...@theobroma-systems.com ---

Re: [PATCH] coresight: moving to new hwtracing directory

2015-03-19 Thread Greg KH
On Thu, Mar 19, 2015 at 04:02:02PM -0600, Mathieu Poirier wrote: Keeping drivers related to HW tracing on ARM, i.e coresight, under drivers/coresight doesn't make sense when other architectures start rolling out technologies of the same nature. As such creating a new drivers/hwtracing

Re: [PATCH] coresight: moving to new hwtracing directory

2015-03-20 Thread Greg KH
On Thu, Mar 19, 2015 at 06:21:56PM -0600, Mathieu Poirier wrote: On 19 March 2015 at 16:27, Greg KH gre...@linuxfoundation.org wrote: On Thu, Mar 19, 2015 at 04:02:02PM -0600, Mathieu Poirier wrote: Keeping drivers related to HW tracing on ARM, i.e coresight, under drivers/coresight doesn't

Re: [PATCH 01/86] pci: export pci_ids.h

2015-03-30 Thread Greg KH
On Mon, Mar 30, 2015 at 08:48:44AM +0200, Michael S. Tsirkin wrote: On Sun, Mar 29, 2015 at 10:40:47PM +0200, Greg KH wrote: On Sun, Mar 29, 2015 at 03:37:01PM +0200, Michael S. Tsirkin wrote: The macros in pci_ids.h are pretty useful for userspace using the pci sysfs interface

Re: [PATCH 01/86] pci: export pci_ids.h

2015-03-30 Thread Greg KH
On Mon, Mar 30, 2015 at 10:31:54AM +0200, Michael S. Tsirkin wrote: On Mon, Mar 30, 2015 at 09:53:31AM +0200, Greg KH wrote: On Mon, Mar 30, 2015 at 09:15:26AM +0200, Michael S. Tsirkin wrote: On Mon, Mar 30, 2015 at 08:55:22AM +0200, Greg KH wrote: On Mon, Mar 30, 2015 at 08:48:44AM

Re: [PATCH 01/86] pci: export pci_ids.h

2015-03-30 Thread Greg KH
On Mon, Mar 30, 2015 at 09:15:26AM +0200, Michael S. Tsirkin wrote: On Mon, Mar 30, 2015 at 08:55:22AM +0200, Greg KH wrote: On Mon, Mar 30, 2015 at 08:48:44AM +0200, Michael S. Tsirkin wrote: On Sun, Mar 29, 2015 at 10:40:47PM +0200, Greg KH wrote: On Sun, Mar 29, 2015 at 03:37:01PM

Re: [PATCH 01/86] pci: export pci_ids.h

2015-03-30 Thread Greg KH
On Mon, Mar 30, 2015 at 12:46:36PM +0200, Michael S. Tsirkin wrote: Sorry about keeping this thread alive, I'm just trying to wrap my head around what you consider a sane API. Linux used not to export headers automatically, generally. It used to be just use libc. Why is this header

Re: [PATCH 01/86] pci: export pci_ids.h

2015-03-30 Thread Greg KH
On Mon, Mar 30, 2015 at 01:19:14PM +0200, Michael S. Tsirkin wrote: Why there much more that two packages, I can find at least 5 copies in the wild. Why? I think it's because it's part of linux ABI that doesn't have matching headers. People are asked to build their own, so of course they copy

Re: [PATCH] selftests: Change memory on-off-test.sh name to be unique

2015-04-01 Thread Greg KH
On Tue, Mar 31, 2015 at 06:10:59PM -0600, Shuah Khan wrote: cpu and memory hotplug scripts use the same name. Change memory on-off-test.sh to mem-on-off-test.sh. Signed-off-by: Shuah Khan shua...@osg.samsung.com --- tools/testing/selftests/memory-hotplug/Makefile| 6 +-

Re: [PATCH] selftest: change cpu on-off-test.sh name to be unique

2015-04-01 Thread Greg KH
On Tue, Mar 31, 2015 at 06:10:31PM -0600, Shuah Khan wrote: cpu and memory hotplug scripts use the same name. Change cpu on-off-test.sh to cpu-on-off-test.sh. Signed-off-by: Shuah Khan shua...@osg.samsung.com --- tools/testing/selftests/cpu-hotplug/Makefile | 4 +-

Re: [PATCH 01/86] pci: export pci_ids.h

2015-03-29 Thread Greg KH
On Sun, Mar 29, 2015 at 03:37:01PM +0200, Michael S. Tsirkin wrote: The macros in pci_ids.h are pretty useful for userspace using the pci sysfs interface. At the moment userspace is forced to duplicate these macros (e.g. QEMU does this), it is better to expose them in

Re: [PATCH v5] add support for Freescale's MMA8653FC 10 bit accelerometer

2015-03-26 Thread Greg KH
On Sat, Mar 21, 2015 at 12:26:04PM +0100, Martin Kepplinger wrote: From: Martin Kepplinger martin.kepplin...@theobroma-systems.com The MMA8653FC is a low-power, three-axis, capacitive micromachined accelerometer with 10 bits of resolution with flexible user-programmable options. Embedded

Re: [PATCH v2] coresight: moving to new hwtracing directory

2015-03-26 Thread Greg KH
On Fri, Mar 20, 2015 at 11:01:23AM -0600, Mathieu Poirier wrote: Keeping drivers related to HW tracing on ARM, i.e coresight, under drivers/coresight doesn't make sense when other architectures start rolling out technologies of the same nature. As such creating a new drivers/hwtracing

Re: [PATCH v2] pci: export class IDs from pci_ids.h

2015-04-02 Thread Greg KH
On Thu, Apr 02, 2015 at 11:28:19PM +0200, Michael S. Tsirkin wrote: On Thu, Apr 02, 2015 at 03:53:47PM -0500, Bjorn Helgaas wrote: On Mon, Mar 30, 2015 at 01:33:28PM +0200, Michael S. Tsirkin wrote: The basic class ID macros in pci_ids.h are pretty useful for userspace using the pci sysfs

Re: [PATCH v2 3/4] of: overlay: Add sysfs attributes

2015-04-23 Thread Greg KH
On Thu, Apr 23, 2015 at 03:39:21PM +0300, Pantelis Antoniou wrote: Hi Greg, On Apr 23, 2015, at 15:33 , Greg KH g...@kroah.com wrote: On Thu, Apr 23, 2015 at 03:00:03PM +0300, Pantelis Antoniou wrote: Hi Rob, On Apr 15, 2015, at 04:27 , Rob Herring robherri...@gmail.com wrote

Re: [PATCH v2 3/4] of: overlay: Add sysfs attributes

2015-04-23 Thread Greg KH
On Thu, Apr 23, 2015 at 03:59:02PM +0300, Pantelis Antoniou wrote: It’s the same reason that the device tree core is using it. It is doing that for raw device tree files, not individual attributes, right? Each property of a device tree is a binary attribute. Because they

Re: [PATCH v2 3/4] of: overlay: Add sysfs attributes

2015-04-23 Thread Greg KH
On Thu, Apr 23, 2015 at 03:00:03PM +0300, Pantelis Antoniou wrote: Hi Rob, On Apr 15, 2015, at 04:27 , Rob Herring robherri...@gmail.com wrote: On Tue, Apr 7, 2015 at 2:23 PM, Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Implement a number of sysfs attributes for overlays.

Re: [PATCH v3 2/4] of: overlay: global sysfs enable attribute

2015-04-24 Thread Greg KH
On Fri, Apr 24, 2015 at 12:45:42PM +0300, Pantelis Antoniou wrote: A throw once master enable switch to protect against any further overlay applications if the administrator desires so. Signed-off-by: Pantelis Antoniou pantelis.anton...@konsulko.com --- drivers/of/overlay.c | 45

Re: [PATCH v3 4/4] Documentation: ABI: /sys/firmware/devicetree/overlays

2015-04-24 Thread Greg KH
On Fri, Apr 24, 2015 at 12:45:44PM +0300, Pantelis Antoniou wrote: Documentation ABI entry for overlays sysfs entries. Signed-off-by: Pantelis Antoniou pantelis.anton...@konsulko.com --- .../ABI/testing/sysfs-firmware-devicetree-overlays | 23 ++ 1 file changed, 23

Re: [PATCH v3 2/4] of: overlay: global sysfs enable attribute

2015-04-24 Thread Greg KH
On Fri, Apr 24, 2015 at 12:45:42PM +0300, Pantelis Antoniou wrote: A throw once master enable switch to protect against any further overlay applications if the administrator desires so. Signed-off-by: Pantelis Antoniou pantelis.anton...@konsulko.com --- drivers/of/overlay.c | 45

Re: [RFC v2 1/4] fs: Add generic file system event notifications

2015-04-28 Thread Greg KH
On Tue, Apr 28, 2015 at 03:56:53PM +0200, Jan Kara wrote: On Mon 27-04-15 17:37:11, Greg KH wrote: On Mon, Apr 27, 2015 at 05:08:27PM +0200, Beata Michalska wrote: On 04/27/2015 04:24 PM, Greg KH wrote: On Mon, Apr 27, 2015 at 01:51:41PM +0200, Beata Michalska wrote: Introduce

Re: [PATCH] usb: core: add usb3 lpm sysfs

2015-04-28 Thread Greg KH
On Wed, Apr 29, 2015 at 12:51:27AM +0800, Zhuang Jin Can wrote: Hi Greg KH, On Tue, Apr 28, 2015 at 12:42:24PM +0200, Greg KH wrote: On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote: Some usb3 devices may not support usb3 lpm well. The patch adds a sysfs to enable/disable

Re: [PATCH] usb: core: add usb3 lpm sysfs

2015-04-29 Thread Greg KH
On Thu, Apr 30, 2015 at 12:21:32AM +0800, Zhuang Jin Can wrote: On Wed, Apr 29, 2015 at 01:06:22PM +0200, Greg KH wrote: On Wed, Apr 29, 2015 at 06:57:30PM +0800, Zhuang Jin Can wrote: On Wed, Apr 29, 2015 at 11:01:48AM +0200, Greg KH wrote: On Wed, Apr 29, 2015 at 03:20:04PM +0800

Re: [RFC v2 1/4] fs: Add generic file system event notifications

2015-04-27 Thread Greg KH
On Mon, Apr 27, 2015 at 01:51:41PM +0200, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications, to provide file systems with a common way of reporting any potential issues as they emerge. The notifications are to be issued through generic

Re: [RFC v2 1/4] fs: Add generic file system event notifications

2015-04-27 Thread Greg KH
On Mon, Apr 27, 2015 at 05:08:27PM +0200, Beata Michalska wrote: On 04/27/2015 04:24 PM, Greg KH wrote: On Mon, Apr 27, 2015 at 01:51:41PM +0200, Beata Michalska wrote: Introduce configurable generic interface for file system-wide event notifications, to provide file systems with a common

Re: [RFC v2 1/4] fs: Add generic file system event notifications

2015-04-28 Thread Greg KH
On Tue, Apr 28, 2015 at 04:46:46PM +0200, Beata Michalska wrote: On 04/28/2015 04:09 PM, Greg KH wrote: On Tue, Apr 28, 2015 at 03:56:53PM +0200, Jan Kara wrote: On Mon 27-04-15 17:37:11, Greg KH wrote: On Mon, Apr 27, 2015 at 05:08:27PM +0200, Beata Michalska wrote: On 04/27/2015 04:24

Re: [PATCH v3 2/4] of: overlay: global sysfs enable attribute

2015-04-27 Thread Greg KH
On Mon, Apr 27, 2015 at 09:13:56PM +0300, Pantelis Antoniou wrote: Hi Greg, On Apr 24, 2015, at 23:29 , Greg KH g...@kroah.com wrote: On Fri, Apr 24, 2015 at 12:45:42PM +0300, Pantelis Antoniou wrote: A throw once master enable switch to protect against any further overlay

Re: [PATCH] usb: core: add usb3 lpm sysfs

2015-04-28 Thread Greg KH
On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote: Some usb3 devices may not support usb3 lpm well. The patch adds a sysfs to enable/disable u1 or u2 of the port.The settings apply to both before and after device enumeration. Supported values are 0 - u1 and u2 are disabled, u1 -

Re: [PATCH v3 4/4] Documentation: ABI: /sys/firmware/devicetree/overlays

2015-04-27 Thread Greg KH
On Mon, Apr 27, 2015 at 08:51:20PM +0300, Pantelis Antoniou wrote: Hi Greg, On Apr 24, 2015, at 23:31 , Greg KH g...@kroah.com wrote: On Fri, Apr 24, 2015 at 12:45:44PM +0300, Pantelis Antoniou wrote: Documentation ABI entry for overlays sysfs entries. Signed-off-by: Pantelis

Re: [PATCH] include/uapi/linux/swab.h: define a silent macro to avoid sparse error

2015-06-15 Thread Greg KH
On Sun, Jun 14, 2015 at 11:23:32PM +0100, Bilel DRIRA wrote: define a silent macro when _CHECKER_ is defined. This change fixes the following sparse errors: include/uapi/linux/swab.h:60:16: error: undefined identifier '__builtin_bswap32' include/uapi/linux/swab.h:60:33: error: not a

Re: [char-misc-next 04/11 V2] uuid: extract macros for assigning raw arrays

2015-05-27 Thread Greg KH
On Wed, May 27, 2015 at 06:42:13PM +0300, Tomas Winkler wrote: In order for mei client devices to use device id based on uuid we have to use common types between user space (file2alias.c). Similarly to vmbus, mei uses raw 16 byte array for that. To leverage on existing infrastructure around

Re: [RFC v2 1/4] fs: Add generic file system event notifications

2015-05-26 Thread Greg KH
On Tue, May 26, 2015 at 06:39:48PM +0200, Beata Michalska wrote: Hi, Things has gone a bit quiet thread wise ... As I believe I've managed to snap back to reality, I was hoping we could continue with this? I'm not sure if we've got everything cleared up or ... have we reached a dead end?

[PATCH] mei: fix up uuid matching

2015-05-27 Thread Greg KH
From: Greg Kroah-Hartman gre...@linuxfoundation.org A previous commit, c93b76b34b4d (mei: bus: report also uuid in module alias) caused a build error as I missed applying a needed patch to add some macros to uapi/linux/uuid.h. Instead of those additional macros, change the mei code to use the

Re: [char-misc-next 04/11 V2] uuid: extract macros for assigning raw arrays

2015-05-27 Thread Greg KH
On Wed, May 27, 2015 at 11:25:59PM +, Winkler, Tomas wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Thursday, May 28, 2015 02:23 To: Winkler, Tomas Cc: a...@arndb.de; Stephen Rothwell; linux-api@vger.kernel.org Subject: Re: [char-misc

Re: [PATCH v2] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must not use snprintf

2015-06-30 Thread Greg KH
On Wed, Jul 01, 2015 at 01:56:03AM +, Seymour, Shane M wrote: Changed DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WO|RW. This also forced some show/store function names to change. Changed all show method snprintf() usage to scnprintf() per Documentation/filesystems/sysfs.txt. Forgot to

Re: [PATCH]: Mux n_gsm: Add a DLCI hangup state and callback

2015-06-29 Thread Greg KH
On Mon, Jun 29, 2015 at 05:53:56PM +0200, Gwenn Bourrée wrote: Dear kernel tty maintainers, Please review the following patch: From 6e006bd522124d0e8a2f6075099a21f7051a426f Mon Sep 17 00:00:00 2001 From: Gwenn Bourree gwenn.bour...@intel.com Date: Mon, 29 Jun 2015 17:26:01 +0200

Re: [PATCH]: MUX n_gsm debug print improvements

2015-06-29 Thread Greg KH
On Mon, Jun 29, 2015 at 05:54:58PM +0200, Gwenn Bourrée wrote: Dear kernel tty maintainers, Please review the following patch: From 0ac5da0a4653f43ce4b0761a2be8073185c549bb Mon Sep 17 00:00:00 2001 From: Gwenn Bourree gwenn.bour...@intel.com Date: Mon, 29 Jun 2015 16:09:06 +0200

Re: [PATCH]: MUX n_gsm debug print improvements

2015-06-29 Thread Greg KH
On Mon, Jun 29, 2015 at 05:54:58PM +0200, Gwenn Bourrée wrote: Dear kernel tty maintainers, Please review the following patch: From 0ac5da0a4653f43ce4b0761a2be8073185c549bb Mon Sep 17 00:00:00 2001 From: Gwenn Bourree gwenn.bour...@intel.com Date: Mon, 29 Jun 2015 16:09:06 +0200

Re: [PATCH] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must use scnprintf

2015-06-30 Thread Greg KH
On Tue, Jun 30, 2015 at 05:22:20AM +, Seymour, Shane M wrote: Changed DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WO|RW. This also forced some show/store function names to change. Changed all show method sprint/snprintf usage to scnprintf per Documentation/filesystems/sysfs.txt. There's

Re: [PATCH 2/3] kobject: export kset_find_obj() to be used from modules

2015-08-10 Thread Greg KH
On Mon, Aug 10, 2015 at 12:31:19PM -0400, Gabriel L. Somlo wrote: From: Gabriel Somlo so...@cmu.edu Signed-off-by: Gabriel Somlo so...@cmu.edu --- lib/kobject.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/kobject.c b/lib/kobject.c index 3e3a5c3..f9754a0 100644 ---

Re: [PATCH 3/3] firmware: fw_cfg: create directory hierarchy for fw_cfg file names

2015-08-10 Thread Greg KH
On Mon, Aug 10, 2015 at 12:31:20PM -0400, Gabriel L. Somlo wrote: From: Gabriel Somlo so...@cmu.edu Each fw_cfg entry of type file has an associated 56-char, nul-terminated ASCII string which represents its name. While the fw_cfg device doesn't itself impose any specific naming convention,

Re: [PATCH 2/3] kobject: export kset_find_obj() to be used from modules

2015-08-10 Thread Greg KH
On Mon, Aug 10, 2015 at 02:43:10PM -0400, Gabriel L. Somlo wrote: On Mon, Aug 10, 2015 at 11:33:04AM -0700, Greg KH wrote: On Mon, Aug 10, 2015 at 12:31:19PM -0400, Gabriel L. Somlo wrote: From: Gabriel Somlo so...@cmu.edu Signed-off-by: Gabriel Somlo so...@cmu.edu --- lib

Re: [RFC] Input: Add ps2emu module

2015-07-21 Thread Greg KH
On Tue, Jul 21, 2015 at 03:07:14PM -0400, Stephen Chandler Paul wrote: +#define ps2emu_warn(format, args...) \ + dev_warn(ps2emu_misc.this_device, format, ## args) Don't make a wrapper function for another wrapper function, just spell the thing out in the code, makes it much easier to debug

Re: [RFC 1/1 v2] Input: Add ps2emu module

2015-07-21 Thread Greg KH
On Tue, Jul 21, 2015 at 03:47:17PM -0400, Stephen Chandler Paul wrote: Debugging input devices, specifically laptop touchpads, can be tricky without having the physical device handy. Here we try to remedy that with ps2emu. This module allows an application to connect to a character device

Re: [RFC] Input: Add ps2emu module

2015-07-21 Thread Greg KH
On Tue, Jul 21, 2015 at 03:07:14PM -0400, Stephen Chandler Paul wrote: Debugging input devices, specifically laptop touchpads, can be tricky without having the physical device handy. Here we try to remedy that with ps2emu. This module allows an application to connect to a character device

Re: KDBUS breaks 'make installmandocs'

2015-07-13 Thread Greg KH
On Sun, Jul 12, 2015 at 08:08:46PM +0200, Ulf Magnusson wrote: Hello, Tested with next-20150709. Documentation/kdbus/Makefile lacks an 'installmandocs' target, causing problems for %docs: scripts_basic FORCE $(Q)$(MAKE) $(build)=scripts build_docproc $(Q)$(MAKE)

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-20 Thread Greg KH
On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote: Signed-off-by: Yann Cantin yann.can...@laposte.net You need some kind of text in the changelog here... --- Documentation/ABI/testing/sysfs-driver-ebeam | 53 ++ drivers/input/misc/Kconfig | 22 +

Re: [RFC ebeam PATCH 2/2] input: misc: New USB eBeam input driver

2015-07-20 Thread Greg KH
On Mon, Jul 20, 2015 at 03:26:40PM -0700, Dmitry Torokhov wrote: On Mon, Jul 20, 2015 at 02:59:56PM -0700, Greg KH wrote: On Mon, Jul 20, 2015 at 11:03:19PM +0200, Yann Cantin wrote: Signed-off-by: Yann Cantin yann.can...@laposte.net + + /* sysfs setup */ + err

Re: [PATCH] TTY, devpts: document pty count limiting

2015-10-21 Thread Greg KH
On Wed, Oct 21, 2015 at 01:08:54PM +0300, Konstantin Khlebnikov wrote: > Logic was changed in kernel 3.4 by commit e9aba5158a80 ("tty: rework pty > count limiting") but still isn't documented. Better late than never. > > Signed-off-by: Konstantin Khlebnikov > --- >

Re: [PATCH] TTY, devpts: document pty count limiting

2015-10-22 Thread Greg KH
On Wed, Oct 21, 2015 at 11:08:52PM -0500, Eric W. Biederman wrote: > Greg KH <gre...@linuxfoundation.org> writes: > > > On Wed, Oct 21, 2015 at 01:08:54PM +0300, Konstantin Khlebnikov wrote: > >> Logic was changed in kernel 3.4 by commit e9aba5158a80 ("tty

Re: [PATCH] HID: roccat: Fixed resubmit: Deprecating most Roccat sysfs attributes

2015-10-17 Thread Greg KH
HIDIOCSFEATURE, so I would suggest future removal of device specific > drivers. > The userspace tools don't use these attributes for a year now. > The first Kone is not fully HID-compliant and will still need a module. > > Fix: Resubmitting this patch, now done with 'git format-patch

Re: [PATCH] HID: roccat: Deprecating most Roccat sysfs attributes

2015-10-15 Thread Greg KH
On Thu, Oct 15, 2015 at 05:00:09PM +0200, Stefan Achatz wrote: > Deprecates all Roccat sysfs attributes except the ones for the old Kone by > moving > abi descriptions from testing to obsolete. > For most devices everything can be done using the hidraw ioctls HIDIOCGFEATURE > and HIDIOCSFEATURE,

Re: [PATCH 1/7] kernfs: Add API to generate relative kernfs path

2015-12-08 Thread Greg KH
On Mon, Dec 07, 2015 at 05:06:16PM -0600, serge.hal...@ubuntu.com wrote: > From: Aditya Kali > > The new function kernfs_path_from_node() generates and returns kernfs > path of a given kernfs_node relative to a given parent kernfs_node. > > Changelog 20151125: > -

Re: [PATCH 1/8] kernfs: Add API to generate relative kernfs path

2015-12-23 Thread Greg KH
On Wed, Dec 23, 2015 at 11:24:33AM -0500, Tejun Heo wrote: > On Tue, Dec 22, 2015 at 10:23:22PM -0600, serge.hal...@ubuntu.com wrote: > > From: Aditya Kali > > > > The new function kernfs_path_from_node() generates and returns kernfs > > path of a given kernfs_node

Re: [PATCH 5/8] kernfs: define kernfs_node_dentry

2015-12-23 Thread Greg KH
On Wed, Dec 23, 2015 at 11:25:15AM -0500, Tejun Heo wrote: > On Tue, Dec 22, 2015 at 10:23:26PM -0600, serge.hal...@ubuntu.com wrote: > > From: Aditya Kali > > > > Add a new kernfs api is added to lookup the dentry for a particular > > kernfs path. > > > > Signed-off-by:

Re: [PATCH RFC] [media] Postpone the addition of MEDIA_IOC_G_TOPOLOGY

2015-12-28 Thread Greg KH
On Mon, Dec 28, 2015 at 08:37:19AM -0700, Shuah Khan wrote: > On 12/28/2015 07:03 AM, Mauro Carvalho Chehab wrote: > > There are a few discussions left with regards to this ioctl: > > > > 1) the name of the new structs will contain _v2_ on it? > > 2) what's the best alternative to avoid compat32

Re: [PATCH v1 0/1] ioctl to disallow detaching kernel USB drivers

2015-11-26 Thread Greg KH
On Thu, Nov 26, 2015 at 10:19:29AM +0100, Krzysztof Opasiak wrote: > > > On 11/25/2015 04:45 PM, Emilio López wrote: > >Hi everyone, > > > >This patch introduces a new ioctl, USBDEVFS_DROP_PRIVILEGES, > >to voluntarily forgo the ability to issue ioctls which may > >interfere with other users of

Re: [PATCH v1 0/1] ioctl to disallow detaching kernel USB drivers

2015-11-27 Thread Greg KH
On Fri, Nov 27, 2015 at 09:44:45AM +0100, Krzysztof Opasiak wrote: > > > On 11/26/2015 06:29 PM, Greg KH wrote: > >On Thu, Nov 26, 2015 at 10:19:29AM +0100, Krzysztof Opasiak wrote: > >> > >> > >>On 11/25/2015 04:45 PM, Emilio López wrote: > >>&

Re: [PATCH v1 0/1] ioctl to disallow detaching kernel USB drivers

2015-11-30 Thread Greg KH
On Mon, Nov 30, 2015 at 06:12:22PM +0100, Krzysztof Opasiak wrote: > > > On 11/30/2015 05:16 PM, Alan Stern wrote: > >On Fri, 27 Nov 2015, Krzysztof Opasiak wrote: > > > I run through your code and as far as I understand above is not exactly > true. Your patch allows only to prevent

Re: [PATCH] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

2015-06-24 Thread Greg KH gre...@linuxfoundation.org (gre...@linuxfoundation.org)
On Wed, Jun 24, 2015 at 03:25:57PM +0900, Sergey Senozhatsky wrote: On (06/24/15 06:10), Seymour, Shane M wrote: [..] /* The sysfs driver interface. Read-only at the moment */ -static ssize_t st_try_direct_io_show(struct device_driver *ddp, char *buf) +static ssize_t

Re: [PATCH] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

2015-06-24 Thread Greg KH gre...@linuxfoundation.org (gre...@linuxfoundation.org)
On Wed, Jun 24, 2015 at 03:25:57PM +0900, Sergey Senozhatsky wrote: On (06/24/15 06:10), Seymour, Shane M wrote: [..] /* The sysfs driver interface. Read-only at the moment */ -static ssize_t st_try_direct_io_show(struct device_driver *ddp, char *buf) +static ssize_t

Re: [PATCH v2] st: convert DRIVER_ATTR macros to DRIVER_ATTR_RO

2015-06-24 Thread Greg KH gre...@linuxfoundation.org (gre...@linuxfoundation.org)
On Wed, Jun 24, 2015 at 06:54:35AM +, Seymour, Shane M wrote: Convert DRIVER_ATTR macros to DRIVER_ATTR_RO requested by Greg KH. Also switched to using scnprintf instead of snprintf per Documentation/filesystems/sysfs.txt. Suggested-by: Greg Kroah-Hartman gre...@linuxfoundation.org

Re: [PATCH] sysfs.txt: update show method notes about sprintf/snprintf/scnprintf usage

2015-06-25 Thread Greg KH gre...@linuxfoundation.org (gre...@linuxfoundation.org)
On Thu, Jun 25, 2015 at 10:59:57AM +0900, Sergey Senozhatsky wrote: On (06/25/15 00:55), Seymour, Shane M wrote: Changed the documentation to allow sprintf() for small single values and explicitly say snprintf() must never be used in a show function to format data to be returned to user

Re: [PATCH 3/3] hpsa: Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO

2015-06-30 Thread Greg KH g...@kroah.com (g...@kroah.com)
On Wed, Jul 01, 2015 at 03:47:10AM +, Seymour, Shane M wrote: Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO Changes forced some function names to change. Signed-off-by: Shane Seymour shane.seym...@hp.com Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org -- To