Re: [PATCH, RESEND2] getrusage: fill ru_maxrss value

2008-12-17 Thread Jiri Pirko
On Wed, 17 Dec 2008 19:48:44 +0900 (JST) KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com wrote: (updated) This patch makes -ru_maxrss value in struct rusage filled accordingly to rss hiwater mark. This struct is filled as a parameter to getrusage syscall. -ru_maxrss value is set to

Re: [PATCH, RESEND2] getrusage: fill ru_maxrss value

2008-12-17 Thread KOSAKI Motohiro
This patch makes -ru_maxrss value in struct rusage filled accordingly to rss hiwater mark. This struct is filled as a parameter to getrusage syscall. -ru_maxrss value is set to pages which might be correct as time application converts it to KBs. Why? if kernel convert to KB,

Re: [PATCH, RESEND2] getrusage: fill ru_maxrss value

2008-12-17 Thread KOSAKI Motohiro
(updated) This patch makes -ru_maxrss value in struct rusage filled accordingly to rss hiwater mark. This struct is filled as a parameter to getrusage syscall. -ru_maxrss value is set to pages which might be correct as time application converts it to KBs. Why? if kernel convert to KB,

Re: [PATCH, RESEND2] getrusage: fill ru_maxrss value

2008-12-17 Thread KOSAKI Motohiro
Ah, you talked about /usr/bin/time? sorry, I misunderstood a bit. Why time need number of pages? In general, getrusage()::ru_maxrss is bsd compatibility feature. as far as possible, the same syscall spec is better. and bsd use KB unit. Oh you are right. Now I searched it in FreeBSD