Re: [PATCH v3 1/2] msm: gpio: Add v2 gpio support to MSM SoCs.

2010-11-18 Thread Pavan Kondeti
Hi Greg, On Tue, Nov 16, 2010 at 01:38:35PM -0800, Gregory Bean wrote: Beginning with the MSM8x60, the hardware block responsible for gpio support changes. Provide gpiolib support for the new v2 architecture. Cc: Baruch Siach bar...@tkos.co.il Signed-off-by: Gregory Bean

RE: [PATCH v5 1/1] usb: Adding SuperSpeed support to dummy_hcd

2010-11-18 Thread Tanya Brokhman
Hi Greg Thank you for your comments. Please see my answers inline. -Original Message- From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Greg KH Sent: Wednesday, November 17, 2010 11:36 PM To: Tatyana Brokhman Cc: gre...@suse.de;

[PATCH v4 0/4] usb gadget: Add SuperSpeed support to the Gadget Framework

2010-11-18 Thread Tatyana Brokhman
This patch series adds the SuperSpeed functionality to the gadget framework. This implementation passed both USBCV 3.0 and 2.0 test suites. Rebased on top of v2.6.37-rc1 Tatyana Brokhman (4): usb: Add usb_endpoint_descriptor to be part of the struct usb_ep usb: Configure endpoint according

[PATCH v4 1/4] usb gadget: Add usb_endpoint_descriptor to be part of the struct usb_ep

2010-11-18 Thread Tatyana Brokhman
Change usb_ep_enable() prototype to use endpoint descriptor from usb_ep. This optimization spares the FDs from saving the endpoint chosen descriptor. This optimization is not full though. To fully exploit this change one needs to update all the UDCs as well since in the current implementation each

[PATCH v4 2/4] usb gadget: Configure endpoint according to gadget speed.

2010-11-18 Thread Tatyana Brokhman
Add config_ep_by_speed() to configure the endpoint according to the gadget speed. Using this function will spare the FDs from handling the endpoint chosen descriptor. Signed-off-by: Tatyana Brokhman tlin...@codeaurora.org --- drivers/usb/gadget/composite.c | 76

[PATCH v4 3/4] usb gagdet: Modify existing gadget drivers to use config_ep_by_speed() instead of ep_choose.

2010-11-18 Thread Tatyana Brokhman
Remove obsolete functions: 1. ep_choose() 2. usb_find_endpoint() Signed-off-by: Tatyana Brokhman tlin...@codeaurora.org --- drivers/usb/gadget/config.c | 25 --- drivers/usb/gadget/f_acm.c| 47 +++-- drivers/usb/gadget/f_ecm.c

[PATCH v4 4/4] usb gadget: Add SuperSpeed support to the Gadget Framework

2010-11-18 Thread Tatyana Brokhman
This patch adds the SuperSpeed functionality to the gadget framework. In order not to force all the gadget drivers to supply SuperSpeed descriptors when operating in SuperSpeed mode the following approach was taken: If we're operating in SuperSpeed mode and the gadget driver didn't supply

Re: [PATCH v5 1/1] usb: Adding SuperSpeed support to dummy_hcd

2010-11-18 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Nov 18, 2010 at 01:01:17PM +0200, Tanya Brokhman wrote: Hi Greg Thank you for your comments. Please see my answers inline. Please fix your email client (i.e. get one that works properly)

Re: [PATCH v6] usb: Adding SuperSpeed support to dummy_hcd

2010-11-18 Thread Alan Stern
On Thu, 18 Nov 2010, Tatyana Brokhman wrote: USB 3.0 hub includes 2 hubs - HS and SS ones. Thus, when dummy_hcd enabled it will register 2 root hubs (SS and HS). Hmm. A quick comparison with the original source shows that you neglected to add code for SuperSpeed transfers to periodic_bytes()

Re: [PATCH v3 2/2] msm: gpio: Add irq support to v2 gpiolib.

2010-11-18 Thread Gregory Bean
+ spin_lock_irqsave(tlmm_lock, irq_flags); + for_each_set_bit(i, msm_gpio.enabled_irqs, NR_GPIO_IRQS) { + if (!test_bit(i, msm_gpio.wake_irqs)) + writel(TARGET_PROC_NONE, GPIO_INTR_CFG_SU(i)); + } If none of the enabled irqs is configured as

[PATCH v4 2/2] msm: gpio: Add irq support to v2 gpiolib.

2010-11-18 Thread Gregory Bean
Complete the MSM v2 gpio subsystem by adding irq_chip. Signed-off-by: Gregory Bean gb...@codeaurora.org --- v4 - miscellaneous cleanup to patch 1/2, per pkond...@codeaurora.org v3 - miscellaneous cleanup to patch 1/2, per bar...@tkos.co.il v2 - miscellaneous cleanup to patch 1/2, per

[PATCH v4 1/2] msm: gpio: Add v2 gpio support to MSM SoCs.

2010-11-18 Thread Gregory Bean
Beginning with the MSM8x60, the hardware block responsible for gpio support changes. Provide gpiolib support for the new v2 architecture. Cc: Baruch Siach bar...@tkos.co.il Cc: Pavan Kondeti pkond...@codeaurora.org Signed-off-by: Gregory Bean gb...@codeaurora.org --- v4 - miscellaneous cleanup,

Re: [PATCH v4 2/2] msm: gpio: Add irq support to v2 gpiolib.

2010-11-18 Thread Janakiram Sistla
On Thu, Nov 18, 2010 at 11:52 AM, Gregory Bean gb...@codeaurora.org wrote: Complete the MSM v2 gpio subsystem by adding irq_chip. Signed-off-by: Gregory Bean gb...@codeaurora.org ---  v4 - miscellaneous cleanup to patch 1/2, per pkond...@codeaurora.org  v3 - miscellaneous cleanup to patch

Re: [PATCH v4 2/2] msm: gpio: Add irq support to v2 gpiolib.

2010-11-18 Thread Gregory Bean
On Thu, 18 Nov 2010, Janakiram Sistla wrote: Can you let me know how this naming convention gpio-v2?? Do you mean to MSM have v1 and v2 gpio hardware ??? can not we have one file under mach-msm as gpio.c?? The MSM8x60 is the first MSM chip to carry the second-generation, or v2, GPIO hardware

Re: [PATCH v4 2/2] msm: gpio: Add irq support to v2 gpiolib.

2010-11-18 Thread Janakiram Sistla
On Thu, Nov 18, 2010 at 12:30 PM, Gregory Bean gb...@codeaurora.org wrote: On Thu, 18 Nov 2010, Janakiram Sistla wrote: Can you let me know how this naming convention gpio-v2?? Do you mean to MSM have v1 and v2 gpio hardware ??? can not we have one file under mach-msm as gpio.c?? The

Re: [PATCH v4 2/2] msm: gpio: Add irq support to v2 gpiolib.

2010-11-18 Thread Gregory Bean
Do you mean to MSM have v1 and v2 gpio hardware ??? can not we have one file under mach-msm as gpio.c?? The MSM8x60 is the first MSM chip to carry the second-generation, or v2, GPIO hardware block.  This block is not backward compatible with the v1 block found on older MSMs, so the two drivers

Re: [PATCH v4 2/2] msm: gpio: Add irq support to v2 gpiolib.

2010-11-18 Thread Janakiram Sistla
On Thu, Nov 18, 2010 at 12:59 PM, Gregory Bean gb...@codeaurora.org wrote: Do you mean to MSM have v1 and v2 gpio hardware ??? can not we have one file under mach-msm as gpio.c?? The MSM8x60 is the first MSM chip to carry the second-generation, or v2, GPIO hardware block.  This block is not

[PATCH v5 1/1] usb: Adding SuperSpeed support to dummy_hcd

2010-11-18 Thread Tatyana Brokhman
USB 3.0 hub includes 2 hubs - HS and SS ones. Thus, when dummy_hcd enabled it will register 2 root hubs (SS and HS). Signed-off-by: Tatyana Brokhman tlin...@codeaurora.org --- drivers/usb/gadget/dummy_hcd.c | 500 ++- 1 files changed, 487 insertions(+), 13