On Fri, Aug 16, 2013 at 12:58:49PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Aug 16, 2013 at 02:47:15PM -0500, Josh Cartwright wrote:
> > > > +#ifdef CONFIG_DEBUG_FS
> > >
> > > Why? If debugfs isn't enabled, the functions should just compile away
> > > with the debugfs_() calls, so no need to d
On 08/15/2013 07:35 AM, Pawel Moll wrote:
> On Wed, 2013-08-14 at 20:09 +0100, Kumar Gala wrote:
>> +Required properties:
>> +- compatible: should be "qcom,tcsr-mutex"
>> +- reg: Should contain registers location and length of mutex registers
>> +- reg-names:
>> +"mutex-base" - string to ident
On 08/16/2013 01:48 PM, Kumar Gala wrote:
>
> On Aug 16, 2013, at 2:25 PM, Josh Cartwright wrote:
>
>> Hey Kumar-
>>
>> Thanks for the review.
>>
>> On Fri, Aug 16, 2013 at 01:53:27PM -0500, Kumar Gala wrote:
>>> On Aug 9, 2013, at 3:37 PM, Josh Cartwright wrote:
>>>
Signed-off-by: Josh Cart
On 08/14/2013 01:09 PM, Kumar Gala wrote:
> Add driver for Qualcomm MSM Hardware Mutex block that exists on newer MSM
> SoC (MSM8974, etc).
> diff --git a/Documentation/devicetree/bindings/hwlock/msm-tcsr-mutex.txt
> b/Documentation/devicetree/bindings/hwlock/msm-tcsr-mutex.txt
> +Required prope
On Fri, Aug 16, 2013 at 02:47:15PM -0500, Josh Cartwright wrote:
> > > +#ifdef CONFIG_DEBUG_FS
> >
> > Why? If debugfs isn't enabled, the functions should just compile away
> > with the debugfs_() calls, so no need to do this type of thing here,
> > right?
>
> Not sure I follow you, but it may b
On Fri, Aug 16, 2013 at 02:47:14PM -0500, Josh Cartwright wrote:
> >
> > Why? If debugfs isn't enabled, the functions should just compile away
> > with the debugfs_() calls, so no need to do this type of thing here,
> > right?
>
> Not sure I follow you, but it may be because this is a bit mislea
On 08/14/2013 06:59 AM, Ivan T. Ivanov wrote:
> From: "Ivan T. Ivanov"
>
> MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys
> (SNPS) and HS, SS PHY's control and configuration registers.
>
> It could operate in device mode (SS, HS, FS) and host
> mode (SS, HS, FS, LS).
> diff --git a/
On Fri, Aug 16, 2013 at 03:40:55PM -0500, Josh Cartwright wrote:
> On Fri, Aug 16, 2013 at 12:58:49PM -0700, Greg Kroah-Hartman wrote:
> > On Fri, Aug 16, 2013 at 02:47:15PM -0500, Josh Cartwright wrote:
> > > > > +#ifdef CONFIG_DEBUG_FS
> > > >
> > > > Why? If debugfs isn't enabled, the function
Hey Kumar-
Thanks for the review.
On Fri, Aug 16, 2013 at 01:53:27PM -0500, Kumar Gala wrote:
> On Aug 9, 2013, at 3:37 PM, Josh Cartwright wrote:
>
> > Signed-off-by: Josh Cartwright
> > ---
> > .../devicetree/bindings/spmi/spmi-pmic-arb.txt | 26
> > ++
> > 1 file chan
On Fri, Aug 16, 2013 at 03:21:10PM -0500, Josh Cartwright wrote:
> On Fri, Aug 16, 2013 at 11:49:21AM -0700, Greg Kroah-Hartman wrote:
> > On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote:
> > > +++ b/drivers/spmi/spmi.c
> > > @@ -0,0 +1,449 @@
> [..]
> > > +static void spmi_ctrl_rel
Hey Greg-
Thanks for the comments.
On Fri, Aug 16, 2013 at 11:46:14AM -0700, Greg Kroah-Hartman wrote:
> On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote:
> > --- /dev/null
> > +++ b/drivers/of/of_spmi.c
> > @@ -0,0 +1,74 @@
> > +/* Copyright (c) 2012,2013 The Linux Foundation. All
On Aug 16, 2013, at 2:25 PM, Josh Cartwright wrote:
> Hey Kumar-
>
> Thanks for the review.
>
> On Fri, Aug 16, 2013 at 01:53:27PM -0500, Kumar Gala wrote:
>> On Aug 9, 2013, at 3:37 PM, Josh Cartwright wrote:
>>
>>> Signed-off-by: Josh Cartwright
>>> ---
>>> .../devicetree/bindings/spmi/spmi
On Fri, Aug 16, 2013 at 11:49:21AM -0700, Greg Kroah-Hartman wrote:
> On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote:
> > +++ b/drivers/spmi/spmi.c
> > @@ -0,0 +1,449 @@
[..]
> > +static void spmi_ctrl_release(struct device *dev)
> > +{
> > + struct spmi_controller *ctrl = to_spm
On Aug 9, 2013, at 3:37 PM, Josh Cartwright wrote:
> From: Kenneth Heitke
>
> System Power Management Interface (SPMI) is a specification
> developed by the MIPI (Mobile Industry Process Interface) Alliance
> optimized for the real time control of Power Management ICs (PMIC).
>
> SPMI is a two
On Fri, Aug 09, 2013 at 01:37:07PM -0700, Josh Cartwright wrote:
> +struct spmi_pmic_arb_dev {
> + struct spmi_controller controller;
> + struct device *dev;
> + struct device *slave;
This is problematic.
Why do you have the driver "own" the controller? What is d
On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote:
> +++ b/drivers/spmi/spmi.c
> @@ -0,0 +1,449 @@
> +/* Copyright (c) 2012-2013, The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the
On Fri, Aug 09, 2013 at 01:37:09PM -0700, Josh Cartwright wrote:
> --- /dev/null
> +++ b/drivers/of/of_spmi.c
> @@ -0,0 +1,74 @@
> +/* Copyright (c) 2012,2013 The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under t
From: Kenneth Heitke
System Power Management Interface (SPMI) is a specification
developed by the MIPI (Mobile Industry Process Interface) Alliance
optimized for the real time control of Power Management ICs (PMIC).
SPMI is a two-wire serial interface that supports up to 4 master
devices and up
From: Kenneth Heitke
Qualcomm's PMIC Arbiter SPMI controller functions as a bus master and
is used to communication with one or more PMIC (slave) devices on the
SPMI bus. The PMIC Arbiter is actually a hardware wrapper around the
SPMI controller that provides concurrent and autonomous PMIC acces
The System Power Management Interface (SPMI) is a high-speed,
low-latency, bi-directional, two-wire serial bus suitable for real-time
control of voltage and frequency scaled multi-core application
processors and its power management of auxiliary components. SPMI
obsoletes a number of legacy, custom
On Aug 16, 2013, at 11:43 AM, Kumar Gala wrote:
>
> On Aug 15, 2013, at 12:02 AM, Mike Turquette wrote:
>
>>> Right now we have
>>>
>>> pll8: pll8 {
>>> #clock-cells = <0>;
>>> compatible = "qcom,pll";
>>> clocks = <&pxo>;
>>> };
>>>
>>> i
On Aug 15, 2013, at 12:02 AM, Mike Turquette wrote:
>> Right now we have
>>
>>pll8: pll8 {
>>#clock-cells = <0>;
>>compatible = "qcom,pll";
>>clocks = <&pxo>;
>>};
>>
>> in DT and
>>
>>static struct pll_desc pll8_desc = {
On Wed, Aug 14, 2013 at 11:38:44PM +0100, Rohit Vaswani wrote:
> On 8/12/2013 9:39 AM, Mark Rutland wrote:
> > On Fri, Aug 02, 2013 at 03:15:25AM +0100, Rohit Vaswani wrote:
> >> Add the cpus bindings and the Kraitv2 release sequence
> >> to make SMP work for 2 cores on MSM8974.
> >>
> >> Signed-of
On Wed, Aug 14, 2013 at 09:55:31PM +0100, Rohit Vaswani wrote:
> On 8/12/2013 8:50 AM, Mark Rutland wrote:
> > Hi,
> >
> > Apologies for the long delay for review on this.
> >
> > I really like the direction this is going, but I have some qualms with
> > the implementation.
>
> Thanks for your rev
Hi Ivan,
On 08/15/2013 10:22 AM, Ivan T. Ivanov wrote:
Hi Georgi,
I have several comments below.
Shouldn't we add required clocks here? It looks that some of them
are optional and others mandatory.
Yes, there are various clocks for MMC, SD/SDIO and at least 400mhz must
be provided for
25 matches
Mail list logo
