Re: [PATCH v2 00/14] Add Qualcomm SD Card Controller support

2014-05-23 Thread Srinivas Kandagatla
On 23/05/14 08:50, Ulf Hansson wrote: On 23 May 2014 09:13, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: Hi Ulf, I like to get this patches for v3.16, any chance of considering these patches to v3.16 ? I promise to have them properly reviewed early next week, sorry for taking

Re: [PATCH v2 05/14] mmc: mmci: Add register read/write wrappers.

2014-05-23 Thread Linus Walleij
On Thu, May 15, 2014 at 11:36 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds wrappers for readl/writel functions used in the driver. The reason for this wrappers is to accommodate SOCs like Qualcomm which has requirement

Re: [PATCH v2 06/14] mmc: mmci: Qcomm: Add 3 clock cycle delay after register write

2014-05-23 Thread Linus Walleij
On Thu, May 15, 2014 at 11:37 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org Most of the Qcomm SD card controller registers must be updated to the MCLK domain so subsequent writes to registers will be ignored until 3 clock cycles have

Re: [PATCH v2 08/14] mmc: mmci: add 8bit bus support in variant data

2014-05-23 Thread Linus Walleij
On Thu, May 15, 2014 at 11:37 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds 8bit bus enable to variant structure giving more flexibility to the driver to support more SOCs which have different clock register layout.

Re: [PATCH v2 07/14] mmc: mmci: add ddrmode mask to variant data

2014-05-23 Thread Linus Walleij
On Thu, May 15, 2014 at 11:37 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds ddrmode mask to variant structure giving more flexibility to the driver to support more SOCs which have different datactrl register layout.

Re: [PATCH v2 09/14] mmc: mmci: add edge support to data and command out in variant data.

2014-05-23 Thread Linus Walleij
On Thu, May 15, 2014 at 11:37 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds edge support for data and command out to variant structure giving more flexibility to the driver to support more SOCs which have different clock

Re: [PATCH v2 11/14] mmc: mmci: Add support to data commands via variant structure.

2014-05-23 Thread Srinivas Kandagatla
Thanks Linus W. On 23/05/14 10:09, Linus Walleij wrote: On Thu, May 15, 2014 at 11:37 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org On some SOCs like Qcom there are explicit bits in the command register to specify if its a data transfer

Re: [PATCH v2 12/14] mmc: mmci: add support for fbclk to latch data and cmd.

2014-05-23 Thread Linus Walleij
On Thu, May 15, 2014 at 11:37 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds support to fbclk that is used to latch data and cmd on some controllers like SD Card controller in Qcom SOC. Signed-off-by: Srinivas Kandagatla

Re: [PATCH v2 13/14] mmc: mmci: add qcom specific clk control

2014-05-23 Thread Linus Walleij
On Thu, May 15, 2014 at 11:37 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org On Qcom SD card controller, cclk is mclk and mclk should be directly controlled by the driver. This patch adds support to control mclk directly in the driver, and

Re: [PATCH v2 12/14] mmc: mmci: add support for fbclk to latch data and cmd.

2014-05-23 Thread Srinivas Kandagatla
On 23/05/14 10:12, Linus Walleij wrote: On Thu, May 15, 2014 at 11:37 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds support to fbclk that is used to latch data and cmd on some controllers like SD Card controller in Qcom

Re: [PATCH v2 14/14] mmc: mmci: Add Qcom specific pio_read function.

2014-05-23 Thread Srinivas Kandagatla
On 23/05/14 10:31, Linus Walleij wrote: On Thu, May 15, 2014 at 11:38 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org MCIFIFOCNT register behaviour on Qcom chips is very different than the other pl180 integrations. MCIFIFOCNT register

Re: [PATCH v2 14/14] mmc: mmci: Add Qcom specific pio_read function.

2014-05-23 Thread Srinivas Kandagatla
Hi Linus W, On 23/05/14 10:31, Linus Walleij wrote: static int mmci_qcom_pio_read(struct mmci_host *host, char *buffer, unsigned int remain) { u32 *ptr = (u32*) buffer; unsigned int count = 0; unsigned int words; unsigned int fifo_size =

[PATCH v3 00/13] Add Qualcomm SD Card Controller support

2014-05-23 Thread srinivas . kandagatla
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org Thankyou Linus W and everyone for reviewing RFC to v3 patches. This patch series adds Qualcomm SD Card Controller support in pl180 mmci driver. QCom SDCC is basically a pl180, but bit more customized, some of the register layouts and

[PATCH v3 02/13] mmc: mmci: convert register bits to use BIT() macro.

2014-05-23 Thread srinivas . kandagatla
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch converts the register bits in the header file to use BIT(() macro, which looks much neater. No functional changes done. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- drivers/mmc/host/mmci.h | 208

[PATCH v3 03/13] mmc: mmci: Add Qualcomm Id to amba id table

2014-05-23 Thread srinivas . kandagatla
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds a fake Qualcomm ID 0x00051180 to the amba_ids, as Qualcomm SDCC controller is pl180, but amba id registers read 0x0's. The plan is to remove SDCC driver totally and use mmci as the main SD controller driver for Qualcomm

[PATCH v3 07/13] mmc: mmci: add ddrmode mask to variant data

2014-05-23 Thread srinivas . kandagatla
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds ddrmode mask to variant structure giving more flexibility to the driver to support more SOCs which have different datactrl register layout. Without this patch datactrl register is updated with wrong ddrmode mask on non ST

[PATCH v3 13/13] mmc: mmci: Add Qcom specific pio_read function.

2014-05-23 Thread srinivas . kandagatla
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org MCIFIFOCNT register behaviour on Qcom chips is very different than the other pl180 integrations. MCIFIFOCNT register contains the number of words that are still waiting to be transferred through the FIFO. It keeps decrementing once the host

[PATCH v3 11/13] mmc: mmci: Add support to data commands via variant structure.

2014-05-23 Thread srinivas . kandagatla
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org On some SOCs like Qcom there are explicit bits in the command register to specify if its a data transfer command or not. So this patch adds support to such bits in variant data, giving more flexibility to the driver. Signed-off-by:

[PATCH v3 12/13] mmc: mmci: add explicit clk control

2014-05-23 Thread srinivas . kandagatla
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org On Controllers like Qcom SD card controller where cclk is mclk and mclk should be directly controlled by the driver. This patch adds support to control mclk directly in the driver, and also adds explicit_mclk_control and cclk_is_mclk flags

[PATCH v3 10/13] mmc: mmci: add Qcom specifics of clk and datactrl registers.

2014-05-23 Thread srinivas . kandagatla
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds specifics of clk and datactrl register on Qualcomm SD Card controller. This patch also populates the Qcom variant data with these new values specific to Qualcomm SD Card Controller. Signed-off-by: Srinivas Kandagatla

[PATCH v3 05/13] mmc: mmci: Add register read/write wrappers.

2014-05-23 Thread srinivas . kandagatla
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds wrappers for readl/writel functions used in the driver. The reason for this wrappers is to accommodate SOCs like Qualcomm which has requirement for delaying the write for few cycles when writing to its SD Card Controller

[PATCH v3 09/13] mmc: mmci: add edge support to data and command out in variant data.

2014-05-23 Thread srinivas . kandagatla
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds edge support for data and command out to variant structure giving more flexibility to the driver to support more SOCs which have different clock register layout. Without this patch other new SOCs like Qcom will have to add

[PATCH v3 08/13] mmc: mmci: add 8bit bus support in variant data

2014-05-23 Thread srinivas . kandagatla
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds 8bit bus enable to variant structure giving more flexibility to the driver to support more SOCs which have different clock register layout. Without this patch other new SOCs like Qcom will have to add more code to special

[PATCH v3 04/13] mmc: mmci: Add Qcom datactrl register variant

2014-05-23 Thread srinivas . kandagatla
From: Srinivas Kandagatla srinivas.kandaga...@linaro.org Instance of this IP on Qualcomm's SOCs has bit different layout for datactrl register. Bit position datactrl[16:4] hold the true block size instead of power of 2. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org

Re: [PATCH v1 3/5] clk: gcc: Add APQ8084 Global Clock Controller support

2014-05-23 Thread Georgi Djakov
On 05/22/2014 07:38 PM, Kumar Gala wrote: On May 22, 2014, at 11:24 AM, Georgi Djakov gdja...@mm-sol.com wrote: This patch adds support for the global clock controller found on the APQ8084 based devices. The APQ8084 and MSM8974 share a lot of clock data, so instead of duplicating all the

Re: [PATCH v1 3/5] clk: gcc: Add APQ8084 Global Clock Controller support

2014-05-23 Thread Georgi Djakov
On 05/22/2014 08:22 PM, Stephen Boyd wrote: On 05/22/14 09:24, Georgi Djakov wrote: diff --git a/drivers/clk/qcom/gcc-msm8974.c b/drivers/clk/qcom/gcc-msm8974.c index 58cb2f5..c2a8d77 100644 --- a/drivers/clk/qcom/gcc-msm8974.c +++ b/drivers/clk/qcom/gcc-msm8974.c @@ -204,6 +204,12 @@ static

[PATCH v2 0/4] Add Qualcomm APQ8084 SoC support

2014-05-23 Thread Georgi Djakov
This patchset adds basic support for the Qualcomm Snapdragon 805 APQ8084 SoC. The first two patches add device-tree files for the SoC and the board, the third adds a board compatible string to the DT machine descriptor. The last one adds information about the low-level debug UART base address to

[PATCH v2 4/4] ARM: debug: qcom: add UART addresses to Kconfig help

2014-05-23 Thread Georgi Djakov
Add information about the APQ8084 debug UART physical and virtual addresses in the DEBUG_QCOM_UARTDM Kconfig help section. Requires: https://lkml.org/lkml/2014/4/14/312 Signed-off-by: Georgi Djakov gdja...@mm-sol.com --- arch/arm/Kconfig.debug |1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 2/4] ARM: dts: qcom: Add APQ8084-MTP board support

2014-05-23 Thread Georgi Djakov
Add device-tree file for APQ8084-MTP board, which belongs to the Snapdragon 805 family. Signed-off-by: Georgi Djakov gdja...@mm-sol.com --- arch/arm/boot/dts/Makefile |3 ++- arch/arm/boot/dts/qcom-apq8084-mtp.dts |6 ++ 2 files changed, 8 insertions(+), 1 deletion(-)

[PATCH v2 1/4] ARM: dts: qcom: Add APQ8084 SoC support

2014-05-23 Thread Georgi Djakov
Add support for the Qualcomm Snapdragon 805 APQ8084 SoC. It is used on APQ8084-MTP and other boards. Signed-off-by: Georgi Djakov gdja...@mm-sol.com --- arch/arm/boot/dts/qcom-apq8084.dtsi | 179 +++ 1 file changed, 179 insertions(+) create mode 100644

Re: [PATCH v2 4/4] ARM: debug: qcom: add UART addresses to Kconfig help

2014-05-23 Thread Matthias Brugger
2014-05-23 17:12 GMT+02:00 Georgi Djakov gdja...@mm-sol.com: Add information about the APQ8084 debug UART physical and virtual addresses in the DEBUG_QCOM_UARTDM Kconfig help section. Requires: https://lkml.org/lkml/2014/4/14/312 Signed-off-by: Georgi Djakov gdja...@mm-sol.com ---

[GIT PULL] qcom defconfig changes for v3.16

2014-05-23 Thread Kumar Gala
The following changes since commit c9eaa447e77efe77b7fa4c953bd62de8297fd6c5: Linux 3.15-rc1 (2014-04-13 14:18:35 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/galak/linux-qcom.git tags/qcom-defconfig-for-3.16 for you to fetch changes up to

Re: [Patch v2 3/4] soc: qcom: Add GSBI driver

2014-05-23 Thread Stephen Boyd
On 04/24/14 09:31, Andy Gross wrote: + +static const struct of_device_id gsbi_dt_match[] = { + { .compatible = qcom,gsbi-v1.0.0, }, +}; Eek. This isn't NULL terminated. -8--- From: Stephen Boyd sb...@codeaurora.org Subject: [PATCH] soc: qcom: Terminate gsbi of match table Failure

Re: [PATCH 0/5] ks8851 DT updates

2014-05-23 Thread David Miller
From: Stephen Boyd sb...@codeaurora.org Date: Thu, 22 May 2014 14:00:08 -0700 This set of patches properly documents the micrel ks8851 spi ethernet controller, converts to devm_regulator_get_optional() to make error paths slightly simpler, and finally adds supports for another optional

[PATCH v2 2/4] net: ks8851: Use devm_regulator_get_optional()

2014-05-23 Thread Stephen Boyd
This simplifies error paths and removes the need to regulator_put(). Cc: Nishanth Menon n...@ti.com Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/net/ethernet/micrel/ks8851.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git

[PATCH v2 0/4] ks8851 DT/regulator/gpio updates

2014-05-23 Thread Stephen Boyd
This set of patches properly documents the micrel ks8851 spi ethernet controller, converts to devm_regulator_get_optional() to make error paths slightly simpler, and finally adds supports for another optional regulator and a reset gpio. This allows me to use the ks8851 on my MSM8960 CDP board.

[PATCH v2 3/4] net: ks8851: Add optional vdd_io regulator and reset gpio

2014-05-23 Thread Stephen Boyd
Allow the ks8851 driver to enable an optional 1.8V vdd_io regulator and assert the reset pin to the phy if a reset gpio is present in device tree. Cc: Nishanth Menon n...@ti.com Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/net/ethernet/micrel/ks8851.c | 54

[PATCH v2 4/4] net: ks8851: Add of match table

2014-05-23 Thread Stephen Boyd
Users are currently just providing ks8851 as the compatible for this driver in device tree. Add a compatible string that provides the vendor name along with the device name to be more explicit. Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/net/ethernet/micrel/ks8851.c | 6 ++

Re: [GIT PULL] qcom DT changes for v3.16

2014-05-23 Thread Arnd Bergmann
On Friday 23 May 2014, Kumar Gala wrote: Qualcomm ARM Based Device Tree Updates for v3.16 * Added device tree nodes for pinctrl and SDHC for msm8974 SoC/DB8074 board * Added binding spec for GSBI configuration node Pulled

Re: [GIT PULL] qcom defconfig changes for v3.16

2014-05-23 Thread Arnd Bergmann
On Friday 23 May 2014, Kumar Gala wrote: Qualcomm ARM Based defconfig Updates for v3.16 * Add a new qcom_defconfig for mach-qcom * Update msm_defconfig for handling building the old mach-msm Merged into next/defconfig, thanks! Arnd -- To unsubscribe from this list: send the line

Re: [GIT PULL] qcom driver changes for v3.16

2014-05-23 Thread Arnd Bergmann
On Friday 23 May 2014, Kumar Gala wrote: The following changes since commit c9eaa447e77efe77b7fa4c953bd62de8297fd6c5: Linux 3.15-rc1 (2014-04-13 14:18:35 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/galak/linux-qcom.git

Re: [PATCH] clk: qcom: Fix blsp2_ahb_clk register offset

2014-05-23 Thread Mike Turquette
Quoting Georgi Djakov (2014-05-20 09:50:54) The address of the blsp2_ahb_clk register is incorrect. Fix it. Signed-off-by: Georgi Djakov gdja...@mm-sol.com Applied to clk-next. Regards, Mike --- drivers/clk/qcom/gcc-msm8974.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v3 13/13] mmc: mmci: Add Qcom specific pio_read function.

2014-05-23 Thread Stephen Boyd
On 05/23/14 05:53, srinivas.kandaga...@linaro.org wrote: @@ -1022,6 +1025,40 @@ mmci_cmd_irq(struct mmci_host *host, struct mmc_command *cmd, } } +static int mmci_qcom_pio_read(struct mmci_host *host, char *buffer, + unsigned int remain) +{ + u32 *ptr =

Re: arm-soc build: 12 warnings 0 failures (arm-soc/v3.15-rc6-907-ge7c189d)

2014-05-23 Thread Stephen Boyd
On 05/23/14 16:28, Olof's autobuilder wrote: Warnings: 1 arch/arm/mach-msm/board-trout-gpio.c:120:2: warning: passing argument 2 of '__raw_writeb' makes pointer from integer without a cast [enabled by default] 1 arch/arm/mach-msm/board-trout-gpio.c:135:2: warning: passing

[PATCH] pinctrl: msm: Add missing sdc1 and sdc3 groups for apq8064

2014-05-23 Thread Bjorn Andersson
Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- drivers/pinctrl/pinctrl-apq8064.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-apq8064.c b/drivers/pinctrl/pinctrl-apq8064.c index 23c4c21..3adf9fd 100644 ---

[PATCH] spi: Set cs-gpios to output direction

2014-05-23 Thread Stephen Boyd
Some gpios used for cs-gpios may not be configured for output by default. In these cases gpio_set_value() won't have any effect and so the chip select line won't toggle. Request the cs-gpios and set them to output direction once we know if the chip select is default high or default low. Cc: Linus