Re: [PATCH v3 3/4] scsi: ufs: add trace events and dump prints for debug

2015-03-01 Thread Gilad Broner
If I understand the patch above, you basically have: if () goto out; else ret = ufshcd_resume(); out: Wouldn't it be better to just reverse the above if condition? if (!...) ret = ufshcd_resume(); That would be much less

Re: [PATCH v3 2/4] scsi: ufs: add debugfs for ufs

2015-03-01 Thread Gilad Broner
+#define UFSHCD_UPDATE_TAG_STATS(hba, tag) +#define UFSHCD_UPDATE_TAG_STATS_COMPLETION(hba, cmd) +#define UFSHCD_UPDATE_ERROR_STATS(hba, type) + +#endif Is there any reason that these are defined as macros instead of static functions? No special reason that I'm aware of. I will convert

Re: [PATCH v6 1/2] DT: hwspinlock: Add binding documentation for Qualcomm hwmutex

2015-03-01 Thread Andy Gross
On Fri, Feb 27, 2015 at 02:30:16PM -0800, Bjorn Andersson wrote: Add binding documentation for the Qualcomm Hardware Mutex. Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- Looks fine. Reviewed-by: Andy Gross agr...@codeaurora.org -- Qualcomm Innovation Center, Inc. The

[PATCH 3/6] clk: qcom: gdsc: Add GDSCs in msm8916 GCC

2015-03-01 Thread Rajendra Nayak
Add all data for the GDSCs which are part of msm8916 GCC block. Signed-off-by: Rajendra Nayak rna...@codeaurora.org --- drivers/clk/qcom/Kconfig | 1 + drivers/clk/qcom/gcc-msm8916.c | 46

[PATCH 4/6] clk: qcom: gdsc: Add GDSCs in msm8974 GCC

2015-03-01 Thread Rajendra Nayak
From: Stephen Boyd sb...@codeaurora.org Theres just one GDSC as part of the msm8974 GCC block. Signed-off-by: Stephen Boyd sb...@codeaurora.org Signed-off-by: Rajendra Nayak rna...@codeaurora.org --- drivers/clk/qcom/Kconfig | 1 + drivers/clk/qcom/gcc-msm8974.c

[PATCH 2/6] clk: qcom: gdsc: Prepare common clk probe to register gdscs

2015-03-01 Thread Rajendra Nayak
The common clk probe registers a clk provider and a reset controller. Update it to register a genpd provider using the gdsc data provided by each platform. Signed-off-by: Rajendra Nayak rna...@codeaurora.org --- drivers/clk/qcom/common.c | 27 ++-

[PATCH 0/6] Add support for QCOM GDSCs

2015-03-01 Thread Rajendra Nayak
GDSCs (Global Distributed Switch Controllers) control switches that supply power to an on-chip power domain and hence can be programmed in SW to safely power collapse and restore power to the respective PDs. They are part of a considerable number of recent QCOM SoCs (This series adds support for

[PATCH 1/6] clk: qcom: Add support for GDSCs

2015-03-01 Thread Rajendra Nayak
From: Stephen Boyd sb...@codeaurora.org GDSCs (Global Distributed Switch Controllers) are responsible for safely collapsing and restoring power to peripherals in the SoC. These are best modelled as power domains using genpd and given the registers are scattered throughout the clock controller

[PATCH 5/6] clk: qcom: gdsc: Add GDSCs in msm8974 MMCC

2015-03-01 Thread Rajendra Nayak
From: Stephen Boyd sb...@codeaurora.org Add the GDSC instances that exist as part of msm8974 MMCC block Signed-off-by: Stephen Boyd sb...@codeaurora.org Signed-off-by: Rajendra Nayak rna...@codeaurora.org --- drivers/clk/qcom/Kconfig | 1 + drivers/clk/qcom/mmcc-msm8974.c

[PATCH 6/6] clk: qcom: gdsc: Add GDSCs in apq8084 GCC

2015-03-01 Thread Rajendra Nayak
Add the GDSC instances that exist as part of apq8084 GCC block Signed-off-by: Rajendra Nayak rna...@codeaurora.org --- drivers/clk/qcom/gcc-apq8084.c | 38 include/dt-bindings/clock/qcom,gcc-apq8084.h | 6 + 2 files changed, 44 insertions(+) diff