Re: [PATCH v6 2/2] hwspinlock: qcom: Add support for Qualcomm HW, Mutex block

2015-03-12 Thread Ohad Ben-Cohen
On Thu, Mar 12, 2015 at 12:15 AM, Andy Gross agr...@codeaurora.org wrote: On Wed, Mar 11, 2015 at 01:42:38PM -0700, Tim Bird wrote: snip I'm pretty anxious about this one, as my current work has a dependency on it. Virtually the entirety of the QualComm SOC work is dependent on this because

Re: [PATCH v6 1/2] DT: hwspinlock: Add binding documentation for Qualcomm hwmutex

2015-03-12 Thread Ohad Ben-Cohen
Hi Mark, Rob, On Sat, Feb 28, 2015 at 12:30 AM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: Add binding documentation for the Qualcomm Hardware Mutex. Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- I think the conclusion on the dt binding discussion for

Re: [PATCH v2 1/3] devicetree: bindings: Document qcom,msm-id and qcom,board-id

2015-03-12 Thread Kumar Gala
On Mar 11, 2015, at 10:33 AM, Bjorn Andersson bj...@kryo.se wrote: On Tue, Mar 10, 2015 at 12:57 PM, Kumar Gala ga...@codeaurora.org wrote: On Mar 10, 2015, at 2:52 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 13:10:08 Kumar Gala wrote: The top level qcom,msm-id and

Re: [PATCH 5/5] drm/msm/mdp5: Add hardware configuration for msm8x16

2015-03-12 Thread Archit Taneja
Hi, On 03/09/2015 06:41 PM, Stephane Viau wrote: This change adds the hw configuration for msm8x16 chipsets in mdp5_cfg module. Note that only one external display interface is present in this configuration (DSI) but has not been enabled yet. It will be enabled once drm/msm driver supports DSI

Re: [PATCH v2 1/3] devicetree: bindings: Document qcom,msm-id and qcom,board-id

2015-03-12 Thread Kumar Gala
On Mar 11, 2015, at 3:20 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 08:33:04 Bjorn Andersson wrote: But are these values actually used by the boot loader? As far as I could see in 8974 the dtbTool provided by Qualcomm extracts the values from the list of dtbs and

Re: [PATCH v6 1/2] DT: hwspinlock: Add binding documentation for Qualcomm hwmutex

2015-03-12 Thread Bjorn Andersson
On Thu 12 Mar 02:51 PDT 2015, Mark Rutland wrote: On Fri, Feb 27, 2015 at 10:30:16PM +, Bjorn Andersson wrote: Add binding documentation for the Qualcomm Hardware Mutex. Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- I think the conclusion on the dt binding

[PATCH v6 3/3] scsi: ufs: add trace events and dump prints for debug

2015-03-12 Thread Gilad Broner
Add trace events to driver to allow monitoring and profilig of activities such as PM suspend/resume, hibernate enter/exit, clock gating and clock scaling up/down. In addition, add UFS host controller register dumps to provide detailed information in case of errors to assist in analysis of issues.

[PATCH v6 2/3] scsi: ufs: add debugfs for ufs

2015-03-12 Thread Gilad Broner
From: Lee Susman lsus...@codeaurora.org Adding debugfs capability for ufshcd. debugfs attributes introduced in this patch: - View driver/controller runtime data - Command tag statistics for performance analisis - Dump device descriptor info - Track recoverable errors statistics during

Re: [RFC PATCH v15 04/11] ARM: cpuidle: Register cpuidle_ops for QCOM cpus

2015-03-12 Thread Daniel Lezcano
On 03/11/2015 07:16 PM, Stephen Boyd wrote: On 03/09/15 08:16, Lina Iyer wrote: Register cpuidle ops for Krait Processor Sub-System. Supports v1 and v2 versions of KPSS. Cc: Stephen Boyd sb...@codeaurora.org Cc: Arnd Bergmann a...@arndb.de Cc: Kevin Hilman khil...@linaro.org Cc: Daniel Lezcano

Re: [PATCH v6 1/3] scsi: ufs: add ioctl interface for query request

2015-03-12 Thread Akinobu Mita
2015-03-12 21:27 GMT+09:00 Gilad Broner gbro...@codeaurora.org: From: Dolev Raviv dra...@codeaurora.org This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device.

[PATCH v7 0/3] Add ioctl and debug utilities to UFS driver

2015-03-12 Thread Gilad Broner
Changes from V6: Moved NULL user argument check from ufshcd_ioctl to ufshcd_query_ioctl. Add comment in include/scsi/scsi.h to note 0x5388 is in use. Dolev Raviv (1): scsi: ufs: add ioctl interface for query request Gilad Broner (1): scsi: ufs: add trace events and dump prints for debug Lee

[PATCH v7 1/3] scsi: ufs: add ioctl interface for query request

2015-03-12 Thread Gilad Broner
From: Dolev Raviv dra...@codeaurora.org This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Signed-off-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Noa Rubens

[PATCH v7 1/3] scsi: ufs: add ioctl interface for query request

2015-03-12 Thread Gilad Broner
From: Dolev Raviv dra...@codeaurora.org This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Signed-off-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Noa Rubens

[PATCH v4 1/2] leds: add DT binding for Qualcomm PM8941 WLED block

2015-03-12 Thread Bjorn Andersson
From: Courtney Cavin courtney.ca...@sonymobile.com This adds device tree binding documentation for the WLED ('White' LED) block on Qualcomm's PM8941 PMICs. Signed-off-by: Courtney Cavin courtney.ca...@sonymobile.com Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- Changes since

Re: [RFC PATCH v15 04/11] ARM: cpuidle: Register cpuidle_ops for QCOM cpus

2015-03-12 Thread Lina Iyer
On Thu, Mar 12 2015 at 06:34 -0600, Daniel Lezcano wrote: On 03/11/2015 07:16 PM, Stephen Boyd wrote: On 03/09/15 08:16, Lina Iyer wrote: [...] +#if IS_ENABLED(CONFIG_QCOM_PM) Why not #ifdef CONFIG_QCOM_PM? I thought IS_ENABLED was for C code where you want to put it in an if ()

Re: [RFC PATCH 00/18] ARM: msm multiplatform support

2015-03-12 Thread Arnd Bergmann
On Saturday 07 March 2015 03:12:12 dwal...@fifo99.com wrote: On Wed, Mar 04, 2015 at 08:32:54PM +0100, Arnd Bergmann wrote: This is my final piece of the puzzle for ARMv6/v7 multiplatform support. In combination with the other patches that are now at

Re: [PATCH v6 2/2] hwspinlock: qcom: Add support for Qualcomm HW, Mutex block

2015-03-12 Thread Tim Bird
On 03/12/2015 01:16 AM, Ohad Ben-Cohen wrote: On Thu, Mar 12, 2015 at 12:15 AM, Andy Gross agr...@codeaurora.org wrote: On Wed, Mar 11, 2015 at 01:42:38PM -0700, Tim Bird wrote: snip I'm pretty anxious about this one, as my current work has a dependency on it. Virtually the entirety of

Re: [PATCH v6 1/3] scsi: ufs: add ioctl interface for query request

2015-03-12 Thread Gilad Broner
+ if (!buffer) { + dev_err(hba-dev, %s: User buffer is NULL!\n, __func__); + return -EINVAL; + } + Should we remove this check or move it into ufshcd_query_ioctl()? For example, BLKFLS ioctl without argument is correct usage, but it always triggers

[PATCH v7 2/3] scsi: ufs: add debugfs for ufs

2015-03-12 Thread Gilad Broner
From: Lee Susman lsus...@codeaurora.org Adding debugfs capability for ufshcd. debugfs attributes introduced in this patch: - View driver/controller runtime data - Command tag statistics for performance analisis - Dump device descriptor info - Track recoverable errors statistics during

[PATCH v7 0/3] Add ioctl and debug utilities to UFS driver

2015-03-12 Thread Gilad Broner
Changes from V6: Moved NULL user argument check from ufshcd_ioctl to ufshcd_query_ioctl. Add comment in include/scsi/scsi.h to note 0x5388 is in use. *** BLURB HERE *** Dolev Raviv (1): scsi: ufs: add ioctl interface for query request Gilad Broner (1): scsi: ufs: add trace events and dump

Re: [PATCH v3 2/4] arm64: dts: Add Qualcomm MSM8916 SoC and evaluation board dts

2015-03-12 Thread Mark Rutland
Hi Kumar, +/ { + model = Qualcomm Technologies, Inc. MSM 8916 MTP; + compatible = qcom,msm8916-mtp, qcom,msm8916-mtp-smb1360, + qcom,msm8916, qcom,mtp; +}; No /chosen/stdout-path? Does your UART driver support earlycon? [...] + cpus { +

[PATCH] drm/msm: Refactor msm drm driver to be able to support module

2015-03-12 Thread Jilai Wang
Each HW component's driver such as HDMI/eDP/DSI should be able to compiled as a module which allows user to prevent this part of code to be compiled if not needed. Signed-off-by: Jilai Wang jil...@codeaurora.org --- drivers/gpu/drm/msm/adreno/adreno_device.c | 13 +--

Re: [PATCH v3 2/4] arm64: dts: Add Qualcomm MSM8916 SoC and evaluation board dts

2015-03-12 Thread Kumar Gala
On Mar 12, 2015, at 12:05 PM, Mark Rutland mark.rutl...@arm.com wrote: Hi Kumar, +/ { +model = Qualcomm Technologies, Inc. MSM 8916 MTP; +compatible = qcom,msm8916-mtp, qcom,msm8916-mtp-smb1360, +qcom,msm8916, qcom,mtp; +}; No /chosen/stdout-path? Nope ;).

Re: [PATCH] Lock 7 is cpuidle specific, use non-generic value for locking

2015-03-12 Thread Lina Iyer
On Thu, Mar 12 2015 at 14:35 -0600, Stephen Boyd wrote: On 03/12/15 12:38, Lina Iyer wrote: --- sign off? :) I was just hacking it to make it easier to understand. Sure. drivers/hwspinlock/qcom_hwspinlock.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff

[PATCH] drm/msm: Refactor msm drm driver by introducing msm_drm_sub_dev

2015-03-12 Thread Jilai Wang
Introduce msm_drm_sub_dev for each mdp interface component such as HDMI/eDP/DSI to contain common information shared with MDP. Signed-off-by: Jilai Wang jil...@codeaurora.org --- drivers/gpu/drm/msm/edp/edp.c | 18 +-- drivers/gpu/drm/msm/edp/edp.h | 1 +

Re: [PATCH] Lock 7 is cpuidle specific, use non-generic value for locking

2015-03-12 Thread Lina Iyer
On Thu, Mar 12 2015 at 14:49 -0600, Andy Gross wrote: On Thu, Mar 12, 2015 at 01:38:28PM -0600, Lina Iyer wrote: snip static int qcom_hwspinlock_trylock(struct hwspinlock *lock) { struct regmap_field *field = lock-priv; u32 lock_owner; int ret; + u32 proc_id;

Re: [PATCH] Lock 7 is cpuidle specific, use non-generic value for locking

2015-03-12 Thread Stephen Boyd
On 03/12/15 13:48, Lina Iyer wrote: On Thu, Mar 12 2015 at 14:35 -0600, Stephen Boyd wrote: On 03/12/15 12:38, Lina Iyer wrote: --- sign off? :) I was just hacking it to make it easier to understand. Sure. drivers/hwspinlock/qcom_hwspinlock.c | 15 +++ 1 file changed, 11

[PATCH v4 2/2] leds: add Qualcomm PM8941 WLED driver

2015-03-12 Thread Bjorn Andersson
From: Courtney Cavin courtney.ca...@sonymobile.com This adds support for the WLED ('White' LED) block on Qualcomm's PM8941 PMICs. Signed-off-by: Courtney Cavin courtney.ca...@sonymobile.com Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- Changes since v3: - Use devres helper

[PATCH v7 3/3] scsi: ufs: add trace events and dump prints for debug

2015-03-12 Thread Gilad Broner
Add trace events to driver to allow monitoring and profilig of activities such as PM suspend/resume, hibernate enter/exit, clock gating and clock scaling up/down. In addition, add UFS host controller register dumps to provide detailed information in case of errors to assist in analysis of issues.

Re: [PATCH v6 2/2] hwspinlock: qcom: Add support for Qualcomm HW Mutex block

2015-03-12 Thread Lina Iyer
On Fri, Feb 27 2015 at 15:30 -0700, Bjorn Andersson wrote: Add driver for Qualcomm Hardware Mutex block found in many Qualcomm SoCs. Based on initial effort by Kumar Gala ga...@codeaurora.org Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- [...] +#include

Re: [PATCH v6 2/2] hwspinlock: qcom: Add support for Qualcomm HW Mutex block

2015-03-12 Thread Andy Gross
On Thu, Mar 12, 2015 at 01:31:50PM -0600, Lina Iyer wrote: On Fri, Feb 27 2015 at 15:30 -0700, Bjorn Andersson wrote: Add driver for Qualcomm Hardware Mutex block found in many Qualcomm SoCs. Based on initial effort by Kumar Gala ga...@codeaurora.org Signed-off-by: Bjorn Andersson

[PATCH] Lock 7 is cpuidle specific, use non-generic value for locking

2015-03-12 Thread Lina Iyer
--- drivers/hwspinlock/qcom_hwspinlock.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c index 93b62e0..7642524 100644 --- a/drivers/hwspinlock/qcom_hwspinlock.c +++

Re: [PATCH v6 2/2] hwspinlock: qcom: Add support for Qualcomm HW Mutex block

2015-03-12 Thread Lina Iyer
On Thu, Mar 12 2015 at 13:43 -0600, Andy Gross wrote: On Thu, Mar 12, 2015 at 01:31:50PM -0600, Lina Iyer wrote: On Fri, Feb 27 2015 at 15:30 -0700, Bjorn Andersson wrote: Add driver for Qualcomm Hardware Mutex block found in many Qualcomm SoCs. Based on initial effort by Kumar Gala

Re: [PATCH v3 2/4] arm64: dts: Add Qualcomm MSM8916 SoC and evaluation board dts

2015-03-12 Thread Kumar Gala
On Mar 12, 2015, at 1:25 PM, Mark Rutland mark.rutl...@arm.com wrote: + cpus { + #address-cells = 1; + #size-cells = 0; + + CPU0: cpu@0 { + device_type = cpu; + compatible = arm,cortex-a53, arm,armv8; + reg =

Re: [PATCH v3 2/4] arm64: dts: Add Qualcomm MSM8916 SoC and evaluation board dts

2015-03-12 Thread Mark Rutland
+ cpus { + #address-cells = 1; + #size-cells = 0; + + CPU0: cpu@0 { + device_type = cpu; + compatible = arm,cortex-a53, arm,armv8; + reg = 0x0; + }; + + CPU1: cpu@1 { +

[PATCH v4 2/4] arm64: dts: Add Qualcomm MSM8916 SoC and evaluation board dts

2015-03-12 Thread Kumar Gala
Add initial device tree support for Qualcomm MSM8916 SoC and MTP8916 evaluation board. At the current time we only boot up a single processor. Signed-off-by: Kumar Gala ga...@codeaurora.org --- v4: * Added chosen node so we dont need to spec everything for earlycon * fixed up timer node to

Re: [PATCH] Lock 7 is cpuidle specific, use non-generic value for locking

2015-03-12 Thread Lina Iyer
On Thu, Mar 12 2015 at 15:12 -0600, Stephen Boyd wrote: On 03/12/15 13:48, Lina Iyer wrote: On Thu, Mar 12 2015 at 14:35 -0600, Stephen Boyd wrote: On 03/12/15 12:38, Lina Iyer wrote: --- sign off? :) I was just hacking it to make it easier to understand. Sure.

Re: [PATCH v6 2/2] hwspinlock: qcom: Add support for Qualcomm HW Mutex block

2015-03-12 Thread Lina Iyer
On Fri, Feb 27 2015 at 15:30 -0700, Bjorn Andersson wrote: Add driver for Qualcomm Hardware Mutex block found in many Qualcomm SoCs. Based on initial effort by Kumar Gala ga...@codeaurora.org Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com +config HWSPINLOCK_QCOM + tristate

Re: [PATCH v5 3/3] scsi: ufs: add trace events and dump prints for debug

2015-03-12 Thread Gilad Broner
This and the auto_bkops_state is pretty much the same. Can't you use the same TP_printk() and just have a DECLARE_EVENT_CLASS? The trace point name is printed with the event to see different events. I agree. will upload the fix in next patchset. -- Qualcomm Israel, on behalf of Qualcomm

[PATCH v6 0/3] Add ioctl and debug utilities to UFS driver

2015-03-12 Thread Gilad Broner
Changes from V5: Created a common trace event class for driver state changes instead of individual trace events definitions. Dolev Raviv (1): scsi: ufs: add ioctl interface for query request Gilad Broner (1): scsi: ufs: add trace events and dump prints for debug Lee Susman (1): scsi: ufs:

[PATCH v6 1/3] scsi: ufs: add ioctl interface for query request

2015-03-12 Thread Gilad Broner
From: Dolev Raviv dra...@codeaurora.org This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Signed-off-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Noa Rubens

Re: [PATCH v6 1/2] DT: hwspinlock: Add binding documentation for Qualcomm hwmutex

2015-03-12 Thread Mark Rutland
On Fri, Feb 27, 2015 at 10:30:16PM +, Bjorn Andersson wrote: Add binding documentation for the Qualcomm Hardware Mutex. Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- I think the conclusion on the dt binding discussion for hwspinlocks was that we're down to having