Re: [PATCH v3] mfd: Add specific compatible strings for Qualcomm's SPMI PMIC's

2015-03-23 Thread Lee Jones
I want to see if Stephen B is now happy with this. Not CC'ing him as a previous review is bad form IMO. Some of the PMIC's could have specific regmap configuration tables in future, so add specific compatible strings for known PMIC's. Also print runtime detected chip revision information.

Re: [PATCH 3/4] drm/msm: Initial add DSI connector support

2015-03-23 Thread Archit Taneja
Hi Hai, On 03/19/2015 02:35 AM, h...@codeaurora.org wrote: Hi Archit, Thanks for your comments. Please see my response for some comments below. Comments without response will be addressed in patch version 2. I will wait for other comments if any to push patch V2. +static int

Re: [PATCH v3 3/4] drm/msm/mdp5: Add START signal to kick off certain pipelines

2015-03-23 Thread Archit Taneja
Hi Stephane, On 03/14/2015 01:19 AM, Stephane Viau wrote: Some interfaces (WB, DSI Command Mode) need to be kicked off through a START Signal. This signal needs to be sent at the right time and requests in some cases to keep track of the pipeline status (eg: whether pipeline registers are

[PATCH v17] Currently SPM driver always initializes before the cpuidle driver

2015-03-23 Thread Lina Iyer
Remove unnecessary complexity in supporting initialization of SPM driver after cpuidle driver. The current kernel initializes SPM driver before cpuidle driver. Signed-off-by: Lina Iyer lina.i...@linaro.org --- drivers/soc/qcom/spm.c | 28 1 file changed, 4

Re: [PATCH v3 3/4] drm/msm/mdp5: Add START signal to kick off certain pipelines

2015-03-23 Thread Archit Taneja
On 03/24/2015 03:40 AM, Stéphane Viau wrote: Hi Archit, Hi Stephane, On 03/14/2015 01:19 AM, Stephane Viau wrote: Some interfaces (WB, DSI Command Mode) need to be kicked off through a START Signal. This signal needs to be sent at the right time and requests in some cases to keep track of

[PATCH v3] mmc: sdhci-msm: Add support for vendor capabilities registers

2015-03-23 Thread Georgi Djakov
Some versions of this controller do not advertise their 3.0v and 8bit bus-width support capabilities. It is required to explicitly set these capabilities for the specific controller versions. Signed-off-by: Georgi Djakov georgi.dja...@linaro.org --- Changes since v2: * Use the generic sdhci

Re: [PATCH v3] mfd: Add specific compatible strings for Qualcomm's SPMI PMIC's

2015-03-23 Thread Stephen Boyd
On 03/23, Lee Jones wrote: I want to see if Stephen B is now happy with this. Not CC'ing him as a previous review is bad form IMO. Some of the PMIC's could have specific regmap configuration tables in future, so add specific compatible strings for known PMIC's. Also print runtime

Re: [PATCH v17 04/10] ARM: dts: qcom: Add power-controller device node for 8074 Krait CPUs

2015-03-23 Thread Kumar Gala
On Mar 20, 2015, at 1:21 PM, Lina Iyer lina.i...@linaro.org wrote: Each Krait CPU in the QCOM 8074/8974 SoC has an SAW power controller to regulate the power to the cpu and aide the core in entering idle states. Reference the SAW instance and associate the instance with the CPU core. Cc:

Re: [PATCH v2 1/7] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-23 Thread Srinivas Kandagatla
On 23/03/15 21:09, Mark Brown wrote: On Fri, Mar 13, 2015 at 09:50:14AM +, Srinivas Kandagatla wrote: A couple of *very* minor points below, otherwise this looks OK to me. Thankyou for the review. +struct eeprom_device *eeprom_register(struct eeprom_config *config) +{ + struct

Re: [PATCH v2 1/7] eeprom: Add a simple EEPROM framework for eeprom providers

2015-03-23 Thread Mark Brown
On Fri, Mar 13, 2015 at 09:50:14AM +, Srinivas Kandagatla wrote: A couple of *very* minor points below, otherwise this looks OK to me. +struct eeprom_device *eeprom_register(struct eeprom_config *config) +{ + struct eeprom_device *eeprom; + int rval; + + if (!config-regmap

Re: [PATCH v17 01/10] ARM: qcom: Add Subsystem Power Manager (SPM) driver

2015-03-23 Thread Kumar Gala
On Mar 20, 2015, at 1:21 PM, Lina Iyer lina.i...@linaro.org wrote: Based on work by: Mahesh Sivasubramanian msiva...@codeaurora.org, Ai Li a...@codeaurora.org, Praveen Chidambaram pchid...@codeaurora.org Original tree available at - git://codeaurora.org/quic/la/kernel/msm-3.10.git Cc:

Re: [PATCH v3 3/4] drm/msm/mdp5: Add START signal to kick off certain pipelines

2015-03-23 Thread Stéphane Viau
Hi Archit, Hi Stephane, On 03/14/2015 01:19 AM, Stephane Viau wrote: Some interfaces (WB, DSI Command Mode) need to be kicked off through a START Signal. This signal needs to be sent at the right time and requests in some cases to keep track of the pipeline status (eg: whether pipeline

Re: [PATCH 3/4] drm/msm: Initial add DSI connector support

2015-03-23 Thread hali
Hi Archit, Hi Hai, On 03/19/2015 02:35 AM, h...@codeaurora.org wrote: Hi Archit, Thanks for your comments. Please see my response for some comments below. Comments without response will be addressed in patch version 2. I will wait for other comments if any to push patch V2. +static int

[PATCH 01/10] ARM: qcom: Add Subsystem Power Manager (SPM) driver

2015-03-23 Thread Lina Iyer
SPM is a hardware block that controls the peripheral logic surrounding the application cores (cpu/l$). When the core executes WFI instruction, the SPM takes over the putting the core in low power state as configured. The wake up for the SPM is an interrupt at the GIC, which then completes the rest

Re: [PATCH] drm/msm: Refactor msm drm driver by introducing msm_drm_sub_dev

2015-03-23 Thread Rob Clark
On Thu, Mar 12, 2015 at 4:48 PM, Jilai Wang jil...@codeaurora.org wrote: Introduce msm_drm_sub_dev for each mdp interface component such as HDMI/eDP/DSI to contain common information shared with MDP. Signed-off-by: Jilai Wang jil...@codeaurora.org --- drivers/gpu/drm/msm/edp/edp.c

[PATCH] arm64: dts: Add Qualcomm APQ8016 SBC evaluation board dts

2015-03-23 Thread Kumar Gala
Add initial device tree support for Qualcomm APQ8016 SBC Evaluation board. This board is also referred to as the DragonBoard 410c. Signed-off-by: Kumar Gala ga...@codeaurora.org --- arch/arm64/boot/dts/qcom/Makefile | 2 +- arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 22

Re: [PATCH v3 0/3] clk: qcom: Introduce parent_map tables

2015-03-23 Thread Stephen Boyd
On 03/20, Georgi Djakov wrote: This patchset introduces the parent_map index tables, which solve the issue discussed here [1]. While doing this, fix also some of the code around (patches 1 and 2). [1] https://lkml.org/lkml/2015/3/5/682 Patchset based on clk-next. Thanks. Applied all to

Re: [PATCH v3 2/2] clk: qcom: Add MSM8916 Global Clock Controller support

2015-03-23 Thread Stephen Boyd
On 03/18, Georgi Djakov wrote: + +enum { + P_XO, + P_GPLL0, + P_GPLL0_AUX, + P_BIMC, + P_GPLL1, + P_GPLL1_AUX, + P_GPLL2, + P_GPLL2_AUX, + P_SLEEP_CLK, + P_DSI0_PHYPLL_BYTE, + P_DSI0_PHYPLL_DSI, +}; + +static const struct parent_map

Re: [PATCH v17 01/10] ARM: qcom: Add Subsystem Power Manager (SPM) driver

2015-03-23 Thread Lina Iyer
On Mon, Mar 23 2015 at 16:06 -0600, Kumar Gala wrote: On Mar 20, 2015, at 1:21 PM, Lina Iyer lina.i...@linaro.org wrote: Based on work by: Mahesh Sivasubramanian msiva...@codeaurora.org, Ai Li a...@codeaurora.org, Praveen Chidambaram pchid...@codeaurora.org Original tree available at -

Re: [PATCH v3 1/6] clk: qcom: Add support for GDSCs

2015-03-23 Thread Stephen Boyd
On 03/20, Rajendra Nayak wrote: []... @@ -0,0 +1,46 @@ +/* + * Copyright (c) 2015, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version

Re: [PATCH v17 04/10] ARM: dts: qcom: Add power-controller device node for 8074 Krait CPUs

2015-03-23 Thread Lina Iyer
On Mon, Mar 23 2015 at 16:05 -0600, Kumar Gala wrote: On Mar 20, 2015, at 1:21 PM, Lina Iyer lina.i...@linaro.org wrote: Each Krait CPU in the QCOM 8074/8974 SoC has an SAW power controller to regulate the power to the cpu and aide the core in entering idle states. Reference the SAW instance

Re: [PATCH v3 1/2] dt-bindings: Add #defines for MSM8916 clocks and resets

2015-03-23 Thread Stephen Boyd
On 03/18, Georgi Djakov wrote: Add clocks/resets defines for the global clock controller found on Qualcomm MSM8916 SoCs. Signed-off-by: Georgi Djakov georgi.dja...@linaro.org --- Applied to clk-next. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation

Re: [PATCH v17 01/10] ARM: qcom: Add Subsystem Power Manager (SPM) driver

2015-03-23 Thread Kumar Gala
On Mar 23, 2015, at 4:15 PM, Lina Iyer lina.i...@linaro.org wrote: On Mon, Mar 23 2015 at 16:06 -0600, Kumar Gala wrote: On Mar 20, 2015, at 1:21 PM, Lina Iyer lina.i...@linaro.org wrote: Based on work by: Mahesh Sivasubramanian msiva...@codeaurora.org, Ai Li a...@codeaurora.org,

Re: [PATCH v17 01/10] ARM: qcom: Add Subsystem Power Manager (SPM) driver

2015-03-23 Thread Lina Iyer
On Mon, Mar 23 2015 at 17:38 -0600, Kumar Gala wrote: On Mar 23, 2015, at 4:15 PM, Lina Iyer lina.i...@linaro.org wrote: On Mon, Mar 23 2015 at 16:06 -0600, Kumar Gala wrote: On Mar 20, 2015, at 1:21 PM, Lina Iyer lina.i...@linaro.org wrote: Based on work by: Mahesh Sivasubramanian

Re: [PATCH v3 1/6] clk: qcom: Add support for GDSCs

2015-03-23 Thread Rajendra Nayak
On 03/24/2015 04:53 AM, Stephen Boyd wrote: On 03/20, Rajendra Nayak wrote: []... @@ -0,0 +1,46 @@ +/* + * Copyright (c) 2015, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General