the future of qualcomm SoC in linux

2013-11-01 Thread Daniel Walker
David, Bryan, In general this community wants all code maintained. Your intentions seem to be that you want to push code, but you want to orphan it fairly quickly after you push the code. I know this is true having worked with both of you and many of your developers, and recent events seem to

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-31 Thread Daniel Walker
On Wed, Oct 30, 2013 at 10:19:30PM -0700, Olof Johansson wrote: On Wed, Oct 30, 2013 at 7:45 PM, Daniel Walker dwal...@fifo99.com wrote: On Wed, Oct 30, 2013 at 05:36:58PM -0700, Olof Johansson wrote: On Wed, Oct 30, 2013 at 4:25 PM, Daniel Walker dwal...@fifo99.com wrote: So the current

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-31 Thread Daniel Walker
On Thu, Oct 31, 2013 at 08:53:58AM -0700, Olof Johansson wrote: On Thu, Oct 31, 2013 at 5:07 AM, Daniel Walker dwal...@fifo99.com wrote: On Wed, Oct 30, 2013 at 10:19:30PM -0700, Olof Johansson wrote: On Wed, Oct 30, 2013 at 7:45 PM, Daniel Walker dwal...@fifo99.com wrote: On Wed, Oct 30

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-31 Thread Daniel Walker
On Thu, Oct 31, 2013 at 10:12:03AM -0700, Kevin Hilman wrote: Daniel Walker dwal...@fifo99.com writes: No. The idea behind splitting them is to allow current platforms with active maintainers to progress without being held back. The older platforms can stay and have an opportunity

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-31 Thread Daniel Walker
On Thu, Oct 31, 2013 at 11:51:34AM -0700, Kevin Hilman wrote: Daniel Walker dwal...@fifo99.com writes: On Thu, Oct 31, 2013 at 10:12:03AM -0700, Kevin Hilman wrote: Daniel Walker dwal...@fifo99.com writes: No. The idea behind splitting them is to allow current platforms

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-31 Thread Daniel Walker
On Thu, Oct 31, 2013 at 07:23:30PM +, Russell King - ARM Linux wrote: On Thu, Oct 31, 2013 at 10:35:06AM -0700, Daniel Walker wrote: ARM and the sub-architectures is already confusing I don't think we need to start compounding the problem by allowing random whatever-you-want sub

Re: [PATCH 4/4] ARM: msm: Remove 8x50 support

2013-10-30 Thread Daniel Walker
On Wed, Oct 30, 2013 at 02:30:23PM +0100, Arnd Bergmann wrote: On Tuesday 29 October 2013, Daniel Walker wrote: Isn't this the Nexus one platform ? Same as the last one , why don't you just update it to use the device tree? This doesn't seem like it would be all that difficult. Please

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-30 Thread Daniel Walker
On Wed, Oct 30, 2013 at 04:08:27PM -0700, Kevin Hilman wrote: Olof Johansson o...@lixom.net writes: I would be very happy to take more code for the older Qualcomm chipset to enable full functionality for them, but it's been my impression that far from all that is needed to make it a

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-30 Thread Daniel Walker
On Wed, Oct 30, 2013 at 05:36:58PM -0700, Olof Johansson wrote: On Wed, Oct 30, 2013 at 4:25 PM, Daniel Walker dwal...@fifo99.com wrote: So the current users of those platforms are, what SOL ? What users? Show me one. What am I chop liver ? Daniel -- To unsubscribe from this list

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-29 Thread Daniel Walker
On Tue, Oct 29, 2013 at 08:37:28AM -0700, Olof Johansson wrote: Daniel, I would be very happy to take more code for the older Qualcomm chipset to enable full functionality for them, but it's been my impression that far from all that is needed to make it a useful platform is in the upstream

Re: [PATCH 2/4] ARM: msm: Remove 7x00 support

2013-10-29 Thread Daniel Walker
On Tue, Oct 29, 2013 at 10:39:45AM -0700, Olof Johansson wrote: On Tue, Oct 29, 2013 at 10:08 AM, Daniel Walker dwal...@fifo99.com wrote: Personally I think splitting mach- stuff isn't very useful or interesting.. There's just no technical reason for it, for example x86 and x86_64

Re: [PATCH 3/4] ARM: msm: Remove 7x30 supporty

2013-10-29 Thread Daniel Walker
Why wouldn't you just update it to use the device tree ? There are lots of phones our there using 7x30 .. This is one that Qualcomm specifically upstreamed, so what was the point of upstreaming it ? On Mon, Oct 28, 2013 at 01:43:25PM -0700, David Brown wrote: The MSM7x30 SoC support was

Re: [PATCH 4/4] ARM: msm: Remove 8x50 support

2013-10-29 Thread Daniel Walker
Isn't this the Nexus one platform ? Same as the last one , why don't you just update it to use the device tree? This doesn't seem like it would be all that difficult. On Mon, Oct 28, 2013 at 01:43:26PM -0700, David Brown wrote: The MSM8x50 SoC support was added in 2010 based on code from

Re: [PATCH v2] arm: msm: fix up very basic HTC Sapphire support

2012-05-12 Thread Daniel Walker
items on the first review and not now on the second one, but see below. Daniel, I don't mind fixing up minor things, but can you take care of the other issues that Olof has brought up. Thanks, David On Fri, May 11, 2012 at 5:15 PM, David Brown dav...@codeaurora.org wrote: From: Daniel Walker dwal

Re: [PATCH] arm: msm: trout: fix compile failure

2012-04-13 Thread Daniel Walker
On Thu, Apr 12, 2012 at 08:45:37AM -0700, Daniel Walker wrote: Fixes the following warnings, arch/arm/mach-msm/board-trout.c: In function 'trout_init': arch/arm/mach-msm/board-trout.c:71: error: 'system_rev' undeclared (first use in this function) arch/arm/mach-msm/board-trout.c:71: error

[PATCH] arm: msm: trout: fix compile failure

2012-04-12 Thread Daniel Walker
undeclared identifier is reported only once arch/arm/mach-msm/board-trout-panel.c:267: error: for each function it appears in.) This came in with the following commit 9f97da78bf018206fb623cd351d454af2f105fe0 which removes asm/system.h Signed-off-by: Daniel Walker dwal...@fifo99.com cc: David

Re: [PATCH] ARM: msm: remove unused MSM boards

2012-04-11 Thread Daniel Walker
On Wed, Apr 11, 2012 at 10:37:50AM -0700, David Brown wrote: The mahimahi and sapphire were never finished, and have never been built. The halibut target was a dev board that hasn't ever been widely available (MSM7201 SURF). I don't mind if you remove halibut, but the others are just

Re: [PATCH] ARM: msm: remove unused MSM boards

2012-04-11 Thread Daniel Walker
On Wed, Apr 11, 2012 at 11:04:09AM -0700, David Brown wrote: On Wed, Apr 11, 2012 at 10:55:50AM -0700, Daniel Walker wrote: On Wed, Apr 11, 2012 at 10:37:50AM -0700, David Brown wrote: The mahimahi and sapphire were never finished, and have never been built. The halibut target

Re: [PATCH] ARM: msm: remove unused MSM boards

2012-04-11 Thread Daniel Walker
On Wed, Apr 11, 2012 at 11:04:09AM -0700, David Brown wrote: On Wed, Apr 11, 2012 at 10:55:50AM -0700, Daniel Walker wrote: On Wed, Apr 11, 2012 at 10:37:50AM -0700, David Brown wrote: The mahimahi and sapphire were never finished, and have never been built. The halibut target

Re: [PATCH v3 2/2] DMAEngine: Add DMAEngine driver based on old MSM DMA APIs

2012-03-14 Thread Daniel Walker
On Tue, Mar 13, 2012 at 06:16:39PM +0530, Ravi Kumar V wrote: On 3/13/2012 1:44 AM, Daniel Walker wrote: On Mon, Mar 12, 2012 at 04:02:44PM +0530, Ravi Kumar V wrote: Add DMAEngine based driver using the old MSM DMA APIs internally. What do you mean by this? There is a MSM DMA driver

Re: [PATCH v3 2/2] DMAEngine: Add DMAEngine driver based on old MSM DMA APIs

2012-03-12 Thread Daniel Walker
On Mon, Mar 12, 2012 at 04:02:44PM +0530, Ravi Kumar V wrote: Add DMAEngine based driver using the old MSM DMA APIs internally. What do you mean by this? The benefit of this approach is that not all the drivers have to get converted to DMAEngine APIs simultaneosly while both the drivers can

Re: [PATCH v2 2/2] msm: DMAEngine: Add DMAEngine driver based on old MSM DMA APIs

2012-01-07 Thread Daniel Walker
On Sat, 2012-01-07 at 19:21 +, Russell King - ARM Linux wrote: On Sat, Jan 07, 2012 at 10:54:43AM -0800, David Brown wrote: On Fri, Jan 06, 2012 at 05:59:29PM -0800, Daniel Walker wrote: diff --git a/drivers/dma/msm-dma.c b/drivers/dma/msm-dma.c new file mode 100644 index

Re: [PATCH 1/3] ARM: msm: Remove MSM7x00 support

2011-12-01 Thread Daniel Walker
On Wed, 2011-11-30 at 16:29 -0800, David Brown wrote: - default ARCH_MSM7X00A - -config ARCH_MSM7X00A - bool MSM7x00A / MSM7x01A - select MACH_TROUT if !MACH_HALIBUT - select ARCH_MSM_ARM11 - select MSM_SMD - select MSM_SMD_PKG3 - select CPU_V6 -

Re: [PATCH 1/3] ARM: msm: Remove MSM7x00 support

2011-12-01 Thread Daniel Walker
On Thu, 2011-12-01 at 10:17 -0800, David Brown wrote: On Thu, Dec 01, 2011 at 07:17:37AM -0800, Daniel Walker wrote: On Wed, 2011-11-30 at 16:29 -0800, David Brown wrote: - default ARCH_MSM7X00A - -config ARCH_MSM7X00A - bool MSM7x00A / MSM7x01A - select

Re: [PATCH 1/3] ARM: msm: Remove MSM7x00 support

2011-12-01 Thread Daniel Walker
On Thu, 2011-12-01 at 11:27 -0800, David Brown wrote: On Thu, Dec 01, 2011 at 10:39:05AM -0800, Daniel Walker wrote: If someone is willing to step up and make it work, then we can keep it around. My only G1 is fried, so I have no way to do anything other than keep it compiling

Re: [PATCH 1/3] ARM: msm: Remove MSM7x00 support

2011-12-01 Thread Daniel Walker
On Thu, 2011-12-01 at 11:43 -0800, David Brown wrote: On Thu, Dec 01, 2011 at 11:33:12AM -0800, Daniel Walker wrote: On Thu, 2011-12-01 at 11:27 -0800, David Brown wrote: On Thu, Dec 01, 2011 at 10:39:05AM -0800, Daniel Walker wrote: If someone is willing to step up and make it work

Re: [PATCH 1/3] ARM: msm: Remove MSM7x00 support

2011-12-01 Thread Daniel Walker
On Thu, 2011-12-01 at 20:19 +, Russell King - ARM Linux wrote: Now, the obvious question to ask now is this: as you sent your question, and Daniel obviously objects, was Daniel one of your respondants? If not, then he carries some of the blame for this patch being created in the first

Re: [PATCH 1/3] ARM: msm: Remove MSM7x00 support

2011-12-01 Thread Daniel Walker
On Thu, 2011-12-01 at 12:26 -0800, David Brown wrote: On Thu, Dec 01, 2011 at 08:19:50PM +, Russell King - ARM Linux wrote: On Thu, Dec 01, 2011 at 11:43:53AM -0800, David Brown wrote: On Thu, Dec 01, 2011 at 11:33:12AM -0800, Daniel Walker wrote: On Thu, 2011-12-01 at 11:27 -0800

Re: [PATCH 1/3] ARM: msm: Remove MSM7x00 support

2011-12-01 Thread Daniel Walker
On Thu, 2011-12-01 at 20:35 +, Russell King - ARM Linux wrote: On Thu, Dec 01, 2011 at 12:25:47PM -0800, Daniel Walker wrote: On Thu, 2011-12-01 at 20:19 +, Russell King - ARM Linux wrote: Now, the obvious question to ask now is this: as you sent your question, and Daniel

Re: [PATCH] msm: timer: compensate for timer shift in msm_read_timer_count

2011-06-09 Thread Daniel Walker
On Wed, 2011-06-08 at 20:44 -0700, Jeff Ohlstein wrote: Some msm targets have timers whose lower bits are unreliable. So, we present our timers as lower frequency than they actually are, and ignore the bottom 5 bits on such targets. This compensation was erroneously removed from the

Re: [PATCH] msm: watchdog: support watchdog on 8x60 and 8960

2011-03-30 Thread Daniel Walker
On Tue, 2011-03-29 at 21:40 -0700, Jeff Ohlstein wrote: Daniel Walker wrote: Are you saying this is mostly a debugging facility ? The interrupts off thing I can see as just debugging, but I don't understand the bus lockups part. It isn't just a debugging facility. It is still

Re: [PATCH 2/3] msm: Peripheral Image Loader (PIL) driver

2011-03-23 Thread Daniel Walker
On Wed, 2011-03-16 at 11:48 -0700, Saravana Kannan wrote: On 03/16/2011 11:40 AM, David Brown wrote: On Wed, Mar 16 2011, Daniel Walker wrote: On Wed, 2011-03-09 at 20:44 -0800, Stephen Boyd wrote: On 8660, the modem, dsp, and sensors peripherals require their firmware to be loaded

Re: [PATCH] msm: iommu: Use relaxed register access functions

2011-03-23 Thread Daniel Walker
On Thu, 2011-03-17 at 13:01 -0700, Stepan Moskovchenko wrote: Use the relaxed versions of readl/writel for IOMMU register access, inserting barriers where appropriate. Could you provide comments on why you need barriers in the various places you've placed them. Daniel -- To unsubscribe from

Re: [RFC] mmc: msm_sdcc: Use SPS BAM as DMA engine

2011-03-23 Thread Daniel Walker
On Fri, 2011-03-18 at 18:54 +0530, Subhash Jadavani wrote: On recent MSMs, ADM (Data Mover) HW is not present which means existing SDCC driver can perform data transfer in PIO (peripheral IO) mode only. But PIO mode requires lot of CPU attention which would mean consuming extra CPU MIPS.

Re: [PATCH 09/20] video: msm: Split out MDP2.2 HW specific code.

2011-03-23 Thread Daniel Walker
On Fri, 2011-03-18 at 14:57 -0700, Carl Vanderlip wrote: index df9d74e..d6e75c3 100644 --- a/arch/arm/mach-msm/Kconfig +++ b/arch/arm/mach-msm/Kconfig @@ -76,6 +76,11 @@ config HAS_MSM_DEBUG_UART_PHYS config MSM_VIC bool +config MSM_MDP22 + bool + depends on

Re: [Git pull] MSM for v2.6.39

2011-03-23 Thread Daniel Walker
On Thu, 2011-03-17 at 08:59 -0700, David Brown wrote: David Brown (16): msm: Add CPU queries msm: Generalize timer register mappings msm: Generalize QGIC registers msm: Add MSM 8960 cpu_is check Merge branch 'msm-uart' into for-next Merge branch

Re: [PATCH] msm: Add gpio support for 8960

2011-03-23 Thread Daniel Walker
On Wed, 2011-03-23 at 16:56 -0700, Rohit Vaswani wrote: - set_irq_chained_handler(TLMM_SCSS_SUMMARY_IRQ, + set_irq_chained_handler(TLMM_MSM_SUMMARY_IRQ, msm_summary_irq_handler); Ok, so looks like a rename. Can you add this to the commit text along with

Re: [PATCH 2/3] msm: Peripheral Image Loader (PIL) driver

2011-03-16 Thread Daniel Walker
On Wed, 2011-03-09 at 20:44 -0800, Stephen Boyd wrote: On 8660, the modem, dsp, and sensors peripherals require their firmware to be loaded into memory before they can be properly taken out of reset. Drivers are expected to call pil_get() when they wish to load a peripheral. This will

Re: [PATCH v2 2/2] msm: add single-wire serial bus interface (SSBI) driver

2011-02-24 Thread Daniel Walker
You have some submission problems. one is that the subject should be drivers: msm: ... , this patch also shouldn't go to David. On Thu, 2011-02-24 at 15:19 -0700, Kenneth Heitke wrote: SSBI is the Qualcomm single-wire serial bus interface used to connect the MSM devices to the PMIC and other

Re: [PATCH] MAINTAINERS: Update MSM maintainers

2011-02-23 Thread Daniel Walker
On Wed, 2011-02-23 at 13:26 -0800, Bryan Huntsman wrote: On 02/22/2011 05:12 PM, Linus Torvalds wrote: On Tue, Feb 22, 2011 at 4:19 PM, Daniel Walker dwal...@fifo99.com wrote: On Tue, 2011-02-22 at 16:03 -0800, David Brown wrote: Remove Bryan Huntsman and Daniel Walker from the MSM

Re: [PATCH] msm: add single-wire serial bus interface (SSBI) driver

2011-02-22 Thread Daniel Walker
On Tue, 2011-02-22 at 16:17 -0800, David Brown wrote: On Tue, Feb 22 2011, Daniel Walker wrote: On Tue, 2011-02-22 at 12:47 -0800, Dima Zavin wrote: What is the problem leaving it under arch/arm/mach-msm? Because it's a driver. There are a lot of other drivers currently under

Re: [PATCH] msm: headsmp.S: Fix section mismatch

2011-02-19 Thread Daniel Walker
On Fri, 2011-02-18 at 19:14 -0800, Stephen Boyd wrote: WARNING: vmlinux.o(.cpuinit.text+0xc80): Section mismatch in reference from the function boot_secondary() to the variable .init.text:msm_secondary_startup The function __cpuinit boot_secondary() references a variable __init

Re: [PATCH] msm: add single-wire serial bus interface (SSBI) driver

2011-02-17 Thread Daniel Walker
On Thu, 2011-02-17 at 17:34 -0700, Kenneth Heitke wrote: SSBI is the Qualcomm single-wire serial bus interface used to connect the MSM devices to the PMIC and other devices. Since SSBI only supports a single slave, the driver gets the name of the slave device passed in from the board file

Re: [PATCH 1/3] msm: iommu: Create a Kconfig item for the IOMMU driver

2011-02-15 Thread Daniel Walker
On Tue, 2011-02-15 at 11:35 -0800, David Brown wrote: On Fri, Feb 11 2011, Daniel Walker wrote: On Fri, 2011-02-11 at 12:28 -0800, Stepan Moskovchenko wrote: +config MSM_IOMMU + bool MSM IOMMU Support + depends on ARCH_MSM8X60 + select IOMMU_API + default n

Re: [PATCH 1/3] msm: iommu: Create a Kconfig item for the IOMMU driver

2011-02-11 Thread Daniel Walker
On Fri, 2011-02-11 at 12:28 -0800, Stepan Moskovchenko wrote: +config MSM_IOMMU + bool MSM IOMMU Support + depends on ARCH_MSM8X60 + select IOMMU_API + default n + help + Support for the IOMMUs found on certain Qualcomm SOCs. + These IOMMUs

Re: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets

2011-02-11 Thread Daniel Walker
On Fri, 2011-02-11 at 12:28 -0800, Stepan Moskovchenko wrote: Make the IOMMU platform data target-independent in preparation for adding MSM8960 IOMMU support. The IOMMU configuration on MSM8x60 and MSM8960 is identical and the same platform data can be used for both. Signed-off-by: Stepan

Re: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets

2011-02-11 Thread Daniel Walker
On Fri, 2011-02-11 at 12:51 -0800, Steve Muckle wrote: On 02/11/11 12:42, Daniel Walker wrote: static struct resource msm_iommu_jpegd_resources[] = { { - .start = MSM_IOMMU_JPEGD_PHYS, - .end = MSM_IOMMU_JPEGD_PHYS + MSM_IOMMU_JPEGD_SIZE - 1, + .start

Re: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets

2011-02-11 Thread Daniel Walker
On Fri, 2011-02-11 at 13:00 -0800, Steve Muckle wrote: On 02/11/11 12:58, Daniel Walker wrote: On Fri, 2011-02-11 at 12:51 -0800, Steve Muckle wrote: On 02/11/11 12:42, Daniel Walker wrote: static struct resource msm_iommu_jpegd_resources[] = { { -.start

Re: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets

2011-02-11 Thread Daniel Walker
On Fri, 2011-02-11 at 13:03 -0800, David Brown wrote: On Fri, Feb 11 2011, Steve Muckle wrote: On 02/11/11 12:42, Daniel Walker wrote: static struct resource msm_iommu_jpegd_resources[] = { { - .start = MSM_IOMMU_JPEGD_PHYS, - .end = MSM_IOMMU_JPEGD_PHYS

Re: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets

2011-02-11 Thread Daniel Walker
On Fri, 2011-02-11 at 13:53 -0800, David Brown wrote: On Fri, Feb 11 2011, Daniel Walker wrote: On Fri, 2011-02-11 at 13:03 -0800, David Brown wrote: On Fri, Feb 11 2011, Steve Muckle wrote: If they were used in more than one place, we could justify the definition, but in this case

Re: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets

2011-02-11 Thread Daniel Walker
On Fri, 2011-02-11 at 12:28 -0800, Stepan Moskovchenko wrote: Make the IOMMU platform data target-independent in preparation for adding MSM8960 IOMMU support. The IOMMU configuration on MSM8x60 and MSM8960 is identical and the same platform data can be used for both. Signed-off-by: Stepan

Re: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets

2011-02-11 Thread Daniel Walker
On Fri, 2011-02-11 at 14:37 -0800, David Brown wrote: On Fri, Feb 11 2011, Daniel Walker wrote: On Fri, 2011-02-11 at 12:28 -0800, Stepan Moskovchenko wrote: Make the IOMMU platform data target-independent in preparation for adding MSM8960 IOMMU support. The IOMMU configuration

Re: [PATCH 2/3] msm: iommu: Generalize platform data for multiple targets

2011-02-11 Thread Daniel Walker
On Fri, 2011-02-11 at 15:16 -0800, David Brown wrote: On Fri, Feb 11 2011, Daniel Walker wrote: On Fri, 2011-02-11 at 14:37 -0800, David Brown wrote: It is functionality that will be shared across multiple socs. Putting the name of a specific soc would just be misleading. Currently

Re: [PATCH 0/7] Nexus One Support

2011-02-07 Thread Daniel Walker
On Fri, 2011-02-04 at 14:36 +0100, Pavel Machek wrote: On Thu 2011-01-20 12:32:38, Daniel Walker wrote: This series adds basic Nexus One support which includes a booting kernel, and functional MMC . Most people won't be able to use this yet unfortunately because you need a serial cable

Re: linux-next: manual merge of the msm tree with the arm tree

2011-02-04 Thread Daniel Walker
On Wed, 2011-02-02 at 16:47 -0500, Nicolas Pitre wrote: The actual problem here is that some people, notably the msm folks, are bypassing the maintainer hierarchy and going straight to Linus for their pull requests instead of asking RMK to pull. We once debated this at I don't think it's

Re: linux-next: manual merge of the msm tree with the arm tree

2011-02-04 Thread Daniel Walker
On Fri, 2011-02-04 at 17:42 +, Russell King wrote: So you tell me - do I take the p2v stuff out of public view tonight because it's not stable, and therefore you don't even know about the conflict? Or do I continue publishing the unstable changes so that people have the ability to see

Re: [PATCH] USB: Fix trout build failure with ci13xxx_msm gadget

2011-02-04 Thread Daniel Walker
On Fri, 2011-02-04 at 10:08 +0530, Pavankumar Kondeti wrote: + This driver is not supported on boards like trout which + has an external PHY. What is an external PHY? Daniel -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center,

Re: msm gadget compilation failure with trout

2011-01-28 Thread Daniel Walker
On Fri, 2011-01-28 at 12:31 +0530, Pavan Kondeti wrote: Hi Denis, On 1/28/2011 2:56 AM, Daniel Walker wrote: On Thu, 2011-01-27 at 22:12 +0100, Denis 'GNUtoo' Carikli wrote: Hi, I've that: drivers/usb/gadget/ci13xxx_msm.c: In function 'ci13xxx_msm_notify_event': drivers/usb

Re: [PATCH] msm: Clean up useless ifdefs

2011-01-27 Thread Daniel Walker
On Thu, 2011-01-27 at 12:13 -0800, Stepan Moskovchenko wrote: Remove ifdefs that do nothing, either from having the code between them previously removed, or from having been accidentally added to the wrong file. Change-Id: I94aac2cb24e23ba7f8b4b158ce6653dc3b786989 Signed-off-by: Stepan

Re: msm gadget compilation failure with trout

2011-01-27 Thread Daniel Walker
On Thu, 2011-01-27 at 22:12 +0100, Denis 'GNUtoo' Carikli wrote: Hi, I've that: drivers/usb/gadget/ci13xxx_msm.c: In function 'ci13xxx_msm_notify_event': drivers/usb/gadget/ci13xxx_msm.c:42:3: error: 'USB_AHBBURST' undeclared (first use in this function)

Re: [PATCH 1/4] msm: clock: Remove unused code and definitions

2011-01-26 Thread Daniel Walker
On Wed, 2011-01-26 at 14:01 -0800, David Brown wrote: On Tue, Jan 25 2011, Daniel Walker wrote: On Tue, 2011-01-25 at 13:52 -0800, Saravana Kannan wrote: On 01/25/2011 01:38 PM, Daniel Walker wrote: On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote: Remove dead code and push out

Re: [PATCH 4/4] msm: clock: Add support for more proc_comm clocks

2011-01-26 Thread Daniel Walker
On Wed, 2011-01-26 at 14:03 -0800, David Brown wrote: On Tue, Jan 25 2011, Daniel Walker wrote: On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote: Support the CE_CLK and CODEC_SSBI_CLK. Also add support for uart, and i2c clocks on targets which support proc_comm clocks. Basically

Re: [PATCH v2 01/11] msm: Add CPU queries

2011-01-25 Thread Daniel Walker
On Mon, 2011-01-24 at 16:57 -0800, David Brown wrote: On Mon, Jan 24 2011, Daniel Walker wrote: On Mon, 2011-01-24 at 16:20 -0800, David Brown wrote: On Mon, Jan 24 2011, Daniel Walker wrote: On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: +#define cpu_is_msm7x01() 0

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

2011-01-25 Thread Daniel Walker
On Tue, 2011-01-25 at 14:45 +0100, Tejun Heo wrote: On Mon, Jan 03, 2011 at 10:10:45AM -0800, Daniel Walker wrote: On Mon, 2011-01-03 at 18:06 +0100, Stanislaw Gruszka wrote: On Mon, Jan 03, 2011 at 02:49:43PM +0100, Tejun Heo wrote: With cmwq, there's no reason to use separate

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

2011-01-25 Thread Daniel Walker
On Tue, 2011-01-25 at 11:14 -0800, David Brown wrote: On Tue, Jan 25 2011, Daniel Walker wrote: On Tue, 2011-01-25 at 14:45 +0100, Tejun Heo wrote: On Mon, Jan 03, 2011 at 10:10:45AM -0800, Daniel Walker wrote: On Mon, 2011-01-03 at 18:06 +0100, Stanislaw Gruszka wrote: On Mon, Jan

Re: [PATCH v2 01/11] msm: Add CPU queries

2011-01-25 Thread Daniel Walker
On Tue, 2011-01-25 at 11:45 -0800, David Brown wrote: On Tue, Jan 25 2011, Daniel Walker wrote: On Tue, 2011-01-25 at 11:17 -0800, David Brown wrote: I suggesting we do it across the board because consistency is a good thing .. It also allows us to use 8x60 when 8660 and 8960

Re: [PATCH 1/4] msm: clock: Remove unused code and definitions

2011-01-25 Thread Daniel Walker
On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote: Remove dead code and push out clock-7x30.h and clock-pcom.h to where they are actually used. I'd do two patches for this. The stuff your doing is too disconnected. Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc.

Re: [PATCH 4/4] msm: clock: Add support for more proc_comm clocks

2011-01-25 Thread Daniel Walker
On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote: Support the CE_CLK and CODEC_SSBI_CLK. Also add support for uart, and i2c clocks on targets which support proc_comm clocks. Basically when you catch yourself writing also in the commit text you need to re-evaluate making two patches.. In

Re: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check

2011-01-24 Thread Daniel Walker
On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: diff --git a/arch/arm/mach-msm/include/mach/cpu.h b/arch/arm/mach-msm/include/mach/cpu.h index e1ba9db..a9481b0 100644 --- a/arch/arm/mach-msm/include/mach/cpu.h +++ b/arch/arm/mach-msm/include/mach/cpu.h @@ -24,6 +24,7 @@ #define

Re: [PATCH v2 04/11] msm: io: I/O register definitions for MSM8960

2011-01-24 Thread Daniel Walker
On Mon, 2011-01-24 at 13:31 -0800, David Brown wrote: On Mon, Jan 24 2011, Daniel Walker wrote: On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: +/* + * Copyright (C) 2007 Google, Inc. + * Copyright (c) 2008-2011, Code Aurora Forum. All rights reserved. + * Author: Brian Swetland

Re: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check

2011-01-24 Thread Daniel Walker
On Mon, 2011-01-24 at 14:13 -0800, David Brown wrote: On Mon, Jan 24 2011, Daniel Walker wrote: What do you want me to call it? #define cpu_is_97d0c886-3768-4998-8925-16f36209d0d1() I want you to call it msm8x60 .. msm8960 is not a subset of msm8x60. It's just a misleading name

Re: [PATCH v2 02/11] msm: Generalize timer register mappings

2011-01-24 Thread Daniel Walker
On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: + int global_offset = 0; + + if (cpu_is_msm7x01()) { + msm_clocks[MSM_CLOCK_GPT].regbase = MSM_CSR_BASE; + msm_clocks[MSM_CLOCK_DGT].regbase = MSM_CSR_BASE + 0x10; + } else if

Re: [PATCH v2 06/11] msm: irqs-8960: Interrupt map for MSM8960

2011-01-24 Thread Daniel Walker
On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: +#define INT_VGIC (GIC_PPI_START + 0) +#define INT_DEBUG_TIMER_EXP(GIC_PPI_START + 1) +#define INT_GP_TIMER_EXP (GIC_PPI_START + 2) +#define INT_GP_TIMER2_EXP

Re: [PATCH v2 01/11] msm: Add CPU queries

2011-01-24 Thread Daniel Walker
On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: +#define cpu_is_msm7x01() 0 +#define cpu_is_msm7x30() 0 +#define cpu_is_qsd8x50() 0 +#define cpu_is_msm8x60() 0 Now that I look at this again, why not drop the x all together ? Daniel -- Sent by a consultant of

Re: [PATCH 0/7] Nexus One Support

2011-01-21 Thread Daniel Walker
On Thu, 2011-01-20 at 18:13 -0800, Dima Zavin wrote: You did not write ANY code for the mahimahi (Nexus One) board. You took patches from the android.git.kernel.org git server, squashed some together, and then slapped your name on them as the author. I appreciate your effort to send this code

Re: [PATCH] drivers: mmc: msm: remove clock disable in probe

2011-01-21 Thread Daniel Walker
On Thu, 2011-01-20 at 19:24 -0800, Saravana Kannan wrote: On 01/19/2011 02:50 AM, Vitaly Wool wrote: Hi, On Tue, Jan 18, 2011 at 7:14 PM, Daniel Walkerdwal...@codeaurora.org wrote: The probe function adds the MMC host which can start accepting request immediately. There is an

Re: [PATCH 0/7] Nexus One Support

2011-01-21 Thread Daniel Walker
On Fri, 2011-01-21 at 09:56 -0800, Jesse Barnes wrote: On Fri, 21 Jan 2011 09:48:27 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: On Fri, 21 Jan 2011 07:46:41 -0800 Daniel Walker dwal...@codeaurora.org wrote: This isn't what's happening tho. In maintainer land if someone forwards

Re: [PATCH 0/7] Nexus One Support

2011-01-21 Thread Daniel Walker
On Fri, 2011-01-21 at 10:04 -0800, Jesse Barnes wrote: On Fri, 21 Jan 2011 10:00:28 -0800 Daniel Walker dwal...@codeaurora.org wrote: On Fri, 2011-01-21 at 09:56 -0800, Jesse Barnes wrote: On Fri, 21 Jan 2011 09:48:27 -0800 Jesse Barnes jbar...@virtuousgeek.org wrote: On Fri

Re: [PATCH] mmc: msm: fix dma usage not to use internal APIs

2011-01-21 Thread Daniel Walker
On Fri, 2011-01-21 at 19:28 +, Russell King - ARM Linux wrote: Again, why don't you talk about these problems on the architecture list rather than keeping it to your self. This is one of the *biggest* problems I have with people setting up per- platform mailing lists. It hides

Re: [PATCH 0/7] Nexus One Support

2011-01-21 Thread Daniel Walker
On Fri, 2011-01-21 at 12:44 -0800, Dima Zavin wrote: Really though? Let's look at one of them: 2 Arve Hjønnevåg a...@android.com 6 Brian Swetland swetl...@google.com 14 Dima Zavin d...@android.com 2 Haley Teng haley_t...@htc.com 1 Iliyan Malchev

Re: [PATCH 0/7] Nexus One Support

2011-01-21 Thread Daniel Walker
On Fri, 2011-01-21 at 13:02 -0800, Joe Perches wrote: On Fri, 2011-01-21 at 12:49 -0800, Daniel Walker wrote: On Fri, 2011-01-21 at 12:44 -0800, Dima Zavin wrote: Really though? Let's look at one of them: 2 Arve Hjønnevåg a...@android.com 6 Brian Swetland swetl

Re: [PATCH 0/7] Nexus One Support

2011-01-21 Thread Daniel Walker
On Fri, 2011-01-21 at 13:01 -0800, Jesse Barnes wrote: On Fri, 21 Jan 2011 12:49:55 -0800 Daniel Walker dwal...@codeaurora.org wrote: On Fri, 2011-01-21 at 12:44 -0800, Dima Zavin wrote: Really though? Let's look at one of them: 2 Arve Hjønnevåg a...@android.com 6

Re: [PATCH 0/7] Nexus One Support

2011-01-21 Thread Daniel Walker
On Fri, 2011-01-21 at 20:58 -0500, Steven Rostedt wrote: On Fri, Jan 21, 2011 at 04:03:13PM -0800, Daniel Walker wrote: right, but it wasn't a cherrypick which was explain in the thread. So there's no wrongs here .. I'm sorry Daniel, but you are absolutely wrong! This thread is getting

Re: [PATCH] mmc: msm: fix dma usage not to use internal APIs

2011-01-20 Thread Daniel Walker
On Tue, 2011-01-18 at 15:03 -0800, Daniel Walker wrote: Remove parts of this driver which use internal API calls. This replaces the calls as suggested by Russell King. Cc: Russell King - ARM Linux li...@arm.linux.org.uk Signed-off-by: Daniel Walker dwal...@codeaurora.org --- drivers/mmc

Re: [PATCH] mmc: msm: fix dma usage not to use internal APIs

2011-01-20 Thread Daniel Walker
On Thu, 2011-01-20 at 13:12 +, Russell King - ARM Linux wrote: On Thu, Jan 20, 2011 at 01:02:46PM +, Russell King - ARM Linux wrote: Strongly ordered requires no additional maintainence to ensure that writes to it are immediately visible to hardware. However, ARMv6 and later

[PATCH 3/7] msm: qsd8x50: add acpuclock code

2011-01-20 Thread Daniel Walker
This adds acpuclock-qsd8x50.c from Google. This provides control over the cpu frequency for qsd8x50 SoCs. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/Makefile |3 +- arch/arm/mach-msm/acpuclock-qsd8x50.c | 457 arch

[PATCH 4/7] msm: mahimahi: add mahimahi board file

2011-01-20 Thread Daniel Walker
This adds basic boot support for Nexus One (aka Mahimahi). This code was taken from Google's tree, with slight modifications and clean up. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/Kconfig |8 ++- arch/arm/mach-msm/Makefile |1 + arch/arm

[PATCH 2/7] [ARM] msm: qsd8k memory base is at 0x20000000

2011-01-20 Thread Daniel Walker
From: Brian Swetland swetl...@google.com The memory layout is effective as of AMSS 3170+. Signed-off-by: Haley Teng haley_t...@htc.com Signed-off-by: Dima Zavin d...@android.com --- arch/arm/mach-msm/Makefile.boot |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

[PATCH 7/7] msm: mahimahi: initialize mmc at start up

2011-01-20 Thread Daniel Walker
MMC should fully function at this point. This adds in the calls to start the initialization. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/board-mahimahi.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-msm/board

[PATCH 5/7] msm: mahimahi: add in mmc support code

2011-01-20 Thread Daniel Walker
This adds code to enable MMC on mahimahi. This code was taken from Google's tree, with slight modifications and clean up. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/Makefile |1 + arch/arm/mach-msm/board-mahimahi-mmc.c | 206

[PATCH 1/7] msm: qsd8x50: add uart platform data

2011-01-20 Thread Daniel Walker
This enables the uart for QSD8x50. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/devices-qsd8x50.c | 42 +++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-msm/devices-qsd8x50.c b/arch/arm/mach-msm

Re: [PATCH 0/7] Nexus One Support

2011-01-20 Thread Daniel Walker
On Thu, 2011-01-20 at 16:42 -0800, Dima Zavin wrote: You are not the author of any of these patches. Where are the author attributions for the team that actually wrote this code? In the commit text.. The author field is used to denote who authored the commit, which in this case is me. The code

Re: [PATCH 0/7] Nexus One Support

2011-01-20 Thread Daniel Walker
On Thu, 2011-01-20 at 17:41 -0800, Joe Perches wrote: On Thu, 2011-01-20 at 16:55 -0800, Daniel Walker wrote: On Thu, 2011-01-20 at 16:42 -0800, Dima Zavin wrote: You are not the author of any of these patches. Where are the author attributions for the team that actually wrote this code

[PATCH] drivers: mmc: msm: remove clock disable in probe

2011-01-18 Thread Daniel Walker
in the probe function. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- drivers/mmc/host/msm_sdcc.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c index a46b9a8..36dbb71 100644 --- a/drivers/mmc/host/msm_sdcc.c +++ b

Re: [PATCH] drivers: mmc: msm: update to new arm pfn_to_dma API

2011-01-18 Thread Daniel Walker
On Tue, 2011-01-18 at 18:28 +, Russell King - ARM Linux wrote: On Tue, Jan 18, 2011 at 10:04:04AM -0800, Daniel Walker wrote: The page_to_dma() API call was removed. It caused this build failure, Because it's an API internal interface. Don't use it. Why is this driver poking about

Re: [PATCH] drivers: mmc: msm: update to new arm pfn_to_dma API

2011-01-18 Thread Daniel Walker
On Tue, 2011-01-18 at 21:16 +, Russell King - ARM Linux wrote: On Tue, Jan 18, 2011 at 01:00:20PM -0800, Daniel Walker wrote: Just greping the driver I found at least one writel() .. I'm not really concerned with that tho. I use this driver, I need this driver to work. You broke

[PATCH] mmc: msm: fix dma usage not to use internal APIs

2011-01-18 Thread Daniel Walker
This doesn't work yet. I tried booting with this patch, and the boot stops after detecting the MMC partitions. It won't actually boot off the MMC. Without this patch and with the page_to_dma/pfn_to_dma changes it does work. Not-Signed-off-by: Daniel Walker dwal...@codeaurora.org --- drivers/mmc

[PATCH] mmc: msm: fix dma usage not to use internal APIs

2011-01-18 Thread Daniel Walker
Remove parts of this driver which use internal API calls. This replaces the calls as suggested by Russell King. Cc: Russell King - ARM Linux li...@arm.linux.org.uk Signed-off-by: Daniel Walker dwal...@codeaurora.org --- drivers/mmc/host/msm_sdcc.c | 49

Re: [PATCH] ARM: msm: 7x30: don't force a gpiomux table for the whole arch

2011-01-14 Thread Daniel Walker
On Thu, 2011-01-13 at 19:35 -0800, Rohit Vaswani wrote: On 1/10/2011 11:00 AM, Dima Zavin wrote: This is completely board specific and therefore must be provided on a per-board basis. Change-Id: I96f922ad9bb9cbce7874c5ae6ac0d7479b7a2124 Signed-off-by: Dima Zavind...@android.com

Re: [PATCH 4/5 v4] msm: convert 7x30 to gpiomux.

2011-01-10 Thread Daniel Walker
On Sun, 2011-01-09 at 14:53 -0800, Dima Zavin wrote: Greg, Just rebased on top of 2.6.37 and this patch is totally the wrong way to go about this. I should have commented at the appropriate time, so sorry for the late reply. Having this msm_gpiomux_configs be always compiled in for all

  1   2   3   >