Re: [PATCH/RESEND v15 8/10] usb:dummy_hcd: use the shared_hcd infrastructure

2011-06-09 Thread Felipe Balbi
On Mon, Jun 06, 2011 at 02:40:52PM +0300, Tatyana Brokhman wrote: This patch is a preparation for adding SuperSpeed support to dummy hcd. It takes the master side fields out of the struct dummy to a separate structure. The init process was also modified to resemble the way it is done by xHCI.

Re: [PATCH v14 7/9] usb:gadget: Add SuperSpeed support to the Gadget Framework

2011-06-06 Thread Felipe Balbi
On Fri, Jun 03, 2011 at 09:00:17PM +0300, Tanya Brokhman wrote: Hi Felipe, On Tue, May 31, 2011 at 04:18:27PM +0300, Tatyana Brokhman wrote: @@ -377,9 +425,10 @@ static int config_desc(struct usb_composite_dev *cdev, unsigned w_value) u8 type = w_value

Re: [PATCH v14 4/9] usb: Add max_speed to usb_composite_driver structure

2011-06-06 Thread Felipe Balbi
Hi, On Tue, May 31, 2011 at 04:18:24PM +0300, Tatyana Brokhman wrote: This field is used by the Gadget drivers to specify the maximum speed they support, meaning: the maximum speed they can provide descriptors for. The driver speed will be set in consideration of this value.

Re: [PATCH v14 7/9] usb:gadget: Add SuperSpeed support to the Gadget Framework

2011-06-03 Thread Felipe Balbi
Hi, On Tue, May 31, 2011 at 04:18:27PM +0300, Tatyana Brokhman wrote: @@ -377,9 +425,10 @@ static int config_desc(struct usb_composite_dev *cdev, unsigned w_value) u8 type = w_value 8; enum usb_device_speed speed = USB_SPEED_UNKNOWN; -

Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd

2011-05-25 Thread Felipe Balbi
Hi, On Wed, May 25, 2011 at 07:46:38AM +0300, Tanya Brokhman wrote: Which leaves a question about the composite gadget framework. Should it be updated with SS support? Probably not until the various function drivers have all been updated. As I mentioned, updating all of the gadget

Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd

2011-05-25 Thread Felipe Balbi
On Wed, May 25, 2011 at 12:26:08PM +0300, Tanya Brokhman wrote: As I mentioned, updating all of the gadget drivers will take a long time and I don't fill confident enough doing since I'm not familiar with all of them and don't have the ability to test each of them properly. I can add

Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd

2011-05-25 Thread Felipe Balbi
Hi, On Wed, May 25, 2011 at 01:52:15PM +0300, Tanya Brokhman wrote: following: 1. if CONFIG_USB_GADGET_SUPERSPEED=true, existing gadget drivers are still functional with dummy_hcd since as I already mentioned, they will be enumerated through HS root hub and thus the

Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd

2011-05-24 Thread Felipe Balbi
Hi, On Tue, May 24, 2011 at 01:31:14PM +0300, Tanya Brokhman wrote: but then again, maybe you changed driver-speed to super and didn't provide superspeed descriptors. Yes :) The driver-speed is updated in usb_composite_probe() if CONFIG_USB_GADGET_SUPERSPEED is defined. So, are we

Re: [PATCH v11 4/7] usb:gadget: Add SuperSpeed support to the Gadget Framework

2011-05-23 Thread Felipe Balbi
Hi, On Sun, May 22, 2011 at 12:59:08PM +0200, Sebastian Andrzej Siewior wrote: Well here is the dilemma: if I do it the other tree were done - I get checkpatch error. You're right, adding this the way it's above doesn't look too good but when I fixed the other three I was asked not to do so

Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd

2011-05-23 Thread Felipe Balbi
Hi, On Mon, May 23, 2011 at 09:41:16AM +0300, Tatyana Brokhman wrote: This patch adds SS support to the dummy hcd module. It may be used to test SS device when no (SS) HW is available. USB 3.0 hub includes 2 hubs - HS and SS ones. This patch adds support for a SS hub in the dummy_hcd module.

Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd

2011-05-23 Thread Felipe Balbi
Hi, On Mon, May 23, 2011 at 10:20:45AM +0300, Tanya Brokhman wrote: diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c index bf7981d..c2731d3 100644 --- a/drivers/usb/gadget/dummy_hcd.c +++ b/drivers/usb/gadget/dummy_hcd.c @@ -70,6 +70,15 @@

Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd

2011-05-23 Thread Felipe Balbi
hi, On Mon, May 23, 2011 at 11:18:53AM +0300, Tanya Brokhman wrote: + +static struct dummy_hcd_module_parameters mod_data = { + .is_super_speed = false +}; +module_param_named(is_super_speed, mod_data.is_super_speed, bool, +S_IRUGO);

Re: [PATCH v11 0/7] usb gadget: Add SuperSpeed support to the Gadget Framework

2011-05-20 Thread Felipe Balbi
On Thu, May 19, 2011 at 06:27:59AM -0700, Greg KH wrote: On Thu, May 19, 2011 at 02:43:25PM +0300, Tatyana Brokhman wrote: It was tested in the following ways: 1. Dummy_hcd and g_zero gadget with our internally developed unittest. (See bellow) 2. Our DCD (that is not ready for

Re: [PATCH v11 0/7] usb gadget: Add SuperSpeed support to the Gadget Framework

2011-05-19 Thread Felipe Balbi
Hi, On Thu, May 19, 2011 at 02:43:25PM +0300, Tatyana Brokhman wrote: It was tested in the following ways: 1. Dummy_hcd and g_zero gadget with our internally developed unittest. (See bellow) 2. Our DCD (that is not ready for upstreaming yet but we're working on it) and g_mass_storage

Re: [PATCH/RESEND v10 2/7] usb: Configure endpoint according to gadget speed.

2011-05-18 Thread Felipe Balbi
Hi, On Tue, May 17, 2011 at 04:03:16PM +0300, Tatyana Brokhman wrote: Add config_ep_by_speed() to configure the endpoint according to the gadget diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h index 5c4c30c..7d1188a 100644 --- a/include/linux/usb/gadget.h +++

Re: [PATCH v10 4/7] usb:gadget: Add SuperSpeed support to the Gadget Framework

2011-05-18 Thread Felipe Balbi
Hi, On Tue, May 17, 2011 at 04:03:18PM +0300, Tatyana Brokhman wrote: diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index 5780f35..5be5f6d 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -352,7 +392,9 @@ static int

Re: [PATCH/RESEND v10 6/7] usb:gadget: Introduce usb_generate_ss_descriptors()

2011-05-18 Thread Felipe Balbi
On Tue, May 17, 2011 at 04:03:20PM +0300, Tatyana Brokhman wrote: This patch implements the usb_generate_ss_descriptors() function that is used to automatically generate SuperSpeed descriptors for gadget drivers that didn't provide any of their own. If a gadget driver wishes to have the

Re: [PATCH v10 7/7] usb: Adding SuperSpeed support to dummy_hcd

2011-05-18 Thread Felipe Balbi
Hi, On Tue, May 17, 2011 at 04:03:21PM +0300, Tatyana Brokhman wrote: This patch adds SS support to the dummy hcd module. It may be used to test SS device when no (SS) HW is available. USB 3.0 hub includes 2 hubs - HS and SS ones. This patch adds support for a SS hub in the dummy_hcd module.

Re: [PATCH v10 0/7] usb gadget: Add SuperSpeed support to the Gadget Framework

2011-05-18 Thread Felipe Balbi
Hi, On Tue, May 17, 2011 at 11:09:05AM -0700, Greg KH wrote: Also, I need Felipe to agree that this framework is acceptable for his needs before I can apply this. I'm work with Tatiana's approach Greg, provided the fixes the comments I had to this latest version and remove patch 6/7 from her

Re: [PATCH v10 0/7] usb gadget: Add SuperSpeed support to the Gadget Framework

2011-05-18 Thread Felipe Balbi
Hi, On Wed, May 18, 2011 at 06:53:22AM -0700, Greg KH wrote: On Wed, May 18, 2011 at 01:18:36PM +0300, Felipe Balbi wrote: Hi, On Tue, May 17, 2011 at 11:09:05AM -0700, Greg KH wrote: Also, I need Felipe to agree that this framework is acceptable for his needs before I can apply

Re: [PATCH v9 5/7] usb: Add streams support to the gadget framework

2011-05-11 Thread Felipe Balbi
Hi, On Wed, May 11, 2011 at 04:29:44PM +0300, Tanya Brokhman wrote: Hi Felipe @@ -129,6 +132,22 @@ ep_matches ( } /* + * Get the number of required streams from the EP companion + * descriptor and see if the EP matches it + */ + if (usb_endpoint_xfer_bulk(desc))

Re: [PATCH v6 0/5] usb gadget: Add SuperSpeed support to the Gadget Framework

2011-04-14 Thread Felipe Balbi
On Thu, Apr 14, 2011 at 03:03:18PM +0300, Tanya Brokhman wrote: Still, Tanya, it would be nice if you could already drop the UAS gadget driver for us to start reviewing that one too :-) We can start with your code but if anyone comes up with a comment to your patchset, we need to get

Re: [PATCH 1/5] usb/gadget: cleanup of Add SuperSpeed support to the Gadget Framework

2011-04-13 Thread Felipe Balbi
Hi, On Tue, Apr 12, 2011 at 09:34:52PM +0200, Sebastian Andrzej Siewior wrote: style, some endianess fixups Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/usb/gadget/Kconfig |1 - drivers/usb/gadget/composite.c | 62

Re: [PATCH] USB: Fix trout build failure with ci13xxx_msm gadget

2011-04-13 Thread Felipe Balbi
On Thu, Apr 07, 2011 at 04:04:21PM +0530, Pavan Kondeti wrote: On 4/5/2011 6:25 PM, Felipe Balbi wrote: On Fri, Feb 04, 2011 at 10:08:18AM +0530, Pavankumar Kondeti wrote: This patch fixes the below compilation errors. CC drivers/usb/gadget/ci13xxx_msm.o CC net/mac80211

Re: [PATCH 2/5 v6] usb: Add usb_endpoint_descriptor to be part of the struct usb_ep

2011-03-28 Thread Felipe Balbi
On Sun, Mar 27, 2011 at 02:26:48PM +0200, Tanya Brokhman wrote: On Wed, Mar 23, 2011 at 10:03:38AM +0200, Tatyana Brokhman wrote: Change usb_ep_enable() prototype to use endpoint descriptor from usb_ep. This optimization spares the FDs from saving the endpoint chosen descriptor.

Re: [PATCH 5/5 v5] usb:gadget: Add SuperSpeed support to the Gadget Framework

2011-03-25 Thread Felipe Balbi
Hi, On Wed, Mar 23, 2011 at 10:04:57AM +0200, Tatyana Brokhman wrote: This patch adds the SuperSpeed functionality to the gadget framework. In order not to force all the gadget drivers to supply SuperSpeed descriptors when operating in SuperSpeed mode the following approach was taken: If

Re: [PATCH 1/5 v8] usb: Adding SuperSpeed support to dummy_hcd

2011-03-25 Thread Felipe Balbi
Hi, On Wed, Mar 23, 2011 at 10:02:51AM +0200, Tatyana Brokhman wrote: This patch adds SS support to the dummy hcd module. It may be used to test SS device when no (SS) HW is available. USB 3.0 hub includes 2 hubs - HS and SS ones. This patch adds support for a SS hub in the dummy_hcd module.

Re: finding out the attached device current requirement

2011-03-03 Thread Felipe Balbi
On Thu, Mar 03, 2011 at 02:22:34PM +0530, Pavan Kondeti wrote: Hi I am adding ACA (Accessory Charger Adapter) detection support for MSM OTG driver. Battery charging spec introduced ACA to facilitate charging when acting as a host. The host does not have to supply power on VBUS when ACA is

Re: [RFC 2/5] USB: core: OTG Supplement Revision 2.0 updates

2010-12-16 Thread Felipe Balbi
Hi, On Thu, Dec 16, 2010 at 02:24:05PM +0530, Pavan Kondeti wrote: @@ -1270,6 +1283,43 @@ static int usb_resume_both(struct usb_device *udev, pm_message_t msg) return status; } +#ifdef CONFIG_USB_OTG +void usb_hnp_polling_work(struct work_struct *work) do you really need this to be

Re: [RFC 5/5] USB: Eliminate delays involved in root hub initialization during HNP

2010-12-15 Thread Felipe Balbi
On Wed, Dec 15, 2010 at 04:44:14PM +0530, Pavankumar Kondeti wrote: Some USB controllers have common resources (IRQ, register address space) for Host, Peripheral and OTG. So HCD is added only before entering into Host mode. Root hub initialization is done in different steps to decrease boot up

Re: [RFC/PATCH] usb: Add streams support to epautoconf.

2010-11-14 Thread Felipe Balbi
Hi, On Sun, 2010-11-14 at 10:29 -0800, Greg KH wrote: + if (USB_ENDPOINT_XFER_BULK == type) { Ick, no, don't do comparisons like this. The compiler will let you know if you acidentally get it wrong with only one '=' character, don't do things backward like this just to work around

Re: [RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

2010-11-10 Thread Felipe Balbi
Hi, On Wed, 2010-11-10 at 12:15 -0800, David Brownell wrote: Original $SUBJECT was [RFC/PATCH 1/2] Add usb_endpoint_descriptor to be part of the struct usb_ep dated Wednesday, October 6, 2010, 9:34 PM and with a long CC list (that included the MSM list that allegedly didn't receive it).

<    1   2