Re: [PATCH v3 1/3] tty: serial: msm: Add mask value for UART_DM registers

2015-04-28 Thread Greg KH
On Fri, Apr 10, 2015 at 05:49:54PM +0530, Pramod Gurav wrote: The bit masks for RFR_LEVEL1 and STALE_TIMEOUT_MSB values in MR1 and IPR registers respectively are different for UART and UART_DM hardware cores. We have been using UART core mask values for these. Add the same for UART_DM core.

Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices

2015-04-08 Thread Greg KH
On Wed, Apr 08, 2015 at 11:27:40AM -, rtat...@codeaurora.org wrote: On Wed, Mar 25, 2015 at 12:23:19PM +0530, rtat...@codeaurora.org wrote: From: Rupesh Tatiya rtat...@codeaurora.org USB 2.01+ full-speed devices can have extended descriptor as well and can support LPM. Change-Id:

Re: [PATCH V5 0/2] add support for pmic_arb v2 and correct framework

2015-03-26 Thread Greg KH
On Thu, Mar 26, 2015 at 10:26:09AM -0500, Kumar Gala wrote: On Mar 26, 2015, at 4:51 AM, Ivan T. Ivanov iiva...@mm-sol.com wrote: On Wed, 2015-03-25 at 11:37 -0600, Gilad Avidov wrote: pmic_arb v2 has no support for spmi non-data commands and thus returns -EOPNOTSUPP on .cmd

Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices

2015-03-25 Thread Greg KH
On Wed, Mar 25, 2015 at 12:23:19PM +0530, rtat...@codeaurora.org wrote: From: Rupesh Tatiya rtat...@codeaurora.org USB 2.01+ full-speed devices can have extended descriptor as well and can support LPM. Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b We can't take patches with this in

Re: [PATCH] tty: serial: msm: fix checkpatch warnings

2014-08-04 Thread Greg KH
On Mon, Aug 04, 2014 at 07:50:46PM +0530, Kiran Padwal wrote: This patch fixes the following checkpatch.pl warning: WARNING: braces {} are not necessary for any arm of this statement WARNING: Missing a blank line after declarations WARNING: Prefer [subsystem eg:

Re: [PATCH] tty: serial: msm: fix checkpatch warnings

2014-08-04 Thread Greg KH
On Mon, Aug 04, 2014 at 02:42:02PM -0700, Frank Rowand wrote: On 8/4/2014 7:20 AM, Kiran Padwal wrote: This patch fixes the following checkpatch.pl warning: WARNING: braces {} are not necessary for any arm of this statement WARNING: Missing a blank line after declarations

Re: [PATCH] usb: host: ehci-msm: Make of_device_id array const

2014-08-01 Thread Greg KH
On Wed, Jul 30, 2014 at 06:14:45PM +0530, Kiran Padwal wrote: Make of_device_id array const, because all OF functions handle it as const. Signed-off-by: Kiran Padwal kiran.pad...@smartplayin.com --- drivers/usb/host/ehci-msm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: char interface to sdio, chdio.c

2014-07-17 Thread Greg KH
On Thu, Jul 17, 2014 at 12:17:00PM +0200, Arnd Bergmann wrote: On Wednesday 16 July 2014 22:33:47 Greg KH wrote: + mmc: Char SDIO Device Driver A few comments on the ioctl interface, since I suppose we'll have to live with that once it gets merged. Thanks for the review comments. I'll

Re: char interface to sdio, chdio.c

2014-07-16 Thread Greg KH
On Wed, Jul 16, 2014 at 11:21:57AM -0700, Stephen Boyd wrote: On 07/15/14 20:26, Greg KH wrote: Hi Stephen. I had some people ask me about a sdio userspace interface, and ran across the chdio.c file as found in the MSM android kernel trees: You mean csdio.c right? Ick, yes, sorry

Re: char interface to sdio, chdio.c

2014-07-16 Thread Greg KH
On Wed, Jul 16, 2014 at 04:08:11PM -0700, Stephen Boyd wrote: On 07/16/14 12:38, Stephen Boyd wrote: On 07/16/14 11:44, Greg KH wrote: My specific question is why 2 different interfaces? Ok. It definitely looks odd to support set/get of the VDD with sysfs and ioctl interfaces. I'm just

Re: char interface to sdio, chdio.c

2014-07-16 Thread Greg KH
On Wed, Jul 16, 2014 at 04:08:11PM -0700, Stephen Boyd wrote: On 07/16/14 12:38, Stephen Boyd wrote: On 07/16/14 11:44, Greg KH wrote: My specific question is why 2 different interfaces? Ok. It definitely looks odd to support set/get of the VDD with sysfs and ioctl interfaces. I'm just

Re: [PATCH] tty: serial: msm: Fix section mismatch warning

2014-06-03 Thread Greg KH
On Tue, Jun 03, 2014 at 03:13:22PM -0500, Kumar Gala wrote: WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in reference from the variable msm_platform_driver to the function .init.text:msm_serial_probe() The variable msm_platform_driver references the function __init

Re: [PATCH] tty: serial: msm: Fix section mismatch warning

2014-06-03 Thread Greg KH
On Tue, Jun 03, 2014 at 02:04:43PM -0700, Olof Johansson wrote: On Tue, Jun 3, 2014 at 1:33 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Jun 03, 2014 at 03:13:22PM -0500, Kumar Gala wrote: WARNING: drivers/tty/built-in.o(.data+0x3544): Section mismatch in reference from

Re: [GIT PULL] qcom driver changes for v3.16-2

2014-05-30 Thread Greg KH
On Fri, May 30, 2014 at 11:41:01AM -0500, Kumar Gala wrote: The following changes since commit 5d144e36b7c51612922fa05d37ff3a869261cc82: soc: qcom: Add GSBI driver (2014-05-23 11:38:04 -0500) are available in the git repository at:

Re: [PATCH v3 0/1] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-25 Thread Greg KH
On Fri, Nov 22, 2013 at 09:30:40AM -0800, Olav Haugan wrote: v3: Updated commit text with info about affected SoCs. You forgot to add a Cc: stable tag :( I'll go do it... -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to

Re: [PATCH v2] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-19 Thread Greg KH
On Tue, Nov 12, 2013 at 09:06:37AM -0800, Olav Haugan wrote: Hi Greg, On 11/11/2013 4:19 PM, Greg KH wrote: On Thu, Nov 07, 2013 at 05:58:03PM -0800, Olav Haugan wrote: zsmalloc encodes a handle using the pfn and an object index. On hardware platforms with physical memory starting

Re: [PATCH v2] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-11 Thread Greg KH
On Thu, Nov 07, 2013 at 05:58:03PM -0800, Olav Haugan wrote: zsmalloc encodes a handle using the pfn and an object index. On hardware platforms with physical memory starting at 0x0 the pfn can be 0. This causes the encoded handle to be 0 and is incorrectly interpreted as an allocation failure.

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-06 Thread Greg KH
On Wed, Nov 06, 2013 at 01:09:59PM -0800, Nitin Gupta wrote: On Tue, Nov 5, 2013 at 5:56 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Nov 05, 2013 at 04:54:12PM -0800, Olav Haugan wrote: zsmalloc encodes a handle using the page pfn and an object index. On some hardware platforms

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-06 Thread Greg KH
On Wed, Nov 06, 2013 at 03:46:19PM -0800, Nitin Gupta wrote: I'm getting really tired of them hanging around in here for many years now... Minchan has tried many times to promote zram out of staging. This was his most recent attempt: https://lkml.org/lkml/2013/8/21/54 There he

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-06 Thread Greg KH
On Wed, Nov 06, 2013 at 04:00:02PM -0800, Olav Haugan wrote: On 11/5/2013 5:56 PM, Greg KH wrote: On Tue, Nov 05, 2013 at 04:54:12PM -0800, Olav Haugan wrote: zsmalloc encodes a handle using the page pfn and an object index. On some hardware platforms the pfn could be 0 and this causes

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-05 Thread Greg KH
On Tue, Nov 05, 2013 at 04:54:12PM -0800, Olav Haugan wrote: zsmalloc encodes a handle using the page pfn and an object index. On some hardware platforms the pfn could be 0 and this causes the encoded handle to be 0 which is interpreted as an allocation failure. What platforms specifically

Re: [PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-08 Thread Greg KH
On Thu, Aug 08, 2013 at 04:49:24PM -0700, Jack Pham wrote: From: Manu Gautam mgau...@codeaurora.org I don't seem to have a patch 1/2 from you, did it not get sent somehow? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to

Re: [PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-08 Thread Greg KH
On Thu, Aug 08, 2013 at 07:12:13PM -0700, Jack Pham wrote: Hi Greg, On Thu, Aug 08, 2013 at 05:05:41PM -0700, Greg KH wrote: I don't seem to have a patch 1/2 from you, did it not get sent somehow? Here was patch 1/2: http://marc.info/?l=linux-usbm=137282127113409w=2 which you've applied

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-07-25 Thread Greg KH
On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote: From: Manu Gautam mgau...@codeaurora.org The USB Embedded High-speed Host Electrical Test (EHSET) defines the SINGLE_STEP_SET_FEATURE test as follows: 1) The host enumerates the test device with VID:0x1A0A, PID:0x0108 2) The host

Re: sysfs crashes while recursively checking file permissions

2012-11-16 Thread Greg KH
On Fri, Nov 02, 2012 at 01:20:12PM +0530, Chintan Pandya wrote: Hi, I am running one test on my ARM system which checks the sysfs file system's whole directory recursively and checks its file permission. While I perform this test, I face random (as in varies the nature of crash sometimes)

Re: [RFC/PATCH v4 0/3] UAS Gadget Driver.

2011-12-06 Thread Greg KH
On Tue, Dec 06, 2011 at 08:39:58AM -0800, Shimrit Malichi wrote: On Sun, Dec 04, 2011 at 10:18:14PM +0200, Shimrit Malichi wrote: This patch series implements the UAS gadget driver. It has been tested using the following: 1. Linux UAS host driver 2. Internaly developed unittests

Re: [RFC/PATCH v4 0/3] UAS Gadget Driver.

2011-12-05 Thread Greg KH
On Sun, Dec 04, 2011 at 10:18:14PM +0200, Shimrit Malichi wrote: This patch series implements the UAS gadget driver. It has been tested using the following: 1. Linux UAS host driver 2. Internaly developed unittests framework The device is functional. More stress tests are needed. TODO:

Re: USB support for device tree

2011-11-04 Thread Greg KH
On Fri, Nov 04, 2011 at 01:55:09PM +0530, Pavan Kondeti wrote: Hi I am working on adding USB device tree support for MSM platform. One of our chip set has 2 hsusb cores. The first core is configured as otg and the other core is configured in host only mode (EHCI compliant). Are the below

Re: [Qualcomm PM8921 MFD 4/6] mfd: pm8xxx-mpp: Add pm8xxx MPP driver

2011-07-08 Thread Greg KH
On Wed, Mar 02, 2011 at 02:13:19PM -0800, adhar...@codeaurora.org wrote: From: David Collins colli...@codeaurora.org Add support for multi-purpose pins (MPPs) on Qualcomm PM8xxx PMIC chips. PM8xxx MPPs can be configured as digital or analog inputs or outputs, current sinks, or buffers.

Re: [Qualcomm PM8921 MFD 3/6] gpio: pm8xxx-gpio: Add pm8xxx gpio driver

2011-07-08 Thread Greg KH
On Wed, Mar 02, 2011 at 02:13:18PM -0800, adhar...@codeaurora.org wrote: From: Abhijeet Dharmapurikar adhar...@codeaurora.org Add support for GPIO on Qualcomm PM8xxx PMIC chips. Change-Id: I5c00baeedc6c40ed40065d15c83577051e6ac9c6 What is this line for? -- To unsubscribe from this list:

Re: [stable] [PATCH v2] msm: timer: compensate for timer shift in msm_read_timer_count

2011-07-05 Thread Greg KH
On Tue, Jul 05, 2011 at 12:15:41PM -0700, Jeff Ohlstein wrote: Greg KH wrote: On Mon, Jun 20, 2011 at 04:27:16PM -0700, David Brown wrote: I don't think this patch was intended for stable in the first place. Jeff, this is a fix for 3.0-rcx, right? Then why was it sent to sta

Re: [PATCH v2 1/2] usb: gadget: add max_speed to usb_composite_driver

2011-06-29 Thread Greg KH
On Thu, Jun 30, 2011 at 08:14:15AM +0300, Tanya Brokhman wrote: Good morning Felipe, I went over the emails and all is ok. Thanks! One question: Greg/Alan mentioned that the compilation warning should be fixed by __maybe_unused. I wasn't aware such thing existed. Just looked it up.

Re: [stable] [PATCH v2] msm: timer: compensate for timer shift in msm_read_timer_count

2011-06-21 Thread Greg KH
On Mon, Jun 20, 2011 at 04:27:16PM -0700, David Brown wrote: On Mon, Jun 20 2011, Greg KH wrote: On Fri, Jun 17, 2011 at 01:55:38PM -0700, Jeff Ohlstein wrote: Some msm targets have timers whose lower bits are unreliable. So, we present our timers as lower frequency than they actually

Re: [stable] [PATCH v2] msm: timer: compensate for timer shift in msm_read_timer_count

2011-06-20 Thread Greg KH
On Fri, Jun 17, 2011 at 01:55:38PM -0700, Jeff Ohlstein wrote: Some msm targets have timers whose lower bits are unreliable. So, we present our timers as lower frequency than they actually are, and ignore the bottom 5 bits on such targets. This compensation was erroneously removed from the

Re: [PATCH/RFC 5/5] usb: Add support for streams alloc/dealloc to devio.c

2011-06-16 Thread Greg KH
On Thu, Jun 16, 2011 at 07:28:40PM +0300, Felipe Balbi wrote: On Thu, Jun 16, 2011 at 04:31:07PM +0300, Tatyana Brokhman wrote: Allow user space applications such as LIBUSB, to request streams alloc/dealloc from HCD that implements XHCI. Signed-off-by: Amit Blay ab...@qualcomm.com

Re: [PATCH v11 0/7] usb gadget: Add SuperSpeed support to the Gadget Framework

2011-05-19 Thread Greg KH
On Thu, May 19, 2011 at 07:14:22PM +0300, Felipe Balbi wrote: I would really like to see this in 2.6.40 as it would help my own development, but the way things looks I can't simply introduce such a big bug on kernel. If you manage to fix this in the upcoming few days, I can still push myself

Re: [PATCH v11 0/7] usb gadget: Add SuperSpeed support to the Gadget Framework

2011-05-19 Thread Greg KH
On Thu, May 19, 2011 at 09:43:43PM +0300, Tanya Brokhman wrote: On Thu, May 19, 2011 at 07:14:22PM +0300, Felipe Balbi wrote: I would really like to see this in 2.6.40 as it would help my own development, but the way things looks I can't simply introduce such a big bug on kernel. If

Re: [PATCH v11 0/7] usb gadget: Add SuperSpeed support to the Gadget Framework

2011-05-19 Thread Greg KH
On Thu, May 19, 2011 at 02:43:25PM +0300, Tatyana Brokhman wrote: It was tested in the following ways: 1. Dummy_hcd and g_zero gadget with our internally developed unittest. (See bellow) 2. Our DCD (that is not ready for upstreaming yet but we're working on it) and g_mass_storage

Re: [PATCH v10 0/7] usb gadget: Add SuperSpeed support to the Gadget Framework

2011-05-17 Thread Greg KH
On Tue, May 17, 2011 at 04:03:14PM +0300, Tatyana Brokhman wrote: It was tested in the following ways: 1. Dummy_hcd and g_zero gadget with our internally developed unittest. (See bellow) 2. Our DCD (that is not ready for upstreaming yet but we're working on it) and g_mass_storage

Re: [PATCH v10 0/7] usb gadget: Add SuperSpeed support to the Gadget Framework

2011-05-17 Thread Greg KH
On Tue, May 17, 2011 at 09:52:00PM +0300, Tanya Brokhman wrote: The unittest framework that was used for testing can be downloaded from git://codeaurora.org/quic/usb3/ut/.git Please use the upstream branch. See https://www.codeaurora.org/gitweb/quic/usb3/?p=ut/.git;a=summary for

Re: [PATCH V4 2/5] USB: OTG: msm: vote for dayatona fabric clock

2011-05-03 Thread Greg KH
On Tue, May 03, 2011 at 05:59:37PM +0530, Pavan Kondeti wrote: Hi Sergei, On 5/3/2011 4:44 PM, Sergei Shtylyov wrote: Hello. On 03-05-2011 9:13, Pavankumar Kondeti wrote: From: Anji jonnala an...@codeaurora.org HSUSB core clock is derived from daytona fabric clock and for

Re: [PATCH 1/7] USB: gadget: Fix typo (s/EBUSY/-EBUSY) in ci13xxx_udc

2011-04-29 Thread Greg KH
On Fri, Apr 29, 2011 at 09:04:03AM -0700, David Brown wrote: On Thu, Apr 28 2011, Pavankumar Kondeti wrote: Signed-off-by: Pavankumar Kondeti pkond...@codeaurora.org It is helpful to maintains to describe second revisions of patches in the subject, something like: [PATCH v2 1/7] ...

Re: [RFC/PATCH v3 2/5] uas: MS UAS Gadget driver - Infrastructure

2011-04-14 Thread Greg KH
On Thu, Apr 14, 2011 at 04:36:15PM +0300, Tatyana Brokhman wrote: This patch implements the infrastructure for the UAS gadget driver. The UAS gadget driver registers as a second configuration of the MS gadet driver. A new module parameter was added to the mass_storage module: bool use_uasp.

Re: [RFC/PATCH 5/5] uas: HACK needed for UAS host.

2011-03-07 Thread Greg KH
On Mon, Mar 07, 2011 at 06:48:51PM +0200, Tatyana Brokhman wrote: REMOVE LATER ON! Remove what? The patch or this description? confused, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2 2/2] msm: add single-wire serial bus interface (SSBI) driver

2011-02-24 Thread Greg KH
On Thu, Feb 24, 2011 at 07:54:21PM -0800, David Brown wrote: On Thu, Feb 24 2011, Greg KH wrote: drivers/ssbi? What's keeping this from later moving off of the msm chips to run on others? USB started out only on one processor, as did a lot of other bus-specific drivers, before

Re: [PATCH 1/3] USB: EHCI: Fix compiler warnings with MSM driver

2011-02-17 Thread Greg KH
On Tue, Feb 15, 2011 at 09:42:33AM +0530, Pavankumar Kondeti wrote: This patch fixes the following compile warnings drivers/usb/host/ehci-dbg.c:45: warning: 'dbg_hcs_params' defined but not used drivers/usb/host/ehci-dbg.c:89: warning: 'dbg_hcc_params' defined but not used

Re: [PATCH 0/3] hvc_dcc cleanups and fixes

2011-02-03 Thread Greg KH
On Mon, Dec 20, 2010 at 12:08:35PM -0800, Stephen Boyd wrote: Here are the split patches. The first two patches cleanup and fix the hvc_dcc driver for my compiler. The final patch is more controversial, it removes the v6 and v7 differences in this driver. Stephen Boyd (3): hvc_dcc: Fix

Re: [PATCH 0/3] hvc_dcc cleanups and fixes

2011-02-03 Thread Greg KH
On Thu, Feb 03, 2011 at 03:19:07PM -0800, Stephen Boyd wrote: On Mon, Dec 20, 2010 at 12:08:35PM -0800, Stephen Boyd wrote: Here are the split patches. The first two patches cleanup and fix the hvc_dcc driver for my compiler. The final patch is more controversial, it removes the v6 and

Re: [RFC/PATCH v4] usb: Add streams support to the gadget framework.

2011-01-20 Thread Greg KH
On Thu, Jan 20, 2011 at 01:45:13PM +0200, Maya Erez wrote: Add the capability to search for an EP with a required number of streams. Why? What in-kernel code needs this? Keep the stream ID for each usb_request. Again, why? thanks, greg k-h -- To unsubscribe from this list: send the line

Re: [PATCH 0/3] hvc_dcc cleanups and fixes

2011-01-05 Thread Greg KH
On Wed, Jan 05, 2011 at 05:49:17PM -0800, Stephen Boyd wrote: Greg, On 12/20/2010 12:08 PM, Stephen Boyd wrote: Here are the split patches. Should I resend these with the proper acks or can/have you picked these patches up? They are in my to-apply queue after .38-rc1 is out. thanks,

Re: [RFC 1/5] USB: core: Add input prompt and help text for USB_OTG config

2010-12-15 Thread Greg KH
On Wed, Dec 15, 2010 at 04:44:10PM +0530, Pavankumar Kondeti wrote: bd6882 commit removes the duplicate USB_OTG config from gadget/Kconfig. But does not copy the input prompt and help text to the original config defined in core/Kconfig. Add them now. Signed-off-by: Pavankumar Kondeti

Re: [PATCH v2] This driver supports UART-DM HW on MSM platforms. It uses the on chip DMA to drive data transfers and has optional support for UART power management independent of Linux suspend/resume

2010-12-14 Thread Greg KH
That's some subject: are you sure that should really be the subject? On Tue, Dec 14, 2010 at 11:49:46AM +0530, Mayank Rana wrote: The driver was originally developed by Google. It is functionally equivalent to the version available at: http://android.git.kernel.org/?p=kernel/experimental.git

Re: [PATCH] serial: msm_serial_hs: Add MSM high speed UART driver

2010-12-13 Thread Greg KH
On Mon, Dec 13, 2010 at 12:38:20PM +0530, Mayank Rana wrote: +#includelinux/msm_serial_hs.h Please put this file in include/platform_data/ instead. Greg, Thanks for reviewing the patch. Is there any particular reason not allowing msm_serial_hs.h as part of include/linux and need of

Re: [PATCH] serial: msm_serial_hs: Add MSM high speed UART driver

2010-12-13 Thread Greg KH
On Mon, Dec 13, 2010 at 11:26:26AM -0800, David Brown wrote: On Mon, Dec 13, 2010 at 10:06:07AM -0800, Greg KH wrote: Yes, it's not good to clutter up include/linux/ with this kind of platform specific stuff. Create a new directory and we will then move all of these types of files over

Re: [RFC 1/2] USB: Notify OTG errors to user space via uevents

2010-12-06 Thread Greg KH
On Mon, Dec 06, 2010 at 06:07:50PM +0530, Pavankumar Kondeti wrote: OTG specification mandates no silent failures and all errors should be reported to the user. The spec itself does not give the exact error description. But recommends the error message to be self explanatory. Provide

Re: [RFC 1/2] USB: Notify OTG errors to user space via uevents

2010-12-06 Thread Greg KH
On Mon, Dec 06, 2010 at 06:32:30PM -0800, pkond...@codeaurora.org wrote: Hi Greg, On Mon, Dec 06, 2010 at 06:07:50PM +0530, Pavankumar Kondeti wrote: OTG specification mandates no silent failures and all errors should be reported to the user. The spec itself does not give the exact

Re: [RFC 1/2] USB: Notify OTG errors to user space via uevents

2010-12-06 Thread Greg KH
On Tue, Dec 07, 2010 at 09:18:32AM +0530, Pavan Kondeti wrote: On 12/7/2010 8:02 AM, pkond...@codeaurora.org wrote: Hi Greg, On Mon, Dec 06, 2010 at 06:07:50PM +0530, Pavankumar Kondeti wrote: OTG specification mandates no silent failures and all errors should be reported to the user.

Re: [RFC 1/2] USB: Notify OTG errors to user space via uevents

2010-12-06 Thread Greg KH
On Tue, Dec 07, 2010 at 09:50:22AM +0530, Pavan Kondeti wrote: On 12/7/2010 9:20 AM, Greg KH wrote: On Mon, Dec 06, 2010 at 06:32:30PM -0800, pkond...@codeaurora.org wrote: Hi Greg, On Mon, Dec 06, 2010 at 06:07:50PM +0530, Pavankumar Kondeti wrote: OTG specification mandates no silent

Re: [PATCH] drivers: char: hvc: add arm JTAG DCC console support

2010-12-01 Thread Greg KH
On Wed, Dec 01, 2010 at 10:54:56AM -0800, Daniel Walker wrote: On Tue, 2010-11-30 at 21:30 -0800, Stephen Boyd wrote: On 11/30/2010 11:25 AM, Daniel Walker wrote: @@ -682,6 +682,15 @@ config HVC_UDBG select HVC_DRIVER default n +config HVC_DCC + bool

Re: [PATCH v4 0/4] usb gadget: Add SuperSpeed support to the Gadget Framework

2010-11-19 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Nov 19, 2010 at 12:56:22PM +0200, Tanya Brokhman wrote: Hi Greg Unfortunately I can't add a pointer to the unittest I mentioned since we didn't release them yet. It's in our TODO list but

Re: [PATCH v5 1/1] usb: Adding SuperSpeed support to dummy_hcd

2010-11-19 Thread Greg KH
On Fri, Nov 19, 2010 at 02:29:39PM -0800, Bryan Huntsman wrote: On 11/17/2010 05:23 PM, Greg KH wrote: On Wed, Nov 17, 2010 at 03:59:48PM -0800, Daniel Walker wrote: On Wed, 2010-11-17 at 13:35 -0800, Greg KH wrote: On Tue, Nov 16, 2010 at 04:08:12PM +0200, Tatyana Brokhman wrote: USB 3.0

Re: [PATCH v5 1/1] usb: Adding SuperSpeed support to dummy_hcd

2010-11-18 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Nov 18, 2010 at 01:01:17PM +0200, Tanya Brokhman wrote: Hi Greg Thank you for your comments. Please see my answers inline. Please fix your email client (i.e. get one that works properly)

Re: [PATCH v5 1/1] usb: Adding SuperSpeed support to dummy_hcd

2010-11-17 Thread Greg KH
On Wed, Nov 17, 2010 at 03:59:48PM -0800, Daniel Walker wrote: On Wed, 2010-11-17 at 13:35 -0800, Greg KH wrote: On Tue, Nov 16, 2010 at 04:08:12PM +0200, Tatyana Brokhman wrote: USB 3.0 hub includes 2 hubs - HS and SS ones. Thus, when dummy_hcd enabled it will register 2 root hubs (SS

Re: [PATCH v5 1/1] usb: Adding SuperSpeed support to dummy_hcd

2010-11-17 Thread Greg KH
On Wed, Nov 17, 2010 at 04:12:24PM -0800, David Brown wrote: On Wed, Nov 17, 2010 at 01:35:35PM -0800, Greg KH wrote: Does your lawyers agree that this is correct to add based on the size of the file? Hint, it doesn't pass the rule that some lawyers I work with go by, so I would

Re: [PATCH 1/4] USB: Add MSM OTG Controller driver

2010-11-17 Thread Greg KH
On Thu, Nov 18, 2010 at 10:30:16AM +0530, Pavan Kondeti wrote: Hi Greg, On Wed, Nov 17, 2010 at 08:16:37AM -0800, Greg KH wrote: On Wed, Nov 17, 2010 at 03:53:52PM +0530, Pavan Kondeti wrote: Hi Greg, On Tue, Nov 16, 2010 at 01:43:46PM -0800, Greg KH wrote: On Tue, Nov 09, 2010

Re: [PATCH 1/8] staging: dream: fix information leak to userland

2010-10-29 Thread Greg KH
On Fri, Oct 29, 2010 at 11:27:00AM -0700, Bryan Huntsman wrote: Greg, I'll check around internally and see if there are any concerns about dropping it. I'll get back to you soon. Thanks. Wonderful, thanks for doing this. greg k-h No concerns from us. Feel free to drop it.

Re: [PATCH] serial: msm_serial_hs: Add MSM high speed UART driver

2010-10-22 Thread Greg KH
On Fri, Oct 22, 2010 at 12:09:46PM +0530, Sankalp Bose wrote: This driver supports UART-DM HW on MSM platforms. It uses the on chip DMA to drive data transfers and has optional support for UART power management independent of Linux suspend/resume and wakeup from Rx. The driver was

Re: [PATCH v4] usb: usb3.0 ch9 definitions

2010-10-08 Thread Greg KH
On Fri, Oct 08, 2010 at 03:26:18PM +0200, Tatyana Brokhman wrote: Adding SuperSpeed usb definitions as defined by ch9 of the USB3.0 spec. This patch is a preparation for adding SuperSpeed support to the gadget framework. Signed-off-by: Tatyana Brokhmantlin...@codeaurora.org ---

Re: [RFC/PATCH v2 2/3] usb: usb3.0 ch9 definitions

2010-10-07 Thread Greg KH
On Thu, Oct 07, 2010 at 05:24:36PM +0200, tlinder wrote: Signed-off-by: tlinder tlin...@codeaurora.org I need a real name here please. --- include/linux/usb/ch9.h | 59 +- 1 files changed, 57 insertions(+), 2 deletions(-) diff --git

Re: [RFC/PATCH v2 3/3] usb:gadget: Add SuperSpeed support to the Gadget Framework

2010-10-07 Thread Greg KH
On Thu, Oct 07, 2010 at 05:24:57PM +0200, tlinder wrote: +/** Default endpoint companion descriptor */ What's the '**' for? +static struct usb_ss_ep_comp_descriptor default_ep_comp_desc = { + .bDescriptorType = USB_DT_SS_ENDPOINT_COMP, + .bLength = 0x06, +

Re: [RFC/PATCH v2 3/3] usb:gadget: Add SuperSpeed support to the Gadget Framework

2010-10-07 Thread Greg KH
On Thu, Oct 07, 2010 at 05:24:57PM +0200, tlinder wrote: --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig @@ -520,11 +520,11 @@ config USB_GADGET_DUMMY_HCD side is the master; the gadget side is the slave. Gadget drivers can be high, full, or low speed; and

Re: [RFC/PATCH v3] usb: usb3.0 ch9 definitions

2010-10-07 Thread Greg KH
On Thu, Oct 07, 2010 at 08:34:28PM +0200, Brokhman Tatyana wrote: Adding SuperSpeed usb definitions as defined by ch9 of the USB3.0 spec. This patch is a preparation for adding SuperSpeed support to the gadget framework. Signed-off-by: Brokhman Tatyana tlin...@codeaurora.org Is this still a

Re: [PATCH 1/4] platform: Use drv-driver.bus instead of assuming platform_bus_type

2010-09-01 Thread Greg KH
On Wed, Aug 18, 2010 at 12:53:12PM -0700, Patrick Pannuto wrote: On 08/18/2010 12:44 PM, Greg KH wrote: On Wed, Aug 18, 2010 at 12:15:40PM -0700, Patrick Pannuto wrote: In theory (although not *yet* in practice), a driver being passed to platform_driver_probe might have driver.bus set

Re: [PATCH 1/4] platform: Use drv-driver.bus instead of assuming platform_bus_type

2010-08-18 Thread Greg KH
On Wed, Aug 18, 2010 at 12:15:40PM -0700, Patrick Pannuto wrote: In theory (although not *yet* in practice), a driver being passed to platform_driver_probe might have driver.bus set to something other than platform_bus_type. Locking drv-driver.bus is always correct. Change-Id:

Re: [PATCH 1/4] platform: Use drv-driver.bus instead of assuming platform_bus_type

2010-08-18 Thread Greg KH
On Wed, Aug 18, 2010 at 12:53:12PM -0700, Patrick Pannuto wrote: On 08/18/2010 12:44 PM, Greg KH wrote: On Wed, Aug 18, 2010 at 12:15:40PM -0700, Patrick Pannuto wrote: In theory (although not *yet* in practice), a driver being passed to platform_driver_probe might have driver.bus set

Re: [RFC PATCH] platform: Faciliatate the creation of pseduo-platform busses

2010-08-06 Thread Greg KH
On Fri, Aug 06, 2010 at 09:12:27AM -0600, Grant Likely wrote: On Fri, Aug 6, 2010 at 8:27 AM, Greg KH gre...@suse.de wrote: On Thu, Aug 05, 2010 at 04:59:35PM -0600, Grant Likely wrote: (On that point Greg, what is the reason for even having the /sys/devices/platform/ parent?  Why not just

Re: [RFC PATCH] platform: Faciliatate the creation of pseduo-platform busses

2010-08-03 Thread Greg KH
On Tue, Aug 03, 2010 at 05:02:29PM -0700, Patrick Pannuto wrote: On 08/03/2010 04:56 PM, Greg KH wrote: On Tue, Aug 03, 2010 at 04:35:06PM -0700, Patrick Pannuto wrote: Inspiration for this comes from: http://www.mail-archive.com/linux-o...@vger.kernel.org/msg31161.html INTRO