Re: [PATCH 0/2] crypto: qce: fix few sparse warnings

2014-07-08 Thread Herbert Xu
On Fri, Jul 04, 2014 at 05:03:28PM +0300, Stanimir Varbanov wrote: > Hi Herbert, > > Here are sparse fixes for Qualcomm crypto driver reported here [1]. > The patches are based on cryptodev-2.6 tree. All applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herb

Re: [PATCH v4 0/3] Add Qualcomm crypto driver

2014-07-03 Thread Herbert Xu
On Wed, Jun 25, 2014 at 07:28:56PM +0300, Stanimir Varbanov wrote: > Here is v4 of the patchset. > > Changes since v3: > - Fixed trivial typo related to unnecessary semicolon. All applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ P

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-05-13 Thread Herbert Xu
On Fri, May 09, 2014 at 12:57:39AM +0300, Stanimir Vabanov wrote: > Hi Herbert, > > On 04/28/2014 11:59 AM, Herbert Xu wrote: > > On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote: > >> > >> +#define QCE_MAJOR_VERSION50x05 > >> +

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-04-29 Thread Herbert Xu
) If you dig deeper you'll find that when cryptd calls the actual completion functions (rather than its own) it disables BH. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: s

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-04-28 Thread Herbert Xu
ting them wait through the backlog mechanism. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majo

Re: [RFC PATCH v2 1/9] crypto: qce: Add core driver implementation

2014-04-28 Thread Herbert Xu
On Mon, Apr 14, 2014 at 03:48:37PM +0300, Stanimir Varbanov wrote: > > + if (backlog) > + backlog->complete(backlog, -EINPROGRESS); The completion function needs to be called with BH disabled. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herb

Re: [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

2014-04-28 Thread Herbert Xu
already set min_keysize and max_keysize correctly. > + } else if (IS_3DES(flags)) { > + if (keylen != DES3_EDE_KEY_SIZE) > + goto badkey; Ditto. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.

Re: [RFC PATCH v2 4/9] crypto: qce: Add ablkcipher algorithms

2014-04-28 Thread Herbert Xu
goto badkey; You need to support 192 here. If the hardware doesn't do that you can work around it by using a software fallback. In general you need to provide everything that is supported by the generic software implementation. Cheers, -- Email: Herbert Xu Home Page: http:/

Re: [PATCH] hwrng: msm: switch Kconfig to ARCH_QCOM depends

2014-02-25 Thread Herbert Xu
On Wed, Feb 12, 2014 at 11:33:14AM +0200, Stanimir Varbanov wrote: > Hi, > > We've split Qualcomm MSM support into legacy and multiplatform. The RNG > > driver is only relevant on the multiplatform supported SoCs so switch the > > Kconfig depends to ARCH_QCOM. > >

Re: [PATCH v3] hwrng: msm: switch Kconfig to ARCH_QCOM depends

2014-02-20 Thread Herbert Xu
On Thu, Feb 20, 2014 at 03:58:53PM -0600, Kumar Gala wrote: > We've split Qualcomm MSM support into legacy and multiplatform. The RNG > driver is only relevant on the multiplatform supported SoCs so switch the > Kconfig depends to ARCH_QCOM. > > CC: Herbert Xu > CC: Stan

Re: [PATCH v3 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-29 Thread Herbert Xu
gt; Reviewed-by: Stephen Boyd Both patches applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a messa

Re: [PATCH v3 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-26 Thread Herbert Xu
On Fri, Oct 25, 2013 at 04:57:23PM +0300, Stanimir Varbanov wrote: > Hi Herbert, > > On 10/23/2013 12:45 PM, Herbert Xu wrote: > > On Wed, Oct 23, 2013 at 12:41:10PM +0300, Stanimir Varbanov wrote: > >> On 10/15/2013 05:11 PM, Stanimir Varbanov wrote: > >>> Th

Re: [PATCH v3 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-23 Thread Herbert Xu
lks are OK with it I'm happy to take them. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord