Re: [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails

2015-11-10 Thread James Bottomley
On Tue, 2015-11-10 at 12:19 -0500, Sinan Kaya wrote: > On 11/10/2015 11:47 AM, Arnd Bergmann wrote: > > On Tuesday 10 November 2015 11:06:40 Sinan Kaya wrote: > >> On 11/10/2015 3:38 AM, Arnd Bergmann wrote: > >> From the email thread, it looks like this was introduced to support > >> some

Re: [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails

2015-11-10 Thread James Bottomley
On Tue, 2015-11-10 at 14:14 -0500, Sinan Kaya wrote: > > On 11/10/2015 1:27 PM, James Bottomley wrote: > > On Tue, 2015-11-10 at 12:19 -0500, Sinan Kaya wrote: > >> On 11/10/2015 11:47 AM, Arnd Bergmann wrote: > >>> On Tuesday 10 November 2015 11:06:40 Sinan Kaya

Re: [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails

2015-11-10 Thread James Bottomley
On Tue, 2015-11-10 at 14:56 -0500, Sinan Kaya wrote: > > On 11/10/2015 2:43 PM, James Bottomley wrote: > > The Issue, as stated by LSI is > > > > Initially set the consistent DMA mask to 32 bit and then change > > it > > to 64

Re: [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails

2015-11-10 Thread James Bottomley
On Tue, 2015-11-10 at 15:26 -0500, Sinan Kaya wrote: > > On 11/10/2015 3:05 PM, James Bottomley wrote: > > OK, you don't seem to be understanding the problem: the Altix isn't a > > LSI card, it was a SGI platform. > > Got it. > > > It was the platform where

Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device

2015-06-17 Thread James Bottomley
On Wed, 2015-06-17 at 14:21 +, Dov Levenglick wrote: Hi James, Rob raises a point that we don't agree with. On the other hand, we are not capable of convincing him in the validity of our approach - we are at an impasse. I would like to point out that our approach was reviewed by Paul and

Re: [PATCH v7 2/3] scsi: ufs: add debugfs for ufs

2015-03-27 Thread James Bottomley
On Thu, 2015-03-12 at 17:54 +0200, Gilad Broner wrote: From: Lee Susman lsus...@codeaurora.org Adding debugfs capability for ufshcd. This patch fails to build as a module because you aren't building corectly: ERROR: ufsdbg_add_debugfs [drivers/scsi/ufs/ufshcd.ko] undefined! ERROR:

Re: [RFC/PATCH 2/2] scsi: ufs: requests completion handling

2013-08-29 Thread James Bottomley
On Thu, 2013-08-29 at 11:54 +0300, Raviv Shvili wrote: The patch solves the request completion report order. At the current implementation, when multiple requests end at the same interrupt call, the requests reported as completed according to a bitmap scan from the lowest tags to the highest,

Re: [RFC/PATCH 2/2] scsi: ufs: requests completion handling

2013-08-29 Thread James Bottomley
On Thu, 2013-08-29 at 20:37 +0300, Yaniv Gardi wrote: Hi James, See reply inline Thanks, Yaniv -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of James Bottomley Sent: Thursday, August 29, 2013 12:28 PM To: Raviv

Re: [PATCH] block: Fix possible sleep in invalid context

2013-07-01 Thread James Bottomley
On Mon, 2013-07-01 at 15:17 -0700, Andrew Morton wrote: On Mon, 1 Jul 2013 20:58:35 +0530 Sujit Reddy Thumma sthu...@codeaurora.org wrote: When block runtime PM is enabled following warning is seen while resuming the device. BUG: sleeping function called from invalid context at

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-17 Thread James Bottomley
On Wed, 2013-01-16 at 23:14 +, Russell King - ARM Linux wrote: On Wed, Jan 16, 2013 at 10:32:35AM +, James Bottomley wrote: On Wed, 2013-01-16 at 12:07 +0530, Subhash Jadavani wrote: Now consider this call stack from MMC block driver (this is on the ARmv7 based board

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-17 Thread James Bottomley
On Wed, 2013-01-16 at 15:18 -0800, Tejun Heo wrote: On Wed, Jan 16, 2013 at 10:32:35AM +, James Bottomley wrote: diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index 6b2fb87..ab88c5b 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -809,7

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-17 Thread James Bottomley
On Thu, 2013-01-17 at 10:47 +, Russell King - ARM Linux wrote: On Thu, Jan 17, 2013 at 10:37:42AM +, Russell King - ARM Linux wrote: On Thu, Jan 17, 2013 at 09:11:20AM +, James Bottomley wrote: I'd actually prefer page = pfn_to_page(page_to_pfn(page) + 1); because it makes

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-17 Thread James Bottomley
On Thu, 2013-01-17 at 11:04 +, Russell King - ARM Linux wrote: On Thu, Jan 17, 2013 at 11:01:47AM +, James Bottomley wrote: On Thu, 2013-01-17 at 10:47 +, Russell King - ARM Linux wrote: Also, couldn't the addition of the scatterlist offset to the page also be buggy too

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-16 Thread James Bottomley
in the page offset map. Fix this by doing the increment via the pfn, which will do the right thing whatever the memory model. Signed-off-by: James Bottomley jbottom...@parallels.com --- diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index 6b2fb87..ab88c5b 100644 --- a/arch/arm/mm/dma

Re: ARM DMA: Fix in dma_cache_maint_page

2013-01-16 Thread James Bottomley
On Wed, 2013-01-16 at 18:17 +0530, Subhash Jadavani wrote: Is it possible to pick up James patch below? Thread here: http://comments.gmane.org/gmane.linux.kernel.mmc/18670, have the details on the motivation behind this fix. Someone should also audit the arm kernel code for more of these

Re: ARM DMA: Fix in dma_cache_maint_page

2013-01-16 Thread James Bottomley
On Wed, 2013-01-16 at 13:08 +, Russell King - ARM Linux wrote: On Wed, Jan 16, 2013 at 12:51:55PM +, James Bottomley wrote: On Wed, 2013-01-16 at 18:17 +0530, Subhash Jadavani wrote: Is it possible to pick up James patch below? Thread here: http://comments.gmane.org

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-15 Thread James Bottomley
On Tue, 2013-01-15 at 21:31 +0530, Subhash Jadavani wrote: blk_rq_map_sg() function merges the physically contiguous pages to use same scatter-gather node without checking if their page descriptors are contiguous or not. Now when dma_map_sg() is called on the scatter gather list, it would