Re: [PATCH] hvc_dcc: Simplify assembly for v6 and v7 ARM

2010-12-20 Thread Daniel Walker
On Fri, 2010-12-17 at 21:16 -0800, Stephen Boyd wrote: The inline assembly differences for v6 vs. v7 in the hvc_dcc driver are purely optimizations. On a v7 processor, an mrc with the pc sets the condition codes to the 28-31 bits of the register being read. It just so happens that the TX/RX

Re: [PATCH] hvc_dcc: Simplify assembly for v6 and v7 ARM

2010-12-20 Thread Stephen Boyd
On 12/20/2010 09:51 AM, Daniel Walker wrote: I would expect to see three patches. One that adds volatile, which appears to be a good fix. Another patch that changes the assembly lines, and another that does the clean up. The last two are more controversial ones Ok. I'll send a series later

Re: [PATCH] hvc_dcc: Simplify assembly for v6 and v7 ARM

2010-12-20 Thread Nicolas Pitre
On Mon, 20 Dec 2010, Stephen Boyd wrote: On 12/20/2010 09:51 AM, Daniel Walker wrote: I would expect to see three patches. One that adds volatile, which appears to be a good fix. Another patch that changes the assembly lines, and another that does the clean up. The last two are more

[PATCH] hvc_dcc: Simplify assembly for v6 and v7 ARM

2010-12-17 Thread Stephen Boyd
The inline assembly differences for v6 vs. v7 in the hvc_dcc driver are purely optimizations. On a v7 processor, an mrc with the pc sets the condition codes to the 28-31 bits of the register being read. It just so happens that the TX/RX full bits the DCC driver is testing for are high enough in