Re: [PATCH 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-10 Thread Ivan T. Ivanov
Hi, On Tue, 2014-09-09 at 15:49 +0300, Stanimir Varbanov wrote: > On 09/09/2014 01:32 PM, Arnd Bergmann wrote: > > On Monday 08 September 2014 18:30:00 Stanimir Varbanov wrote: > > These numbers all look hardware specific, so why put macros into the > > device tree rather than using them d

Re: [PATCH 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-09 Thread Stanimir Varbanov
On 09/09/2014 01:32 PM, Arnd Bergmann wrote: > On Monday 08 September 2014 18:30:00 Stanimir Varbanov wrote: > These numbers all look hardware specific, so why put macros into the > device tree rather than using them directly? The idea was to use #defines in DT nodes when we need

Re: [PATCH 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-09 Thread Arnd Bergmann
On Monday 08 September 2014 18:30:00 Stanimir Varbanov wrote: > >>> These numbers all look hardware specific, so why put macros into the > >>> device tree rather than using them directly? > >> > >> The idea was to use #defines in DT nodes when we need to overwrite the > >> adc channel parameters, s

Re: [PATCH 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-08 Thread Stanimir Varbanov
On 09/08/2014 01:19 PM, Arnd Bergmann wrote: > On Monday 08 September 2014 11:13:50 Stanimir Varbanov wrote: >> On 09/05/2014 03:26 PM, Arnd Bergmann wrote: >>> On Friday 05 September 2014 15:14:33 Stanimir Varbanov wrote: + VADC_CHAN(LR_MUX1_BAT_THERM, 0) /* 0x30 */

Re: [PATCH 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-08 Thread Arnd Bergmann
On Monday 08 September 2014 11:13:50 Stanimir Varbanov wrote: > On 09/05/2014 03:26 PM, Arnd Bergmann wrote: > > On Friday 05 September 2014 15:14:33 Stanimir Varbanov wrote: > >> + VADC_CHAN(LR_MUX1_BAT_THERM, 0) /* 0x30 */ > >> + VADC_CHAN(LR_MUX2_BAT_ID, 0) > >> +

Re: [PATCH 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-08 Thread Stanimir Varbanov
Hi Arnd, Thank you for the comments! On 09/05/2014 03:26 PM, Arnd Bergmann wrote: > On Friday 05 September 2014 15:14:33 Stanimir Varbanov wrote: >> + VADC_CHAN(LR_MUX1_BAT_THERM, 0) /* 0x30 */ >> + VADC_CHAN(LR_MUX2_BAT_ID, 0) >> + VADC_CHAN(LR_MUX3_XO_THERM, 0)

Re: [PATCH 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-05 Thread Arnd Bergmann
On Friday 05 September 2014 15:14:33 Stanimir Varbanov wrote: > + VADC_CHAN(LR_MUX1_BAT_THERM, 0) /* 0x30 */ > + VADC_CHAN(LR_MUX2_BAT_ID, 0) > + VADC_CHAN(LR_MUX3_XO_THERM, 0) > + VADC_CHAN(LR_MUX4_AMUX_THM1, 0) > + VADC_CHAN(LR_MUX5_AMUX_THM2, 0) > +

[PATCH 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-09-05 Thread Stanimir Varbanov
The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has 15bits resolution and register space inside PMIC accessible across SPMI bus. The vadc driver registers itself through IIO interface. Signed-off-by: Stanimir Varbanov Signed-off-by: Ivan T. Ivanov --- drivers/iio/adc/Kconfig