Re: [PATCH v2 3/4] scsi: ufs: add trace events and dump prints for debug

2015-02-22 Thread Gilad Broner
struct ufs_stats { +#ifdef CONFIG_DEBUG_FS bool enabled; u64 **tag_stats; int q_depth; int err_stats[UFS_ERR_MAX]; +#endif Can any of the tracepoint code be called that references these when CONFIG_DEBUG_FS is not set? Because soon (possibly even this merge window),

Re: [PATCH v2 3/4] scsi: ufs: add trace events and dump prints for debug

2015-02-12 Thread Steven Rostedt
On Tue, 10 Feb 2015 15:58:54 +0200 Gilad Broner gbro...@codeaurora.org wrote: I really hate large patches like this. So much to dig through. -#ifdef CONFIG_DEBUG_FS +#define UIC_ERR_REG_HIST_LENGTH 8 +/** + * struct ufs_uic_err_reg_hist - keeps history of uic errors + * @pos: index to

[PATCH v2 3/4] scsi: ufs: add trace events and dump prints for debug

2015-02-10 Thread Gilad Broner
Add trace events to driver to allow monitoring and profilig of activities such as PM suspend/resume, hibernate enter/exit, clock gating and clock scaling up/down. In addition, add UFS host controller register dumps to provide detailed information in case of errors to assist in analysis of issues.