Re: [PATCH v3 3/4] scsi: ufs: add trace events and dump prints for debug

2015-03-01 Thread Gilad Broner
If I understand the patch above, you basically have: if () goto out; else ret = ufshcd_resume(); out: Wouldn't it be better to just reverse the above if condition? if (!...) ret = ufshcd_resume(); That would be much less

Re: [PATCH v3 3/4] scsi: ufs: add trace events and dump prints for debug

2015-02-23 Thread Steven Rostedt
On Mon, 23 Feb 2015 09:15:15 - Dov Levenglick d...@codeaurora.org wrote: [ Cut's a 1000 lines of unneeded patch ] +#endif /* if !defined(_TRACE_UFS_H) || defined(TRACE_HEADER_MULTI_READ) */ + +/* This part must be outside protection */ +#include trace/define_trace.h -- Qualcomm

[PATCH v3 3/4] scsi: ufs: add trace events and dump prints for debug

2015-02-23 Thread Gilad Broner
Add trace events to driver to allow monitoring and profilig of activities such as PM suspend/resume, hibernate enter/exit, clock gating and clock scaling up/down. In addition, add UFS host controller register dumps to provide detailed information in case of errors to assist in analysis of issues.

Re: [PATCH v3 3/4] scsi: ufs: add trace events and dump prints for debug

2015-02-23 Thread Dov Levenglick
Add trace events to driver to allow monitoring and profilig of activities such as PM suspend/resume, hibernate enter/exit, clock gating and clock scaling up/down. In addition, add UFS host controller register dumps to provide detailed information in case of errors to assist in analysis of