Re: [PATCH v4 3/4] pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver

2014-10-07 Thread Linus Walleij
On Tue, Sep 30, 2014 at 7:02 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: On Wed 24 Sep 06:09 PDT 2014, Ivan T. Ivanov wrote: I am unable to make this work. of_gpio_simple_xlate() didn't know that GPIO range is offset with 1. Requesting last GPIO return error. And debug output

Re: [PATCH v4 3/4] pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver

2014-09-30 Thread Bjorn Andersson
On Wed 24 Sep 06:09 PDT 2014, Ivan T. Ivanov wrote: On Tue, 2014-09-23 at 21:18 -0700, Bjorn Andersson wrote: On Mon 15 Sep 07:44 PDT 2014, Ivan T. Ivanov wrote: snip +static int pmic_gpio_of_xlate(struct gpio_chip *chip, + const struct of_phandle_args

Re: [PATCH v4 3/4] pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver

2014-09-24 Thread Ivan T. Ivanov
On Tue, 2014-09-23 at 21:18 -0700, Bjorn Andersson wrote: On Mon 15 Sep 07:44 PDT 2014, Ivan T. Ivanov wrote: This is the pinctrl, pinmux, pinconf and gpiolib driver for the Qualcomm GPIO sub-function blocks found in the PMIC chips. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com I

Re: [PATCH v4 3/4] pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver

2014-09-24 Thread Ivan T. Ivanov
On Tue, 2014-09-23 at 21:18 -0700, Bjorn Andersson wrote: On Mon 15 Sep 07:44 PDT 2014, Ivan T. Ivanov wrote: snip +static int pmic_gpio_of_xlate(struct gpio_chip *chip, + const struct of_phandle_args *gpio_desc, + u32 *flags) +{

Re: [PATCH v4 3/4] pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver

2014-09-23 Thread Bjorn Andersson
On Mon 15 Sep 07:44 PDT 2014, Ivan T. Ivanov wrote: This is the pinctrl, pinmux, pinconf and gpiolib driver for the Qualcomm GPIO sub-function blocks found in the PMIC chips. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com I think this looks pretty good, just some minor comments. Mostly on

[PATCH v4 3/4] pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver

2014-09-15 Thread Ivan T. Ivanov
This is the pinctrl, pinmux, pinconf and gpiolib driver for the Qualcomm GPIO sub-function blocks found in the PMIC chips. Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- drivers/pinctrl/qcom/Kconfig | 12 + drivers/pinctrl/qcom/Makefile | 1 +