Re: [PATCH v4 1/2] phy: qcom: Add driver for QCOM APQ8064 SATA PHY

2014-07-16 Thread Srinivas Kandagatla
On 15/07/14 17:56, Bartlomiej Zolnierkiewicz wrote: + +/* Helper function to do poll and timeout */ +static int read_poll_timeout(void __iomem *addr, u32 mask) +{ + unsigned long timeout = jiffies + msecs_to_jiffies(TIMEOUT_MS); + + do { + if (readl_relaxed(addr) mask) +

Re: [PATCH v3 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver

2014-07-16 Thread kiran padwal
tested-by: Kiran Padwal kiran.pad...@smartplayin.com This driver tested with APQ806x SATA PHY Driver. On Wed, Jun 18, 2014 at 12:06 AM, Kumar Gala ga...@codeaurora.org wrote: Add support for the Qualcomm AHCI SATA controller that exists on several SoC and specifically the IPQ806x family of

Re: [PATCH v4 3/3] regulator: qcom-rpm: Regulator driver for the Qualcomm RPM

2014-07-16 Thread pramod gurav
Hi Bjorn, On Wed, Jul 16, 2014 at 4:30 AM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: Driver for regulators exposed by the Resource Power Manager (RPM) found in Qualcomm 8660, 8960 and 8064 based devices. Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com ---

Re: [PATCH v2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Srivatsa S. Bhat
On 07/15/2014 11:05 PM, skan...@codeaurora.org wrote: Srivatsa S. Bhat wrote: On 07/15/2014 11:06 AM, Saravana Kannan wrote: On 07/14/2014 09:35 PM, Viresh Kumar wrote: On 15 July 2014 00:38, Saravana Kannan skan...@codeaurora.org wrote: Yeah, it definitely crashes if policy-cpu if an

Re: [PATCH v2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Srivatsa S. Bhat
On 07/16/2014 11:14 AM, Viresh Kumar wrote: On 15 July 2014 12:28, Srivatsa S. Bhat sriva...@mit.edu wrote: Wait, allowing an offline CPU to be the policy-cpu (i.e., the CPU which is considered as the master of the policy/group) is just absurd. Yeah, that was as Absurd as I am :) I have

Re: [PATCH 2/3] pinctrl: Device tree bindings for Qualcomm pm8xxx gpio block

2014-07-16 Thread Ivan T. Ivanov
On Tue, 2014-07-15 at 17:23 -0700, Bjorn Andersson wrote: On Mon, Jul 14, 2014 at 11:35 PM, Ivan T. Ivanov iiva...@mm-sol.com wrote: On Mon, 2014-07-14 at 14:20 -0700, Stephen Boyd wrote: [..] Isn't this document only for the gpios? I think you're talking about the MPPs, which also exist

[PATCH] phy: qcom-apq8064: fix possible timeout without check

2014-07-16 Thread Srinivas Kandagatla
This patch fixes a possible timeout in poll loop without actually checking the register before return. In theory the there is a possibility of loop being scheduled after a long lock/delay, which would then force the loop to exit without actually checking the register. Reported-by: Bartlomiej

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Viresh Kumar
On 16 July 2014 04:17, Saravana Kannan skan...@codeaurora.org wrote: diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c +/* symlink related CPUs */ +static int cpufreq_dev_symlink(struct cpufreq_policy *policy, bool add) { - unsigned int j; + unsigned int j,

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Viresh Kumar
On 16 July 2014 05:58, Saravana Kannan skan...@codeaurora.org wrote: + if (!cpus cpufreq_driver-stop_cpu cpufreq_driver-setpolicy) { + cpufreq_driver-stop_cpu(policy); + } Viresh, I tried your suggestion (and my initial thought too) to combine this as an if/else

Re: [PATCH v3 2/2] cpufreq: Simplify and fix mutual exclusion with hotplug

2014-07-16 Thread Viresh Kumar
On 16 July 2014 04:17, Saravana Kannan skan...@codeaurora.org wrote: Again, just too many things in a single patch. That's not acceptable. Few of these might be bug fixes, which must go in before any other updates. And so it must have been added as first patch. Even the other stuff you are

Re: [PATCH v4 1/3] soc: devicetree: bindings: Add Qualcomm RPM DT binding

2014-07-16 Thread pramod gurav
Hi Bjorn, RPM breaks on IFC6410 without entry for 'qcom.ipc' node. Please find my observations below. On Wed, Jul 16, 2014 at 4:30 AM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: Add binding for the Qualcomm Resource Power Manager (RPM) found in 8660, 8960 and 8064 based devices. The

Re: [PATCH v4] devicetree: Add generic IOMMU device tree bindings

2014-07-16 Thread Will Deacon
On Wed, Jul 16, 2014 at 02:25:20AM +0100, Olav Haugan wrote: On 7/13/2014 4:43 AM, Rob Clark wrote: On Sun, Jul 13, 2014 at 5:43 AM, Will Deacon will.dea...@arm.com wrote: My plan for the ARM SMMU driver is: (1) Change -probe() to walk the device-tree looking for all masters with

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Srivatsa S. Bhat
On 07/16/2014 01:54 PM, Viresh Kumar wrote: On 16 July 2014 04:17, Saravana Kannan skan...@codeaurora.org wrote: diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c +/* symlink related CPUs */ +static int cpufreq_dev_symlink(struct cpufreq_policy *policy, bool add) { -

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Stanimir Varbanov
Hi, snip Signed-off-by: Pramod Gurav pramod.gurav@gmail.com CC: Josh Cartwright jo...@codeaurora.org CC: Mark Brown broo...@linaro.org --- This was found when I enabled support for Qualcomm QPNP PMICs and was compiling it. It selects REGMAP_SPMI and hence the crash.

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Pramod Gurav
Hi, On Wednesday, 16 July, 2014 5:37pm, Stanimir Varbanov svarba...@mm-sol.com said: Hi, snip Signed-off-by: Pramod Gurav pramod.gurav@gmail.com CC: Josh Cartwright jo...@codeaurora.org CC: Mark Brown broo...@linaro.org --- This was found when I enabled support for Qualcomm QPNP

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Stanimir Varbanov
snip config REGMAP_SPMI + select SPMI NO, IMO the CONFIG_SPMI should be enabled by qcom_defconfig and multi_v7_defconfig. See CONFIG_I2C and REGMAP_I2C for example. I am using multi_v7_defconfig but its not enabling it. I ran qcom_defconfig which does. yes, it seems reasonable to

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Lars-Peter Clausen
On 07/16/2014 01:39 PM, pramod.gurav@gmail.com wrote: From: Pramod Gurav pramod.gurav@gmail.com REGMAP_SPMI module calls some functions from SPMI hence build breaks when SPMI is not enabled while compiling REGMAP_SPMI with below linker errors: drivers/built-in.o: In function

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Pramod Gurav
Hi, On Wednesday, 16 July, 2014 5:55pm, Stanimir Varbanov svarba...@mm-sol.com said: snip config REGMAP_SPMI + select SPMI NO, IMO the CONFIG_SPMI should be enabled by qcom_defconfig and multi_v7_defconfig. See CONFIG_I2C and REGMAP_I2C for example. I am using multi_v7_defconfig

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Viresh Kumar
On 16 July 2014 16:46, Srivatsa S. Bhat sriva...@mit.edu wrote: Short answer: If the sysfs directory has already been created by cpufreq, then yes, it will remain as it is. However, if the online operation failed before that, then cpufreq won't know about that CPU at all, and no file will be

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Stanimir Varbanov
snip Thanks. I misunderstood the Kconfig documentation which says, Reverse dependencies can only be used with boolean or tristate symbols. In the note following this statement doc says, In general use select only for non-visible symbols. The CONFIG_SPMI option is visible in menuconfig

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Mark Brown
On Wed, Jul 16, 2014 at 06:26:15PM +0530, Pramod Gurav wrote: Fix your mailer to word wrap within paragraphs, this will make your mails more legible - see Documentation/email-clients.txt. On Wednesday, 16 July, 2014 5:55pm, Stanimir Varbanov svarba...@mm-sol.com said: The CONFIG_SPMI option

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Ivan T. Ivanov
On Wed, 2014-07-16 at 14:53 +0100, Mark Brown wrote: On Wed, Jul 16, 2014 at 06:26:15PM +0530, Pramod Gurav wrote: Fix your mailer to word wrap within paragraphs, this will make your mails more legible - see Documentation/email-clients.txt. On Wednesday, 16 July, 2014 5:55pm, Stanimir

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Mark Brown
On Wed, Jul 16, 2014 at 05:00:54PM +0300, Ivan T. Ivanov wrote: On Wed, 2014-07-16 at 14:53 +0100, Mark Brown wrote: No, this isn't an either/or thing - the dependency is absolutely mandatory if the device needs SPMI. The defconfigs are a separate thing, they just exist to give people a

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Dirk Brandewie
On 07/15/2014 03:47 PM, Saravana Kannan wrote: The CPUfreq core moves the cpufreq policy ownership between CPUs when CPUs within a cluster (CPUs sharing same policy) go ONLINE/OFFLINE. When moving policy ownership between CPUs, it also moves the cpufreq sysfs directory between CPUs and also

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread pramod gurav
On Wed, Jul 16, 2014 at 7:48 PM, Mark Brown broo...@kernel.org wrote: On Wed, Jul 16, 2014 at 05:00:54PM +0300, Ivan T. Ivanov wrote: On Wed, 2014-07-16 at 14:53 +0100, Mark Brown wrote: No, this isn't an either/or thing - the dependency is absolutely mandatory if the device needs SPMI.

Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

2014-07-16 Thread Mark Brown
On Wed, Jul 16, 2014 at 08:12:04PM +0530, pramod gurav wrote: On Wed, Jul 16, 2014 at 7:48 PM, Mark Brown broo...@kernel.org wrote: A dependency from a selected symbol will have no effect. Thanks Mark. So essentially in this case PMIC driver should 'select SPMI'. Right? I would expect it

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Viresh Kumar
On 16 July 2014 19:59, Dirk Brandewie dirk.brande...@gmail.com wrote: stop_cpu() only needs to be called during __cpufreq_remove_dev_prepare() no where else. Oh, thanks for reminding us.. Look at this Saravana: 367dc4a cpufreq: Add stop CPU callback to cpufreq_driver interface -- To

Re: [PATCH 00/14] cpufreq: cpu0: Extend support beyond CPU0, V2

2014-07-16 Thread Viresh Kumar
Cc'ing Thomas, On 8 July 2014 10:20, Viresh Kumar viresh.ku...@linaro.org wrote: On 4 July 2014 09:51, Viresh Kumar viresh.ku...@linaro.org wrote: Yeah, having something like what you suggested from DT is the perfect solution to get over this. The only reason why I am not touching that here

[PATCH v8 2/2] phy: qcom: Add device tree bindings for IPQ806x SATA PHY

2014-07-16 Thread Kumar Gala
Add binding spec for Qualcomm SoC PHYs, starting with the SATA PHY on the IPQ806x family of SoCs. Signed-off-by: Kumar Gala ga...@codeaurora.org --- v8, v7: * no change v6: * Moved binding to qcom-ipq806x-sata-phy.txt instead of qcom-phy.txt .../bindings/phy/qcom-ipq806x-sata-phy.txt |

[PATCH v8 1/2] phy: qcom: Add driver for QCOM IPQ806x SATA PHY

2014-07-16 Thread Kumar Gala
Add a PHY driver for uses with AHCI based SATA controller driver on the IPQ806x family of SoCs. Signed-off-by: Kumar Gala ga...@codeaurora.org --- v8: * Add comment about the mb() v7: * Fix compilation issues due to change in devm_phy_create API v6: * Add platform_set_drvdata v5: * Fix

Re: [PATCH] PM / devfreq: Allocate memory using the right data type

2014-07-16 Thread Stephen Boyd
On 07/15/14 20:10, Saravana Kannan wrote: diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 65eed38..349e28ea 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -483,9 +483,10 @@ struct devfreq *devfreq_add_device(struct device *dev,

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Srivatsa S. Bhat
On 07/16/2014 06:43 PM, Viresh Kumar wrote: On 16 July 2014 16:46, Srivatsa S. Bhat sriva...@mit.edu wrote: Short answer: If the sysfs directory has already been created by cpufreq, then yes, it will remain as it is. However, if the online operation failed before that, then cpufreq won't know

Re: char interface to sdio, chdio.c

2014-07-16 Thread Stephen Boyd
On 07/15/14 20:26, Greg KH wrote: Hi Stephen. I had some people ask me about a sdio userspace interface, and ran across the chdio.c file as found in the MSM android kernel trees: You mean csdio.c right? https://android.googlesource.com/kernel/msm/+/57b74303d6f033ab04be039379f6661337fb9279

Re: char interface to sdio, chdio.c

2014-07-16 Thread Greg KH
On Wed, Jul 16, 2014 at 11:21:57AM -0700, Stephen Boyd wrote: On 07/15/14 20:26, Greg KH wrote: Hi Stephen. I had some people ask me about a sdio userspace interface, and ran across the chdio.c file as found in the MSM android kernel trees: You mean csdio.c right? Ick, yes, sorry

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Saravana Kannan
On 07/16/2014 01:30 AM, Viresh Kumar wrote: On 16 July 2014 05:58, Saravana Kannan skan...@codeaurora.org wrote: + if (!cpus cpufreq_driver-stop_cpu cpufreq_driver-setpolicy) { + cpufreq_driver-stop_cpu(policy); + } Viresh, I tried your suggestion (and my initial

Re: [PATCH v3 2/2] cpufreq: Simplify and fix mutual exclusion with hotplug

2014-07-16 Thread Saravana Kannan
On 07/16/2014 01:48 AM, Viresh Kumar wrote: On 16 July 2014 04:17, Saravana Kannan skan...@codeaurora.org wrote: Again, just too many things in a single patch. That's not acceptable. Few of these might be bug fixes, which must go in before any other updates. And so it must have been added as

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Saravana Kannan
On 07/16/2014 08:28 AM, Viresh Kumar wrote: On 16 July 2014 19:59, Dirk Brandewie dirk.brande...@gmail.com wrote: stop_cpu() only needs to be called during __cpufreq_remove_dev_prepare() no where else. Oh, thanks for reminding us.. Look at this Saravana: 367dc4a cpufreq: Add stop CPU

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Saravana Kannan
On 07/16/2014 04:16 AM, Srivatsa S. Bhat wrote: On 07/16/2014 01:54 PM, Viresh Kumar wrote: On 16 July 2014 04:17, Saravana Kannan skan...@codeaurora.org wrote: diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c SNIP -static int cpufreq_add_policy_cpu(struct

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Saravana Kannan
On 07/16/2014 06:13 AM, Viresh Kumar wrote: On 16 July 2014 16:46, Srivatsa S. Bhat sriva...@mit.edu wrote: Short answer: If the sysfs directory has already been created by cpufreq, then yes, it will remain as it is. However, if the online operation failed before that, then cpufreq won't know

Re: [PATCH v4] devicetree: Add generic IOMMU device tree bindings

2014-07-16 Thread Rob Clark
On Tue, Jul 15, 2014 at 9:25 PM, Olav Haugan ohau...@codeaurora.org wrote: On 7/13/2014 4:43 AM, Rob Clark wrote: On Sun, Jul 13, 2014 at 5:43 AM, Will Deacon will.dea...@arm.com wrote: On Sat, Jul 12, 2014 at 01:57:31PM +0100, Rob Clark wrote: On Sat, Jul 12, 2014 at 8:22 AM, Arnd Bergmann

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Saravana Kannan
On 07/16/2014 01:24 AM, Viresh Kumar wrote: On 16 July 2014 04:17, Saravana Kannan skan...@codeaurora.org wrote: diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c +/* symlink related CPUs */ +static int cpufreq_dev_symlink(struct cpufreq_policy *policy, bool add) { -

[PATCH 2/2] WIP: rnndb: add support for MDP5 v1.3 using dynamic offsets

2014-07-16 Thread Stephane Viau
In order to deal with offsets differences between MDP5 v1.3 and earlier versions, dynamic offsets are introduced. At runtime, MDP version is read to find out which hardware configuration is embedded on the target. Once this is found out, these dynamic offsets are set through global variables

[PATCH 0/2] rnndb: support for MDP5 v1.3 using dynamic offsets

2014-07-16 Thread Stephane Viau
This patchset is intended to be used on top of Rob's wip changes in the 'variable-bases' branch. Dynamic offsets are introduced for MDP5 register description in order to support multiple versions (v.1.3 added here). Stephane Viau (2): WIP: rnndb: move reg_.. bitset definitions to common MDP xml

[PATCH] ARM: dts: qcom: Add 8064 multimedia clock controller node

2014-07-16 Thread Stephen Boyd
Add the mmcc node so that we can probe and use the multimedia clocks on apq8064. Signed-off-by: Stephen Boyd sb...@codeaurora.org --- arch/arm/boot/dts/qcom-apq8064.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi

Re: [PATCH 00/14] cpufreq: cpu0: Extend support beyond CPU0, V2

2014-07-16 Thread Rafael J. Wysocki
On Wednesday, July 16, 2014 09:31:54 PM Viresh Kumar wrote: Cc'ing Thomas, On 8 July 2014 10:20, Viresh Kumar viresh.ku...@linaro.org wrote: On 4 July 2014 09:51, Viresh Kumar viresh.ku...@linaro.org wrote: Yeah, having something like what you suggested from DT is the perfect solution to

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Saravana Kannan
On 07/16/2014 01:25 PM, Saravana Kannan wrote: On 07/16/2014 01:24 AM, Viresh Kumar wrote: On 16 July 2014 04:17, Saravana Kannan skan...@codeaurora.org wrote: diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c @@ -1110,9 +1092,10 @@ static int __cpufreq_add_dev(struct

Re: [PATCH v4 3/3] regulator: qcom-rpm: Regulator driver for the Qualcomm RPM

2014-07-16 Thread Bjorn Andersson
On Tue, Jul 15, 2014 at 5:08 PM, Mark Brown broo...@kernel.org wrote: On Tue, Jul 15, 2014 at 04:00:41PM -0700, Bjorn Andersson wrote: Driver for regulators exposed by the Resource Power Manager (RPM) found in Qualcomm 8660, 8960 and 8064 based devices. I have patch 3/3 here but no cover or

Re: [PATCH v4 1/3] soc: devicetree: bindings: Add Qualcomm RPM DT binding

2014-07-16 Thread Bjorn Andersson
On Wed, Jul 16, 2014 at 3:06 AM, pramod gurav pramod.gurav@gmail.com wrote: Hi Bjorn, RPM breaks on IFC6410 without entry for 'qcom.ipc' node. Please find my observations below. On Wed, Jul 16, 2014 at 4:30 AM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: [...] +

Re: [PATCH v4 3/3] regulator: qcom-rpm: Regulator driver for the Qualcomm RPM

2014-07-16 Thread Bjorn Andersson
On Wed, Jul 16, 2014 at 12:01 AM, pramod gurav pramod.gurav@gmail.com wrote: Hi Bjorn, On Wed, Jul 16, 2014 at 4:30 AM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: [...] +static const struct regulator_linear_range pldo_ranges[] = { + REGULATOR_LINEAR_RANGE( 75, 0,

Re: [PATCH v4 3/3] regulator: qcom-rpm: Regulator driver for the Qualcomm RPM

2014-07-16 Thread Mark Brown
On Wed, Jul 16, 2014 at 03:17:13PM -0700, Bjorn Andersson wrote: On Wed, Jul 16, 2014 at 12:01 AM, pramod gurav On Wed, Jul 16, 2014 at 4:30 AM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: +static const struct regulator_linear_range pldo_ranges[] = { +

Re: [PATCH v4 3/3] regulator: qcom-rpm: Regulator driver for the Qualcomm RPM

2014-07-16 Thread Mark Brown
On Wed, Jul 16, 2014 at 03:15:16PM -0700, Bjorn Andersson wrote: On Tue, Jul 15, 2014 at 5:08 PM, Mark Brown broo...@kernel.org wrote: I have patch 3/3 here but no cover or other patches - what is the story there? I forgot to add you as explicit recipient of the other mails in the series,

Re: [PATCH] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Saravana Kannan
On 07/16/2014 03:02 PM, Rafael J. Wysocki wrote: On Wednesday, July 09, 2014 07:37:30 PM Saravana Kannan wrote: Preliminary patch. Not tested. Just sending out to give an idea of what I'm looking to do. Expect a lot more simplification when it's done. Benefits: * A lot more simpler code. *

Re: char interface to sdio, chdio.c

2014-07-16 Thread Stephen Boyd
On 07/16/14 12:38, Stephen Boyd wrote: On 07/16/14 11:44, Greg KH wrote: My specific question is why 2 different interfaces? Ok. It definitely looks odd to support set/get of the VDD with sysfs and ioctl interfaces. I'm just guessing, but I suspect it's a permissions thing given that the

Re: char interface to sdio, chdio.c

2014-07-16 Thread Greg KH
On Wed, Jul 16, 2014 at 04:08:11PM -0700, Stephen Boyd wrote: On 07/16/14 12:38, Stephen Boyd wrote: On 07/16/14 11:44, Greg KH wrote: My specific question is why 2 different interfaces? Ok. It definitely looks odd to support set/get of the VDD with sysfs and ioctl interfaces. I'm just

[PATCH] PM / OPP: cpufreq: Avoid sleeping while atomic

2014-07-16 Thread Stephen Boyd
We allocate the cpufreq table after calling rcu_read_lock(), which disables preemption. This causes scheduling while atomic warnings. Use GFP_ATOMIC instead of GFP_KERNEL and update for kcalloc while we're here. BUG: sleeping function called from invalid context at mm/slub.c:1246 in_atomic(): 0,

Re: [PATCH v3] PM / devfreq: Add possible_frequencies device attribute

2014-07-16 Thread MyungJoo Ham
On Wed, Jul 16, 2014 at 12:01 PM, Saravana Kannan skan...@codeaurora.org wrote: Some devices use freq_table instead of OPP. For those devices, the available_frequencies sysfs file shows up empty. So, add a possible_frequencies attribute/syfs file that list all the possible frequencies. For

[PATCH v2 0/1] Add iommu map_range/unmap_range calls

2014-07-16 Thread Olav Haugan
Patch for adding map_range/unmap range to the generic IOMMU API. v1 - v2: * Added support for option argument to unmap call. This can be used by IOMMU driver implentations to allow clients to signal to the driver not to do TLB invalidate for example. * Added fallback in case

[PATCH v2 1/1] iommu-api: Add map_range/unmap_range functions

2014-07-16 Thread Olav Haugan
Mapping and unmapping are more often than not in the critical path. map_range and unmap_range allows SMMU driver implementations to optimize the process of mapping and unmapping buffers into the SMMU page tables. Instead of mapping one physical address, do TLB operation (expensive), mapping, do

Re: [PATCH] PM / OPP: cpufreq: Avoid sleeping while atomic

2014-07-16 Thread Viresh Kumar
On 17 July 2014 05:05, Stephen Boyd sb...@codeaurora.org wrote: We allocate the cpufreq table after calling rcu_read_lock(), which disables preemption. This causes scheduling while atomic warnings. Use GFP_ATOMIC instead of GFP_KERNEL and update for kcalloc while we're here. I am surprised to

Re: char interface to sdio, chdio.c

2014-07-16 Thread Greg KH
On Wed, Jul 16, 2014 at 04:08:11PM -0700, Stephen Boyd wrote: On 07/16/14 12:38, Stephen Boyd wrote: On 07/16/14 11:44, Greg KH wrote: My specific question is why 2 different interfaces? Ok. It definitely looks odd to support set/get of the VDD with sysfs and ioctl interfaces. I'm just

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Viresh Kumar
On 17 July 2014 01:26, Saravana Kannan skan...@codeaurora.org wrote: On 07/16/2014 04:16 AM, Srivatsa S. Bhat wrote: That is, we wanted to do the kobject cleanup after releasing the hotplug lock, and POST_DEAD stage was well-suited for that. I think, this has changed in Saravana's patch, we

Re: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

2014-07-16 Thread Viresh Kumar
On 17 July 2014 01:26, Saravana Kannan skan...@codeaurora.org wrote: No it's not. All the cpu*/ directories for all possible CPUs will be there whether a CPU is online/offline. Which is why I also weed out impossible CPUs, but you said the driver shouldn't be passing impossible CPUs anyway.