Re: [Patch v6 2/2] dmaengine: Add ADM driver

2015-05-21 Thread Archit Taneja
Hi, On 03/17/2015 11:16 AM, Andy Gross wrote: Add the DMA engine driver for the QCOM Application Data Mover (ADM) DMA controller found in the MSM8x60 and IPQ/APQ8064 platforms. The ADM supports both memory to memory transactions and memory to/from peripheral device transactions. The

Re: [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

2015-05-21 Thread Paul Bolle
On Wed, 2015-05-20 at 10:22 +0200, Paul Bolle wrote: By the way, as far as I can see, this (new) module can only be loaded manually (or via scripts). Is that what people want? This comment wasn't well thought through. So I hand another look at the code of usf-qcom. I noticed that the single

[PATCH] ASoC: qcom: remove incorrect dependencies

2015-05-21 Thread Arnd Bergmann
Compile-tests show a warning for the newly added SND_SOC_STORM symbol: warning: (SND_SOC_STORM) selects SND_SOC_LPASS_CPU which has unmet direct dependencies (SOUND !M68K !UML SND SND_SOC SND_SOC_QCOM) The problem is that it can be selected for COMPILE_TEST on non-QCOM builds, but the

Re: [PATCH v2 01/13] ASoC: qcom: make lpass driver depend on OF

2015-05-21 Thread Mark Brown
On Sat, May 16, 2015 at 01:32:09PM +0100, Srinivas Kandagatla wrote: lpass driver only support DT so make this explicit in the kconfig. This doesn't apply against current code, please check and resend. signature.asc Description: Digital signature

[PATCH v3 01/10] ASoC: qcom: make lpass driver depend on OF

2015-05-21 Thread Srinivas Kandagatla
lpass driver only support DT so make this explicit in the kconfig. Tested-by: Kenneth Westfield kwest...@codeaurora.org Acked-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- sound/soc/qcom/Kconfig | 2 ++ 1 file changed, 2

[PATCH v3 00/10] ASoC: qcom: add support to apq8016 audio

2015-05-21 Thread Srinivas Kandagatla
Hi Mark, Am resending the the patches with rebased on top of topic/qcom branch. All these patches are tested and Acked. Thankyou for reviewing the v2 patches, here is the v3 patchset after incorporating review comments and testing on Storm Board. This patchset adds apq8016 audio support into

[PATCH v3 02/10] ASoC: qcom: support bitclk and osrclk per i2s port

2015-05-21 Thread Srinivas Kandagatla
This patch adds support to allow bitclk and osrclk per i2s dai port. on APQ8016 there are 4 i2s ports each one has its own bit clks. Without this patch its not possible to support multiple i2s ports in the lpass driver. Tested-by: Kenneth Westfield kwest...@codeaurora.org Acked-by: Kenneth

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-21 Thread Ankit Gupta
On 05/20, Ankit Gupta wrote: On Tue, 19 May 2015 17:36:41 -0700 Stephen Boyd sb...@codeaurora.org wrote: On 05/18/15 14:51, Ankit Gupta wrote: + +TRACE_EVENT(spmi_read_end, +TP_PROTO(u8 opcode, u8 sid, u16 addr, int ret, u8 len, Should len be size_t instead of u8? It

Re: [PATCH] ASoC: qcom: remove incorrect dependencies

2015-05-21 Thread Kenneth Westfield
On Thu, May 21, 2015 at 11:07:08AM +0200, Arnd Bergmann wrote: Compile-tests show a warning for the newly added SND_SOC_STORM symbol: warning: (SND_SOC_STORM) selects SND_SOC_LPASS_CPU which has unmet direct dependencies (SOUND !M68K !UML SND SND_SOC SND_SOC_QCOM) The problem is

Re: [PATCH] ASoC: qcom: remove incorrect dependencies

2015-05-21 Thread Arnd Bergmann
On Thursday 21 May 2015 14:00:00 Kenneth Westfield wrote: diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index 5f58e4f1bca9..b07f183fc47f 100644 --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -6,12 +6,10 @@ config SND_SOC_QCOM config SND_SOC_LPASS_CPU

Re: [PATCH v2 04/13] ASoC: qcom: remove hardcoded dma channel

2015-05-21 Thread Mark Brown
On Sat, May 16, 2015 at 01:32:34PM +0100, Srinivas Kandagatla wrote: This patch removes hardcoded dma channel value in lpass driver, Now the dma channel allocation happens in the SOC specific layer. This will allow different LPASS integrations to use the lpass driver in more generic way.

Re: [PATCH v2 02/13] ASoC: qcom: move ipq806x specific bits out of lpass driver.

2015-05-21 Thread Mark Brown
On Sat, May 16, 2015 at 01:32:17PM +0100, Srinivas Kandagatla wrote: This patch tries to make the lpass driver more generic by moving the ipq806x specific bits out of the cpu and platform driver, also allows the SOC specific drivers to add the correct register offsets. Applied, thanks.

[PATCH v3 10/10] ASoC: qcom: document apq8016 sbc machine driver bindings

2015-05-21 Thread Srinivas Kandagatla
This patch adds bindings for apq8016 sbc machine driver. On APQ8016 4 MI2S can be configured to different sinks like internal codec/external codec, this connection is controlled via 2 iomux registers. Tested-by: Kenneth Westfield kwest...@codeaurora.org Acked-by: Kenneth Westfield

[PATCH v3 08/10] ASoC: qcom: add apq8016 sound card support

2015-05-21 Thread Srinivas Kandagatla
This patch adds apq8016 machine driver support. This patch was tested on two apq8016-sbc and msm8916-mtp board for both hdmi and analog audio features. Tested-by: Kenneth Westfield kwest...@codeaurora.org Acked-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla

[PATCH v3 09/10] ASoC: qcom: Document apq8016 bindings.

2015-05-21 Thread Srinivas Kandagatla
This patch updates lpass bindings with apq8016 specific bindings. Tested-by: Kenneth Westfield kwest...@codeaurora.org Acked-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org ---

Re: [PATCH] ASoC: qcom: remove incorrect dependencies

2015-05-21 Thread Mark Brown
On Thu, May 21, 2015 at 11:07:08AM +0200, Arnd Bergmann wrote: Compile-tests show a warning for the newly added SND_SOC_STORM symbol: Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

2015-05-21 Thread ygardi
On Wed, 2015-05-20 at 10:22 +0200, Paul Bolle wrote: By the way, as far as I can see, this (new) module can only be loaded manually (or via scripts). Is that what people want? This comment wasn't well thought through. So I hand another look at the code of usf-qcom. I noticed that the

Re: [PATCH] coresight-etm3x: Add Qualcomm PFT v1.1 peripheral ID

2015-05-21 Thread Ivan T. Ivanov
On Thu, 2015-05-21 at 08:10 -0600, Mathieu Poirier wrote: On 20 May 2015 at 09:02, Ivan T. Ivanov iva...@linaro.org wrote: Add Qualcomm's PFT v1.1 peripheral ID to supported devices. This device could be found at least in MSM8974 and APQ8064 chipsets. Signed-off-by: Ivan T. Ivanov

Re: [PATCH] coresight-etm3x: Add Qualcomm PFT v1.1 peripheral ID

2015-05-21 Thread Mathieu Poirier
On 20 May 2015 at 09:02, Ivan T. Ivanov ivan.iva...@linaro.org wrote: Add Qualcomm's PFT v1.1 peripheral ID to supported devices. This device could be found at least in MSM8974 and APQ8064 chipsets. Signed-off-by: Ivan T. Ivanov ivan.iva...@linaro.org ---

[PATCH v3 06/10] ASoC: qcom: add bit map to track static dma channel allocations

2015-05-21 Thread Srinivas Kandagatla
This patch adds dma channel bit mask to lpass data to keep track of dma channel allocations. This flag would be used in apq8016 lpass driver. Tested-by: Kenneth Westfield kwest...@codeaurora.org Acked-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla

[PATCH v3 05/10] ASoC: qcom: Add ability to handle interrupts per dma channel

2015-05-21 Thread Srinivas Kandagatla
This patch adds ablity to lpass driver to handle interrupt per dma channel. Without this patch its not possible to use multipl ports on the lpass. Tested-by: Kenneth Westfield kwest...@codeaurora.org Acked-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-21 Thread Ankit Gupta
On 05/18/15 14:51, Ankit Gupta wrote: Add tracepoints to retrieve information about read, write and non-data commands. For performance measurement support tracepoints are added at the beginning and at the end of transfers. Following is a list showing the new tracepoint events. The cmd

[PATCH v3 04/10] ASoC: qcom: add dma channel control offset to variant data

2015-05-21 Thread Srinivas Kandagatla
This patch adds ability to pass dma channel control bits start offset, which differ in differnet qcom SOCs. On apq8016 dma channel control bits start after an offset of 1. Tested-by: Kenneth Westfield kwest...@codeaurora.org Acked-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by:

[PATCH v3 03/10] ASoC: qcom: make osr clock optional

2015-05-21 Thread Srinivas Kandagatla
Some LPASS integrations like on APQ8016 do not have OSR clk, so making osr clk optional would allow such integrations to use lpass driver. Tested-by: Kenneth Westfield kwest...@codeaurora.org Acked-by: Kenneth Westfield kwest...@codeaurora.org Signed-off-by: Srinivas Kandagatla

[PATCH v3 07/10] ASoC: qcom: Add apq8016 lpass driver support

2015-05-21 Thread Srinivas Kandagatla
This patch adds apq8016 lpass driver support. APQ8016 has 4 MI2S which can be routed to one internal codec and 2 external codec interfaces. Primary, Secondary, Quaternary I2S can do Rx(playback) and Tertiary and Quaternary can do Tx(capture). Tested-by: Kenneth Westfield kwest...@codeaurora.org

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-21 Thread Stephen Boyd
On 05/20/15 11:58, Steven Rostedt wrote: On Wed, 20 May 2015 11:29:55 -0700 Stephen Boyd sb...@codeaurora.org wrote: I see no reason to spend to 4-8 bytes when spmi spec allows for maximum buffer size of 16. Do you suggest changing the API of read_cmd()? Is that a maximum buffer size of 16

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-21 Thread Stephen Boyd
On 05/18/15 14:51, Ankit Gupta wrote: Add tracepoints to retrieve information about read, write and non-data commands. For performance measurement support tracepoints are added at the beginning and at the end of transfers. Following is a list showing the new tracepoint events. The cmd

[PATCH v5 04/11] nvmem: Add a simple NVMEM framework for consumers

2015-05-21 Thread Srinivas Kandagatla
This patch adds just consumers part of the framework just to enable easy review. Up until now, nvmem drivers were stored in drivers/misc, where they all had to duplicate pretty much the same code to register a sysfs file, allow in-kernel users to access the content of the devices they were

[PATCH v5 01/11] regmap: Introduce regmap_get_max_register.

2015-05-21 Thread Srinivas Kandagatla
This patch introduces regmap_get_max_register() function which would be used by the infrastructures like nvmem framework built on top of regmap. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- drivers/base/regmap/regmap.c | 12 include/linux/regmap.h | 7

[PATCH v5 02/11] regmap: Introduce regmap_get_reg_stride.

2015-05-21 Thread Srinivas Kandagatla
This patch introduces regmap_get_reg_stride() function which would be used by the infrastructures like nvmem framework built on top of regmap. Mostly this function would be used for sanity checks on inputs within such infrastructure. Signed-off-by: Srinivas Kandagatla

Re: [PATCH v2 00/13] ASoC: qcom: add support to apq8016 audio

2015-05-21 Thread Mark Brown
On Sat, May 16, 2015 at 01:31:02PM +0100, Srinivas Kandagatla wrote: Thankyou for reviewing the v1 patches, here is the v2 patchset after incorporating review comments and testing on Storm Board. Please don't send new serieses in reply to old ones, it makes them harder to notice.

[PATCH v5 00/11] Add simple NVMEM Framework via regmap.

2015-05-21 Thread Srinivas Kandagatla
Thankyou all for providing inputs and comments on previous versions of this patchset. Here is the v5 of the patchset addressing all the issues raised as part of previous versions review. This patchset adds a new simple NVMEM framework to kernel. Up until now, NVMEM drivers were stored in

[PATCH v5 03/11] nvmem: Add a simple NVMEM framework for nvmem providers

2015-05-21 Thread Srinivas Kandagatla
This patch adds just providers part of the framework just to enable easy review. Up until now, NVMEM drivers like eeprom were stored in drivers/misc, where they all had to duplicate pretty much the same code to register a sysfs file, allow in-kernel users to access the content of the devices they

[PATCH v5 10/11] nvmem: sunxi: Move the SID driver to the nvmem framework

2015-05-21 Thread Srinivas Kandagatla
From: Maxime Ripard maxime.rip...@free-electrons.com Now that we have the nvmem framework, we can consolidate the common driver code. Move the driver to the framework, and hopefully, it will fix the sysfs file creation race. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com

[PATCH v5 06/11] nvmem: Add bindings for simple nvmem framework

2015-05-21 Thread Srinivas Kandagatla
This patch adds bindings for simple nvmem framework which allows nvmem consumers to talk to nvmem providers to get access to nvmem cell data. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com [Maxime Ripard: intial version of eeprom framework] Signed-off-by: Srinivas Kandagatla

[PATCH v5 09/11] nvmem: qfprom: Add bindings for qfprom

2015-05-21 Thread Srinivas Kandagatla
This patch adds bindings for qfprom found in QCOM SOCs. QFPROM driver is based on simple nvmem framework. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- Documentation/devicetree/bindings/nvmem/qfprom.txt | 35 ++ 1 file changed, 35 insertions(+) create

[PATCH v5 07/11] nvmem: Add simple nvmem-mmio consumer helper functions.

2015-05-21 Thread Srinivas Kandagatla
This patch adds probe and remove helper functions for nvmems which are mmio based, With these helper function new nvmem consumer drivers need very little code add its driver. This code is currently used for qfprom and sunxi-sid nvmem consumer drivers. Signed-off-by: Srinivas Kandagatla

[PATCH v5 11/11] nvmem: Add to MAINTAINERS for nvmem framework

2015-05-21 Thread Srinivas Kandagatla
This patch adds MAINTAINERS to nvmem framework. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b2ef613..26e1829 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6993,6

[PATCH v5 08/11] nvmem: qfprom: Add Qualcomm QFPROM support.

2015-05-21 Thread Srinivas Kandagatla
This patch adds QFPROM support driver which is used by other drivers like thermal sensor and cpufreq. On MSM parts there are some efuses (called qfprom) these fuses store things like calibration data, speed bins.. etc. Drivers like cpufreq, thermal sensors would read out this data for configuring

Re: [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

2015-05-21 Thread ygardi
On Thu, 2015-05-21 at 10:09 +, yga...@codeaurora.org wrote: On Wed, 2015-05-20 at 10:22 +0200, Paul Bolle wrote: Am I missing something obvious here? Because ufs-qcom currently looks pointless to me, and I actually see little reason to even have it in the mainline tree. we