Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-07 Thread Nicolas Pitre
On Thu, 7 Oct 2010, Daniel Walker wrote: > On Thu, 2010-10-07 at 14:27 -0700, Tony Lindgren wrote: > > > Can you please pass the read and write functions to the driver > > in platform_data? We are already booting kernels with both > > ARMv6 and 7 compiled in. > > What kind of situation did you w

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-07 Thread Nicolas Pitre
On Thu, 7 Oct 2010, Tony Lindgren wrote: > Hi, > > * Daniel Walker [101005 11:59]: > > +#if !defined(CONFIG_CPU_V7) > > +static inline char > > +__dcc_getchar(void) > > +{ > > + char __c; > > + > > + asm("mrc p14, 0, %0, c0, c5, 0 @ read comms data reg" > > + : "=r" (__c) : : "cc"

Re: [PATCH 1/3] [ARM] Translate delay.S into (mostly) C

2010-10-07 Thread Nicolas Pitre
On Thu, 7 Oct 2010, Stephen Boyd wrote: > Why doesn't any other architecture use assembly for their lpj code? They > may use headers with assembly in them or C code with assembly in them, > but they don't write all of the delay code in assembly and rely on > function interleaving. This leads me to

Re: [PATCH 1/3] [ARM] Translate delay.S into (mostly) C

2010-10-07 Thread Stephen Boyd
On 10/06/2010 01:05 PM, Nicolas Pitre wrote: > You could use the noinline qualifier from with those > functions you don't want inlined. > That won't help me for the interleaving behavior though. >> Is it possible to do all this in assembly ? Can't you have the default >> implementation using t

Re: [RFC/PATCH v3] usb: usb3.0 ch9 definitions

2010-10-07 Thread Daniel Walker
On Thu, 2010-10-07 at 20:34 +0200, Brokhman Tatyana wrote: > Adding SuperSpeed usb definitions as defined by ch9 of the USB3.0 spec. > This patch is a preparation for adding SuperSpeed support to the gadget > framework. > > Signed-off-by: Brokhman Tatyana Shouldn't your name be reversed? First L

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-07 Thread Daniel Walker
On Thu, 2010-10-07 at 14:27 -0700, Tony Lindgren wrote: > Can you please pass the read and write functions to the driver > in platform_data? We are already booting kernels with both > ARMv6 and 7 compiled in. What kind of situation did you want to use it in ? I was thinking about how arm could ha

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-07 Thread Tony Lindgren
Hi, * Daniel Walker [101005 11:59]: > +#if !defined(CONFIG_CPU_V7) > +static inline char > +__dcc_getchar(void) > +{ > + char __c; > + > + asm("mrc p14, 0, %0, c0, c5, 0 @ read comms data reg" > + : "=r" (__c) : : "cc"); > + > + return __c; > +} > +#else > +static inline

Re: [RFC/PATCH v3] usb: usb3.0 ch9 definitions

2010-10-07 Thread Greg KH
On Thu, Oct 07, 2010 at 08:34:28PM +0200, Brokhman Tatyana wrote: > Adding SuperSpeed usb definitions as defined by ch9 of the USB3.0 spec. > This patch is a preparation for adding SuperSpeed support to the gadget > framework. > > Signed-off-by: Brokhman Tatyana Is this still a [RFC] or is it so

[RFC/PATCH v3] usb: usb3.0 ch9 definitions

2010-10-07 Thread Brokhman Tatyana
Adding SuperSpeed usb definitions as defined by ch9 of the USB3.0 spec. This patch is a preparation for adding SuperSpeed support to the gadget framework. Signed-off-by: Brokhman Tatyana --- include/linux/usb/ch9.h | 58 ++- 1 files changed, 57 inser

Re: [RFC/PATCH v2 3/3] usb:gadget: Add SuperSpeed support to the Gadget Framework

2010-10-07 Thread Greg KH
On Thu, Oct 07, 2010 at 05:24:57PM +0200, tlinder wrote: > --- a/drivers/usb/gadget/Kconfig > +++ b/drivers/usb/gadget/Kconfig > @@ -520,11 +520,11 @@ config USB_GADGET_DUMMY_HCD > side is the master; the gadget side is the slave. Gadget drivers > can be high, full, or low speed; a

Re: [RFC/PATCH v2 2/3] usb: usb3.0 ch9 definitions

2010-10-07 Thread Greg KH
On Thu, Oct 07, 2010 at 05:24:36PM +0200, tlinder wrote: > Signed-off-by: tlinder I need a "real" name here please. > --- > include/linux/usb/ch9.h | 59 +- > 1 files changed, 57 insertions(+), 2 deletions(-) > > diff --git a/include/linux/usb/ch9.

Re: [RFC/PATCH v2 3/3] usb:gadget: Add SuperSpeed support to the Gadget Framework

2010-10-07 Thread Greg KH
On Thu, Oct 07, 2010 at 05:24:57PM +0200, tlinder wrote: > +/** Default endpoint companion descriptor */ What's the '**' for? > +static struct usb_ss_ep_comp_descriptor default_ep_comp_desc = { > + .bDescriptorType = USB_DT_SS_ENDPOINT_COMP, > + .bLength = 0x06, > +

[RFC/PATCH v2 3/3] usb:gadget: Add SuperSpeed support to the Gadget Framework

2010-10-07 Thread tlinder
This patch adds the SuperSpeed functionality to the gadget framework. In order not to force all the gadget drivers to supply SuperSpeed descriptors when operating in SuperSpeed mode the following approach was taken: If we're operating in SuperSpeed mode and the gadget driver didn't supply SuperSpee

[RFC/PATCH v2 2/3] usb: usb3.0 ch9 definitions

2010-10-07 Thread tlinder
Signed-off-by: tlinder --- include/linux/usb/ch9.h | 59 +- 1 files changed, 57 insertions(+), 2 deletions(-) diff --git a/include/linux/usb/ch9.h b/include/linux/usb/ch9.h index da2ed77..20573b2 100644 --- a/include/linux/usb/ch9.h +++ b/include/lin