Re: [PATCH] msm: smd: Add smd_pkt driver

2011-01-26 Thread Daniel Walker
On Wed, 2011-01-26 at 15:32 -0800, Andrew Morton wrote: > On Tue, 25 Jan 2011 11:20:51 -0800 > David Brown wrote: > > > On Wed, Dec 15 2010, Niranjana Vishwanathapura wrote: > > > > > Add smd_pkt driver which provides device interface > > > to smd packet ports. > > > > > > Signed-off-by: Niranja

[PATCHv2 2/5] msm: clock: Remove 7x30 and pcom includes from clock.h

2011-01-26 Thread Stephen Boyd
clock.h includes clock-pcom.h and clock-7x30.h when it really doesn't need to. Remove the includes and fixup breakages. Reviewed-By: Saravana Kannan Signed-off-by: Stephen Boyd --- arch/arm/mach-msm/clock-pcom.c |1 + arch/arm/mach-msm/clock.c |1 + arch/arm/mach-msm/cloc

[PATCHv2 5/5] msm: clock: Add support for more proc_comm clocks

2011-01-26 Thread Stephen Boyd
Add support for the ce, codec_ssbi, uart clocks, and i2c clocks. Reviewed-by: Saravana Kannan Signed-off-by: Stephen Boyd --- arch/arm/mach-msm/clock-pcom.h |4 +++- arch/arm/mach-msm/devices-msm7x30.c |2 ++ arch/arm/mach-msm/devices-qsd8x50.c |6 ++ 3 files changed, 11 in

[PATCHv2 3/5] msm: clock: Move debugfs code from clock.c to clock-debug.c

2011-01-26 Thread Stephen Boyd
From: Matt Wagantall The clock debugfs code is large enough, and easy enough to separate, that it deserves its own file which is compiled only when CONFIG_DEBUG_FS is enabled. Also, cleanup header file #includes that are no longer required. Reviewed-by: Saravana Kannan Signed-off-by: Matt Waga

[PATCHv2 4/5] msm: clock: Invert debugfs directory layout

2011-01-26 Thread Stephen Boyd
There are currently 3 separate directories for clock debugging in debugfs: clk_enable, clk_rate, and clk_local. Each of these directories contains a list of clocks. This is rather annoying when you are focusing on one clock and want to enable/disable it and then check its rate. You either have to c

[PATCHv2 1/5] msm: clock: Remove unused code and definitions

2011-01-26 Thread Stephen Boyd
This code is dead or otherwise useless so just remove it. Reviewed-by: Saravana Kannan Signed-off-by: Stephen Boyd --- arch/arm/mach-msm/board-msm8x60.c |4 --- arch/arm/mach-msm/clock.c | 20 +--- arch/arm/mach-msm/clock.h | 42 --

[PATCHv2 0/5] MSM: clock debugfs and cleanups

2011-01-26 Thread Stephen Boyd
These patches were previously posted as part of a larger series. I've refreshed these against the latest msm for-next branch. They cleanup debugfs and the clock code and add support for some proc_comm clocks. Changes since v2: * Fix build breakage on 7x00 * Split patch 1 in half Matt Wagantall

Re: [PATCH] msm: smd: Add smd_pkt driver

2011-01-26 Thread David Brown
On Wed, Jan 26 2011, Andrew Morton wrote: > On Tue, 25 Jan 2011 11:20:51 -0800 > David Brown wrote: > >> On Wed, Dec 15 2010, Niranjana Vishwanathapura wrote: >> >> > Add smd_pkt driver which provides device interface >> > to smd packet ports. > > Looks OK, I grabbed it. > > I read the entire em

[PATCH 2/2] msm: Warning fix in trout gpio board file

2011-01-26 Thread David Brown
arch/arm/mach-msm/board-trout-gpio.c: In function 'trout_gpio_to_irq': arch/arm/mach-msm/board-trout-gpio.c:77: error: unused variable 'msm_gpio' Change-Id: I21177f74f156b3fe56dd39dcd524998229e27ff9 Signed-off-by: David Brown --- arch/arm/mach-msm/board-trout-gpio.c |2 -- 1 files changed, 0

[PATCH 1/2] msm: Remove broken register definition from trout

2011-01-26 Thread David Brown
Missed a register change with the clock cleanup on the MSM7x01 targets. Change-Id: Ic42234b67f6c15760d74f9efca2932cc739931e4 Signed-off-by: David Brown --- arch/arm/mach-msm/io.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-msm/io.c b/arch/arm/mach-msm/i

Re: [PATCH] msm: smd: Add smd_pkt driver

2011-01-26 Thread Andrew Morton
On Tue, 25 Jan 2011 11:20:51 -0800 David Brown wrote: > On Wed, Dec 15 2010, Niranjana Vishwanathapura wrote: > > > Add smd_pkt driver which provides device interface > > to smd packet ports. > > > > Signed-off-by: Niranjana Vishwanathapura > > --- > > drivers/char/Kconfig |8 + > >

[PATCH] ARM: Fix SMP_ON_UP for non ARM ltd. implementations

2011-01-26 Thread Stephen Boyd
The SMP_ON_UP checks restrict the feature to ARM limited designs, when other implementers support SMP designs. Instead of checking for an ARM CPU and ARMv6/v7 just check for a v6 or v7 and then rely on the MPIDR for non ARM 11MPCore designs. Signed-off-by: Stephen Boyd --- arch/arm/kernel/head.S

Re: [PATCH v2 02/11] msm: Generalize timer register mappings

2011-01-26 Thread Dima Zavin
On Wed, Jan 26, 2011 at 2:41 PM, David Brown wrote: > On Wed, Jan 26 2011, Dima Zavin wrote: > >> On Mon, Jan 24, 2011 at 2:44 PM, David Brown wrote: > >> To be honest I don't understand why you would want to do this at >> runtime. You cannot select multiple SoCs in the kernel build anyway, >> no

Re: [PATCH 1/4] msm: clock: Remove unused code and definitions

2011-01-26 Thread Stephen Boyd
On 01/26/2011 02:03 PM, Daniel Walker wrote: > > He's adding stuff too .. So it's not _just_ removal which is what I was > getting at. I'll split this, no worries. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora F

Re: [PATCH v2 02/11] msm: Generalize timer register mappings

2011-01-26 Thread Russell King - ARM Linux
On Wed, Jan 26, 2011 at 02:12:59PM -0800, Dima Zavin wrote: > To be honest I don't understand why you would want to do this at > runtime. You cannot select multiple SoCs in the kernel build anyway, > nor would you want to. Trying to have same kernel to boot on ARM v6 > and ARM v7 would already be f

Re: [PATCH v2 02/11] msm: Generalize timer register mappings

2011-01-26 Thread David Brown
On Wed, Jan 26 2011, Dima Zavin wrote: > On Mon, Jan 24, 2011 at 2:44 PM, David Brown wrote: > To be honest I don't understand why you would want to do this at > runtime. You cannot select multiple SoCs in the kernel build anyway, > nor would you want to. Trying to have same kernel to boot on AR

Re: [PATCH v2 02/11] msm: Generalize timer register mappings

2011-01-26 Thread Dima Zavin
On Mon, Jan 24, 2011 at 2:44 PM, David Brown wrote: > On Mon, Jan 24 2011, Daniel Walker wrote: > >> On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: >>> +       int global_offset = 0; >>> + >>> +       if (cpu_is_msm7x01()) { >>> +               msm_clocks[MSM_CLOCK_GPT].regbase = MSM_CSR_BA

Re: [PATCH 4/4] msm: clock: Add support for more proc_comm clocks

2011-01-26 Thread Daniel Walker
On Wed, 2011-01-26 at 14:03 -0800, David Brown wrote: > On Tue, Jan 25 2011, Daniel Walker wrote: > > > On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote: > >> Support the CE_CLK and CODEC_SSBI_CLK. Also add support for uart, > >> and i2c clocks on targets which support proc_comm clocks. > > >

Re: [PATCH 1/4] msm: clock: Remove unused code and definitions

2011-01-26 Thread Daniel Walker
On Wed, 2011-01-26 at 14:01 -0800, David Brown wrote: > On Tue, Jan 25 2011, Daniel Walker wrote: > > > On Tue, 2011-01-25 at 13:52 -0800, Saravana Kannan wrote: > >> On 01/25/2011 01:38 PM, Daniel Walker wrote: > >> > On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote: > >> >> Remove dead code

Re: [PATCH 4/4] msm: clock: Add support for more proc_comm clocks

2011-01-26 Thread David Brown
On Tue, Jan 25 2011, Daniel Walker wrote: > On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote: >> Support the CE_CLK and CODEC_SSBI_CLK. Also add support for uart, >> and i2c clocks on targets which support proc_comm clocks. > > Basically when you catch yourself writing "also" in the commit te

Re: [PATCH 1/4] msm: clock: Remove unused code and definitions

2011-01-26 Thread David Brown
On Tue, Jan 25 2011, Daniel Walker wrote: > On Tue, 2011-01-25 at 13:52 -0800, Saravana Kannan wrote: >> On 01/25/2011 01:38 PM, Daniel Walker wrote: >> > On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote: >> >> Remove dead code and push out clock-7x30.h and clock-pcom.h to >> >> where they ar

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

2011-01-26 Thread David Brown
On Wed, Jan 26 2011, Tejun Heo wrote: > On Tue, Jan 25, 2011 at 03:21:31PM -0800, David Brown wrote: > I suppose it will show up in linux-next? I'm planning on marking > flush_scheduled_work() deprecated there soonish, so... Hmm, it should be there. Well, it will at least be there when the nex

Re: [QUERY] Download calibration data to co-processor

2011-01-26 Thread Mark Brown
On Tue, Jan 25, 2011 at 11:58:54PM -0800, Patrick Lai wrote: > On 1/25/2011 5:36 AM, Mark Brown wrote: > >What we're doing for this currently is passing the configuration data in > >platform data or via request_firmware() (mostly using the latter for > >larger data). At the minute we're loading

Re: [PATCH 20/32] video/msm_fb: use system_wq instead of dedicated workqueues

2011-01-26 Thread Tejun Heo
On Tue, Jan 25, 2011 at 03:21:31PM -0800, David Brown wrote: > On Mon, Jan 03 2011, Tejun Heo wrote: > > > With cmwq, there's no reason to use separate workqueues. Drop > > msmfb_info->resume_workqueue and use system_wq instead. > > > > Signed-off-by: Tejun Heo > > Cc: Stanislaw Gruszka > > Cc: