Re: [Patch v7 2/2] dmaengine: add Qualcomm BAM dma driver

2014-02-26 Thread Andy Gross
On Wed, Feb 26, 2014 at 06:51:55PM +0200, Stanimir Varbanov wrote: + /* read revision and configuration information */ + val = readl_relaxed(bdev-regs + BAM_REVISION) NUM_EES_MASK; + The ees shit is not zero and you got wrong ee. Could you add the line below or something similar:

Re: [PATCH 2/4] arm: qcom: Split Qualcomm support into legacy and multiplatform

2014-02-26 Thread Kumar Gala
On Feb 26, 2014, at 8:22 AM, Kevin Hilman khil...@linaro.org wrote: Kumar Gala ga...@codeaurora.org writes: Introduce a new mach-qcom that will support SoCs that intend to be multiplatform compatiable while keeping mach-msm to legacy SoC/board support that will not transition over to

[PATCH v4 0/8] Modernize pm8921 with irqdomains, regmap, DT

2014-02-26 Thread Stephen Boyd
These patches lay the groundwork for converting the pm8921 sub-devices to devicetree as well as simplify the API by migrating the core code to use the regmap API instead of the custom pm8xxx read/write wrapper. Changes since v3: * Added irqdomain Kconfig select * New patch to loosen Kconfig on

[PATCH v4 8/8] devicetree: bindings: Document PM8921/8058 PMICs

2014-02-26 Thread Stephen Boyd
PM8921 and PM8058 are PMICs found paired with MSM8960 and MSM8660 devices respectively. They contain subdevices such as keypads, RTC, regulators, clocks, etc. Cc: devicet...@vger.kernel.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- .../devicetree/bindings/mfd/qcom,pm8xxx.txt|

[PATCH v4 6/8] mfd: pm8921: Add DT match table

2014-02-26 Thread Stephen Boyd
Allow this driver to probe based on devicetree. Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/mfd/pm8921-core.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c index

[PATCH v4 4/8] mfd: ssbi: Add regmap read/write helpers

2014-02-26 Thread Stephen Boyd
Add read and write helper functions that the pm8921-core driver can use to read and write ssbi registers via a no-bus regmap. Cc: Mark Brown broo...@kernel.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- include/linux/ssbi.h | 20 1 file changed, 20 insertions(+)

[PATCH v4 1/8] mfd: Move pm8xxx-irq.c contents into only driver that uses it

2014-02-26 Thread Stephen Boyd
The pm8xxx-irq.c code is practically mandatory given that the pm8921-core driver will WARN about it missing and the Kconfig marks it as default y when a PM8xxx chips is enabled. The only reason the file was split out was because we planned to support other pm8xxx chips with different pm8xxx-core.c

[PATCH v4 2/8] mfd: pm8921: Update for genirq changes

2014-02-26 Thread Stephen Boyd
Since this code has been marked broken for some time a few genirq tree wide changes weren't made. set_irq_wake() was renamed to irq_set_irq_wake() in commit a0cd9ca2b (genirq: Namespace cleanup, 2011-02-10) and commit 10a8c383 (irq: introduce entry and exit functions for chained handlers)

[PATCH v4 3/8] mfd: pm8921: Migrate to irqdomains

2014-02-26 Thread Stephen Boyd
Convert this driver to use irqdomains so that the PMIC's child devices can be converted to devicetree. Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/mfd/Kconfig | 1 + drivers/mfd/pm8921-core.c | 198

[PATCH v4 7/8] mfd: pm8921: Loosen Kconfig dependency

2014-02-26 Thread Stephen Boyd
Allow this driver to be compiled on all ARM builds as it doesn't rely on anything within arm/mach-msm. Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index

[PATCH v3 0/9] Use regmap+devm+DT in pm8xxx input drivers

2014-02-26 Thread Stephen Boyd
These patches move the pm8xxx input drivers over to use devm_* APIs and regmap. This breaks the dependency of these drivers on the pm8xxx specific read/write calls and also simplifies the probe code a bit. Finally we add devicetree support to these drivers so they can be probed on the platforms

[PATCH v4 5/8] mfd: pm8921: Use ssbi regmap

2014-02-26 Thread Stephen Boyd
Use a regmap so that the pm8xxx read/write APIs can be removed once all consumer drivers are converted. Reviewed-by: Mark Brown broo...@linaro.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/mfd/Kconfig | 1 + drivers/mfd/pm8921-core.c | 66

[PATCH v3 2/9] Input: pmic8xxx-keypad - Migrate to devm_* APIs

2014-02-26 Thread Stephen Boyd
Simplify the error paths and reduce the lines of code in this driver by using the devm_* APIs. Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/input/keyboard/pmic8xxx-keypad.c | 62 +--- 1 file changed, 17 insertions(+), 45 deletions(-) diff --git

[PATCH v3 5/9] Input: pm8xxx-vibrator - Add DT match table

2014-02-26 Thread Stephen Boyd
The driver is only supported on DT enabled platforms. Convert the driver to DT so that it can probe properly. Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/input/misc/pm8xxx-vibrator.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/input/misc/pm8xxx-vibrator.c

[PATCH v3 3/9] Input: pmic8xxx-keypad - Migrate to regmap APIs

2014-02-26 Thread Stephen Boyd
Use the regmap APIs for this driver instead of custom pm8xxx APIs. This breaks this driver's dependency on the pm8xxx APIs and allows us to easily port it to other bus protocols in the future. Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/input/keyboard/pmic8xxx-keypad.c | 81

[PATCH v3 7/9] devicetree: bindings: Document PM8921/8058 keypads

2014-02-26 Thread Stephen Boyd
Document the keypad device found on PM8921 and PM8058 PMICs. Cc: devicet...@vger.kernel.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- .../bindings/input/qcom,pm8xxx-keypad.txt | 72 ++ 1 file changed, 72 insertions(+) create mode 100644

[PATCH v3 6/9] Input: pmic8xxx-keypad - Migrate to DT

2014-02-26 Thread Stephen Boyd
The driver is only supported on DT enabled platforms. Convert the driver to DT so that it can probe properly. Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/input/keyboard/pmic8xxx-keypad.c | 148 ++- include/linux/input/pmic8xxx-keypad.h| 52

[PATCH v3 8/9] devicetree: bindings: Document PM8921/8058 power keys

2014-02-26 Thread Stephen Boyd
Document the power key found on PM8921 and PM8058 PMICs. Cc: devicet...@vger.kernel.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- .../bindings/input/qcom,pm8xxx-pwrkey.txt | 39 ++ 1 file changed, 39 insertions(+) create mode 100644

[PATCH v3 9/9] devicetree: bindings: Document PM8921/8058 vibrators

2014-02-26 Thread Stephen Boyd
Document the vibration device found on PM8921 and PM8058 PMICs. Cc: devicet...@vger.kernel.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- .../devicetree/bindings/input/qcom,pm8xxx-vib.txt| 16 1 file changed, 16 insertions(+) create mode 100644

[PATCH] devicetree: bindings: Make msm8974-pinctrl documentation match code

2014-02-26 Thread Stephen Boyd
The compatible string doesn't have an x in it. Fix it. Also remove the qcom prefix from pins and functions as this binding uses the generic pinctrl bindings for the pins and functions. Cc: Bjorn Andersson bjorn.anders...@sonymobile.com Signed-off-by: Stephen Boyd sb...@codeaurora.org ---

[PATCH v3 1/9] Input: pmic8xxx-pwrkey - Migrate to regmap APIs

2014-02-26 Thread Stephen Boyd
Use the regmap APIs for this driver instead of custom pm8xxx APIs. This breaks this driver's dependency on the pm8xxx APIs and allows us to easily port it to other bus protocols in the future. Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/input/misc/pmic8xxx-pwrkey.c | 4 1

[PATCH v3 4/9] Input: pmic8xxx-pwrkey - Migrate to DT

2014-02-26 Thread Stephen Boyd
The driver is only supported on DT enabled platforms. Convert the driver to DT so that it can probe properly. Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/input/misc/pmic8xxx-pwrkey.c | 33 - include/linux/input/pmic8xxx-pwrkey.h | 31

Re: [PATCH 1/3] cpufreq: stats: Remove redundant cpufreq_cpu_get() call

2014-02-26 Thread Saravana Kannan
On 02/25/2014 09:06 PM, Viresh Kumar wrote: On 26 February 2014 09:08, Saravana Kannan skan...@codeaurora.org wrote: __cpufreq_stats_create_table always gets pass the valid and real policy struct. So, there's no need to call cpufreq_cpu_get() to get the policy again. Change-Id:

[PATCH 1/3] cpufreq: stats: Remove redundant cpufreq_cpu_get() call

2014-02-26 Thread Saravana Kannan
__cpufreq_stats_create_table always gets pass the valid and real policy struct. So, there's no need to call cpufreq_cpu_get() to get the policy again. Acked-by: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Saravana Kannan skan...@codeaurora.org --- drivers/cpufreq/cpufreq_stats.c | 12

[PATCH 2/3] cpufreq: stats: Fix error handling in __cpufreq_stats_create_table()

2014-02-26 Thread Saravana Kannan
Remove sysfs group if __cpufreq_stats_create_table() fails after creating one. Acked-by: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Saravana Kannan skan...@codeaurora.org --- drivers/cpufreq/cpufreq_stats.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 3/3] cpufreq: stats: Refactor common code into __cpufreq_stats_create_table()

2014-02-26 Thread Saravana Kannan
cpufreq_frequency_get_table() is called from all callers of __cpufreq_stats_create_table(). So, move it inside. Suggested-by: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Saravana Kannan skan...@codeaurora.org --- drivers/cpufreq/cpufreq_stats.c | 22 +- 1 file

Re: [PATCH] cpufreq: Set policy to non-NULL only after all hotplug online work is done

2014-02-26 Thread Saravana Kannan
On 02/25/2014 10:02 PM, Viresh Kumar wrote: On 26 February 2014 07:18, Saravana Kannan skan...@codeaurora.org wrote: On 02/25/2014 02:41 PM, Rafael J. Wysocki wrote: And is fully initialized actually well defined? The point in add dev/hot plug path after which we will no longer change

Re: [PATCH 2/4] arm: qcom: Split Qualcomm support into legacy and multiplatform

2014-02-26 Thread Kevin Hilman
Kumar Gala ga...@codeaurora.org writes: On Feb 26, 2014, at 8:22 AM, Kevin Hilman khil...@linaro.org wrote: Kumar Gala ga...@codeaurora.org writes: Introduce a new mach-qcom that will support SoCs that intend to be multiplatform compatiable while keeping mach-msm to legacy SoC/board

Re: [PATCH] ARM: qcom: Enable basic support for Qualcomm platforms in multi_v7_defconfig

2014-02-26 Thread Kevin Hilman
Kumar Gala ga...@codeaurora.org writes: Enable support for the MSM8x60, MSM8960, and MSM8974 SoCs, clocks and serial console as part of the standard multi_v7_defconfig. Signed-off-by: Kumar Gala ga...@codeaurora.org --- I leave this to the arm-soc guys to apply because of possible

Re: [PATCH v3 2/9] Input: pmic8xxx-keypad - Migrate to devm_* APIs

2014-02-26 Thread Stephen Boyd
On 02/26/14 16:09, Josh Cartwright wrote: On Wed, Feb 26, 2014 at 11:05:55AM -0800, Stephen Boyd wrote: Simplify the error paths and reduce the lines of code in this driver by using the devm_* APIs. Signed-off-by: Stephen Boyd sb...@codeaurora.org ---

Re: [PATCH v3 1/9] Input: pmic8xxx-pwrkey - Migrate to regmap APIs

2014-02-26 Thread Stephen Boyd
On 02/26/14 16:30, Josh Cartwright wrote: On Wed, Feb 26, 2014 at 04:20:03PM -0800, Stephen Boyd wrote: On 02/26/14 16:13, Josh Cartwright wrote: On Wed, Feb 26, 2014 at 04:05:40PM -0800, Stephen Boyd wrote: On 02/26/14 15:59, Josh Cartwright wrote: However, I think it needs to be made clear

Re: [PATCH 3/3] cpufreq: stats: Refactor common code into __cpufreq_stats_create_table()

2014-02-26 Thread Viresh Kumar
On 27 February 2014 01:47, Saravana Kannan skan...@codeaurora.org wrote: cpufreq_frequency_get_table() is called from all callers of __cpufreq_stats_create_table(). So, move it inside. Suggested-by: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Saravana Kannan skan...@codeaurora.org