Re: [PATCH 6/6] documentation: bindings: document PMIC8921/8058 RTC

2014-03-05 Thread Stephen Boyd
On 03/05/14 16:00, Josh Cartwright wrote: > On Wed, Mar 05, 2014 at 12:58:55PM -0800, Stephen Boyd wrote: >> On 03/05/14 11:29, Josh Cartwright wrote: >>> diff --git a/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt >>> b/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt >>> new

Re: [PATCH 6/6] documentation: bindings: document PMIC8921/8058 RTC

2014-03-05 Thread Josh Cartwright
On Wed, Mar 05, 2014 at 12:58:55PM -0800, Stephen Boyd wrote: > On 03/05/14 11:29, Josh Cartwright wrote: > > diff --git a/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt > > b/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt > > new file mode 100644 > > index 000..699bd30 >

Re: [PATCH 1/6] rtc: pm8xxx: fixup checkpatch/style issues

2014-03-05 Thread Josh Cartwright
On Wed, Mar 05, 2014 at 01:02:29PM -0800, Stephen Boyd wrote: > On 03/05/14 11:29, Josh Cartwright wrote: > > Before performing additional cleanups to this driver, do the easy > > cleanups first. > > > > Signed-off-by: Josh Cartwright > > Reviewed-by: Stephen Boyd Thanks for the reviews. > > @

Re: [PATCH v10 1/3] mmc: sdhci-msm: Qualcomm SDHCI binding documentation

2014-03-05 Thread Josh Cartwright
Hey Rob- On Wed, Mar 05, 2014 at 12:56:22AM -0600, Rob Herring wrote: > On Tue, Mar 4, 2014 at 1:27 PM, Georgi Djakov wrote: > > +- reg-names: Should contain the following: > > + "hc_mem" - Host controller register map > > + "core_mem" - SD Core register map > > reg-names should not

Re: [PATCH 1/6] rtc: pm8xxx: fixup checkpatch/style issues

2014-03-05 Thread Joe Perches
On Wed, 2014-03-05 at 13:02 -0800, Stephen Boyd wrote: > On 03/05/14 11:29, Josh Cartwright wrote: > > Before performing additional cleanups to this driver, do the easy > > cleanups first. > > > > Signed-off-by: Josh Cartwright > > Reviewed-by: Stephen Boyd > > > @@ -253,7 +253,7 @@ static int

Re: [PATCH 1/6] rtc: pm8xxx: fixup checkpatch/style issues

2014-03-05 Thread Stephen Boyd
On 03/05/14 11:29, Josh Cartwright wrote: > Before performing additional cleanups to this driver, do the easy > cleanups first. > > Signed-off-by: Josh Cartwright Reviewed-by: Stephen Boyd > @@ -253,7 +253,7 @@ static int pm8xxx_rtc_set_alarm(struct device *dev, > struct rtc_wkalrm *alarm) >

Re: [PATCH 6/6] documentation: bindings: document PMIC8921/8058 RTC

2014-03-05 Thread Stephen Boyd
On 03/05/14 11:29, Josh Cartwright wrote: > diff --git a/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt > b/Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt > new file mode 100644 > index 000..699bd30 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/qcom,pm8xxx

Re: [PATCH 4/6] rtc: pm8xxx: add support for devicetree

2014-03-05 Thread Stephen Boyd
On 03/05/14 11:29, Josh Cartwright wrote: > Add support for describing the PM8921/PM8058 RTC in device tree. > > Additionally: >- drop support for describing the RTC using platform data, > as there are no current in tree users who do so. >- make allow_set_time a device-specific flag, i

Re: [PATCH 5/6] rtc: pm8xxx: move device_init_wakeup() before rtc_register

2014-03-05 Thread Stephen Boyd
On 03/05/14 11:29, Josh Cartwright wrote: > Setup wakeup capability before rtc_register to ensure the rtc class core > properly sets up our 'wakealarm' sysfs attribute. > > Signed-off-by: Josh Cartwright Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora F

Re: [PATCH 2/6] rtc: pm8xxx: use regmap API for register accesses

2014-03-05 Thread Stephen Boyd
On 03/05/14 11:29, Josh Cartwright wrote: > Now that the parent mfd driver has been made to work again, and has been > reworked to create a regmap instance intended for it's children to use, > rework the pm8xxx driver to use the regmap API for it's register > accesses. > > Signed-off-by: Josh Cartw

Re: [PATCH 3/6] rtc: pm8xxx: use devm_request_any_context_irq

2014-03-05 Thread Stephen Boyd
On 03/05/14 11:29, Josh Cartwright wrote: > Make use of the devm_* variant of request_any_context_irq to allow for > elimination of remove(). > > Signed-off-by: Josh Cartwright Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux F

Re: [PATCH v10 2/3] mmc: sdhci-msm: Initial support for Qualcomm chipsets

2014-03-05 Thread Georgi Djakov
On 03/05/2014 06:41 AM, Ulf Hansson wrote: On 4 March 2014 20:27, Georgi Djakov wrote: [..] + +struct sdhci_msm_pltfm_data { + u32 caps; /* Supported UHS-I Modes */ + u32 caps2; /* More capabilities */ Why do you need the

Re: [PATCH v10 1/3] mmc: sdhci-msm: Qualcomm SDHCI binding documentation

2014-03-05 Thread Georgi Djakov
On 03/05/2014 06:25 AM, Ulf Hansson wrote: On 4 March 2014 20:27, Georgi Djakov wrote: [..] +Required properties: +- compatible: Should contain "qcom,sdhci-msm-v4". +- reg: Base address and length of the register set listed in reg-names. +- reg-names: Should contain the following: + "hc_

Re: [PATCH] mfd: pm8921: fixup probe() error path when irq invalid

2014-03-05 Thread Stephen Boyd
On 03/05/14 11:34, Josh Cartwright wrote: > platform_get_irq() returns a negative error code when an IRQ is invalid > or unspecified. Make 'irq' signed to properly handle this. > Reviewed-by: Stephen Boyd Thanks -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by T

[PATCH] mfd: pm8921: fixup probe() error path when irq invalid

2014-03-05 Thread Josh Cartwright
platform_get_irq() returns a negative error code when an IRQ is invalid or unspecified. Make 'irq' signed to properly handle this. Cc: Stephen Boyd Signed-off-by: Josh Cartwright --- drivers/mfd/pm8921-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/pm8

[PATCH] pinctrl: msm: drop wake_irqs bitmap

2014-03-05 Thread Josh Cartwright
Currently, the wake_irqs bitmap is used to track whether there are any gpio's which are configured as wake irqs, and uses this to determine whether or not to call enable_irq_wake()/disable_irq_wake() on the summary interrupt. However, the genirq core already handles this case, by maintaining a 'wa

[PATCH 4/6] rtc: pm8xxx: add support for devicetree

2014-03-05 Thread Josh Cartwright
Add support for describing the PM8921/PM8058 RTC in device tree. Additionally: - drop support for describing the RTC using platform data, as there are no current in tree users who do so. - make allow_set_time a device-specific flag, instead of mucking with the rtc_ops Signed-off-b

[PATCH 6/6] documentation: bindings: document PMIC8921/8058 RTC

2014-03-05 Thread Josh Cartwright
This RTC is found on the Qualcomm 8921 and 8058 PMICs. Signed-off-by: Josh Cartwright --- .../devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt| 29 ++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/qcom,pm8xxx-rtc.txt diff --git a/D

[PATCH 5/6] rtc: pm8xxx: move device_init_wakeup() before rtc_register

2014-03-05 Thread Josh Cartwright
Setup wakeup capability before rtc_register to ensure the rtc class core properly sets up our 'wakealarm' sysfs attribute. Signed-off-by: Josh Cartwright --- drivers/rtc/rtc-pm8xxx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rt

[PATCH 1/6] rtc: pm8xxx: fixup checkpatch/style issues

2014-03-05 Thread Josh Cartwright
Before performing additional cleanups to this driver, do the easy cleanups first. Signed-off-by: Josh Cartwright --- drivers/rtc/rtc-pm8xxx.c | 88 +--- 1 file changed, 45 insertions(+), 43 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/

[PATCH 2/6] rtc: pm8xxx: use regmap API for register accesses

2014-03-05 Thread Josh Cartwright
Now that the parent mfd driver has been made to work again, and has been reworked to create a regmap instance intended for it's children to use, rework the pm8xxx driver to use the regmap API for it's register accesses. Signed-off-by: Josh Cartwright --- drivers/rtc/rtc-pm8xxx.c | 145 ++

[PATCH 3/6] rtc: pm8xxx: use devm_request_any_context_irq

2014-03-05 Thread Josh Cartwright
Make use of the devm_* variant of request_any_context_irq to allow for elimination of remove(). Signed-off-by: Josh Cartwright --- drivers/rtc/rtc-pm8xxx.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c

Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller

2014-03-05 Thread Wolfram Sang
> + qup->adap.nr = pdev->id; > + qup->adap.dev.parent = qup->dev; > + qup->adap.dev.of_node = pdev->dev.of_node; > + strlcpy(qup->adap.name, "QUP I2C adapter", sizeof(qup->adap.name)); > + > + ret = i2c_add_numbered_adapter(&qup->adap); I'd suggest to use just i2c_add_adapter

Re: [PATCH v5 10/14] usb: phy: msm: Use reset framework for LINK and PHY resets

2014-03-05 Thread Sergei Shtylyov
Hello. On 05-03-2014 14:13, Ivan T. Ivanov wrote: From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 30 ++ include/linux/usb/msm_hsusb.h |3 +++ 2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/dr

Loan Application

2014-03-05 Thread Loans
Loan Application at a low rate of 0.5% send your Name,Amount,Phone and country to standar...@56788.com Note: $5,000.00 USD minimum and $100,000,000 Maximum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majord...@vger.kernel.org More major

[PATCH v5 08/14] usb: phy: msm: Properly check result from platform_get_irq()

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Function return negative code on error. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index c2048c7..31fb916 100644 ---

[PATCH v5 02/14] usb: phy: msm: Migrate to Managed Device Resource allocation

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Move memory, regulators, clocks and irq allocation to devm_* variants. Properly check for valid clk handles. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 192 - 1 file changed, 74 insertions(+), 118 deletions(

[PATCH v5 05/14] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Use enum usb_dr_mode and drop default usb_dr_mode from platform data. USB DT bindings states: dr_mode: "...In case this attribute isn't passed via DT, USB DRD controllers should default to OTG...", so remove redundand field. Signed-off-by: Ivan T. Ivanov Acked-by: David

[PATCH v5 06/14] usb: phy: msm: Remove unused pclk_src_name

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" There are no references to 'pclk_src_name' in plaform code, so it is unused. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 26 +- include/linux/usb/msm_hsusb.h |5 - 2 files changed, 1 insertion(+), 30 deletions(-) d

[PATCH v5 10/14] usb: phy: msm: Use reset framework for LINK and PHY resets

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 30 ++ include/linux/usb/msm_hsusb.h |3 +++ 2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c i

[PATCH v5 07/14] usb: phy: msm: Remove HSUSB prefix from regulator names

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Prefix did not bring any useful information. Currently none of the MSM platforms define these regulators, so it is safe to rename them. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --

[PATCH v5 11/14] usb: phy: msm: Add support for secondary PHY control

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allow support to use 2nd HSPHY with USB2 Core. Some platforms may have configuration to allow USB controller work with any of the two HSPHYs present. By default driver configures USB core to use primary HSPHY. Add support to allow user select 2nd HSPHY using DT parameter.

[PATCH v5 03/14] usb: phy: msm: Remove unnecessarily check for valid regulators.

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Whether regulators are available or not is checked at driver probe. If they are not available driver will refuse to load, so no need to check them again. Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 10 -- 1 file changed, 10 deletions(-) d

[PATCH v5 12/14] usb: phy: msm: Correct USB PHY Reset sequence for newer platform

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" On few legacy platforms, USB PHY is having dedicated reset clk. It is used to reset USB PHY after putting USB PHY into low power mode and for calibration of USB PHY. Putting USB PHY into low power mode is causing ulpi read/write timeout as expected. USB PHY reset clk is not

[PATCH v5 09/14] usb: phy: msm: Add device tree support and binding information

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allows MSM OTG controller to be specified via device tree. Signed-off-by: Ivan T. Ivanov --- .../devicetree/bindings/usb/msm-hsusb.txt | 67 drivers/usb/phy/phy-msm-usb.c | 108 include/linux/usb/msm_hsus

[PATCH v5 01/14] usb: phy: msm: Move global regulators variables to driver state

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 82 - include/linux/usb/msm_hsusb.h |3 ++ 2 files changed, 42 insertions(+), 43 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-

[PATCH v5 14/14] usb: phy: msm: Vote for corner of VDD CX instead of voltage of VDD CX

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" New platform uses RBCPR hardware feature, with that voting for absolute voltage of VDD CX is not required. Hence vote for corner of VDD CX which uses nominal corner voltage on VDD CX. Signed-off-by: Ivan T. Ivanov Cc: Mayank Rana --- .../devicetree/bindings/usb/msm-hsus

[PATCH v5 04/14] usb: phy: msm: Fix checkpatch.pl warnings

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" This fixes following: WARNING: quoted string split across lines WARNING: Prefer seq_puts to seq_printf Signed-off-by: Ivan T. Ivanov --- drivers/usb/phy/phy-msm-usb.c | 39 ++- 1 file changed, 14 insertions(+), 25 deletions(-) diff

[PATCH v5 13/14] usb: phy: msm: Handle disconnect events

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Put the transceiver in non-driving mode. Otherwise host may not detect soft-disconnection. Signed-off-by: Ivan T. Ivanov Cc: Pavankumar Kondeti --- drivers/usb/phy/phy-msm-usb.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/usb/phy/ph

[PATCH v5 00/14] usb: phy: msm: Fixes, cleanups and DT support

2014-03-05 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, This is a fifth version of patches posted earlier here [1]. They have been tested on AP8074 DragonBoard. Only gadget mode utilized for now. CV Test Suite engine "Chapter 9 tests" are passing except "Halt Endpoint Test". usbtest driver report following failure: test