Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID.
On 13/05/14 23:13, Stephen Boyd wrote: On 05/13, Srinivas Kandagatla wrote: Thanks Linus W, On 13/05/14 08:16, Linus Walleij wrote: On Tue, Apr 29, 2014 at 10:19 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org (...) + AMBA_VENDOR_QCOM = 0x51, Yeah it's a Q, like 0x41 is A for ARM. You could as well mention this in the commit message. Sounds good, I will fix it in next version and send it to Russell's patch tracker. Please add a note that this id is fake in the commit text or in the code as well. Sure, I will add it in commit text. -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/4] spi: qup: Correct selection of FIFO/Block mode
On Tue, May 13, 2014 at 04:34:42PM -0500, Andy Gross wrote: This patch fixes the calculation for determining whether to use FIFO or BLOCK mode. Applied, thanks. signature.asc Description: Digital signature
Re: [PATCH] i2c: qup: Fix pm_runtime_get_sync usage
On Fri, May 02, 2014 at 08:54:29PM -0500, Andy Gross wrote: This patch corrects the error check on the call to pm_runtime_get_sync. Signed-off-by: Andy Gross agr...@codeaurora.org Applied to for-current, thanks! signature.asc Description: Digital signature
Re: [PATCH] Input: pmic8xxx-pwrkey - Set sane default for debounce time
On Mon, Mar 31, 2014 at 11:29:27AM -0700, Stephen Boyd wrote: On 03/31/14 11:23, Dmitry Torokhov wrote: On Mon, Mar 31, 2014 at 11:14:24AM -0700, Stephen Boyd wrote: If the debounce time is 0 our usage of ilog2() later on in this driver will cause undefined behavior. If CONFIG_OF=n this fact is evident to the compiler, and it emits a call to ilog2_NaN() which doesn't exist. Fix this by setting a sane default for debounce. Reported-by: Arnd Bergmann a...@arndb.de Signed-off-by: Stephen Boyd sb...@codeaurora.org --- drivers/input/misc/pmic8xxx-pwrkey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/misc/pmic8xxx-pwrkey.c b/drivers/input/misc/pmic8xxx-pwrkey.c index 1cb8fda7a166..27add04676e1 100644 --- a/drivers/input/misc/pmic8xxx-pwrkey.c +++ b/drivers/input/misc/pmic8xxx-pwrkey.c @@ -92,7 +92,7 @@ static int pmic8xxx_pwrkey_probe(struct platform_device *pdev) bool pull_up; if (of_property_read_u32(pdev-dev.of_node, debounce, kpd_delay)) - kpd_delay = 0; + kpd_delay = 15625; What if somebody supplied 0 via DT? Can we check and return -EINVAL? Sure. Here's a v2. -8-- From: Stephen Boyd sb...@codeaurora.org Subject: [PATCH v2] Input: pmic8xxx-pwrkey - Set sane default for debounce time If the debounce time is 0 our usage of ilog2() later on in this driver will cause undefined behavior. If CONFIG_OF=n this fact is evident to the compiler, and it emits a call to ilog2_NaN() which doesn't exist. Fix this by setting a sane default for debounce and failing to probe if debounce is 0 in the DT. Reported-by: Arnd Bergmann a...@arndb.de Signed-off-by: Stephen Boyd sb...@codeaurora.org Applied, thank you. Sorry for the delay. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] arm: msm: remove board file for the HTC Sapphire device
Commit 614ad9814850 (arm: msm: add board file for the HTC Sapphire
device) added just board-sapphire.c. It did not add board-sapphire.h,
Makefile changes or Kconfig changes.
Four years have passed and this file is still dangling. Remove it.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Also untested.
arch/arm/mach-msm/board-sapphire.c | 117 -
1 file changed, 117 deletions(-)
delete mode 100644 arch/arm/mach-msm/board-sapphire.c
diff --git a/arch/arm/mach-msm/board-sapphire.c
b/arch/arm/mach-msm/board-sapphire.c
deleted file mode 100644
index 327605174d63..
--- a/arch/arm/mach-msm/board-sapphire.c
+++ /dev/null
@@ -1,117 +0,0 @@
-/* linux/arch/arm/mach-msm/board-sapphire.c
- * Copyright (C) 2007-2009 HTC Corporation.
- * Author: Thomas Tsai thomas_t...@htc.com
- *
- * This software is licensed under the terms of the GNU General Public
- * License version 2, as published by the Free Software Foundation, and
- * may be copied, distributed, and modified under those terms.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
-*/
-#include linux/gpio.h
-#include linux/kernel.h
-#include linux/init.h
-#include linux/platform_device.h
-#include linux/input.h
-#include linux/interrupt.h
-#include linux/irq.h
-#include linux/device.h
-
-#include linux/delay.h
-
-#include mach/hardware.h
-#include asm/mach-types.h
-#include asm/mach/arch.h
-#include asm/mach/map.h
-#include asm/mach/flash.h
-#include mach/vreg.h
-
-#include asm/io.h
-#include asm/delay.h
-#include asm/setup.h
-
-#include linux/mtd/nand.h
-#include linux/mtd/partitions.h
-
-#include gpio_chip.h
-#include board-sapphire.h
-#include proc_comm.h
-#include devices.h
-#include common.h
-
-void msm_init_irq(void);
-void msm_init_gpio(void);
-
-static struct platform_device *devices[] __initdata = {
- msm_device_smd,
- msm_device_dmov,
- msm_device_nand,
- msm_device_uart1,
- msm_device_uart3,
-};
-
-void msm_timer_init(void);
-
-static void __init sapphire_init_irq(void)
-{
- msm_init_irq();
-}
-
-static void __init sapphire_init(void)
-{
- platform_add_devices(devices, ARRAY_SIZE(devices));
-}
-
-static struct map_desc sapphire_io_desc[] __initdata = {
- {
- .virtual = SAPPHIRE_CPLD_BASE,
- .pfn = __phys_to_pfn(SAPPHIRE_CPLD_START),
- .length = SAPPHIRE_CPLD_SIZE,
- .type= MT_DEVICE_NONSHARED
- }
-};
-
-static void __init sapphire_fixup(struct tag *tags, char **cmdline,
- struct meminfo *mi)
-{
- int smi_sz = parse_tag_smi((const struct tag *)tags);
-
- mi-nr_banks = 1;
- mi-bank[0].start = PHYS_OFFSET;
- mi-bank[0].node = PHYS_TO_NID(PHYS_OFFSET);
- if (smi_sz == 32) {
- mi-bank[0].size = (84*1024*1024);
- } else if (smi_sz == 64) {
- mi-bank[0].size = (101*1024*1024);
- } else {
- /* Give a default value when not get smi size */
- smi_sz = 64;
- mi-bank[0].size = (101*1024*1024);
- }
-}
-
-static void __init sapphire_map_io(void)
-{
- msm_map_common_io();
- iotable_init(sapphire_io_desc, ARRAY_SIZE(sapphire_io_desc));
- msm_clock_init();
-}
-
-static void __init sapphire_init_late(void)
-{
- smd_debugfs_init();
-}
-
-MACHINE_START(SAPPHIRE, sapphire)
-/* Maintainer: Brian Swetland swetl...@google.com */
- .atag_offset= 0x100,
- .fixup = sapphire_fixup,
- .map_io = sapphire_map_io,
- .init_irq = sapphire_init_irq,
- .init_machine = sapphire_init,
- .init_late = sapphire_init_late,
- .init_time = msm_timer_init,
-MACHINE_END
--
1.9.0
--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)
Commit 1b802ff79f03 (arm: msm: add board file for Nexus One (ie.
mahimahi)) added just board-mahimahi.c. It did not add
board-mahimahi.h, Makefile changes or Kconfig changes.
Four years have passed and this file is still dangling. Remove it.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
---
Untested. But what to test here?
arch/arm/mach-msm/board-mahimahi.c | 88 --
1 file changed, 88 deletions(-)
delete mode 100644 arch/arm/mach-msm/board-mahimahi.c
diff --git a/arch/arm/mach-msm/board-mahimahi.c
b/arch/arm/mach-msm/board-mahimahi.c
deleted file mode 100644
index 7d9981cb400e..
--- a/arch/arm/mach-msm/board-mahimahi.c
+++ /dev/null
@@ -1,88 +0,0 @@
-/* linux/arch/arm/mach-msm/board-mahimahi.c
- *
- * Copyright (C) 2009 Google, Inc.
- * Copyright (C) 2009 HTC Corporation.
- * Author: Dima Zavin d...@android.com
- *
- * This software is licensed under the terms of the GNU General Public
- * License version 2, as published by the Free Software Foundation, and
- * may be copied, distributed, and modified under those terms.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- */
-
-#include linux/delay.h
-#include linux/gpio.h
-#include linux/init.h
-#include linux/input.h
-#include linux/io.h
-#include linux/kernel.h
-#include linux/platform_device.h
-
-#include asm/mach-types.h
-#include asm/mach/arch.h
-#include asm/mach/map.h
-#include asm/setup.h
-
-#include mach/hardware.h
-
-#include board-mahimahi.h
-#include devices.h
-#include proc_comm.h
-#include common.h
-
-static uint debug_uart;
-
-module_param_named(debug_uart, debug_uart, uint, 0);
-
-static struct platform_device *devices[] __initdata = {
-#if !defined(CONFIG_MSM_SERIAL_DEBUGGER)
- msm_device_uart1,
-#endif
- msm_device_uart_dm1,
- msm_device_nand,
-};
-
-static void __init mahimahi_init(void)
-{
- platform_add_devices(devices, ARRAY_SIZE(devices));
-}
-
-static void __init mahimahi_fixup(struct tag *tags, char **cmdline,
- struct meminfo *mi)
-{
- mi-nr_banks = 2;
- mi-bank[0].start = PHYS_OFFSET;
- mi-bank[0].node = PHYS_TO_NID(PHYS_OFFSET);
- mi-bank[0].size = (219*1024*1024);
- mi-bank[1].start = MSM_HIGHMEM_BASE;
- mi-bank[1].node = PHYS_TO_NID(MSM_HIGHMEM_BASE);
- mi-bank[1].size = MSM_HIGHMEM_SIZE;
-}
-
-static void __init mahimahi_map_io(void)
-{
- msm_map_common_io();
- msm_clock_init();
-}
-
-static void __init mahimahi_init_late(void)
-{
- smd_debugfs_init();
-}
-
-void msm_timer_init(void);
-
-MACHINE_START(MAHIMAHI, mahimahi)
- .atag_offset= 0x100,
- .fixup = mahimahi_fixup,
- .map_io = mahimahi_map_io,
- .init_irq = msm_init_irq,
- .init_machine = mahimahi_init,
- .init_late = mahimahi_init_late,
- .init_time = msm_timer_init,
-MACHINE_END
--
1.9.0
--
To unsubscribe from this list: send the line unsubscribe linux-arm-msm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
