Re: [PATCH 1/2] clk: qcom: add clocks necessary for apq8064 sdcc

2014-06-11 Thread Andreas Färber
Am 10.06.2014 22:58, schrieb Stephen Boyd: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds clocks necessary for SD card controller on apq8064 SOC. Without this patch the clocks are visible to the sdcc driver. Was this maybe meant to read invisible? Regards, Andreas

Re: [PATCH 1/2] clk: qcom: add clocks necessary for apq8064 sdcc

2014-06-11 Thread Srinivas Kandagatla
On 11/06/14 10:14, Andreas Färber wrote: This patch adds clocks necessary for SD card controller on apq8064 SOC. Without this patch the clocks are visible to the sdcc driver. Was this maybe meant to read invisible? You are correct it was suposed to be not visible, will fix it. Regards,

Re: [PATCH v6 02/12] mmc: mmci: Add Qualcomm specific register defines.

2014-06-11 Thread Linus Walleij
On Mon, Jun 2, 2014 at 11:08 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds a Qualcomm SD Card controller specific register variations to header file. Qualcomm SDCC controller is pl180, with slight changes in the register

Re: [PATCH v6 03/12] mmc: mmci: Add enough delay between writes to CMD register.

2014-06-11 Thread Linus Walleij
On Mon, Jun 2, 2014 at 11:08 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org On Qcom SD Card controller POWER, CLKCTRL, DATACTRL and COMMAND registers should be updated in MCLK domain, and writes to these registers must be separated by

Re: [PATCH v6 09/12] mmc: mmci: add f_max to variant structure

2014-06-11 Thread Linus Walleij
On Mon, Jun 2, 2014 at 11:09 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org Some of the controller have maximum supported frequency, This patch adds support in variant data structure to specify such restrictions. This gives more

Re: [PATCH v6 11/12] mmc: mmci: Add Qcom specific rx_fifocnt logic.

2014-06-11 Thread Linus Walleij
On Mon, Jun 2, 2014 at 11:10 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org MCIFIFOCNT register behaviour on Qcom chips is very different than the other pl180 integrations. MCIFIFOCNT register contains the number of words that are still

Re: [PATCH v6 12/12] mmc: mmci: Add Qualcomm Id to amba id table

2014-06-11 Thread Linus Walleij
On Mon, Jun 2, 2014 at 11:10 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds a fake Qualcomm ID 0x00051180 to the amba_ids, as Qualcomm SDCC controller is pl180, but amba id registers read 0x0's. The plan is to remove SDCC

Re: [PATCH v6 00/12] Qualcomm SD Card Controller support

2014-06-11 Thread Ulf Hansson
On 2 June 2014 11:03, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org Thankyou Linus W, Ulf H, Russell K and everyone for reviewing RFC to v5 patches. This patch series adds Qualcomm SD Card Controller support in pl180 mmci driver. QCom SDCC

Re: [PATCH v6 00/12] Qualcomm SD Card Controller support

2014-06-11 Thread Srinivas Kandagatla
Hi Ulf, On 11/06/14 18:35, Ulf Hansson wrote: Thanks Srinivas, great work! We didn't reach 3.16, but now I have applied this for my next branch intended for 3.17. That's great. For you information, the v6 patchset needed a minor re-base, and one of the patches had a checkpatch error. I

Re: [PATCH 1/4] spi: qup: Remove chip select function

2014-06-11 Thread Andy Gross
On Mon, May 19, 2014 at 11:07:38AM +0300, Ivan T. Ivanov wrote: snip +- num-cs: total number of chipselects My understanding is that num-cs have to be parsed by master driver, not by core SPI driver. Right. I need to parse it and check vs the max cs and use that value to set the