Re: QSD8250 illegal instruction on WinCE devices

2010-06-29 Thread Daniel Walker
On Tue, 2010-06-29 at 21:03 +0200, Martijn Stolk wrote: No worries. I wanted to isolate what specifically fixes the problem myself in order to make a minimal patch. I'm also hoping for some help regarding information, as I don't have access to official QSD8250 documentation. I've found

Re: [PATCH v2] msm: gpio: Add set_wake support to msm7200a-gpio's irq_chip.

2010-07-06 Thread Daniel Walker
On Tue, 2010-07-06 at 09:56 -0700, Greg Bean wrote: Add power-management and irq_chip hooks to allow configuration of msm-gpio irq lines as wakeup sources. What level of correlation is there between power management and the wake up hooks? Just irq_masks ? When the system sleeps,

[PATCH 4/5] msm: fix up mddi clock

2010-07-13 Thread Daniel Walker
This adds in the CLK_MINMAX flag, renames the clocks to mddi_clk, and adds in the device pointer. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/devices-msm7x00.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-msm/devices

Re: [PATCH 2/4] mm: cma: Contiguous Memory Allocator added

2010-07-20 Thread Daniel Walker
On Tue, 2010-07-20 at 17:51 +0200, Michal Nazarewicz wrote: +** Use cases + +Lets analyse some imaginary system that uses the CMA to see how +the framework can be used and configured. + + +We have a platform with a hardware video decoder and a camera each +needing 20 MiB

Re: [PATCH 2/4] mm: cma: Contiguous Memory Allocator added

2010-07-20 Thread Daniel Walker
On Tue, 2010-07-20 at 21:14 +0200, Michał Nazarewicz wrote: On Tue, 20 Jul 2010 20:15:24 +0200, Daniel Walker dwal...@codeaurora.org wrote: On Tue, 2010-07-20 at 17:51 +0200, Michal Nazarewicz wrote: +** Use cases + +Lets analyse some imaginary system that uses the CMA to see how

Re: [PATCH 2/4] mm: cma: Contiguous Memory Allocator added

2010-07-21 Thread Daniel Walker
On Wed, 2010-07-21 at 20:11 +0200, Michał Nazarewicz wrote: (btw, these strings your creating yikes, talk about confusing ..) They are not that scary really. Let's look at cma: a=10M;b=10M Split it on semicolon: a=10M b=10M and you see that it defines two

Re: [PATCH 2/4] mm: cma: Contiguous Memory Allocator added

2010-07-21 Thread Daniel Walker
that in final product defaults from platform would be used and bootloader would be left alone. On Wed, 21 Jul 2010 22:34:32 +0200, Daniel Walker dwal...@codeaurora.org wrote: It should never be anyplace else. I disagree. There are countless “dubug_level” kernel parameters or even some

Re: [PATCH 2/4] mm: cma: Contiguous Memory Allocator added

2010-07-21 Thread Daniel Walker
On Wed, 2010-07-21 at 22:56 +0200, Michał Nazarewicz wrote: On Wed, 21 Jul 2010 22:45:43 +0200, Daniel Walker dwal...@codeaurora.org wrote: Your not hearing the issues.. IT'S TOO COMPLEX! Please remove it. Remove what exactly? Remove the command line option and all related code, or make

Re: [PATCH] Adding rpc server

2010-07-22 Thread Daniel Walker
On Tue, 2010-07-20 at 15:58 +0200, David Lanzendörfer wrote: Hi Daniel I've tried to import the SMD server pack into the kernel. But somehow it went wrong. Any suggestions? Too much at once .. You need to pull individual patches with specific features, or break up large patches into

[PATCH 2/7] msm: gpio support for trout.

2010-07-27 Thread Daniel Walker
This adds the tables required to enable gpiolib support in trout. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/board-trout.c |6 ++ arch/arm/mach-msm/devices-msm7x00.c | 18 ++ 2 files changed, 24 insertions(+), 0 deletions(-) diff

[PATCH 6/7] drivers: msm: video: add dev_set_name call

2010-07-27 Thread Daniel Walker
This is required before the driver can successfully be registered. Adapted from Arve Hjønnevåg a...@android.com changes in the Google tree. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- drivers/video/msm/mdp.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 3/7] msm: update clk rate to use min/max values

2010-07-28 Thread Daniel Walker
On Wed, 2010-07-28 at 12:22 -0400, Neil Leeder wrote: On 7/27/2010 5:04 PM, Daniel Walker wrote: static struct msm_mddi_platform_data mddi_pdata = { - .clk_rate = 12288, + .min_clk_rate = 12288, + .min_clk_rate = 98304000, One of those should probably be max... Ooops

Re: [PATCH 2/3] arm: mm: do not set missing flags on ScorpionMP

2010-07-28 Thread Daniel Walker
On Sat, 2010-07-24 at 09:23 +0100, Russell King - ARM Linux wrote: On Fri, Jul 23, 2010 at 11:58:02AM -0700, Jeff Ohlstein wrote: From: Steve Muckle smuc...@codeaurora.org ScorpionMP does not have the SMP/nAMP mode and TLB ops broadcasting bits in the ACTLR. Please provide a separate

Re: [PATCH 2/3] arm: mm: do not set missing flags on ScorpionMP

2010-07-28 Thread Daniel Walker
On Wed, 2010-07-28 at 23:36 +0100, Russell King - ARM Linux wrote: On Wed, Jul 28, 2010 at 02:58:00PM -0700, Daniel Walker wrote: On Sat, 2010-07-24 at 09:23 +0100, Russell King - ARM Linux wrote: On Fri, Jul 23, 2010 at 11:58:02AM -0700, Jeff Ohlstein wrote: From: Steve Muckle smuc

Re: [PATCH 2/3] arm: mm: do not set missing flags on ScorpionMP

2010-07-29 Thread Daniel Walker
On Thu, 2010-07-29 at 08:18 +0100, Russell King - ARM Linux wrote: On Wed, Jul 28, 2010 at 03:51:35PM -0700, Daniel Walker wrote: @@ -326,6 +327,29 @@ cpu_elf_name: .section .proc.info.init, #alloc, #execinstr + .type __v7_msm_proc_info, #object +__v7_msm_proc_info

Re: [PATCH 2/3] arm: mm: do not set missing flags on ScorpionMP

2010-07-30 Thread Daniel Walker
On Fri, 2010-07-30 at 08:19 +0100, Russell King - ARM Linux wrote: On Thu, Jul 29, 2010 at 03:42:46PM -0700, Daniel Walker wrote: On Thu, 2010-07-29 at 08:18 +0100, Russell King - ARM Linux wrote: On Wed, Jul 28, 2010 at 03:51:35PM -0700, Daniel Walker wrote: @@ -326,6 +327,29

Re: [PATCH 2/3] arm: mm: do not set missing flags on ScorpionMP

2010-07-30 Thread Daniel Walker
On Fri, 2010-07-30 at 21:20 +0100, Russell King - ARM Linux wrote: On Fri, Jul 30, 2010 at 10:09:37AM -0700, Daniel Walker wrote: On Fri, 2010-07-30 at 08:19 +0100, Russell King - ARM Linux wrote: Yes, but if its just for this patch, is there much point to a pull request? I've got

[GIT PULL] MSM updates for 2.6.36

2010-08-11 Thread Daniel Walker
3260e5293727f16ffdce9a6a6203fd9a6b149e58: arm: mm: Don't free prohibited memmap entries (2010-06-15 13:19:55 -0700) are available in the git repository at: git://codeaurora.org/quic/kernel/dwalker/linux-msm.git msm-core Daniel Walker (2): arm: msm: trout: add trout specific gpio interrupts arm: msm: trout

Re: [PATCH 03/24] arm: mm: add proc info for ScorpionMP

2010-08-27 Thread Daniel Walker
On Fri, 2010-08-27 at 14:54 +0100, Catalin Marinas wrote: On Wed, 2010-08-25 at 05:57 +0100, Jeff Ohlstein wrote: From: Daniel Walker dwal...@codeaurora.org ScorpionMP does not have the SMP/nAMP and TLB ops broadcasting bits in ACTLR. Signed-off-by: Daniel Walker dwal

Re: [PATCH 1/5 v3] msm: add gpiomux api for gpio multiplex configuration.

2010-08-27 Thread Daniel Walker
On Fri, 2010-08-27 at 09:19 -0700, Gregory Bean wrote: +obj-y += gpiomux.o +obj-$(CONFIG_ARCH_MSM7X30) += gpiomux-7x30.o gpiomux-7x00.o +obj-$(CONFIG_ARCH_QSD8X50) += gpiomux-8x50.o gpiomux-7x00.o +obj-$(CONFIG_ARCH_MSM8X60) += gpiomux-8x60.o Is this right? I got a built failure before 7x00

Re: [PATCH 1/2] msm: Install the Google-Android gpio driver.

2010-08-31 Thread Daniel Walker
On Mon, 2010-08-30 at 17:18 -0700, Gregory Bean wrote: + /* printk(%s %08x %08x bit %d gpio %d irq %d\n, + __func__, v, m, j, msm_chip-chip.start + j, + FIRST_GPIO_IRQ + msm_chip-chip.start + j); */ Can you

RE: [PATCH 1/2] msm: Install the Google-Android gpio driver.

2010-09-01 Thread Daniel Walker
On Wed, 2010-09-01 at 13:59 -0500, H Hartley Sweeten wrote: On Monday, August 30, 2010 5:18 PM, Gregory Bean wrote: Subject: [PATCH 1/2] msm: Install the Google-Android gpio driver. From: Arve Hjønnevåg a...@android.com As part of the ongoing effort to converge on a common code base,

Re: [PATCH 14/24] msm: add hotplug stub functions

2010-09-03 Thread Daniel Walker
On Fri, 2010-09-03 at 08:31 +0100, Russell King - ARM Linux wrote: On Thu, Sep 02, 2010 at 03:36:40PM -0700, Daniel Walker wrote: If no others use it .. We can do this to fix them all. What do you think? If no one else implements it, then you can't suspend, nor can you support kexec. (We

[PATCH 3/4] arm: mm: add proc info for ARM11MPCore/Cortex-A9 from ARM

2010-09-09 Thread Daniel Walker
Setting of these bits can cause issues on other SMP SoC's not produced by ARM. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mm/proc-v7.S | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc

[PATCH 2/4] arm: dis-allow hotplug on MSM

2010-09-09 Thread Daniel Walker
MSM doesn't support hotplug, so we prevent it from being select with this added line. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index d2dfbc2..829dd67

Re: [PATCH 2/4] arm: dis-allow hotplug on MSM

2010-09-30 Thread Daniel Walker
On Thu, 2010-09-30 at 21:52 +0200, Pavel Machek wrote: Hi! Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index d2dfbc2

[PATCH] GIC: Dont disable INT in ack callback

2010-09-30 Thread Daniel Walker
-by: Abhijeet Dharmapurikar adhar...@codeaurora.org Signed-off-by: Jeff Ohlstein johls...@codeaurora.org Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/common/gic.c | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/arch/arm/common/gic.c b/arch/arm

Re: [PATCH 2/4] arm: dis-allow hotplug on MSM

2010-09-30 Thread Daniel Walker
On Thu, 2010-09-30 at 22:02 +0200, Pavel Machek wrote: Hi! This is goodbye to s2ram support, AFAICT. This depends on SMP tho. It's like saying, depends on That's weird, there was more to this email.. It's like saying, depends on SMP

Re: [PATCH 2/4] arm: dis-allow hotplug on MSM

2010-09-30 Thread Daniel Walker
On Thu, 2010-09-30 at 21:17 +0100, Russell King - ARM Linux wrote: On Thu, Sep 30, 2010 at 01:08:07PM -0700, Daniel Walker wrote: That's actually what I had original, Russell offered this as an alternative. Now that I think about the stubs tho, I'm not sure it's that bad an idea. All

Re: [PATCH] [Streak] Add workaround for TTY kernel OOPS at the cost of performance.

2010-09-30 Thread Daniel Walker
On Fri, 2010-10-01 at 00:42 +0200, Tomasz Sterna wrote: The current framebuffer driver oopses when used as a console (kernel parameter: console=tty ). Here is a patch that makes it work - at the cost of performance. Signed-off-by: Bradley Smith b...@brad-smith.co.uk (cherry picked from

Re: [PATCH] [Streak] Add workaround for TTY kernel OOPS at the cost of performance.

2010-10-01 Thread Daniel Walker
On Fri, 2010-10-01 at 10:52 +0200, Tomasz Sterna wrote: If you start an android-msm-2.6.29 or msm-2.6.35 (these are the ones I tested) with MSM_FB driver compiled in and use 'console=tty' kernel commandline option, kernel starts with proper console output on screen and oopses in the middle of

Re: [PATCH 1/3] [ARM] Translate delay.S into (mostly) C

2010-10-05 Thread Daniel Walker
On Mon, 2010-09-27 at 20:33 -0700, Stephen Boyd wrote: In the next patch we're going to allow machines to override the __delay() implementation at runtime so they can implement a timer based __delay() routine. It's easier to do this using C, so lets write udelay and friends in C. You

Re: [PATCH 2/3] [ARM] Allow machines to override __delay()

2010-10-05 Thread Daniel Walker
On Mon, 2010-09-27 at 20:33 -0700, Stephen Boyd wrote: Some machines want to implement their own __delay() routine based on fixed timers. Expose functionality to set the __delay() routine at runtime. This should allow two machines with different __delay() routines to happily co-exist within

Re: [PATCH 3/3] [ARM] Implement a timer based __delay() loop

2010-10-05 Thread Daniel Walker
On Mon, 2010-09-27 at 20:33 -0700, Stephen Boyd wrote: udelay() can be incorrect on SMP machines that scale their CPU frequencies independently of one another (as pointed out here http://article.gmane.org/gmane.linux.kernel/977567). The delay loop can either be too fast or too slow depending

[PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-05 Thread Daniel Walker
...@quicinc.com Signed-off-by: Daniel Walker dwal...@codeaurora.org --- drivers/serial/Kconfig | 31 +++ drivers/serial/Makefile |1 + drivers/serial/dcc.c| 467 +++ include/linux/serial_core.h |3 + 4 files changed, 502 insertions(+), 0

Re: [PATCH 1/3] [ARM] Translate delay.S into (mostly) C

2010-10-06 Thread Daniel Walker
On Tue, 2010-10-05 at 20:36 -0700, Stephen Boyd wrote: On 10/05/2010 10:22 AM, Daniel Walker wrote: You shouldn't really reference this series in this comment. You have to look at this as a changeset comment. So you really want to describe what this change is doing not what the over all

Re: [PATCH 3/3] [ARM] Implement a timer based __delay() loop

2010-10-06 Thread Daniel Walker
On Tue, 2010-10-05 at 20:36 -0700, Stephen Boyd wrote: On 10/05/2010 10:38 AM, Daniel Walker wrote: +#ifdef ARCH_HAS_READ_CURRENT_TIMER +/* + * Assuming read_current_timer() is monotonically increasing + * across calls. You should add more comments here. You assuming that it's

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-06 Thread Daniel Walker
On Tue, 2010-10-05 at 22:55 -0400, Nicolas Pitre wrote: On Tue, 5 Oct 2010, Daniel Walker wrote: +#if !defined(CONFIG_CPU_V7) +static inline char +__dcc_getchar(void) +{ + char __c; + + asm(mrc p14, 0, %0, c0, c5, 0 @ read comms data reg + : =r (__c) : : cc

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-06 Thread Daniel Walker
On Wed, 2010-10-06 at 11:47 -0400, Nicolas Pitre wrote: It is the wrong fix nevertheless. And in this case it isn't a question of opinion. I'm not saying your wrong, I'm sure you know more about it than I do. I was just letting you know why I added it . Daniel -- Sent by an consultant of

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-06 Thread Daniel Walker
On Wed, 2010-10-06 at 13:02 -0400, Nicolas Pitre wrote: Are you saying it's not needed for either the __dcc_putchar or __dcc_getchar ? I'm saying that CC is unneeded in those cases where the condition flag is unmodified. Those are the !CONFIG_CPU_V7 cases. Ok .. I can drop that stuff

Re: [PATCH 1/3] [ARM] Translate delay.S into (mostly) C

2010-10-06 Thread Daniel Walker
On Wed, 2010-10-06 at 11:30 -0700, Stephen Boyd wrote: Is there some way to force GCC to do what I want (interleave the functions)? It seems happy to inline them and then optimize the register usage and instruction ordering. Perhaps that is OK though and we're wasting our time trying to be

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-07 Thread Daniel Walker
On Thu, 2010-10-07 at 14:27 -0700, Tony Lindgren wrote: Can you please pass the read and write functions to the driver in platform_data? We are already booting kernels with both ARMv6 and 7 compiled in. What kind of situation did you want to use it in ? I was thinking about how arm could have

[PATCH] msm: fix compile failure on struct membank node member

2010-10-11 Thread Daniel Walker
membank' has no member named 'node' linux/arch/arm/mach-msm/board-halibut.c:86: error: implicit declaration of function 'PHYS_TO_NID' I've removed the access to the node member which correct the compile failure. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/board

[PATCH] msm: fix Kconfig target board selection

2010-10-12 Thread Daniel Walker
This prevents build failures since it's currently possible to select 8x50, 7x30, or 7x00 without selecting a specific board. These changes just force a target selection, which is currently defaulting to the most common one (7x30 only has one). Signed-off-by: Daniel Walker dwal...@codeaurora.org

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-13 Thread Daniel Walker
On Wed, 2010-10-13 at 17:21 +0200, Arnd Bergmann wrote: On Tuesday 05 October 2010, Daniel Walker wrote: Many of JTAG debuggers for ARM support DCC protocol over JTAG connection, which is very useful to debug hardwares which has no serial port. This patch adds DCC serial emulation

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-13 Thread Daniel Walker
On Wed, 2010-10-13 at 19:44 +0200, Arnd Bergmann wrote: On Wednesday 13 October 2010 18:17:03 Daniel Walker wrote: I think you would be much better off making it a hvc driver, where you just need to provide a read character and write character function and an optional interrupt handler

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-13 Thread Daniel Walker
On Wed, 2010-10-13 at 21:45 +0200, Arnd Bergmann wrote: On Wednesday 13 October 2010 20:08:35 Daniel Walker wrote: On Wed, 2010-10-13 at 19:44 +0200, Arnd Bergmann wrote: On Wednesday 13 October 2010 18:17:03 Daniel Walker wrote: I think you would be much better off making it a hvc

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-13 Thread Daniel Walker
On Wed, 2010-10-13 at 15:55 -0400, Nicolas Pitre wrote: I found it independently actually .. It looks like there's at least two problems. This jtag driver has a status register which flags when RX is available, and TX is possible. I'm not sure this status register fits into the model. The

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-13 Thread Daniel Walker
On Wed, 2010-10-13 at 16:27 -0400, Nicolas Pitre wrote: On Wed, 13 Oct 2010, Daniel Walker wrote: On Wed, 2010-10-13 at 15:55 -0400, Nicolas Pitre wrote: I found it independently actually .. It looks like there's at least two problems. This jtag driver has a status register which

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-13 Thread Daniel Walker
On Wed, 2010-10-13 at 16:44 -0400, Nicolas Pitre wrote: On Wed, 13 Oct 2010, Daniel Walker wrote: On Wed, 2010-10-13 at 22:10 +0200, Arnd Bergmann wrote: On Wednesday 13 October 2010 21:52:02 Daniel Walker wrote: Seriously, I don't think you need it, but if you really do, we can

Re: [PATCH] serial: DCC(JTAG) serial and console emulation support

2010-10-13 Thread Daniel Walker
On Wed, 2010-10-13 at 13:47 -0700, Daniel Walker wrote: That's what I was suggesting to Arng .. We should extend hvc to allow other major/minor devices. I mean, Arnd here.. Sorry for the typo.. Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation

[GIT PULL] MSM changes for v2.6.37

2010-10-18 Thread Daniel Walker
/kernel/dwalker/linux-msm.git msm-core Abhijeet Dharmapurikar (2): msm: irqs-8x60: interrupt map msm: 8x60: setup correct handlers for private interrupts Daniel Walker (2): msm: dma: add stub functions for dma features not yet present on 8x60 msm: allow uart to be conditionally

[RFC PATCH] arm: msm: moved Kconfig machine entry into mach-msm

2010-10-21 Thread Daniel Walker
Has anyone suggested this? It seems like it might reduce conflicts in the Kconfig file. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/Kconfig | 12 +--- arch/arm/mach-msm/Kconfig.base | 13 + 2 files changed, 14 insertions(+), 11 deletions

Re: [RFC PATCH] arm: msm: moved Kconfig machine entry into mach-msm

2010-10-22 Thread Daniel Walker
On Fri, 2010-10-22 at 08:49 +0100, Russell King - ARM Linux wrote: On Thu, Oct 21, 2010 at 11:37:35AM -0700, Daniel Walker wrote: Has anyone suggested this? It seems like it might reduce conflicts in the Kconfig file. How? The choice normally has one entry for each mach- directory

[PATCH 1/2] msm: fix compile failure when no debug uart is selected

2010-10-27 Thread Daniel Walker
' This fixes the compile failure by adding an ifdef to debug-macro.S that removes all the debug uart code in the case of NONE. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/include/mach/debug-macro.S |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 2/2] msm: Kconfig: drop unused config options

2010-10-27 Thread Daniel Walker
These two config options don't exist, and aren't every going to. So I simply delete them. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/Kconfig |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-msm/Kconfig b/arch/arm/mach-msm

Re: [PATCH] msm: fix debug-macro.S build failure

2010-10-28 Thread Daniel Walker
On Thu, 2010-10-28 at 17:35 +0100, Russell King - ARM Linux wrote: On Thu, Oct 28, 2010 at 09:30:13AM -0700, Daniel Walker wrote: On Wed, 2010-10-27 at 22:30 -0400, Nicolas Pitre wrote: On Wed, 27 Oct 2010, Russell King - ARM Linux wrote: +#else + .macro addruart, rx, tmp

Re: [PATCH 09/10] drivers/video/msm/mddi.c: Remove multiple KERN_level uses

2010-10-28 Thread Daniel Walker
On Mon, 2010-10-25 at 19:44 -0700, Joe Perches wrote: Signed-off-by: Joe Perches j...@perches.com --- drivers/video/msm/mddi.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/video/msm/mddi.c b/drivers/video/msm/mddi.c index 7c316c3..b66d86a 100644 ---

Re: [PATCH] msm: fix debug-macro.S build failure

2010-10-28 Thread Daniel Walker
On Thu, 2010-10-28 at 14:24 -0400, Nicolas Pitre wrote: On Thu, 28 Oct 2010, Daniel Walker wrote: This is what the function currently has, .macro addruart, rp, rv ldr \rp, =MSM_DEBUG_UART_PHYS ldr \rv, =MSM_DEBUG_UART_BASE .endm So

Re: [PATCH] msm: fix debug-macro.S build failure

2010-10-29 Thread Daniel Walker
wrote: On Thu, 28 Oct 2010, Daniel Walker wrote: This is what the function currently has, .macro addruart, rp, rv ldr \rp, =MSM_DEBUG_UART_PHYS ldr \rv, =MSM_DEBUG_UART_BASE .endm So if we have

Re: [PATCH] msm: fix debug-macro.S build failure

2010-10-29 Thread Daniel Walker
On Fri, 2010-10-29 at 23:14 +0100, Russell King - ARM Linux wrote: Your original patch is unsuitable as it leaves the values uninitialized. All I'm really concerned about is fixing the build issue during this merge window. But I'll send another patch with your suggestions added. Daniel --

Re: [PATCH] msm: fix debug-macro.S build failure

2010-10-29 Thread Daniel Walker
On Fri, 2010-10-29 at 18:17 -0400, Nicolas Pitre wrote: Could you at least comment the patch I posted for you? I didn't see anything wrong with it, not from an MSM perspective. If this fixes the issue then Russell might just merge it now. In any case, that kind of fix may perfectly well be

[PATCH -v3] msm: fix debug-macro.S build failure

2010-10-29 Thread Daniel Walker
...@arm.linux.org.uk Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/include/mach/debug-macro.S | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-msm/include/mach/debug-macro.S b/arch/arm/mach-msm/include/mach/debug-macro.S

Re: [PATCH] msm: fix debug-macro.S build failure

2010-10-29 Thread Daniel Walker
On Fri, 2010-10-29 at 18:53 -0400, Nicolas Pitre wrote: On Fri, 29 Oct 2010, Daniel Walker wrote: On Fri, 2010-10-29 at 18:17 -0400, Nicolas Pitre wrote: Could you at least comment the patch I posted for you? I didn't see anything wrong with it, not from an MSM perspective. So

[Fwd: [GIT PULL] msm fixes and msm video]

2010-10-29 Thread Daniel Walker
: Merge branch 'for-2637/i2c-all' of git://git.fluff.org/bjdooks/linux (2010-10-29 16:15:57 -0700) are available in the git repository at: git://codeaurora.org/quic/kernel/dwalker/linux-msm.git for-linus Daniel Walker (8): drivers: video: msm: fix hang on disable_irq drivers: msm

Re: [PATCHv2 1/3] ARM: Translate delay.S into (mostly) C

2010-11-03 Thread Daniel Walker
On Wed, 2010-11-03 at 16:15 -0700, Stephen Boyd wrote: On 11/03/2010 11:27 AM, Will Deacon wrote: Hi Stephen, On Thu, 2010-10-28 at 21:19 +, Stephen Boyd wrote: Nico expressed concern that fixed lpj cmdlines will break due to compiler optimizations. That doesn't seem to be the case

Re: [PATCHv2 2/3] ARM: Allow machines to override __delay()

2010-11-04 Thread Daniel Walker
On Thu, 2010-10-28 at 14:19 -0700, Stephen Boyd wrote: + +static void (*delay_fn)(unsigned long) = delay_loop; + +void set_delay_fn(void (*fn)(unsigned long)) +{ + delay_fn = fn; +} This needs to be a static inline in the header file. +/* + * loops = usecs * HZ * loops_per_jiffy /

Re: [PATCHv2 2/3] ARM: Allow machines to override __delay()

2010-11-04 Thread Daniel Walker
On Thu, 2010-11-04 at 13:58 -0700, Stephen Boyd wrote: On 11/04/2010 12:30 PM, Daniel Walker wrote: On Thu, 2010-10-28 at 14:19 -0700, Stephen Boyd wrote: + +static void (*delay_fn)(unsigned long) = delay_loop; + +void set_delay_fn(void (*fn)(unsigned long)) +{ + delay_fn = fn

Re: [PATCHv2 2/3] ARM: Allow machines to override __delay()

2010-11-05 Thread Daniel Walker
On Fri, 2010-11-05 at 14:51 -0700, Stephen Boyd wrote: On 11/04/2010 02:16 PM, Daniel Walker wrote: On Thu, 2010-11-04 at 13:58 -0700, Stephen Boyd wrote: Wouldn't that mean delay_fn needs to be exposed in the header file too? I like the fact that it's static and scoped to this file

Re: [PATCHv2 2/3] ARM: Allow machines to override __delay()

2010-11-08 Thread Daniel Walker
On Fri, 2010-11-05 at 20:36 -0700, Stephen Boyd wrote: On 11/05/2010 04:43 PM, Daniel Walker wrote: On Fri, 2010-11-05 at 14:51 -0700, Stephen Boyd wrote: Ok. Doing that increases the size of my vmlinux. $ size vmlinux.orig vmlinux.new textdata bss dec hex filename

Re: [RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

2010-11-10 Thread Daniel Walker
On Wed, 2010-11-10 at 11:23 -0800, David Brownell wrote: If absolutely necessary, I can probably dig up those emails again and re-send; better if you try to find them first, and respond. I think they're the last emails from me on these threads. These questions?

Re: [PATCH 09/14] msm: iommu: Kconfig option for cacheable page tables

2010-11-14 Thread Daniel Walker
On Fri, 2010-11-12 at 19:29 -0800, Stepan Moskovchenko wrote: +config IOMMU_PGTABLES_L2 + depends on ARCH_MSM8X60 + depends on MMU + depends on CPU_DCACHE_DISABLE=n + depends on SMP + bool Cacheable IOMMU page tables + default y + help + Allows the

Re: [PATCH 14/14] msm: iommu: Miscellaneous code cleanup

2010-11-15 Thread Daniel Walker
On Fri, 2010-11-12 at 19:30 -0800, Stepan Moskovchenko wrote: Remove some unneeded assignments and messages, restructure a failure path in iova_to_phys, and make __flush_iotlb return int in preparation for adding IOMMU clock control. Why restructure the failure path ? Daniel -- Sent by a

Re: [PATCH 1/3] msm: sirc: warning fix

2010-11-16 Thread Daniel Walker
On Fri, 2010-11-12 at 13:49 -0800, David Brown wrote: Eliminate some unreferenced variables. arch/arm/mach-msm/sirc.c:43: warning: 'save_type' defined but not used arch/arm/mach-msm/sirc.c:44: warning: 'save_polarity' defined but not used I accepted these three , but I altered the commit

Re: [PATCH 14/14] msm: iommu: Miscellaneous code cleanup

2010-11-16 Thread Daniel Walker
On Mon, 2010-11-15 at 17:16 -0800, Stepan Moskovchenko wrote: On 11/15/2010 4:25 PM, Daniel Walker wrote: On Fri, 2010-11-12 at 19:30 -0800, Stepan Moskovchenko wrote: Remove some unneeded assignments and messages, restructure a failure path in iova_to_phys, and make __flush_iotlb return

Re: [PATCH] msm: io: Export __msm_ioremap

2010-11-19 Thread Daniel Walker
On Fri, 2010-11-19 at 11:03 +0530, Pavan Kondeti wrote: Hi Daniel, On Tue, Nov 09, 2010 at 03:41:29PM +0530, Pavankumar Kondeti wrote: This is required for modules to use ioremap() Signed-off-by: Pavankumar Kondeti pkond...@codeaurora.org --- arch/arm/mach-msm/io.c |1 + 1

Re: [PATCH 3/3] msm: iommu: Rework clock logic and add IOMMU bus clock control

2010-11-23 Thread Daniel Walker
On Mon, 2010-11-22 at 19:06 -0800, Stepan Moskovchenko wrote: On 11/22/2010 3:51 PM, Daniel Walker wrote: On Fri, 2010-11-19 at 19:02 -0800, Stepan Moskovchenko wrote: Clean up the clock control code in the probe calls, and add support for controlling the clock for the IOMMU bus

Re: [PATCH v4 2/2] msm: gpio: Add irq support to v2 gpiolib.

2010-11-23 Thread Daniel Walker
On Thu, 2010-11-18 at 11:52 -0800, Gregory Bean wrote: Complete the MSM v2 gpio subsystem by adding irq_chip. It looks like your actually doing more than what stated here. Like your adding pm related structure which shouldn't be needed for just the irq_chip. more comments below,

Re: [PATCH v4 2/2] msm: gpio: Add irq support to v2 gpiolib.

2010-11-23 Thread Daniel Walker
On Tue, 2010-11-23 at 15:08 -0800, Gregory Bean wrote: +static inline void set_gpio_bits(unsigned n, void __iomem *reg) +{ + writel(readl(reg) | n, reg); +} + +static inline void clr_gpio_bits(unsigned n, void __iomem *reg) +{ + writel(readl(reg) ~n, reg); +} It seems

[PATCH] drivers: char: hvc: add arm JTAG DCC console support

2010-11-30 Thread Daniel Walker
a...@arndb.de Cc: Nicolas Pitre n...@fluxnic.net Cc: Greg Kroah-Hartman gre...@suse.de Cc: Mike Frysinger vap...@gentoo.org Signed-off-by: Daniel Walker dwal...@codeaurora.org --- drivers/char/Kconfig |9 +++ drivers/char/Makefile |1 + drivers/char/hvc_dcc.c | 133

Re: [PATCH] drivers: char: hvc: add arm JTAG DCC console support

2010-12-01 Thread Daniel Walker
On Tue, 2010-11-30 at 21:30 -0800, Stephen Boyd wrote: On 11/30/2010 11:25 AM, Daniel Walker wrote: @@ -682,6 +682,15 @@ config HVC_UDBG select HVC_DRIVER default n +config HVC_DCC + bool ARM JTAG DCC console + depends on ARM + select HVC_DRIVER

[PATCH 2/4] msm: add CLK_MINMAX to pmdh_clk

2010-12-02 Thread Daniel Walker
This adds in the CLK_MINMAX flag to the pmdh_clk since it's actual a min/max clock instead of a single frequency clock. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/devices-msm7x00.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm

Re: [PATCH 1/5] mmc: msm_sdcc: Fix possible circular locking dependency warning

2010-12-07 Thread Daniel Walker
On Tue, 2010-12-07 at 16:25 +0530, Sahitya Tummala wrote: In the context of request processing thread, data mover lock is acquired after the host lock. In another context, in the completion handler of data mover the locks are acquired in the reverse order, resulting in possible circular lock

Re: [PATCHv3 2/4] ARM: Allow machines to override __delay()

2010-12-08 Thread Daniel Walker
On Tue, 2010-12-07 at 20:38 -0800, Stephen Boyd wrote: + +static void (*delay_fn)(unsigned long) = delay_loop; + +void set_delay_fn(void (*fn)(unsigned long)) +{ + delay_fn = fn; +} + +/* + * loops = usecs * HZ * loops_per_jiffy / 100 + */ +void __delay(unsigned long loops)

Re: [PATCHv3 2/4] ARM: Allow machines to override __delay()

2010-12-08 Thread Daniel Walker
On Wed, 2010-12-08 at 12:24 -0800, Stephen Boyd wrote: On 12/08/2010 11:22 AM, Daniel Walker wrote: On Tue, 2010-12-07 at 20:38 -0800, Stephen Boyd wrote: + +static void (*delay_fn)(unsigned long) = delay_loop; + +void set_delay_fn(void (*fn)(unsigned long)) +{ + delay_fn = fn

Re: [PATCH] msm: trout: add keypad support

2010-12-09 Thread Daniel Walker
On Thu, 2010-12-09 at 14:01 -0800, Arve Hjønnevåg wrote: On Thu, Dec 9, 2010 at 9:45 AM, Daniel Walker dwal...@codeaurora.org wrote: On Thu, 2010-12-09 at 12:36 +0530, Trilok Soni wrote: +static char *keycaps = --qwerty; +#undef MODULE_PARAM_PREFIX +#define MODULE_PARAM_PREFIX

[PATCH] MAINTAINERS: update MSM git tree

2010-12-09 Thread Daniel Walker
The MSM main git tree has changed over to this new address. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1a1c27b..34d44ec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [PATCH] msm: trout: add keypad support

2010-12-10 Thread Daniel Walker
On Fri, 2010-12-10 at 13:02 +0530, Trilok Soni wrote: To support this, we need to override the input device .name and submit the patches for matrix keypad and gpio keys and let the name come through platform data. You can refer how I am doing in PM8058 keypad driver patch. ok .. But

Re: Change-Id's

2010-12-11 Thread Daniel Walker
On Sat, 2010-12-11 at 14:23 -0800, Linus Torvalds wrote: On Dec 11, 2010 7:45 AM, Daniel Walker dwal...@codeaurora.org wrote: How do people feel about Change-Id's at the end of commit messages? In general, I think the rule should be that tags are ok as long as they are useful

Re: [PATCH] msm: trout: add keypad support

2010-12-13 Thread Daniel Walker
On Fri, 2010-12-10 at 13:02 +0530, Trilok Soni wrote: Hi Daniel, On 12/10/2010 3:33 AM, Daniel Walker wrote: On Thu, 2010-12-09 at 14:01 -0800, Arve Hjønnevåg wrote: On Thu, Dec 9, 2010 at 9:45 AM, Daniel Walker dwal...@codeaurora.org wrote: On Thu, 2010-12-09 at 12:36 +0530, Trilok

[PATCH v2 1/5] msm: trout: add gpio_to_irq

2010-12-13 Thread Daniel Walker
trout has gpiolib support and interrupt support, but was missing the gpio_to_irq function. This adds that functions which should allow proper translation. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/board-trout-gpio.c |8 1 files changed, 8 insertions

[PATCH v2 2/5] msm: add CLK_MINMAX to pmdh_clk

2010-12-13 Thread Daniel Walker
This adds in the CLK_MINMAX flag to the pmdh_clk since it's actual a min/max clock instead of a single frequency clock. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/devices-msm7x00.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm

[PATCH v2 5/5] msm: initial framebuffer support

2010-12-13 Thread Daniel Walker
Initial framebuffer components. Add board-trout-panel.c as well as platform parts to enable the framebuffer. This code comes directly from Google's tree. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- arch/arm/mach-msm/Makefile|1 + arch/arm/mach-msm/board-trout-panel.c

Re: [PATCH 1/2] msm: gpiomux: Improve gpiomux interface design.

2010-12-15 Thread Daniel Walker
On Mon, 2010-12-13 at 09:02 -0800, Gregory Bean wrote: Fix the gpiomux interface by: - collapsing redundant abstractions into shared common ones - disconnecting gpiomux abstractions from particular MSM implementations - moving platform-specific details out of the common abstraction - moving

Re: [PATCH 2/7] msm: Physical offset for MSM8960

2010-12-15 Thread Daniel Walker
On Wed, 2010-12-15 at 05:55 -0800, David Brown wrote: On Wed, Dec 15, 2010 at 04:17:48PM +0300, Sergei Shtylyov wrote: On 15-12-2010 6:49, Stepan Moskovchenko wrote: Add the physical memory offset value for the Qualcomm MSM8960 chip. Signed-off-by: Stepan

Re: [PATCH 1/2] MSM: Add USB suport for QSD8x50

2010-12-15 Thread Daniel Walker
On Tue, 2010-12-14 at 09:10 +0530, Pavan Kondeti wrote: Hi Daniel, Are you talking to me? read below, On 12/8/2010 1:37 PM, Pavankumar Kondeti wrote: OTG driver takes care of putting hardware into low power mode. Hence make peripheral and host devices as children of OTG device and let

Re: [PATCH 2/7] msm: Physical offset for MSM8960

2010-12-15 Thread Daniel Walker
On Wed, 2010-12-15 at 07:38 -0800, David Brown wrote: On Wed, Dec 15, 2010 at 06:40:54AM -0800, Daniel Walker wrote: -#elif defined(CONFIG_ARCH_MSM8X60) +#elif defined(CONFIG_ARCH_MSM8X60) || defined(CONFIG_ARCH_MSM8960) I guess it's a matter of style, and what one is trying

Re: [PATCH 2/7] msm: Physical offset for MSM8960

2010-12-15 Thread Daniel Walker
On Wed, 2010-12-15 at 10:07 -0800, Steve Muckle wrote: On 12/15/10 09:55, Daniel Walker wrote: The board file is very similar, plus the ifdefs. The code differences are the io and irq's .. The naming issue and the duplication can be 8x60 and 8960 are expected to diverge over time

Re: [PATCH] hvc_dcc: Simplify assembly for v6 and v7 ARM

2010-12-20 Thread Daniel Walker
On Fri, 2010-12-17 at 21:16 -0800, Stephen Boyd wrote: The inline assembly differences for v6 vs. v7 in the hvc_dcc driver are purely optimizations. On a v7 processor, an mrc with the pc sets the condition codes to the 28-31 bits of the register being read. It just so happens that the TX/RX

[PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE

2010-12-20 Thread Daniel Walker
It's cleaner to have ifdef's consolidated in one specific area. This change pulls adds one ifdef which will swap out of the function with a stub function if the ifdef is false. Signed-off-by: Daniel Walker dwal...@codeaurora.org --- drivers/mmc/host/msm_sdcc.c | 24 +--- 1

  1   2   3   >