Re: [PATCH] EHCI: Update qTD next pointer in QH overlay region during unlink

2012-09-07 Thread Pavan Kondeti
On 9/7/2012 9:22 PM, Alan Stern wrote: On Fri, 7 Sep 2012, Pavankumar Kondeti wrote: There is a possibility of QH overlay region having reference to a stale qTD pointer during unlink. Consider an endpoint having two pending qTD before unlink process begins. The endpoint's QH queue looks

USB support for device tree

2011-11-04 Thread Pavan Kondeti
Hi I am working on adding USB device tree support for MSM platform. One of our chip set has 2 hsusb cores. The first core is configured as otg and the other core is configured in host only mode (EHCI compliant). Are the below device node names Okay? Please suggest. hsusb0-otg: usb@0xa600 {

Re: USB support for device tree

2011-11-04 Thread Pavan Kondeti
Hi On 11/4/2011 10:15 PM, Grant Likely wrote: On Fri, Nov 4, 2011 at 4:25 AM, Pavan Kondeti pkond...@codeaurora.org wrote: Hi I am working on adding USB device tree support for MSM platform. One of our chip set has 2 hsusb cores. The first core is configured as otg and the other core

Re: [RFC/PATCH] mmc: core: Kill block requests if card is removed

2011-10-12 Thread Pavan Kondeti
Hello Sujit, On 10/12/2011 1:06 PM, Sujit Reddy Thumma wrote: Kill block requests when the host knows that the card is removed from the slot and is sure that it can no longer accept any requests. Kill this silently so that the block layer don't output error messages unnecessarily.

Re: [PATCH V4 2/5] USB: OTG: msm: vote for dayatona fabric clock

2011-05-03 Thread Pavan Kondeti
Hi Sergei, On 5/3/2011 4:44 PM, Sergei Shtylyov wrote: Hello. On 03-05-2011 9:13, Pavankumar Kondeti wrote: From: Anji jonnala an...@codeaurora.org HSUSB core clock is derived from daytona fabric clock and for HSUSB operational require minimum core clock at 55MHz. Since, HSUSB cannot

Re: [PATCH V4 2/5] USB: OTG: msm: vote for dayatona fabric clock

2011-05-03 Thread Pavan Kondeti
Hi Greg, On 5/3/2011 10:45 PM, Greg KH wrote: On Tue, May 03, 2011 at 05:59:37PM +0530, Pavan Kondeti wrote: Hi Sergei, On 5/3/2011 4:44 PM, Sergei Shtylyov wrote: Hello. On 03-05-2011 9:13, Pavankumar Kondeti wrote: From: Anji jonnala an...@codeaurora.org HSUSB core clock is derived

Re: [PATCH 1/7] USB: gadget: Fix typo (s/EBUSY/-EBUSY) in ci13xxx_udc

2011-05-02 Thread Pavan Kondeti
Hi David, Thanks for your feedback. I will re-send the patch series. Thanks, Pavan On 4/29/2011 9:34 PM, David Brown wrote: On Thu, Apr 28 2011, Pavankumar Kondeti wrote: Signed-off-by: Pavankumar Kondeti pkond...@codeaurora.org It is helpful to maintains to describe second revisions of

Re: [PATCH V2 5/5] USB: OTG: msm: Add PHY suspend support for MSM8960

2011-05-02 Thread Pavan Kondeti
On 5/2/2011 5:52 PM, Sergei Shtylyov wrote: Hello. On 02-05-2011 10:36, Pavankumar Kondeti wrote: Signed-off-by: Pavankumar Kondetipkond...@codeaurora.org [...] diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c index 66a1b7c..52853fd 100644 ---

Re: [PATCH 1/5] USB: gadget: Fix unused variable warning in ci13xxx_udc

2011-04-28 Thread Pavan Kondeti
On 4/28/2011 3:31 PM, Michal Nazarewicz wrote: On Thu, 28 Apr 2011 09:58:17 +0200, Pavankumar Kondeti pkond...@codeaurora.org wrote: Signed-off-by: Pavankumar Kondeti pkond...@codeaurora.org --- drivers/usb/gadget/ci13xxx_udc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [PATCH] USB: Fix trout build failure with ci13xxx_msm gadget

2011-04-07 Thread Pavan Kondeti
On 4/5/2011 6:25 PM, Felipe Balbi wrote: On Fri, Feb 04, 2011 at 10:08:18AM +0530, Pavankumar Kondeti wrote: This patch fixes the below compilation errors. CC drivers/usb/gadget/ci13xxx_msm.o CC net/mac80211/led.o drivers/usb/gadget/ci13xxx_msm.c: In function

Re: finding out the attached device current requirement

2011-03-03 Thread Pavan Kondeti
On 3/3/2011 3:15 PM, Felipe Balbi wrote: On Thu, Mar 03, 2011 at 02:22:34PM +0530, Pavan Kondeti wrote: Hi I am adding ACA (Accessory Charger Adapter) detection support for MSM OTG driver. Battery charging spec introduced ACA to facilitate charging when acting as a host. The host does

Re: msm gadget compilation failure with trout

2011-01-30 Thread Pavan Kondeti
On 1/28/2011 10:45 PM, Daniel Walker wrote: On Fri, 2011-01-28 at 12:31 +0530, Pavan Kondeti wrote: Hi Denis, On 1/28/2011 2:56 AM, Daniel Walker wrote: On Thu, 2011-01-27 at 22:12 +0100, Denis 'GNUtoo' Carikli wrote: Hi, I've that: drivers/usb/gadget/ci13xxx_msm.c: In function

Re: [RFC 3/5] USB: gadget: OTG supplement revision 2.0 updates

2010-12-16 Thread Pavan Kondeti
On 12/15/2010 5:48 PM, Felipe Balbi wrote: Hi, On Wed, Dec 15, 2010 at 04:44:12PM +0530, Pavankumar Kondeti wrote: @@ -1047,9 +1065,10 @@ composite_unbind(struct usb_gadget *gadget) kfree(cdev-req-buf); usb_ep_free_request(gadget-ep0, cdev-req); } +

Re: [RFC 4/5] USB: EHCI: Notify HCD about HNP enabled port suspend

2010-12-16 Thread Pavan Kondeti
On 12/15/2010 5:49 PM, Felipe Balbi wrote: Hi, On Wed, Dec 15, 2010 at 04:44:13PM +0530, Pavankumar Kondeti wrote: Introduce start_hnp callback function for HCD to receive notification from EHCI core that HNP enabled port is suspended. HCD may initiate HNP or notify the same to OTG via

Re: [RFC 0/5] USB core changes for supporting OTG on MSM SoC

2010-12-16 Thread Pavan Kondeti
On 12/16/2010 3:08 AM, Alan Stern wrote: On Wed, 15 Dec 2010, Pavankumar Kondeti wrote: This patch series adds OTG 2.0 enhancements and misc changes required for supporting SRP HNP in MSM OTG driver. As these patches modify the USB core code, I would like to receive feedback before

Re: [RFC 5/5] USB: Eliminate delays involved in root hub initialization during HNP

2010-12-16 Thread Pavan Kondeti
On 12/16/2010 5:45 PM, Felipe Balbi wrote: On Thu, Dec 16, 2010 at 04:56:15PM +0530, Pavan Kondeti wrote: On 12/15/2010 5:51 PM, Felipe Balbi wrote: On Wed, Dec 15, 2010 at 04:44:14PM +0530, Pavankumar Kondeti wrote: Some USB controllers have common resources (IRQ, register address space

Re: [RFC v2 4/4] USB: Eliminate delays involved in root hub initialization during HNP

2010-12-16 Thread Pavan Kondeti
On 12/16/2010 6:37 PM, Felipe Balbi wrote: On Thu, Dec 16, 2010 at 03:39:35PM +0300, Sergei Shtylyov wrote: Hello. On 16-12-2010 14:09, Pavankumar Kondeti wrote: Some USB controllers have common resources (IRQ, register address space) for Host, Peripheral and OTG. So HCD is added only

Re: [PATCH 1/2] MSM: Add USB suport for QSD8x50

2010-12-13 Thread Pavan Kondeti
Hi Daniel, On 12/8/2010 1:37 PM, Pavankumar Kondeti wrote: OTG driver takes care of putting hardware into low power mode. Hence make peripheral and host devices as children of OTG device and let runtime PM takes care of notifying peripheral and host state to OTG device. VBUS power up and

Re: [PATCH V3 00/11] Add MSM USB controller driver

2010-12-08 Thread Pavan Kondeti
Hi All, On 12/7/2010 5:53 PM, Pavankumar Kondeti wrote: This patch series adds USB peripheral, host and OTG (role switch based on Id pin status) support for MSM SoC. The peripheral controller driver patches include splitting ci13xxx_udc into core and bus glue layers. Peripheral and Host

Re: [PATCH v2] USB: Add MSM USB Device Controller driver

2010-12-07 Thread Pavan Kondeti
Hi Matthieu, On 11/19/2010 10:46 PM, Matthieu CASTET wrote: The best way to handle this is to introduce flags in the driver. For example look at drivers/mmc/host/sdhci.c (quirk flags). But for now, let's make work msm version. We can add workaround for other controller later. Now you

Re: [RFC 1/2] USB: Notify OTG errors to user space via uevents

2010-12-06 Thread Pavan Kondeti
On 12/7/2010 8:02 AM, pkond...@codeaurora.org wrote: Hi Greg, On Mon, Dec 06, 2010 at 06:07:50PM +0530, Pavankumar Kondeti wrote: OTG specification mandates no silent failures and all errors should be reported to the user. The spec itself does not give the exact error description. But

Re: [RFC 1/2] USB: Notify OTG errors to user space via uevents

2010-12-06 Thread Pavan Kondeti
On 12/7/2010 9:20 AM, Greg KH wrote: On Mon, Dec 06, 2010 at 06:32:30PM -0800, pkond...@codeaurora.org wrote: Hi Greg, On Mon, Dec 06, 2010 at 06:07:50PM +0530, Pavankumar Kondeti wrote: OTG specification mandates no silent failures and all errors should be reported to the user. The spec

Re: [RFC 1/2] USB: Notify OTG errors to user space via uevents

2010-12-06 Thread Pavan Kondeti
On 12/7/2010 10:12 AM, Greg KH wrote: Please don't, this is NOT the way to get errors from the kernel back out to userspace, because, as you have noted, this is not how any other subsystem does it. Thanks for your feedback. Is there any other way kernel can send errors to user

Re: [PATCH v2] USB: Add MSM USB Device Controller driver

2010-11-28 Thread Pavan Kondeti
Hi Dave, On 11/28/2010 12:00 PM, David Brownell wrote: implementing specific hooks needed for MSM. I am relying on gadget_is_xxx() macro for MSM specific workarounds. NEVER DO THAT from inside controller drivers. Here we are using the macro in ci13xxx_udc core which is included by two

Re: [PATCH v2] USB: Add MSM USB Device Controller driver

2010-11-27 Thread Pavan Kondeti
On 11/19/2010 10:46 PM, Matthieu CASTET wrote: Hi, Brian Swetland a écrit : On Tue, Nov 9, 2010 at 6:54 PM, David Brownell davi...@pacbell.net wrote: --- On Tue, 11/9/10, Pavan Kondeti pkond...@codeaurora.org wrote: Hi Matthieu, This look like the arc/chipidea/mips ehci otg core. Yes

Re: [PATCH v3 1/2] msm: gpio: Add v2 gpio support to MSM SoCs.

2010-11-18 Thread Pavan Kondeti
Hi Greg, On Tue, Nov 16, 2010 at 01:38:35PM -0800, Gregory Bean wrote: Beginning with the MSM8x60, the hardware block responsible for gpio support changes. Provide gpiolib support for the new v2 architecture. Cc: Baruch Siach bar...@tkos.co.il Signed-off-by: Gregory Bean

Re: [PATCH 1/4] USB: Add MSM OTG Controller driver

2010-11-17 Thread Pavan Kondeti
On Wed, Nov 17, 2010 at 09:20:16PM -0800, Greg KH wrote: On Thu, Nov 18, 2010 at 10:30:16AM +0530, Pavan Kondeti wrote: Hi Greg, On Wed, Nov 17, 2010 at 08:16:37AM -0800, Greg KH wrote: On Wed, Nov 17, 2010 at 03:53:52PM +0530, Pavan Kondeti wrote: Hi Greg, On Tue, Nov 16

Re: [PATCH v2] USB: Add MSM USB Device Controller driver

2010-11-10 Thread Pavan Kondeti
Hi Igor, On Wed, Nov 10, 2010 at 08:47:16AM +0200, Igor Grinberg wrote: On 11/10/10 04:19, Pavan Kondeti wrote: On Tue, Nov 09, 2010 at 05:36:28PM +0200, Igor Grinberg wrote: On 11/09/10 15:52, Matthieu CASTET wrote: Hi, Pavankumar Kondeti a écrit : diff --git a/drivers/usb

Re: [PATCH v2] USB: Add MSM USB Device Controller driver

2010-11-09 Thread Pavan Kondeti
On Tue, Nov 09, 2010 at 02:36:57PM +0100, Matthieu CASTET wrote: Hi Pavan, Pavan Kondeti a écrit : On Tue, Nov 09, 2010 at 12:40:17PM +0100, Matthieu CASTET wrote: Hi Matthieu, This look like the arc/chipidea/mips ehci otg core. Yes. It is chipidea core for ARM. Why can't you reuse

Re: [PATCH v2] USB: Add MSM USB Device Controller driver

2010-11-09 Thread Pavan Kondeti
On Tue, Nov 09, 2010 at 02:52:09PM +0100, Matthieu CASTET wrote: Hi, Pavankumar Kondeti a écrit : diff --git a/drivers/usb/gadget/msm72k_udc.c b/drivers/usb/gadget/msm72k_udc.c new file mode 100644 index 000..3fa4192 --- /dev/null +++ b/drivers/usb/gadget/msm72k_udc.c + +static

Re: [PATCH v2] USB: Add MSM USB Device Controller driver

2010-11-09 Thread Pavan Kondeti
On Tue, Nov 09, 2010 at 05:36:28PM +0200, Igor Grinberg wrote: On 11/09/10 15:52, Matthieu CASTET wrote: Hi, Pavankumar Kondeti a écrit : diff --git a/drivers/usb/gadget/msm72k_udc.c b/drivers/usb/gadget/msm72k_udc.c new file mode 100644 index 000..3fa4192 --- /dev/null

Re: [PATCH 0/5] Add MSM USB Device Controller support

2010-09-01 Thread Pavan Kondeti
On Thu, Sep 02, 2010 at 12:52:43AM +0200, David Lanzendörfer wrote: Hi I tried your patchset with https://www.codeaurora.org/gitweb/quic/kernel/?p=dwalker/linux-msm.git;a=shortlog;h=refs/heads/for-next But somehow, usb networking doesnt seem to come up? O_o I'm sure, if you have tested it,