Re: [PATCH V1 1/4] scsi: ufs: query descriptor API

2014-06-03 Thread Santosh Y
: + return err; +} + +/** * ufshcd_memory_alloc - allocate memory for host memory space data structures * @hba: per adapter instance * -- 1.8.5.2 Acked-by: Santosh Y santos...@gmail.com -- ~Santosh -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm

Re: [PATCH V1 3/4] scsi: ufs: Logical Unit (LU) command queue depth

2014-06-03 Thread Santosh Y
* @data: data pointer to pass to this function * @cookie: cookie data -- 1.8.5.2 Acked-by: Santosh Y santos...@gmail.com -- ~Santosh -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH V2 1/3] scsi: ufs: Allow vendor specific initialization

2013-08-29 Thread Santosh Y
+static int ufshcd_variant_hba_init(struct ufs_hba *hba) +{ + int err = 0; + + if (!hba-vops) + goto out; + + if (hba-vops-init) { + err = hba-vops-init(hba); + if (err) + goto out; + } + +

Re: [RFC/PATCH 4/4] block: Add URGENT request notification support to CFQ scheduler

2013-07-11 Thread Santosh Y
On Thu, Jul 11, 2013 at 6:31 PM, Tanya Brokhman tlin...@codeaurora.org wrote: When the scheduler reports to the block layer that there is an urgent request pending, the device driver may decide to stop the transmission of the current request in order to handle the urgent one. This is done in

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-03 Thread Santosh Y
On Wed, Jul 3, 2013 at 9:22 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 7/2/2013 9:21 PM, Santosh Y wrote: On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 6/27/2013 4:49 PM, Santosh Y wrote: + spin_lock_irqsave(host-host_lock, flags

Re: [PATCH V2 4/4] scsi: ufs: Improve UFS fatal error handling

2013-07-03 Thread Santosh Y
+ +/** + * ufshcd_fatal_err_handler - handle fatal errors + * @work: pointer to work structure */ static void ufshcd_fatal_err_handler(struct work_struct *work) { struct ufs_hba *hba; + unsigned long flags; + u32 err_xfer = 0; + u32 err_tm = 0; + int

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-02 Thread Santosh Y
On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 6/27/2013 4:49 PM, Santosh Y wrote: + spin_lock_irqsave(host-host_lock, flags); task_req_descp = hba-utmrdl_base_addr; task_req_descp += free_slot; @@ -2353,38 +2387,39

Re: [PATCH V2 3/4] scsi: ufs: Fix device and host reset methods

2013-07-02 Thread Santosh Y
+ +/** + * ufshcd_eh_device_reset_handler - device reset handler registered to + *scsi layer. + * @cmd - SCSI command pointer + * + * Returns SUCCESS/FAILED + */ +static int ufshcd_eh_device_reset_handler(struct scsi_cmnd *cmd) +{ + struct

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-06-27 Thread Santosh Y
On Thu, Jun 13, 2013 at 8:00 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: Currently, sending Task Management (TM) command to the card might be broken in some scenarios as listed below: - If there are more than 8 TM commands the implementation returns error to the caller. Fix: Wait

Re: [PATCH 1/2] scsi: ufs: Add support for host assisted background operations

2013-06-26 Thread Santosh Y
On Thu, Jun 13, 2013 at 7:50 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: Background operations in the UFS device can be disabled by the host to reduce the response latency of transfer requests. Add support for enabling/disabling the background operations during runtime suspend/resume

Re: [PATCH 1/2] scsi: ufs: Add support for sending NOP OUT UPIU

2013-06-14 Thread Santosh Y
On Fri, Jun 14, 2013 at 1:10 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 6/13/2013 10:03 AM, Sujit Reddy Thumma wrote: static struct scsi_host_template ufshcd_driver_template = { @@ -1771,8 +2064,8 @@ int ufshcd_init(struct device *dev, struct ufs_hba **hba_handle, /*

Re: [PATCH 2/2] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-06-14 Thread Santosh Y
On Thu, Jun 13, 2013 at 10:06 AM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 6/12/2013 11:04 AM, Santosh Y wrote: /** + * ufshcd_query_request() - API for issuing query request to the device. + * @hba: ufs driver context + * @query: params for query request + * @descriptor

Re: [PATCH 2/2] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-06-11 Thread Santosh Y
/** + * ufshcd_query_request() - API for issuing query request to the device. + * @hba: ufs driver context + * @query: params for query request + * @descriptor: buffer for sending/receiving descriptor + * @retries: number of times to try executing the command + * + * All necessary

Re: [PATCH V2] scsi: ufs: Add fDeviceInit set flag during initialization

2013-05-08 Thread Santosh Y
it on Seungwon's V4 patch series and you can add my Acked-by: Santosh Y santos...@gmail.com + %s: NULL pointer hba = %p, query = %p response = %p\n, + __func__, hba, query, response); + return -EINVAL; + } + + /* +* A SCSI

Re: [PATCH V4 1/1] scsi: ufs: Add support for sending NOP OUT UPIU

2013-05-08 Thread Santosh Y
; @@ -117,6 +119,8 @@ struct ufshcd_lrb { int command_type; int task_tag; unsigned int lun; + bool intr_cmd; + struct completion *completion; }; /** Please re-base it on Seungwon's V4 patch series and you can add my Acked-by: Santosh Y santos

Re: [PATCH 1/1] scsi: ufs: Generalize UFS Interconnect Layer (UIC) command support

2013-05-02 Thread Santosh Y
-static inline void -ufshcd_send_uic_command(struct ufs_hba *hba, struct uic_command *uic_cmnd) +static int ufshcd_send_uic_command(struct ufs_hba *hba, + struct uic_command *uic_cmnd, int retries) { + int err = 0; + unsigned long flags; + + if

Re: [PATCH 1/1] scsi: ufs: Add support for sending NOP OUT UPIU

2013-05-02 Thread Santosh Y
+ +/** + * ufshcd_validate_dev_connection() - Check device connection status + * @hba: per-adapter instance + * + * Send NOP OUT UPIU and wait for NOP IN response to check whether the + * device Transport Protocol (UTP) layer is ready after a reset. + * If the UTP layer at the device side

Re: [PATCH V4] scsi: ufs: add support for query requests

2013-05-02 Thread Santosh Y
+ +/** + * ufshcd_compose_upiu - form UFS Protocol Information Unit(UPIU) + * @hba - UFS hba + * @lrb - pointer to local reference block + */ +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) +{ + u32 upiu_flags; + int ret = 0; + + switch

Re: scsi: ufs: add support for query requests

2013-04-10 Thread Santosh Y
linux-...@vger.kernel.org is for UFS filesystem. The API for submitting a query request is ufs_query_request() in ufs_core.c. This function is responsible for: This can be part of ufshcd.c which is actually the core file, no need to create a new core file for the function. + +#define

Re: scsi: ufs: add support for query requests

2013-04-10 Thread Santosh Y
This can be done inside the following if condition i.e. if (hba-query.descriptor != NULL). and change the condition to if (!hba-query.descriptor). I meant to write if (hba-query.descriptor)...:-) -- ~Santosh -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the