Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver

2011-08-03 Thread Dmitry Torokhov
On Tue, Aug 02, 2011 at 02:30:18PM +0530, Anirudh Ghayal wrote: Hi Dmitry, On 8/2/2011 12:11 PM, Dmitry Torokhov wrote: On Tue, Aug 02, 2011 at 11:57:13AM +0530, Anirudh Ghayal wrote: Yes should have been dev_err. Dmitry, would you like me to submit another patch for this? I can make

Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver

2011-08-02 Thread Anirudh Ghayal
Hi Shubhrajyoti, Thanks for the review. On 8/2/2011 11:34 AM, Shubhrajyoti Datta wrote: Hi Amy, On Tue, Aug 2, 2011 at 9:43 AM, Anirudh Ghayal agha...@codeaurora.org mailto:agha...@codeaurora.org wrote: From: Amy Maloche amalo...@codeaurora.org mailto:amalo...@codeaurora.org Add

Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver

2011-08-02 Thread Dmitry Torokhov
On Tue, Aug 02, 2011 at 11:57:13AM +0530, Anirudh Ghayal wrote: Yes should have been dev_err. Dmitry, would you like me to submit another patch for this? I can make the @work change as well. Or would you make this minor change as well. Thank you. Anirudh, I made this plus a few more

Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver

2011-08-02 Thread Anirudh Ghayal
Hi Dmitry, On 8/2/2011 12:11 PM, Dmitry Torokhov wrote: On Tue, Aug 02, 2011 at 11:57:13AM +0530, Anirudh Ghayal wrote: Yes should have been dev_err. Dmitry, would you like me to submit another patch for this? I can make the @work change as well. Or would you make this minor change as well.

[PATCH] input: misc: Add support for pm8xxx based vibrator driver

2011-08-01 Thread Anirudh Ghayal
From: Amy Maloche amalo...@codeaurora.org Add support for pm8xx based vibrator to facilitate haptics. This module uses the ff-memless framework. Cc: Dmitry Torokhov dmitry.torok...@gmail.com Signed-off-by: Amy Maloche amalo...@codeaurora.org Signed-off-by: Anirudh Ghayal agha...@codeaurora.org

Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver

2011-08-01 Thread Wanlong Gao
On 08/02/2011 12:13 PM, Anirudh Ghayal wrote: From: Amy Malocheamalo...@codeaurora.org Add support for pm8xx based vibrator to facilitate haptics. This module uses the ff-memless framework. Cc: Dmitry Torokhovdmitry.torok...@gmail.com Signed-off-by: Amy Malocheamalo...@codeaurora.org

Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver

2011-08-01 Thread Dmitry Torokhov
On Tue, Aug 02, 2011 at 12:42:43PM +0800, Wanlong Gao wrote: On 08/02/2011 12:13 PM, Anirudh Ghayal wrote: +/* + * struct pm8xxx_vib - structure to hold vibrator data + * @vib_input_dev: input device supporting force feedback + * @vwork: work structure to set the vibration parameters

Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver

2011-08-01 Thread Wanlong Gao
On 08/02/2011 01:11 PM, Dmitry Torokhov wrote: On Tue, Aug 02, 2011 at 12:42:43PM +0800, Wanlong Gao wrote: On 08/02/2011 12:13 PM, Anirudh Ghayal wrote: +/* + * struct pm8xxx_vib - structure to hold vibrator data + * @vib_input_dev: input device supporting force feedback + * @vwork: work

Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver

2011-08-01 Thread Dmitry Torokhov
On Tue, Aug 02, 2011 at 01:18:46PM +0800, Wanlong Gao wrote: On 08/02/2011 01:11 PM, Dmitry Torokhov wrote: On Tue, Aug 02, 2011 at 12:42:43PM +0800, Wanlong Gao wrote: On 08/02/2011 12:13 PM, Anirudh Ghayal wrote: +/* + * struct pm8xxx_vib - structure to hold vibrator data + *

Re: [PATCH] input: misc: Add support for pm8xxx based vibrator driver

2011-08-01 Thread Wanlong Gao
On 08/02/2011 01:26 PM, Dmitry Torokhov wrote: On Tue, Aug 02, 2011 at 01:18:46PM +0800, Wanlong Gao wrote: On 08/02/2011 01:11 PM, Dmitry Torokhov wrote: On Tue, Aug 02, 2011 at 12:42:43PM +0800, Wanlong Gao wrote: On 08/02/2011 12:13 PM, Anirudh Ghayal wrote: +/* + * struct pm8xxx_vib -