Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-17 Thread Ulf Hansson
2014-09-15 23:45 GMT+02:00 Stephen Boyd sb...@codeaurora.org: On 09/04/14 15:01, Stephen Boyd wrote: 8 From: Stephen Boyd sb...@codeaurora.org Subject: [PATCH] mmc: Consolidate emmc tuning blocks The same tuning block array exists in the dw_mmc h.c and sdhci-msm.c files. Move these

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-15 Thread Stephen Boyd
On 09/04/14 15:01, Stephen Boyd wrote: 8 From: Stephen Boyd sb...@codeaurora.org Subject: [PATCH] mmc: Consolidate emmc tuning blocks The same tuning block array exists in the dw_mmc h.c and sdhci-msm.c files. Move these into mmc.c so that they can be shared across drivers.

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-04 Thread Ulf Hansson
On 4 September 2014 07:06, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Stephen. On 09/03/2014 10:57 PM, Stephen Boyd wrote: If we're tuning on a big-endian CPU we'll never determine we properly tuned the device because we compare the data we received from the controller with a table that

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-04 Thread Stephen Boyd
On 09/04/14 03:53, Ulf Hansson wrote: On 4 September 2014 07:06, Jaehoon Chung jh80.ch...@samsung.com wrote: In dw-mmc.c, tuning_block values are same. So I think we can move these value into generic header. how about? Actually, I believe these values comes from the eMMC specification?

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-04 Thread Jaehoon Chung
On 09/05/2014 06:22 AM, Stephen Boyd wrote: On 09/04/14 03:53, Ulf Hansson wrote: On 4 September 2014 07:06, Jaehoon Chung jh80.ch...@samsung.com wrote: In dw-mmc.c, tuning_block values are same. So I think we can move these value into generic header. how about? Actually, I believe these

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-04 Thread Stephen Boyd
On 09/05, Jaehoon Chung wrote: On 09/05/2014 06:22 AM, Stephen Boyd wrote: On 09/04/14 03:53, Ulf Hansson wrote: On 4 September 2014 07:06, Jaehoon Chung jh80.ch...@samsung.com wrote: In dw-mmc.c, tuning_block values are same. So I think we can move these value into generic header. how

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-03 Thread Ulf Hansson
On 3 September 2014 01:58, Stephen Boyd sb...@codeaurora.org wrote: If we're tuning on a big-endian CPU we'll never determine we properly tuned the device because we compare the data we received from the controller with a table that assumes the CPU is little-endian. Change the table to be an

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-03 Thread Georgi Djakov
On 09/03/2014 02:58 AM, Stephen Boyd wrote: If we're tuning on a big-endian CPU we'll never determine we properly tuned the device because we compare the data we received from the controller with a table that assumes the CPU is little-endian. Change the table to be an array of bytes instead of

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-03 Thread Stephen Boyd
On 09/03, Ulf Hansson wrote: On 3 September 2014 01:58, Stephen Boyd sb...@codeaurora.org wrote: If we're tuning on a big-endian CPU we'll never determine we properly tuned the device because we compare the data we received from the controller with a table that assumes the CPU is

[PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-03 Thread Stephen Boyd
If we're tuning on a big-endian CPU we'll never determine we properly tuned the device because we compare the data we received from the controller with a table that assumes the CPU is little-endian. Change the table to be an array of bytes instead of 32-bit words so we can use memcmp() without

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-03 Thread Jaehoon Chung
Hi, Stephen. On 09/03/2014 10:57 PM, Stephen Boyd wrote: If we're tuning on a big-endian CPU we'll never determine we properly tuned the device because we compare the data we received from the controller with a table that assumes the CPU is little-endian. Change the table to be an array of

[PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-02 Thread Stephen Boyd
If we're tuning on a big-endian CPU we'll never determine we properly tuned the device because we compare the data we received from the controller with a table that assumes the CPU is little-endian. Change the table to be an array of bytes instead of 32-bit words so we can use memcmp() without