Re: [PATCH 3/3] regulator: qcom-rpm: Regulator driver for the Qualcomm RPM

2014-05-29 Thread Bjorn Andersson
On Wed, May 28, 2014 at 9:55 AM, Mark Brown broo...@kernel.org wrote: On Tue, May 27, 2014 at 10:28:41AM -0700, Bjorn Andersson wrote: +static int rpm_reg_set_voltage(struct regulator_dev *rdev, +int min_uV, int max_uV, +unsigned

Re: [PATCH 3/3] regulator: qcom-rpm: Regulator driver for the Qualcomm RPM

2014-05-29 Thread Mark Brown
On Thu, May 29, 2014 at 02:03:40PM -0700, Bjorn Andersson wrote: Please fix your mailer to word wrap at less than 80 columns so quoted text is legible. The hardware in this case is a pmic shared by all cpus in the system, so when we set the voltage, state or load of a regulator we merely

Re: [PATCH 3/3] regulator: qcom-rpm: Regulator driver for the Qualcomm RPM

2014-05-29 Thread Bjorn Andersson
On Thu, May 29, 2014 at 2:18 PM, Mark Brown broo...@kernel.org wrote: On Thu, May 29, 2014 at 02:03:40PM -0700, Bjorn Andersson wrote: Please fix your mailer to word wrap at less than 80 columns so quoted text is legible. The hardware in this case is a pmic shared by all cpus in the system,

Re: [PATCH 3/3] regulator: qcom-rpm: Regulator driver for the Qualcomm RPM

2014-05-29 Thread Mark Brown
On Thu, May 29, 2014 at 02:59:38PM -0700, Bjorn Andersson wrote: On Thu, May 29, 2014 at 2:18 PM, Mark Brown broo...@kernel.org wrote: No, this is awful and there's no way in hell that stuff like this should be implemented in a driver since there's clearly nothing at all hardware specific

Re: [PATCH 3/3] regulator: qcom-rpm: Regulator driver for the Qualcomm RPM

2014-05-28 Thread Mark Brown
On Tue, May 27, 2014 at 10:28:41AM -0700, Bjorn Andersson wrote: +static int rpm_reg_set_voltage(struct regulator_dev *rdev, +int min_uV, int max_uV, +unsigned *selector) +{ + struct qcom_rpm_reg *vreg = rdev_get_drvdata(rdev); +

[PATCH 3/3] regulator: qcom-rpm: Regulator driver for the Qualcomm RPM

2014-05-27 Thread Bjorn Andersson
Driver for regulators exposed by the Resource Power Manager (RPM) found in Qualcomm 8660, 8960 and 8064 based devices. Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- drivers/regulator/Kconfig | 12 + drivers/regulator/Makefile | 1 +