Re: [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver

2014-01-23 Thread Kumar Gala
On Jan 21, 2014, at 5:01 PM, Andy Gross agr...@codeaurora.org wrote: On Tue, Jan 21, 2014 at 09:03:43AM +0100, Arnd Bergmann wrote: On Monday 20 January 2014 16:52:45 Andy Gross wrote: +#ifdef CONFIG_OF +static const struct of_device_id bam_of_match[] = { + { .compatible =

Re: [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver

2014-01-23 Thread Andy Gross
On Thu, Jan 23, 2014 at 02:17:19PM -0600, Kumar Gala wrote: [] Thanks for the clarification. I think I'll probably do: ARCH_MSM_DT || (COMPILE_TEST ARM) Didn?t you need it to be: ARCH_MSM_DT || (COMPILE_TEST OF ARM) - k Yes. That's the version I am going with. I might

Re: [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver

2014-01-21 Thread Arnd Bergmann
On Monday 20 January 2014 16:52:45 Andy Gross wrote: +#ifdef CONFIG_OF +static const struct of_device_id bam_of_match[] = { + { .compatible = qcom,bam-v1.4.0, }, + { .compatible = qcom,bam-v1.4.1, }, + {} +}; +MODULE_DEVICE_TABLE(of, bam_of_match); +#endif Also, you

Re: [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver

2014-01-21 Thread Andy Gross
On Tue, Jan 21, 2014 at 09:03:43AM +0100, Arnd Bergmann wrote: On Monday 20 January 2014 16:52:45 Andy Gross wrote: +#ifdef CONFIG_OF +static const struct of_device_id bam_of_match[] = { + { .compatible = qcom,bam-v1.4.0, }, + { .compatible = qcom,bam-v1.4.1, },

Re: [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver

2014-01-21 Thread Arnd Bergmann
On Tuesday 21 January 2014 17:01:03 Andy Gross wrote: Thanks for the clarification. I think I'll probably do: ARCH_MSM_DT || (COMPILE_TEST ARM) The latter due to my use of writel_relaxed. Yes, looks good. Arnd -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver

2014-01-20 Thread Andy Gross
On Fri, Jan 17, 2014 at 11:49:27PM +0100, Arnd Bergmann wrote: On Friday 10 January 2014, Andy Gross wrote: +static bool bam_dma_filter(struct dma_chan *chan, void *data) +{ + struct bam_filter_args *args = data; + struct bam_chan *bchan = to_bam_chan(chan); + + if (args-dev

Re: [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver

2014-01-20 Thread Andy Gross
On Tue, Jan 14, 2014 at 11:43:48AM -0800, Stephen Boyd wrote: (Mostly nitpicks) On 01/10, Andy Gross wrote: Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller found in the MSM 8x74 platforms. Each BAM DMA device is associated with a specific on-chip

Re: [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver

2014-01-20 Thread Andy Gross
On Mon, Jan 13, 2014 at 10:31:01AM +, Shevchenko, Andriy wrote: On Fri, 2014-01-10 at 13:07 -0600, Andy Gross wrote: Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller found in the MSM 8x74 platforms. Each BAM DMA device is associated with a specific

Re: [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver

2014-01-17 Thread Arnd Bergmann
On Friday 10 January 2014, Andy Gross wrote: +static bool bam_dma_filter(struct dma_chan *chan, void *data) +{ + struct bam_filter_args *args = data; + struct bam_chan *bchan = to_bam_chan(chan); + + if (args-dev == chan-device + args-id == bchan-id) { + +

Re: [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver

2014-01-14 Thread Stephen Boyd
(Mostly nitpicks) On 01/10, Andy Gross wrote: Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller found in the MSM 8x74 platforms. Each BAM DMA device is associated with a specific on-chip peripheral. Each channel provides a uni-directional data transfer engine

Re: [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver

2014-01-13 Thread Shevchenko, Andriy
On Fri, 2014-01-10 at 13:07 -0600, Andy Gross wrote: Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller found in the MSM 8x74 platforms. Each BAM DMA device is associated with a specific on-chip peripheral. Each channel provides a uni-directional data transfer

[PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver

2014-01-10 Thread Andy Gross
Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller found in the MSM 8x74 platforms. Each BAM DMA device is associated with a specific on-chip peripheral. Each channel provides a uni-directional data transfer engine that is capable of transferring data between the