Re: [RFC 3/5] USB: gadget: OTG supplement revision 2.0 updates

2010-12-16 Thread Pavan Kondeti
On 12/15/2010 5:48 PM, Felipe Balbi wrote: Hi, On Wed, Dec 15, 2010 at 04:44:12PM +0530, Pavankumar Kondeti wrote: @@ -1047,9 +1065,10 @@ composite_unbind(struct usb_gadget *gadget) kfree(cdev-req-buf); usb_ep_free_request(gadget-ep0, cdev-req); } +

Re: [RFC 4/5] USB: EHCI: Notify HCD about HNP enabled port suspend

2010-12-16 Thread Pavan Kondeti
On 12/15/2010 5:49 PM, Felipe Balbi wrote: Hi, On Wed, Dec 15, 2010 at 04:44:13PM +0530, Pavankumar Kondeti wrote: Introduce start_hnp callback function for HCD to receive notification from EHCI core that HNP enabled port is suspended. HCD may initiate HNP or notify the same to OTG via

Re: [RFC 0/5] USB core changes for supporting OTG on MSM SoC

2010-12-16 Thread Pavan Kondeti
On 12/16/2010 3:08 AM, Alan Stern wrote: On Wed, 15 Dec 2010, Pavankumar Kondeti wrote: This patch series adds OTG 2.0 enhancements and misc changes required for supporting SRP HNP in MSM OTG driver. As these patches modify the USB core code, I would like to receive feedback before

Re: [RFC 2/5] USB: core: OTG Supplement Revision 2.0 updates

2010-12-16 Thread Felipe Balbi
Hi, On Thu, Dec 16, 2010 at 02:24:05PM +0530, Pavan Kondeti wrote: @@ -1270,6 +1283,43 @@ static int usb_resume_both(struct usb_device *udev, pm_message_t msg) return status; } +#ifdef CONFIG_USB_OTG +void usb_hnp_polling_work(struct work_struct *work) do you really need this to be

[RFC v2 0/4] USB core changes for supporting OTG on MSM SoC

2010-12-16 Thread Pavankumar Kondeti
This patch series adds OTG 2.0 enhancements and misc changes required for supporting SRP HNP in MSM OTG driver. As these patches modify the USB core code, I would like to receive feedback before posting driver patches. The driver patches are available at

[RFC v2 1/4] USB: core: OTG Supplement Revision 2.0 updates

2010-12-16 Thread Pavankumar Kondeti
OTG supplement revision 2.0 spec introduces Attach Detection Protocol (ADP) for detecting peripheral connection without applying power on VBUS. ADP is optional and is included in the OTG descriptor along with SRP and HNP. HNP polling is introduced for peripheral to notify its wish to become

[RFC v2 2/4] USB: gadget: OTG supplement revision 2.0 updates

2010-12-16 Thread Pavankumar Kondeti
Introduce otg_version field in usb_gadget struct. UDC can advertise OTG spec version compatibility by setting otg_version field appropriately. Gadget drivers fill the bcdOTG field in OTG descriptor based on UDC's OTG version. Add sysfs file for host_request and UDC returns the same when HNP

[RFC v2 4/4] USB: Eliminate delays involved in root hub initialization during HNP

2010-12-16 Thread Pavankumar Kondeti
Some USB controllers have common resources (IRQ, register address space) for Host, Peripheral and OTG. So HCD is added only before entering into Host mode. Root hub initialization is done in different steps to decrease boot up time. But this makes B-device difficult to meet HNP timings. Hence

Re: [PATCHv2] regulator: debugfs: Adding debugfs functions into regulator framework

2010-12-16 Thread Mark Brown
On Wed, Dec 15, 2010 at 05:49:05PM -0800, Brandon Leong wrote: I just noticed that you only posted this to the MSM kernel list - please always post generic patches to the relevant generic list, lkml in this case. I've CCed lkml. Allow the user to read and edit regulator information in user

Re: [RFC 5/5] USB: Eliminate delays involved in root hub initialization during HNP

2010-12-16 Thread Pavan Kondeti
On 12/16/2010 5:45 PM, Felipe Balbi wrote: On Thu, Dec 16, 2010 at 04:56:15PM +0530, Pavan Kondeti wrote: On 12/15/2010 5:51 PM, Felipe Balbi wrote: On Wed, Dec 15, 2010 at 04:44:14PM +0530, Pavankumar Kondeti wrote: Some USB controllers have common resources (IRQ, register address space) for

Re: [RFC v2 4/4] USB: Eliminate delays involved in root hub initialization during HNP

2010-12-16 Thread Pavan Kondeti
On 12/16/2010 6:37 PM, Felipe Balbi wrote: On Thu, Dec 16, 2010 at 03:39:35PM +0300, Sergei Shtylyov wrote: Hello. On 16-12-2010 14:09, Pavankumar Kondeti wrote: Some USB controllers have common resources (IRQ, register address space) for Host, Peripheral and OTG. So HCD is added only

Re: [PATCH v2] [ARM] gic: Unmask private interrupts on all cores during IRQ enable

2010-12-16 Thread Stephen Caudle
On 12/09/2010 11:24 AM, Stephen Caudle wrote: It is also unreasonable to have one core enabling the PPI on other cores where the hardware behind the interrupt may not have been initialized yet. If it is a private interrupt for a private peripheral, then only the associated CPU should be

Re: [PATCH 1/7] msm: io: I/O register definitions for MSM8960

2010-12-16 Thread David Brown
On Wed, Dec 15, 2010 at 11:37:19PM +0100, Arnd Bergmann wrote: Yes, I understand that it's hard for many reasons, but my impression is that there is a general agreement on the idea. As I said, I don't expect you to fix it all at once, but it shouldn't be too hard to take care when adding new

[PATCH 00/22] MSM clock driver updates

2010-12-16 Thread Stephen Boyd
This series of patches syncs the MSM clock code in Linus' tree with the MSM tree @ codeaurora.org. They're prepared against the msm-core tree (git://codeaurora.org/quic/kernel/davidb/linux-msm.git msm-core). * 1 - 4 are cleanups and minor additions to the existing clock driver * 5 - 6 add

[PATCH 22/22] msm: clock-8x60: Don't keep IOMMU clocks on at boot

2010-12-16 Thread Stephen Boyd
Now that the IOMMU driver properly handles its clocks we can stop keeping the clocks it requires to be on during early boot. Reviewed-by: Saravana Kannan skan...@codeaurora.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- arch/arm/mach-msm/clock-8x60.c |9 - 1 files changed,

[PATCH 21/22] msm: iommu: Rework clock logic and add IOMMU bus clock control

2010-12-16 Thread Stephen Boyd
From: Stepan Moskovchenko step...@codeaurora.org Clean up the clock control code in the probe calls, and add support for controlling the clock for the IOMMU bus interconnect. With the (proper) clock driver in place, the clock control logic in the probe function can be made much cleaner since it

[PATCH 19/22] msm: iommu: Add bus clocks to platform data

2010-12-16 Thread Stephen Boyd
From: Stepan Moskovchenko step...@codeaurora.org Add the IOMMU bus clock and the IOMMU bus interconnect clocks to the platform data for an IOMMU device. These clocks are needed to access the IOMMU registers. Signed-off-by: Stepan Moskovchenko step...@codeaurora.org Signed-off-by: Stephen Boyd

[PATCH 18/22] msm: clock: Migrate to clkdev

2010-12-16 Thread Stephen Boyd
Migrating to clkdev has several advantages: * Less code in mach-msm/clock.c * A more robust clk_get() implementation * clk_add_alias() support * clk_get_sys() support In general, this will help board authors setup clock aliases and break the dependency on device pointers in the clock

[PATCH 17/22] msm: Migrate to clock rate voting

2010-12-16 Thread Stephen Boyd
Add the appropriate clock voters and integrate clock.c with the voting driver so that voting works appropriately. Reviewed-by: Saravana Kannan skan...@codeaurora.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- arch/arm/mach-msm/clock.c | 23 +--

[PATCH 14/22] msm: clock: Support clk_set_parent() clk_ops

2010-12-16 Thread Stephen Boyd
Voting clocks are linked to the clock they vote on with a parent pointer. Implement this API for sub drivers which wish to use it. Reviewed-by: Saravana Kannan skan...@codeaurora.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- arch/arm/mach-msm/clock.c |2 ++

[PATCH 15/22] msm: clock-pcom: Add pbus specific clock ops

2010-12-16 Thread Stephen Boyd
The pbus clock always runs at half the ebi1 clock frequency. Since ebi1 clock votes are dropped when the application processor is power collapsed, the ebi1 clock is reserved for the acpuclock driver. Other drivers which have ebi1 clock requirements that are independent of application processor

[PATCH 13/22] msm: clock: Push down clock count and locking into sub drivers

2010-12-16 Thread Stephen Boyd
The clock voting code will need to call clk_set_rate() from within a spinlock so we must push down the refcount and lock into each sub driver to avoid recursive locking. Reviewed-by: Saravana Kannan skan...@codeaurora.org Signed-off-by: Stephen Boyd sb...@codeaurora.org ---

[PATCH 01/22] msm: clock: Remove unused code and definitions

2010-12-16 Thread Stephen Boyd
Remove dead code and push out clock-7x30.h and clock-pcom.h to where they are actually used. Reviewed-by: Saravana Kannan skan...@codeaurora.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- arch/arm/mach-msm/board-msm8x60.c |5 arch/arm/mach-msm/clock-pcom.c |1 +

[PATCH 02/22] msm: clock: Move debugfs code from clock.c to clock-debug.c

2010-12-16 Thread Stephen Boyd
From: Matt Wagantall ma...@codeaurora.org The clock debugfs code is large enough, and easy enough to separate, that it deserves its own file which is compiled only when CONFIG_DEBUG_FS is enabled. Also, cleanup header file #includes that are no longer required. Reviewed-by: Saravana Kannan

[PATCH 11/22] msm: clock Add debugfs interface to measure clock rates

2010-12-16 Thread Stephen Boyd
From: Matt Wagantall ma...@codeaurora.org Use the SoC's ring oscillator hardware to measure the clock rate of locally-controlled clocks. This allows for the development of more comprehensive end-to-end clock tests. A 'measure' debugfs node is created for each clock to perform the measurement and

[PATCH 10/22] msm: Move 8x60 to the real clock driver

2010-12-16 Thread Stephen Boyd
The dummy clock driver was added to make 8x60 compile due to proc_comm references in clock.c. Now that those references are gone we can compile the original clock.c with no errors and support clocks on 8x60. Reviewed-by: Saravana Kannan skan...@codeaurora.org Signed-off-by: Stephen Boyd

[PATCH 09/22] msm: clock: Remove references to clk_ops_pcom

2010-12-16 Thread Stephen Boyd
Not all devices use proc_comm. The soc_clk_set_ops() function was unused. Determining if a clock is local vs. remote is fragile when done by comparing clk_ops pointers. Instead, implement an is_local() function for all clk_ops to determine if the clock is local. Once we do this we can compile

[PATCH 06/22] msm: clock-7x30: Update clock table

2010-12-16 Thread Stephen Boyd
Mark clocks with CLK_7X30 to indicate they have the potential to be locally controllable. If it's determined at runtime that these clocks are not locally owned, revert the clocks to proc_comm control. Mark clocks with CLK_PCOM when we know that they can't be locally controlled. Reviewed-by:

[PATCH 05/22] msm: clock-7x30: Add 7x30 local clock driver

2010-12-16 Thread Stephen Boyd
From: Saravana Kannan skan...@codeaurora.org Support locally controllable clocks on the 7x30 target. Signed-off-by: Saravana Kannan skan...@codeaurora.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- arch/arm/mach-msm/Makefile |1 + arch/arm/mach-msm/clock-7x30.c | 1550

[PATCH 04/22] msm: clock: Add support for more proc_comm clocks

2010-12-16 Thread Stephen Boyd
Support the CE_CLK and CODEC_SSBI_CLK. Also add support for sdc, uart, and i2c clocks on targets which support proc_comm clocks. Reviewed-by: Saravana Kannan skan...@codeaurora.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- arch/arm/mach-msm/clock-pcom.h |4 +++-

Re: [PATCH] arm: dma-mapping: move consistent_init to early_initcall

2010-12-16 Thread Saravana Kannan
On 12 December 2010 04:58, Saravana Kannan skan...@codeaurora.org wrote: As you and James suggested, having the NS bit set by the secure world is definitely a solution that would work. But IMHO, the explicit cache flush/invalidate approach keeps the design simple and easy to maintain. That