Re: [PATCH] drivers: mmc: msm: remove clock disable in probe

2011-01-24 Thread Sahitya Tummala
On Fri, 2011-01-21 at 11:16 -0800, Saravana Kannan wrote: I will look further into this if I have time, but at this point I'm still skeptical whether this is the right fix. The reason I went from sure to skeptical is due to the deferred clock delay code in the driver. Saravana, Let me try

Re: [PATCH] drivers: mmc: msm: remove clock disable in probe

2011-01-24 Thread Saravana Kannan
On 01/24/2011 04:44 AM, Sahitya Tummala wrote: On Fri, 2011-01-21 at 11:16 -0800, Saravana Kannan wrote: I will look further into this if I have time, but at this point I'm still skeptical whether this is the right fix. The reason I went from sure to skeptical is due to the deferred clock

Re: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check

2011-01-24 Thread Daniel Walker
On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: diff --git a/arch/arm/mach-msm/include/mach/cpu.h b/arch/arm/mach-msm/include/mach/cpu.h index e1ba9db..a9481b0 100644 --- a/arch/arm/mach-msm/include/mach/cpu.h +++ b/arch/arm/mach-msm/include/mach/cpu.h @@ -24,6 +24,7 @@ #define

Re: [PATCH v2 04/11] msm: io: I/O register definitions for MSM8960

2011-01-24 Thread David Brown
On Mon, Jan 24 2011, Daniel Walker wrote: On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: +/* + * Copyright (C) 2007 Google, Inc. + * Copyright (c) 2008-2011, Code Aurora Forum. All rights reserved. + * Author: Brian Swetland swetl...@google.com Brian didn't really write this did he?

Re: [PATCH v2 04/11] msm: io: I/O register definitions for MSM8960

2011-01-24 Thread Daniel Walker
On Mon, 2011-01-24 at 13:31 -0800, David Brown wrote: On Mon, Jan 24 2011, Daniel Walker wrote: On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: +/* + * Copyright (C) 2007 Google, Inc. + * Copyright (c) 2008-2011, Code Aurora Forum. All rights reserved. + * Author: Brian Swetland

Re: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check

2011-01-24 Thread David Brown
On Mon, Jan 24 2011, Daniel Walker wrote: What do you want me to call it? #define cpu_is_97d0c886-3768-4998-8925-16f36209d0d1() I want you to call it msm8x60 .. msm8960 is not a subset of msm8x60. It's just a misleading name. It's a very different device, and needs it's own identifier.

Re: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check

2011-01-24 Thread Daniel Walker
On Mon, 2011-01-24 at 14:13 -0800, David Brown wrote: On Mon, Jan 24 2011, Daniel Walker wrote: What do you want me to call it? #define cpu_is_97d0c886-3768-4998-8925-16f36209d0d1() I want you to call it msm8x60 .. msm8960 is not a subset of msm8x60. It's just a misleading

Re: [PATCH v2 02/11] msm: Generalize timer register mappings

2011-01-24 Thread Daniel Walker
On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: + int global_offset = 0; + + if (cpu_is_msm7x01()) { + msm_clocks[MSM_CLOCK_GPT].regbase = MSM_CSR_BASE; + msm_clocks[MSM_CLOCK_DGT].regbase = MSM_CSR_BASE + 0x10; + } else if

Re: [PATCH v2 02/11] msm: Generalize timer register mappings

2011-01-24 Thread David Brown
On Mon, Jan 24 2011, Daniel Walker wrote: On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: + int global_offset = 0; + + if (cpu_is_msm7x01()) { + msm_clocks[MSM_CLOCK_GPT].regbase = MSM_CSR_BASE; + msm_clocks[MSM_CLOCK_DGT].regbase = MSM_CSR_BASE

Re: [PATCH v2 06/11] msm: irqs-8960: Interrupt map for MSM8960

2011-01-24 Thread Daniel Walker
On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: +#define INT_VGIC (GIC_PPI_START + 0) +#define INT_DEBUG_TIMER_EXP(GIC_PPI_START + 1) +#define INT_GP_TIMER_EXP (GIC_PPI_START + 2) +#define INT_GP_TIMER2_EXP

Re: [PATCH v2 06/11] msm: irqs-8960: Interrupt map for MSM8960

2011-01-24 Thread David Brown
On Mon, Jan 24 2011, Daniel Walker wrote: On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: +#define SC_AVSCPUXUP (GIC_PPI_START + 12) +#define SC_SICCPUXACGIRPTREQ (GIC_PPI_START + 13) +#define SC_SICCPUXEXTFAULTIRPTREQ

Re: [PATCH v2 02/11] msm: Generalize timer register mappings

2011-01-24 Thread David Brown
On Mon, Jan 24 2011, Daniel Walker wrote: On Mon, 2011-01-24 at 14:44 -0800, David Brown wrote: On Mon, Jan 24 2011, Daniel Walker wrote: On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: + int global_offset = 0; + + if (cpu_is_msm7x01()) { +

Re: [PATCH v2 11/11] msm: Support for the MSM8960 RUMI3 target

2011-01-24 Thread Russell King - ARM Linux
On Wed, Jan 19, 2011 at 12:25:47PM -0800, David Brown wrote: --- a/arch/arm/mach-msm/board-msm8960.c +++ b/arch/arm/mach-msm/board-msm8960.c @@ -41,6 +41,9 @@ static void __init msm8960_init_irq(void) /* Edge trigger PPIs except AVS_SVICINT and AVS_SVICINTSWDONE */

Re: [PATCH v2 05/11] msm: Physical offset for MSM8960

2011-01-24 Thread Russell King - ARM Linux
On Wed, Jan 19, 2011 at 12:25:41PM -0800, David Brown wrote: From: Stepan Moskovchenko step...@codeaurora.org Add the physical memory offset value for the Qualcomm MSM8960 chip. Signed-off-by: Stepan Moskovchenko step...@codeaurora.org Signed-off-by: David Brown dav...@codeaurora.org ---

[GIT PULL for 38-rc3] msm: sdcc driver fixes

2011-01-24 Thread David Brown
These two patches fix some problems with the MMC/SD driver for MSM chips. The first fixes a compilation error. The driver was using internal DMA apis, this fix changes it to use the proper APIs. The second patch fixes a clock enable/disable mismatch. Thanks, David Brown The following changes

Re: [PATCH v2 01/11] msm: Add CPU queries

2011-01-24 Thread Daniel Walker
On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: +#define cpu_is_msm7x01() 0 +#define cpu_is_msm7x30() 0 +#define cpu_is_qsd8x50() 0 +#define cpu_is_msm8x60() 0 Now that I look at this again, why not drop the x all together ? Daniel -- Sent by a consultant of

Re: [PATCH v2 01/11] msm: Add CPU queries

2011-01-24 Thread David Brown
On Mon, Jan 24 2011, Daniel Walker wrote: On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: +#define cpu_is_msm7x01() 0 +#define cpu_is_msm7x30() 0 +#define cpu_is_qsd8x50() 0 +#define cpu_is_msm8x60() 0 Now that I look at this again, why not drop the x all

Re: [PATCH v2 01/11] msm: Add CPU queries

2011-01-24 Thread David Brown
On Mon, Jan 24 2011, Daniel Walker wrote: On Mon, 2011-01-24 at 16:20 -0800, David Brown wrote: On Mon, Jan 24 2011, Daniel Walker wrote: On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: +#define cpu_is_msm7x01() 0 +#define cpu_is_msm7x30() 0 +#define cpu_is_qsd8x50()

Re: [PATCH] msm: serial: Add MSM8960 serial support

2011-01-24 Thread David Brown
On Fri, Jan 21 2011, Stepan Moskovchenko wrote: diff --git a/arch/arm/mach-msm/devices-msm8960.c b/arch/arm/mach-msm/devices-msm8960.c new file mode 100644 index 000..821e6d1 --- /dev/null +++ b/arch/arm/mach-msm/devices-msm8960.c @@ -0,0 +1,83 @@ +/* + * Copyright (C) 2008 Google,

[PATCH 0/4] MSM: clock debugfs and cleanups

2011-01-24 Thread Stephen Boyd
These patches were previously posted as part of a larger series. I've refreshed these against the latest msm for-next branch. They cleanup debugfs and the clock code and add support for some proc_comm clocks. Matt Wagantall (1): msm: clock: Move debugfs code from clock.c to clock-debug.c

[PATCH 2/4] msm: clock: Move debugfs code from clock.c to clock-debug.c

2011-01-24 Thread Stephen Boyd
From: Matt Wagantall ma...@codeaurora.org The clock debugfs code is large enough, and easy enough to separate, that it deserves its own file which is compiled only when CONFIG_DEBUG_FS is enabled. Also, cleanup header file #includes that are no longer required. Reviewed-by: Saravana Kannan

[PATCH 4/4] msm: clock: Add support for more proc_comm clocks

2011-01-24 Thread Stephen Boyd
Support the CE_CLK and CODEC_SSBI_CLK. Also add support for uart, and i2c clocks on targets which support proc_comm clocks. Reviewed-by: Saravana Kannan skan...@codeaurora.org Signed-off-by: Stephen Boyd sb...@codeaurora.org --- arch/arm/mach-msm/clock-pcom.h |4 +++-

[QUERY] Download calibration data to co-processor

2011-01-24 Thread Patrick Lai
Hi, I am looking for ways to download audio calibration data to a co-processor under ALSA framework. I would like to know if there is already a precedent which handles this use case. I considered request_firmware() approach but there are few drawbacks to this approach. The audio calibration