Re: [PATCH V7 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-12-17 Thread Sinan Kaya
On 12/11/2015 4:35 AM, Vinod Koul wrote: > On Thu, Dec 10, 2015 at 03:10:48PM -0500, Sinan Kaya wrote: >> On 12/5/2015 3:00 AM, Vinod Koul wrote: >>> On Wed, Dec 02, 2015 at 02:04:05PM -0500, Sinan Kaya wrote: >>> You are missing the point. Channel can be paused, yes but the descriptor >>>

Re: [PATCH V7 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-12-11 Thread Vinod Koul
On Thu, Dec 10, 2015 at 03:10:48PM -0500, Sinan Kaya wrote: > On 12/5/2015 3:00 AM, Vinod Koul wrote: > > On Wed, Dec 02, 2015 at 02:04:05PM -0500, Sinan Kaya wrote: > > You are missing the point. Channel can be paused, yes but the descriptor > > is in queue and is not paused. The

Re: [PATCH V7 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-12-10 Thread Sinan Kaya
On 12/5/2015 3:00 AM, Vinod Koul wrote: > On Wed, Dec 02, 2015 at 02:04:05PM -0500, Sinan Kaya wrote: > You are missing the point. Channel can be paused, yes but the descriptor > is in queue and is not paused. The descriptor running is paused, yes. > There is subtle difference between

Re: [PATCH V7 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-12-08 Thread Sinan Kaya
On 12/5/2015 3:00 AM, Vinod Koul wrote: > On Wed, Dec 02, 2015 at 02:04:05PM -0500, Sinan Kaya wrote: > You are missing the point. Channel can be paused, yes but the descriptor > is in queue and is not paused. The descriptor running is paused, yes. > There is subtle difference between

Re: [PATCH V7 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-12-04 Thread Vinod Koul
On Wed, Dec 02, 2015 at 02:04:05PM -0500, Sinan Kaya wrote: > >> > You are missing the point. Channel can be paused, yes but the descriptor > >> > is in queue and is not paused. The descriptor running is paused, yes. > >> > There is subtle difference between these > > I'll follow your

Re: [PATCH V7 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-12-02 Thread Sinan Kaya
On 12/1/2015 4:16 PM, Sinan Kaya wrote: >>> > +static enum dma_status hidma_tx_status(struct dma_chan *dmach, > +dma_cookie_t cookie, struct dma_tx_state > *txstate) > +{ > +struct hidma_chan *mchan = to_hidma_chan(dmach);

Re: [PATCH V7 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-12-01 Thread Sinan Kaya
On 12/1/2015 6:34 AM, Vinod Koul wrote: > On Mon, Nov 30, 2015 at 03:06:36PM -0500, Sinan Kaya wrote: >> I have split the debugfs support from this patch to its own patch. Any >> other idea on how else you'd break the code? I can take one more step >> and separate the lower layer from the OS layer

Re: [PATCH V7 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-12-01 Thread Vinod Koul
On Mon, Nov 30, 2015 at 03:06:36PM -0500, Sinan Kaya wrote: > I have split the debugfs support from this patch to its own patch. Any > other idea on how else you'd break the code? I can take one more step > and separate the lower layer from the OS layer by using stub functions > on the initial

Re: [PATCH V7 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-11-30 Thread Sinan Kaya
On 11/30/2015 3:59 AM, Vinod Koul wrote: > On Sun, Nov 22, 2015 at 09:28:25PM -0500, Sinan Kaya wrote: >> This patch adds support for hidma engine. The driver consists >> of two logical blocks. The DMA engine interface and the >> low-level interface. The hardware only supports memcpy/memset >> and

Re: [PATCH V7 3/3] dma: add Qualcomm Technologies HIDMA channel driver

2015-11-30 Thread Vinod Koul
On Sun, Nov 22, 2015 at 09:28:25PM -0500, Sinan Kaya wrote: > This patch adds support for hidma engine. The driver consists > of two logical blocks. The DMA engine interface and the > low-level interface. The hardware only supports memcpy/memset > and this driver only support memcpy interface. HW