Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID.
On Fri, May 16, 2014 at 6:43 PM, Stephen Boyd sb...@codeaurora.org wrote: On 05/16/14 09:24, Linus Walleij wrote: On Wed, May 14, 2014 at 12:13 AM, Stephen Boyd sb...@codeaurora.org wrote: Please add a note that this id is fake in the commit text or in the code as well. You just need one of your hardware engineers to add is to one instance of some test chip round so it exists in any hardware whatsoever and it is not fake anymore... This is a bit like device tree, it's defined by the kernel community as much as by the hardware engineers and it's a little bit of back-and-forth. Sure, but hardware teams have moved on from this IP so I doubt we can even get them to put it into a test chip. In fact, the devices a generation before the ones Srini is working on (msm8660 for example) have a periph ID of 0x41180 so we need to override that ID in DT with this fake ID for things to even work. Hehe I wasn't really suggesting doing that. The point was to illustrate how fragile the border between real and fake is in these cases. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID.
On Wed, May 14, 2014 at 12:13 AM, Stephen Boyd sb...@codeaurora.org wrote: Please add a note that this id is fake in the commit text or in the code as well. You just need one of your hardware engineers to add is to one instance of some test chip round so it exists in any hardware whatsoever and it is not fake anymore... This is a bit like device tree, it's defined by the kernel community as much as by the hardware engineers and it's a little bit of back-and-forth. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID.
On 05/16/14 09:24, Linus Walleij wrote: On Wed, May 14, 2014 at 12:13 AM, Stephen Boyd sb...@codeaurora.org wrote: Please add a note that this id is fake in the commit text or in the code as well. You just need one of your hardware engineers to add is to one instance of some test chip round so it exists in any hardware whatsoever and it is not fake anymore... This is a bit like device tree, it's defined by the kernel community as much as by the hardware engineers and it's a little bit of back-and-forth. Sure, but hardware teams have moved on from this IP so I doubt we can even get them to put it into a test chip. In fact, the devices a generation before the ones Srini is working on (msm8660 for example) have a periph ID of 0x41180 so we need to override that ID in DT with this fake ID for things to even work. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID.
On 13/05/14 23:13, Stephen Boyd wrote: On 05/13, Srinivas Kandagatla wrote: Thanks Linus W, On 13/05/14 08:16, Linus Walleij wrote: On Tue, Apr 29, 2014 at 10:19 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org (...) + AMBA_VENDOR_QCOM = 0x51, Yeah it's a Q, like 0x41 is A for ARM. You could as well mention this in the commit message. Sounds good, I will fix it in next version and send it to Russell's patch tracker. Please add a note that this id is fake in the commit text or in the code as well. Sure, I will add it in commit text. -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID.
On Tue, Apr 29, 2014 at 10:19 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org (...) + AMBA_VENDOR_QCOM = 0x51, Yeah it's a Q, like 0x41 is A for ARM. You could as well mention this in the commit message. And you can probably just put this patch into Russell's patch tracker already. Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID.
Thanks Linus W, On 13/05/14 08:16, Linus Walleij wrote: On Tue, Apr 29, 2014 at 10:19 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org (...) + AMBA_VENDOR_QCOM = 0x51, Yeah it's a Q, like 0x41 is A for ARM. You could as well mention this in the commit message. Sounds good, I will fix it in next version and send it to Russell's patch tracker. --srini And you can probably just put this patch into Russell's patch tracker already. Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 01/11] ARM: amba: Add Qualcomm vendor ID.
On 05/13, Srinivas Kandagatla wrote: Thanks Linus W, On 13/05/14 08:16, Linus Walleij wrote: On Tue, Apr 29, 2014 at 10:19 AM, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org (...) + AMBA_VENDOR_QCOM = 0x51, Yeah it's a Q, like 0x41 is A for ARM. You could as well mention this in the commit message. Sounds good, I will fix it in next version and send it to Russell's patch tracker. Please add a note that this id is fake in the commit text or in the code as well. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line unsubscribe linux-arm-msm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
