[RESEND PATCH 2/2] MIPS syscall auditing patches

2014-04-02 Thread Manuel Lauss
From: Ralf Baechle r...@linux-mips.org These are the userland patches to go along with the recently posted kernel patches. Many of the comments posted along with those also apply here, in particular wrt. to the ABI situation. Signed-off-by: Ralf Baechle r...@linux-mips.org -- mlau: Rediffed

[RESEND PATCH 1/2] MIPS syscall auditing patches

2014-04-02 Thread Manuel Lauss
From: Ralf Baechle r...@linux-mips.org this is the first cut of the MIPS auditing patches. MIPS doesn't quite fit into the existing pattern of other architectures and I'd appreciate your comments and maybe even an Acked-by. - MIPS syscalls return a success / error flag in register $7. If the

[RESEND PATCH 0/2] MIPS syscall auditing patches

2014-04-02 Thread Manuel Lauss
From: Ralf Baechle r...@linux-mips.org Hello, This is a resend of the syscall auditing patches for MIPS, as sent by Ralf Baechle almost 3 years ago [1]. I've rediffed them against latest linux kernels and audit userland trunk. Here's what Ralf said then: This is the first cut of the MIPS

Re: [RESEND PATCH 1/2] MIPS syscall auditing patches

2014-04-02 Thread Richard Guy Briggs
On 14/04/02, Manuel Lauss wrote: From: Ralf Baechle r...@linux-mips.org this is the first cut of the MIPS auditing patches. MIPS doesn't quite fit into the existing pattern of other architectures and I'd appreciate your comments and maybe even an Acked-by. - MIPS syscalls return a

[PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Richard Guy Briggs
When task-comm is passed directly to audit_log_untrustedstring() without getting a copy or using the task_lock, there is a race that could happen that would output a NULL (\0) in the output string that would effectively truncate the rest of the report text after the comm= field in the audit,

Re: [PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Mimi Zohar
On Wed, 2014-04-02 at 12:19 -0400, Richard Guy Briggs wrote: When task-comm is passed directly to audit_log_untrustedstring() without getting a copy or using the task_lock, there is a race that could happen that would output a NULL (\0) in the output string that would effectively truncate the

Re: [PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Steve Grubb
Hello Mimi, On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote: This change is already being upstreamed as commit 73a6b44 Integrity: Pass commname via get_task_comm(). While I was looking at Richard's patch, I noticed a few places where cause and op are logged and the string isn't tied

Re: [PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Mimi Zohar
On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb wrote: Hello Mimi, On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote: This change is already being upstreamed as commit 73a6b44 Integrity: Pass commname via get_task_comm(). While I was looking at Richard's patch, I noticed a few

Re: [PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Eric Paris
On Wed, 2014-04-02 at 14:12 -0400, Mimi Zohar wrote: On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb wrote: Hello Mimi, On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote: This change is already being upstreamed as commit 73a6b44 Integrity: Pass commname via get_task_comm().

Re: [PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Mimi Zohar
On Wed, 2014-04-02 at 14:18 -0400, Eric Paris wrote: On Wed, 2014-04-02 at 14:12 -0400, Mimi Zohar wrote: On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb wrote: Hello Mimi, On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote: This change is already being upstreamed as

oraphaned keywords in audit log text [was: Re: [PATCH] integrity: get comm using lock to avoid race in string] printing

2014-04-02 Thread Richard Guy Briggs
On 14/04/02, Mimi Zohar wrote: On Wed, 2014-04-02 at 14:18 -0400, Eric Paris wrote: On Wed, 2014-04-02 at 14:12 -0400, Mimi Zohar wrote: On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb wrote: Hello Mimi, On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote: This

Re: [PATCH] integrity: get comm using lock to avoid race in string printing

2014-04-02 Thread Richard Guy Briggs
On 14/04/02, Mimi Zohar wrote: On Wed, 2014-04-02 at 12:19 -0400, Richard Guy Briggs wrote: When task-comm is passed directly to audit_log_untrustedstring() without getting a copy or using the task_lock, there is a race that could happen that would output a NULL (\0) in the output