[PATCH AUTOSEL 5.7 115/274] audit: fix a net reference leak in audit_list_rules_send()

2020-06-08 Thread Sasha Levin
From: Paul Moore [ Upstream commit 3054d06719079388a543de6adb812638675ad8f5 ] If audit_list_rules_send() fails when trying to create a new thread to send the rules it also fails to cleanup properly, leaking a reference to a net structure. This patch fixes the error patch and renames

[PATCH AUTOSEL 4.19 042/106] audit: fix a net reference leak in audit_list_rules_send()

2020-06-08 Thread Sasha Levin
From: Paul Moore [ Upstream commit 3054d06719079388a543de6adb812638675ad8f5 ] If audit_list_rules_send() fails when trying to create a new thread to send the rules it also fails to cleanup properly, leaking a reference to a net structure. This patch fixes the error patch and renames

[PATCH AUTOSEL 4.14 33/72] audit: fix a net reference leak in audit_list_rules_send()

2020-06-08 Thread Sasha Levin
From: Paul Moore [ Upstream commit 3054d06719079388a543de6adb812638675ad8f5 ] If audit_list_rules_send() fails when trying to create a new thread to send the rules it also fails to cleanup properly, leaking a reference to a net structure. This patch fixes the error patch and renames

[PATCH AUTOSEL 5.4 079/175] audit: fix a net reference leak in audit_list_rules_send()

2020-06-08 Thread Sasha Levin
From: Paul Moore [ Upstream commit 3054d06719079388a543de6adb812638675ad8f5 ] If audit_list_rules_send() fails when trying to create a new thread to send the rules it also fails to cleanup properly, leaking a reference to a net structure. This patch fixes the error patch and renames

[PATCH AUTOSEL 4.19 037/106] audit: fix a net reference leak in audit_send_reply()

2020-06-08 Thread Sasha Levin
From: Paul Moore [ Upstream commit a48b284b403a4a073d8beb72d2bb33e54df67fb6 ] If audit_send_reply() fails when trying to create a new thread to send the reply it also fails to cleanup properly, leaking a reference to a net structure. This patch fixes the error path and makes a handful of other

[PATCH AUTOSEL 5.7 107/274] audit: fix a net reference leak in audit_send_reply()

2020-06-08 Thread Sasha Levin
From: Paul Moore [ Upstream commit a48b284b403a4a073d8beb72d2bb33e54df67fb6 ] If audit_send_reply() fails when trying to create a new thread to send the reply it also fails to cleanup properly, leaking a reference to a net structure. This patch fixes the error path and makes a handful of other

[PATCH AUTOSEL 4.14 29/72] audit: fix a net reference leak in audit_send_reply()

2020-06-08 Thread Sasha Levin
From: Paul Moore [ Upstream commit a48b284b403a4a073d8beb72d2bb33e54df67fb6 ] If audit_send_reply() fails when trying to create a new thread to send the reply it also fails to cleanup properly, leaking a reference to a net structure. This patch fixes the error path and makes a handful of other

[PATCH AUTOSEL 5.4 073/175] audit: fix a net reference leak in audit_send_reply()

2020-06-08 Thread Sasha Levin
From: Paul Moore [ Upstream commit a48b284b403a4a073d8beb72d2bb33e54df67fb6 ] If audit_send_reply() fails when trying to create a new thread to send the reply it also fails to cleanup properly, leaking a reference to a net structure. This patch fixes the error path and makes a handful of other

[PATCH v3] IMA: Add audit log for failure conditions

2020-06-08 Thread Lakshmi Ramasubramanian
The final log statement in process_buffer_measurement() for failure condition is at debug level. This does not log the message unless the system log level is raised which would significantly increase the messages in the system log. Change this log message to an audit message for better triaging

Re: [PATCH v2] IMA: Add audit log for failure conditions

2020-06-08 Thread Paul Moore
On Mon, Jun 8, 2020 at 7:52 AM Mimi Zohar wrote: > Hi Lakshmi, > > On Sun, 2020-06-07 at 15:14 -0700, Lakshmi Ramasubramanian wrote: > > The final log statement in process_buffer_measurement() for failure > > condition is at debug level. This does not log the message unless > > the system log

Re: [PATCH ghak90 V8 07/16] audit: add contid support for signalling the audit daemon

2020-06-08 Thread Richard Guy Briggs
On 2020-04-22 13:24, Paul Moore wrote: > On Fri, Apr 17, 2020 at 6:26 PM Eric W. Biederman > wrote: > > Paul Moore writes: > > > On Thu, Apr 16, 2020 at 4:36 PM Eric W. Biederman > > > wrote: > > >> Paul Moore writes: > > >> > On Mon, Mar 30, 2020 at 1:49 PM Richard Guy Briggs > > >> >

Re: [PATCH v2] semanage: handle getprotobyname() failure case

2020-06-08 Thread Stephen Smalley
On Fri, Jun 5, 2020 at 4:24 AM Topi Miettinen wrote: > > At least on Debian, /etc/protocols, which is used by > socket.getprotobyname() to resolve protocols to names, does not > contain an entry for "ipv4". In that case, set the protocol number > used by audit logs for "ipv4" to a fixed value. To

Re: result logged in integrity audit message

2020-06-08 Thread Mimi Zohar
Hi Lakshmi, On Fri, 2020-06-05 at 20:13 -0700, Lakshmi Ramasubramanian wrote: > Hi Mimi, > > In integrity audit message function the inverse of "result" is being > logged for "res=". Please see below. Is this intentional? > > void integrity_audit_msg(int audit_msgno, struct inode *inode, >

Re: result logged in integrity audit message

2020-06-08 Thread Lakshmi Ramasubramanian
On 6/6/20 6:51 PM, Mimi Zohar wrote: Hi Lakshmi, The commit message provides an explanation.  Look at b0d5de4d5880 ("IMA: fix audit res field to indicate 1 for success and 0 for failure"). Thanks for the info Mimi. If this function logs the "result" parameter as passed by the caller, the

Re: [PATCH v2] IMA: Add audit log for failure conditions

2020-06-08 Thread Mimi Zohar
Hi Lakshmi, On Sun, 2020-06-07 at 15:14 -0700, Lakshmi Ramasubramanian wrote: > The final log statement in process_buffer_measurement() for failure > condition is at debug level. This does not log the message unless > the system log level is raised which would significantly increase > the

[PATCH v2] IMA: Add audit log for failure conditions

2020-06-08 Thread Lakshmi Ramasubramanian
The final log statement in process_buffer_measurement() for failure condition is at debug level. This does not log the message unless the system log level is raised which would significantly increase the messages in the system log. Change this log message to an audit message for better triaging