Re: [RFC PATCH v2 01/31] Documentation: kvx: Add basic documentation

2023-01-23 Thread Bagas Sanjaya
On Fri, Jan 20, 2023 at 03:09:32PM +0100, Yann Sionneau wrote: > Add some documentation for the kvx architecture and its Linux port. "Document the kvx Linux port. The documentation covers design decision, memory management, exception handling, and SMP." > Documentation/arch.rst |

Re: [RFC PATCH v2 31/31] kvx: Add IPI driver

2023-01-23 Thread Krzysztof Kozlowski
On 20/01/2023 15:10, Yann Sionneau wrote: > + > +int __init kvx_ipi_ctrl_probe(irqreturn_t (*ipi_irq_handler)(int, void *)) > +{ > + struct device_node *np; > + int ret; > + unsigned int ipi_irq; > + void __iomem *ipi_base; > + > + np = of_find_compatible_node(NULL, NULL, "kalra

Re: [RFC PATCH v2 27/31] kvx: Add kvx default config file

2023-01-23 Thread Krzysztof Kozlowski
On 20/01/2023 15:09, Yann Sionneau wrote: > Add a default config file for kvx based Coolidge SoC. > > Co-developed-by: Ashley Lesdalons > Signed-off-by: Ashley Lesdalons > Co-developed-by: Benjamin Mugnier > Signed-off-by: Benjamin Mugnier > Co-developed-by: Clement Leger > Signed-off-by: Cle

Re: [RFC PATCH v2 02/31] Documentation: Add binding for kalray,kv3-1-core-intc

2023-01-23 Thread Krzysztof Kozlowski
On 20/01/2023 15:09, Yann Sionneau wrote: > From: Jules Maselbas Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). > > Add documentation for `kalray,kv3-1-core-intc` binding. > > C

Re: [RFC PATCH v2 03/31] Documentation: Add binding for kalray,kv3-1-apic-gic

2023-01-23 Thread Krzysztof Kozlowski
On 20/01/2023 15:09, Yann Sionneau wrote: > From: Jules Maselbas > > Add documentation for `kalray,kv3-1-apic-gic` binding. > > Co-developed-by: Jules Maselbas > Signed-off-by: Jules Maselbas > Signed-off-by: Yann Sionneau > --- All the comments apply here and to all your other patches - wro

Re: [RFC PATCH v2 06/31] Documentation: Add binding for kalray,kv3-1-ipi-ctrl

2023-01-23 Thread Krzysztof Kozlowski
On 20/01/2023 15:09, Yann Sionneau wrote: > From: Jules Maselbas > > Add documentation for `kalray,kv3-1-ipi-ctrl` binding. > > Co-developed-by: Jules Maselbas > Signed-off-by: Jules Maselbas > Signed-off-by: Yann Sionneau > --- > > Notes: > V1 -> V2: new patch > > .../kalray/kalray,kv

Re: [RFC PATCH v2 29/31] kvx: Add support for cpuinfo

2023-01-23 Thread Krzysztof Kozlowski
On 20/01/2023 15:10, Yann Sionneau wrote: > +static int __init setup_cpuinfo(void) > +{ > + int cpu; > + struct clk *clk; > + unsigned long cpu_freq = 10; > + struct device_node *node = of_get_cpu_node(0, NULL); > + > + clk = of_clk_get(node, 0); > + if (IS_ERR(clk))

Re: [RFC PATCH v2 07/31] Documentation: Add binding for kalray,kv3-1-pwr-ctrl

2023-01-23 Thread Krzysztof Kozlowski
On 20/01/2023 15:09, Yann Sionneau wrote: > From: Jules Maselbas > > Add documentation for `kalray,kv3-1-pwr-ctrl` binding. > > Co-developed-by: Jules Maselbas > Signed-off-by: Jules Maselbas > Signed-off-by: Yann Sionneau > --- > > Notes: > V1 -> V2: new patch > > .../kalray/kalray,kv

Re: [RFC PATCH v2 20/31] kvx: Add memory management

2023-01-23 Thread Mike Rapoport
On Fri, Jan 20, 2023 at 03:09:51PM +0100, Yann Sionneau wrote: > Add memory management support for kvx, including: cache and tlb > management, page fault handling, ioremap/mmap and streaming dma support. > > Co-developed-by: Clement Leger > Signed-off-by: Clement Leger > Co-developed-by: Guillau

Re: [RFC PATCH v2 30/31] kvx: Add power controller driver

2023-01-23 Thread Krzysztof Kozlowski
On 20/01/2023 15:10, Yann Sionneau wrote: > From: Jules Maselbas > > The Power Controller (pwr-ctrl) control cores reset and wake-up > procedure. > + > +static struct device_node * __init get_pwr_ctrl_node(void) > +{ > + const phandle *ph; > + struct device_node *cpu; > + struct dev

Re: [RFC PATCH v2 05/31] Documentation: Add binding for kalray,coolidge-itgen

2023-01-23 Thread Krzysztof Kozlowski
On 20/01/2023 15:09, Yann Sionneau wrote: > From: Jules Maselbas > > Add documentation for `kalray,coolidge-itgen` binding. > > Co-developed-by: Jules Maselbas > Signed-off-by: Jules Maselbas > Signed-off-by: Yann Sionneau The same comments apply plus more... > --- > > Notes: > V1 -> V

Re: [RFC PATCH v2 01/31] Documentation: kvx: Add basic documentation

2023-01-23 Thread Mike Rapoport
Hi, While reviewing kvx-mmu.rst I've spotted several places where the documentation does not match the code, please make sure that the documentation in this patch actually reflects what the code is doing. Also, sectioning looked a bit strange to me, make sure to take a look at the generated html