Re: [PATCH] Add SELinux context and TTY name to AUDIT_TTY records

2009-03-20 Thread Paul Moore
On Friday 20 March 2009 04:53:27 am Miloslav Trmac wrote: - Paul Moore paul.mo...@hp.com wrote: There are several audit experts which should review this code but two things jumped out at me when glancing at your patch: 1. SELinux SIDs should not be recorded Almost all code that

[PATCH] Add SELinux context and TTY name to AUDIT_TTY records

2009-03-19 Thread Miloslav Trmac
From: Miloslav Trmač m...@redhat.com Add SELinux context information and TTY name (consistent with the AUDIT_SYSCALL record) to AUDIT_TTY. An example record after applying this patch: type=TTY msg=audit(1237480806.220:22): tty pid=2601 uid=0 auid=500 ses=1

Re: [PATCH] Add SELinux context and TTY name to AUDIT_TTY records

2009-03-19 Thread Paul Moore
On Thursday 19 March 2009 01:18:00 pm Miloslav Trmac wrote: From: Miloslav Trmač m...@redhat.com Add SELinux context information and TTY name (consistent with the AUDIT_SYSCALL record) to AUDIT_TTY. An example record after applying this patch: type=TTY msg=audit(1237480806.220:22): tty