Re: [patch RFC]: userspace crypto auditing, v2

2010-09-07 Thread Miloslav Trmac
Hello, Thanks for the comments. - Eric Paris epa...@redhat.com wrote: A couple functions I think you can safely drop a level of indentation include audit_log_crypto_op(), audit_filter_rules(), and maybe log_crypto_op() needs a helper function to cut down the indentation? Maybe not. Fixed

Re: [patch RFC]: userspace crypto auditing, v2

2010-09-05 Thread Eric Paris
On Wed, 2010-09-01 at 12:07 -0400, Miloslav Trmac wrote: Hello, I'm posting these patches for early review again; users of the code are not in the kernel yet. I didn't really review them but I have just 2 style comments and one thing you need to make sure of. There are a couple of places the

[patch RFC]: userspace crypto auditing, v2

2010-09-01 Thread Miloslav Trmac
Hello, I'm posting these patches for early review again; users of the code are not in the kernel yet. Changes since the previous version: - New record type CRYPTO_AUDIT_CRYPTO_KEY_VALUE, to implement basic level from CC - aureport handles events with multiple crypto records Record types