Re: Format specifier issue when building kernel

2013-11-01 Thread Richard Guy Briggs
On Thu, Oct 31, 2013 at 12:25:55PM -0700, William Roberts wrote: + if (msg_type != AUDIT_USER_TTY) { + char fmt[64]; + strcat(fmt, msg='%.); + strcat(fmt,

Re: Format specifier issue when building kernel

2013-11-01 Thread Steve Grubb
On Friday, November 01, 2013 12:24:55 PM Richard Guy Briggs wrote: On Thu, Oct 31, 2013 at 12:25:55PM -0700, William Roberts wrote: + if (msg_type != AUDIT_USER_TTY) { + char fmt[64]; + strcat(fmt,

Re: Format specifier issue when building kernel

2013-11-01 Thread Richard Guy Briggs
On Fri, Nov 01, 2013 at 12:34:55PM -0400, Steve Grubb wrote: On Friday, November 01, 2013 12:24:55 PM Richard Guy Briggs wrote: On Thu, Oct 31, 2013 at 12:25:55PM -0700, William Roberts wrote: + if (msg_type != AUDIT_USER_TTY) { + char

Re: Format specifier issue when building kernel

2013-11-01 Thread Richard Guy Briggs
On Fri, Nov 01, 2013 at 12:38:15PM -0400, Richard Guy Briggs wrote: On Fri, Nov 01, 2013 at 12:34:55PM -0400, Steve Grubb wrote: On Friday, November 01, 2013 12:24:55 PM Richard Guy Briggs wrote: On Thu, Oct 31, 2013 at 12:25:55PM -0700, William Roberts wrote: +char usermsg_format[64] = ;

Re: Format specifier issue when building kernel

2013-11-01 Thread William Roberts
On Nov 1, 2013 12:58 PM, Richard Guy Briggs r...@redhat.com wrote: On Fri, Nov 01, 2013 at 12:38:15PM -0400, Richard Guy Briggs wrote: On Fri, Nov 01, 2013 at 12:34:55PM -0400, Steve Grubb wrote: On Friday, November 01, 2013 12:24:55 PM Richard Guy Briggs wrote: On Thu, Oct 31, 2013 at

Re: Format specifier issue when building kernel

2013-11-01 Thread David Rebman
@redhat.com Subject: Re: Format specifier issue when building kernel On Nov 1, 2013 12:58 PM, Richard Guy Briggs r...@redhat.commailto:r...@redhat.com wrote: On Fri, Nov 01, 2013 at 12:38:15PM -0400, Richard Guy Briggs wrote: On Fri, Nov 01, 2013 at 12:34:55PM -0400, Steve Grubb wrote: On Friday

Re: Format specifier issue when building kernel

2013-11-01 Thread William Roberts
linux-audit@redhat.com Subject: Re: Format specifier issue when building kernel On Nov 1, 2013 12:58 PM, Richard Guy Briggs r...@redhat.com wrote: On Fri, Nov 01, 2013 at 12:38:15PM -0400, Richard Guy Briggs wrote: On Fri, Nov 01, 2013 at 12:34:55PM -0400, Steve Grubb wrote: On Friday

Re: Format specifier issue when building kernel

2013-10-31 Thread Richard Guy Briggs
On Mon, Oct 28, 2013 at 08:55:08PM -0700, William Roberts wrote: On Mon, Oct 28, 2013 at 6:43 PM, William Roberts bill.c.robe...@gmail.comwrote: On Mon, Oct 28, 2013 at 6:35 PM, Richard Guy Briggs r...@redhat.comwrote: On Mon, Oct 28, 2013 at 04:31:30PM -0700, William Roberts wrote: On

Re: Format specifier issue when building kernel

2013-10-31 Thread William Roberts
snip Ugh. That's not so easy to read... Slightly longer, how about this? diff --git a/kernel/audit.c b/kernel/audit.c index 8378c5e..3f569d1 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -824,11 +824,13 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)

Re: Format specifier issue when building kernel

2013-10-28 Thread William Roberts
On Mon, Oct 28, 2013 at 4:30 PM, William Roberts bill.c.robe...@gmail.comwrote: I've been working off of Richard Guy Brigs git repo on branch audit-for-next prepping my patch and I noticed a build warning: kernel/audit.c:832:8: warning: format ‘%A’ expects argument of type ‘double’, but

Re: Format specifier issue when building kernel

2013-10-28 Thread Richard Guy Briggs
On Mon, Oct 28, 2013 at 04:31:30PM -0700, William Roberts wrote: On Mon, Oct 28, 2013 at 4:30 PM, William Roberts bill.c.robe...@gmail.comwrote: I've been working off of Richard Guy Brigs git repo on branch audit-for-next prepping my patch and I noticed a build warning:

Re: Format specifier issue when building kernel

2013-10-28 Thread William Roberts
On Mon, Oct 28, 2013 at 6:43 PM, William Roberts bill.c.robe...@gmail.comwrote: On Mon, Oct 28, 2013 at 6:35 PM, Richard Guy Briggs r...@redhat.comwrote: On Mon, Oct 28, 2013 at 04:31:30PM -0700, William Roberts wrote: On Mon, Oct 28, 2013 at 4:30 PM, William Roberts