[PATCH 1/3] audit: fix incorrect order of log new and old feature

2013-10-31 Thread Gao feng
Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- kernel/audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/audit.c b/kernel/audit.c index 7c7c028..f16f835 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -664,7 +664,7 @@ static void

[PATCH] audit: don't generate loginuid log when audit disabled

2013-10-31 Thread Gao feng
Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- kernel/auditsc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 065c7a1..92d0e92 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c @@ -1990,6 +1990,9 @@ static void

Re: [RFC Part1 PATCH 00/20 v2] Add namespace support for audit

2013-10-31 Thread Gao feng
Hi Eric Paris, Can you give me some comments? You think the tying audit namespace to user namespace is a bad idea, so this patchset doesn't assign auditns to userns and introduce an new audit netlink type to help to create audit namespace. and this patchset also introduces an new proc interface

Re: [PATCH] audit: Add cmdline to taskinfo output

2013-10-31 Thread Steve Grubb
On Wednesday, October 30, 2013 01:18:13 PM William Roberts wrote: On Wed, Oct 30, 2013 at 12:42 PM, Steve Grubb sgr...@redhat.com wrote: Again... the comm field got cut off and now I have no idea again. Which is the same as all arches. What I'm trying to say is that all arches would

Re: [PATCH] audit: don't generate loginuid log when audit disabled

2013-10-31 Thread Steve Grubb
On Thursday, October 31, 2013 04:52:22 PM Gao feng wrote: Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- kernel/auditsc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 065c7a1..92d0e92 100644 --- a/kernel/auditsc.c +++

Re: [PATCH v2] audit: remove useless code in audit_enable

2013-10-31 Thread Richard Guy Briggs
On Thu, Oct 31, 2013 at 02:31:01PM +0800, Gao feng wrote: Since kernel parameter is operated before initcall, so the audit_initialized must be AUDIT_UNINITIALIZED or DISABLED in audit_enable. I've queued this patch. Thanks! Signed-off-by: Gao feng gaof...@cn.fujitsu.com ---

Re: [PATCH] audit: Add cmdline to taskinfo output

2013-10-31 Thread William Roberts
On Thu, Oct 31, 2013 at 7:36 AM, Steve Grubb sgr...@redhat.com wrote: On Wednesday, October 30, 2013 01:18:13 PM William Roberts wrote: On Wed, Oct 30, 2013 at 12:42 PM, Steve Grubb sgr...@redhat.com wrote: Again... the comm field got cut off and now I have no idea again. Which is

Re: [PATCH] audit: Add cmdline to taskinfo output

2013-10-31 Thread William Roberts
On Thu, Oct 31, 2013 at 8:28 AM, Richard Guy Briggs r...@redhat.com wrote: On Thu, Oct 31, 2013 at 08:24:11AM -0700, William Roberts wrote: On Thu, Oct 31, 2013 at 7:36 AM, Steve Grubb sgr...@redhat.com wrote: On Wednesday, October 30, 2013 01:18:13 PM William Roberts wrote: On Wed, Oct

[PATCH 0/4][v2] audit: Tidy up audit_context and stop bprm recursion

2013-10-31 Thread Richard Guy Briggs
This patchset is a clean up of the audit_aux_data and audit_context structures and the audit_bprm() call that was needlessly recursing, allocating more resources than necessary. Eric W. Biederman (1): audit: Kill the unused struct audit_aux_data_capset Richard Guy Briggs (3): audit: remove

[PATCH 1/4][v2] audit: Kill the unused struct audit_aux_data_capset

2013-10-31 Thread Richard Guy Briggs
From: Eric W. Biederman ebied...@xmission.com Signed-off-by: Eric W. Biederman ebied...@xmission.com (cherry picked from commit 6904431d6b41190e42d6b94430b67cb4e7e6a4b7) (cherry picked from commit 2b3a6c617396a9e6eedae9a56b2d9642da0216b6) --- kernel/auditsc.c |6 -- 1 files changed, 0

[PATCH 3/4][v2] audit: move audit_aux_data_execve contents into audit_context union

2013-10-31 Thread Richard Guy Briggs
audit_bprm() was being called to add an AUDIT_EXECVE record to the audit context every time search_binary_handler() was recursively called. Only one reference is necessary, so just update it. Move the the contents of audit_aux_data_execve into the union in audit_context, removing dependence on a

Re: [PATCH] audit: Add cmdline to taskinfo output

2013-10-31 Thread Richard Guy Briggs
On Thu, Oct 31, 2013 at 08:24:11AM -0700, William Roberts wrote: On Thu, Oct 31, 2013 at 7:36 AM, Steve Grubb sgr...@redhat.com wrote: On Wednesday, October 30, 2013 01:18:13 PM William Roberts wrote: On Wed, Oct 30, 2013 at 12:42 PM, Steve Grubb sgr...@redhat.com wrote: I have compiled

[PATCH 2/4][v2] audit: remove unused envc member of audit_aux_data_execve

2013-10-31 Thread Richard Guy Briggs
Get rid of write-only audit_aux_data_exeve structure member envc. Signed-off-by: Richard Guy Briggs r...@redhat.com --- kernel/auditsc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 24047f4..c9abaa0 100644 ---

Re: [PATCH 1/3] audit: fix incorrect order of log new and old feature

2013-10-31 Thread Eric Paris
On Thu, 2013-10-31 at 11:39 -0400, Richard Guy Briggs wrote: On Thu, Oct 31, 2013 at 04:27:56PM +0800, Gao feng wrote: Signed-off-by: Gao feng gaof...@cn.fujitsu.com Gao, Could you provide some description, justification and references for each of the patches in this patchset please?

Re: [PATCH] audit: Add cmdline to taskinfo output

2013-10-31 Thread William Roberts
On Thu, Oct 31, 2013 at 8:46 AM, Richard Guy Briggs r...@redhat.com wrote: On Thu, Oct 31, 2013 at 08:33:34AM -0700, William Roberts wrote: On Thu, Oct 31, 2013 at 8:28 AM, Richard Guy Briggs r...@redhat.com wrote: On Thu, Oct 31, 2013 at 08:24:11AM -0700, William Roberts wrote: On

Re: [PATCH] audit: Add cmdline to taskinfo output

2013-10-31 Thread William Roberts
On Thu, Oct 31, 2013 at 8:51 AM, William Roberts bill.c.robe...@gmail.comwrote: On Thu, Oct 31, 2013 at 8:46 AM, Richard Guy Briggs r...@redhat.comwrote: On Thu, Oct 31, 2013 at 08:33:34AM -0700, William Roberts wrote: On Thu, Oct 31, 2013 at 8:28 AM, Richard Guy Briggs r...@redhat.com

Re: [PATCH 3/4][v2] audit: move audit_aux_data_execve contents into audit_context union

2013-10-31 Thread Oleg Nesterov
On 10/31, Richard Guy Briggs wrote: --- a/kernel/audit.h +++ b/kernel/audit.h @@ -197,6 +197,10 @@ struct audit_context { int fd; int flags; } mmap; + struct { +

Re: Format specifier issue when building kernel

2013-10-31 Thread Richard Guy Briggs
On Mon, Oct 28, 2013 at 08:55:08PM -0700, William Roberts wrote: On Mon, Oct 28, 2013 at 6:43 PM, William Roberts bill.c.robe...@gmail.comwrote: On Mon, Oct 28, 2013 at 6:35 PM, Richard Guy Briggs r...@redhat.comwrote: On Mon, Oct 28, 2013 at 04:31:30PM -0700, William Roberts wrote: On

Re: Format specifier issue when building kernel

2013-10-31 Thread William Roberts
snip Ugh. That's not so easy to read... Slightly longer, how about this? diff --git a/kernel/audit.c b/kernel/audit.c index 8378c5e..3f569d1 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -824,11 +824,13 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)

Re: [PATCH 1/3] audit: fix incorrect order of log new and old feature

2013-10-31 Thread Gao feng
Hi Eric Richard, On 10/31/2013 11:49 PM, Eric Paris wrote: On Thu, 2013-10-31 at 11:39 -0400, Richard Guy Briggs wrote: On Thu, Oct 31, 2013 at 04:27:56PM +0800, Gao feng wrote: Signed-off-by: Gao feng gaof...@cn.fujitsu.com Gao, Could you provide some description, justification and

Re: [PATCH] audit: don't generate loginuid log when audit disabled

2013-10-31 Thread Gao feng
On 10/31/2013 10:50 PM, Steve Grubb wrote: On Thursday, October 31, 2013 04:52:22 PM Gao feng wrote: Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- kernel/auditsc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 065c7a1..92d0e92 100644

Re: [PATCH] audit: don't generate loginuid log when audit disabled

2013-10-31 Thread Steve Grubb
On Friday, November 01, 2013 08:55:03 AM Gao feng wrote: On 10/31/2013 10:50 PM, Steve Grubb wrote: On Thursday, October 31, 2013 04:52:22 PM Gao feng wrote: Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- kernel/auditsc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git