[PATCH 1/5] audit: fix incorrect order of log new and old feature

2013-11-01 Thread Gao feng
The order of new feature and old feature is incorrect, this patch fix it. Acked-by: Eric Paris epa...@redhat.com Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- kernel/audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/audit.c b/kernel/audit.c index

[PATCH 2/5] audit: don't generate audit feature changed log when audit disabled

2013-11-01 Thread Gao feng
If audit is disabled,we shouldn't generate the audit log. Acked-by: Eric Paris epa...@redhat.com Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- kernel/audit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/audit.c b/kernel/audit.c index f16f835..c307786 100644 ---

[PATCH 4/5] audit: don't generate loginuid log when audit disabled

2013-11-01 Thread Gao feng
If audit is disabled, we shouldn't generate loginuid audit log. Acked-by: Eric Paris epa...@redhat.com Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- kernel/auditsc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 065c7a1..ceb396f 100644 ---

[PATCH 5/5] audit: change the type of oldloginuid from kuid_t to unsigned long

2013-11-01 Thread Gao feng
The type of oldloginuid should be unsigned long. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- kernel/auditsc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/auditsc.c b/kernel/auditsc.c index ceb396f..9f871ad 100644 --- a/kernel/auditsc.c +++

Re: Format specifier issue when building kernel

2013-11-01 Thread Richard Guy Briggs
On Thu, Oct 31, 2013 at 12:25:55PM -0700, William Roberts wrote: + if (msg_type != AUDIT_USER_TTY) { + char fmt[64]; + strcat(fmt, msg='%.); + strcat(fmt,

Re: Format specifier issue when building kernel

2013-11-01 Thread Steve Grubb
On Friday, November 01, 2013 12:24:55 PM Richard Guy Briggs wrote: On Thu, Oct 31, 2013 at 12:25:55PM -0700, William Roberts wrote: + if (msg_type != AUDIT_USER_TTY) { + char fmt[64]; + strcat(fmt,

Re: Format specifier issue when building kernel

2013-11-01 Thread Richard Guy Briggs
On Fri, Nov 01, 2013 at 12:34:55PM -0400, Steve Grubb wrote: On Friday, November 01, 2013 12:24:55 PM Richard Guy Briggs wrote: On Thu, Oct 31, 2013 at 12:25:55PM -0700, William Roberts wrote: + if (msg_type != AUDIT_USER_TTY) { + char

Re: Format specifier issue when building kernel

2013-11-01 Thread Richard Guy Briggs
On Fri, Nov 01, 2013 at 12:38:15PM -0400, Richard Guy Briggs wrote: On Fri, Nov 01, 2013 at 12:34:55PM -0400, Steve Grubb wrote: On Friday, November 01, 2013 12:24:55 PM Richard Guy Briggs wrote: On Thu, Oct 31, 2013 at 12:25:55PM -0700, William Roberts wrote: +char usermsg_format[64] = ;

Re: Format specifier issue when building kernel

2013-11-01 Thread William Roberts
On Nov 1, 2013 12:58 PM, Richard Guy Briggs r...@redhat.com wrote: On Fri, Nov 01, 2013 at 12:38:15PM -0400, Richard Guy Briggs wrote: On Fri, Nov 01, 2013 at 12:34:55PM -0400, Steve Grubb wrote: On Friday, November 01, 2013 12:24:55 PM Richard Guy Briggs wrote: On Thu, Oct 31, 2013 at

Re: Format specifier issue when building kernel

2013-11-01 Thread David Rebman
unsubscribe From: William Roberts bill.c.robe...@gmail.commailto:bill.c.robe...@gmail.com Date: Friday, November 1, 2013 at 5:10 PM To: Richard Guy Briggs r...@redhat.commailto:r...@redhat.com Cc: linux-audit@redhat.commailto:linux-audit@redhat.com

Re: Format specifier issue when building kernel

2013-11-01 Thread William Roberts
FYI... Sending unsubscribe to this list doest work. On Nov 1, 2013 3:20 PM, David Rebman dreb...@nexuminc.com wrote: unsubscribe From: William Roberts bill.c.robe...@gmail.com Date: Friday, November 1, 2013 at 5:10 PM To: Richard Guy Briggs r...@redhat.com Cc: linux-audit@redhat.com

Re: [PATCH 5/5] audit: change the type of oldloginuid from kuid_t to unsigned long

2013-11-01 Thread Richard Guy Briggs
On Fri, Nov 01, 2013 at 07:34:46PM +0800, Gao feng wrote: The type of oldloginuid should be unsigned long. Can you say why unsigned long rather than int returned from audit_get_sessionid() or unsigned int expected by audit_log_set_loginuid()? Kees: For that matter, why does