Re: [PATCH 00/18] xfrm: Add compat layer

2018-07-27 Thread Steffen Klassert
On Thu, Jul 26, 2018 at 10:49:59AM +0200, Florian Westphal wrote: > Dmitry Safonov wrote: > > So, here I add a compatible layer to xfrm. > > As xfrm uses netlink notifications, kernel should send them in ABI > > format that an application will parse. The proposed solution is > > to save the ABI

Re: [PATCH 00/18] xfrm: Add compat layer

2018-07-27 Thread Nathan Harold
*We (Android) are very interested in removing the restriction for 32-bit userspace processes accessing xfrm netlink on 64-bit kernels. IPsec support is required to pass Android conformance tests, and any manufacturer wishing to ship 32-bit userspace with a recent kernel needs out-of-tree changes

Re: [PATCH 00/18] xfrm: Add compat layer

2018-07-27 Thread Andy Lutomirski
> On Jul 27, 2018, at 9:48 AM, Nathan Harold wrote: > > We (Android) are very interested in removing the restriction for 32-bit > userspace processes accessing xfrm netlink on 64-bit kernels. IPsec support > is required to pass Android conformance tests, and any manufacturer wishing > to

Re: [PATCH 00/18] xfrm: Add compat layer

2018-07-27 Thread Dmitry Safonov
On Fri, 2018-07-27 at 16:19 +0200, Florian Westphal wrote: > Dmitry Safonov wrote: > > 1. It will double copy netlink messages, making it O(n) instead of > > O(1), where n - is number of bind()s.. Probably we don't care much. > > About those bind() patches, I don't understand why they are

Re: [PATCH 00/18] xfrm: Add compat layer

2018-07-27 Thread Dmitry Safonov
On Fri, 2018-07-27 at 09:37 +0200, Steffen Klassert wrote: > On Thu, Jul 26, 2018 at 10:49:59AM +0200, Florian Westphal wrote: > > Dmitry Safonov wrote: > > > So, here I add a compatible layer to xfrm. > > > As xfrm uses netlink notifications, kernel should send them in > > > ABI > > > format

Re: [PATCH 00/18] xfrm: Add compat layer

2018-07-27 Thread Florian Westphal
Dmitry Safonov wrote: > 1. It will double copy netlink messages, making it O(n) instead of > O(1), where n - is number of bind()s.. Probably we don't care much. About those bind() patches, I don't understand why they are needed. Why can't you just add the compat skb to the native skb when doing

[PATCH ghak59 V2 1/6] audit: give a clue what CONFIG_CHANGE op was involved

2018-07-27 Thread Richard Guy Briggs
The failure to add an audit rule due to audit locked gives no clue what CONFIG_CHANGE operation failed. Similarly the set operation is the only other operation that doesn't give the "op=" field to indicate the action. All other CONFIG_CHANGE records include an op= field to give a clue as to what

[PATCH ghak59 V2 4/6] audit: hand taken context to audit_kill_trees for syscall logging

2018-07-27 Thread Richard Guy Briggs
Since the context is taken from the task in __audit_syscall_exit() and __audit_free(), hand it to audit_kill_trees() so it can be used to associate with a syscall record. This requires adding the context parameter to kill_rules() rather than using the current audit_context (which has been taken).

[PATCH ghak59 V2 0/6] audit: config_change normalizations and event record gathering

2018-07-27 Thread Richard Guy Briggs
Make a number of changes to normalize CONFIG_CHANGE records by adding missing op= fields, providing more information in existing op fields and connecting all records to existing audit events. The user record patch is included but is *optional* since there is doubt that we want to disconnect the

[PATCH ghak59 V2 6/6] audit: extend config_change mark/watch/tree rule changes

2018-07-27 Thread Richard Guy Briggs
Give a clue as to the source of mark, watch and tree rule changes. See: https://github.com/linux-audit/audit-kernel/issues/50 See: https://github.com/linux-audit/audit-kernel/issues/59 Signed-off-by: Richard Guy Briggs --- kernel/audit.h | 4 ++-- kernel/audit_fsnotify.c | 2 +-

[PATCH ghak59 V2 3/6] audit: exclude user records from syscall context

2018-07-27 Thread Richard Guy Briggs
Since the function audit_log_common_recv_msg() is shared by a number of AUDIT_CONFIG_CHANGE and the entire range of AUDIT_USER_* record types, and since the AUDIT_CONFIG_CHANGE message type has been converted to a syscall accompanied record type, special-case the AUDIT_USER_* range of messages so

[PATCH ghak59 V2 5/6] audit: kill trees before logging syscall exit for exit/free

2018-07-27 Thread Richard Guy Briggs
The EOE record was being issued prior to the pruning of the killed_tree list. Move the kill_trees call before the audit_log_exit call in __audit_free() and __audit_syscall_exit() so that the user library doesn't leave out any appended pruned trees CONFIG_CHANGE records due to the EOE flagging the

[PATCH ghak59 V2 2/6] audit: add syscall information to CONFIG_CHANGE records

2018-07-27 Thread Richard Guy Briggs
Tie syscall information to all CONFIG_CHANGE calls since they are all a result of user actions. See: https://github.com/linux-audit/audit-kernel/issues/59 See: https://github.com/linux-audit/audit-kernel/issues/50 Signed-off-by: Richard Guy Briggs --- kernel/audit.c | 4 ++--

unsubscribe

2018-07-27 Thread Kurt Weaver
-- Linux-audit mailing list Linux-audit@redhat.com https://www.redhat.com/mailman/listinfo/linux-audit