Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid

2013-08-26 Thread Richard Guy Briggs
On Fri, Aug 23, 2013 at 09:28:07PM +0200, Oleg Nesterov wrote: > On 08/22, Richard Guy Briggs wrote: > > > > On Thu, Aug 22, 2013 at 10:05:55PM +0200, Peter Zijlstra wrote: > > > > > > Why would you ever want to do this? It just makes these tests more > > > expensive for no gain what so ff'ing ever

Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid

2013-08-26 Thread Richard Guy Briggs
On Fri, Aug 23, 2013 at 08:36:21AM +0200, Peter Zijlstra wrote: > On Thu, Aug 22, 2013 at 05:43:47PM -0400, Richard Guy Briggs wrote: > > On Thu, Aug 22, 2013 at 10:05:55PM +0200, Peter Zijlstra wrote: > > > On Tue, Aug 20, 2013 at 05:32:03PM -0400, Richard Guy Briggs wrote: > > > > This stops thes

Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid

2013-08-26 Thread Richard Guy Briggs
On Thu, Aug 22, 2013 at 09:08:48PM +0200, Oleg Nesterov wrote: > On 08/20, Richard Guy Briggs wrote: > > > > static inline int is_global_init(struct task_struct *tsk) > > { > > - return tsk->pid == 1; > > + return task_pid_nr(tsk) == 1; > > } > > Probably it would be better to simply kill i

Re: [PATCH 11/12] pid: rewrite task helper functions avoiding task->pid and task->tgid

2013-08-26 Thread Oleg Nesterov
On 08/22, Richard Guy Briggs wrote: > > On Thu, Aug 22, 2013 at 10:05:55PM +0200, Peter Zijlstra wrote: > > > > Why would you ever want to do this? It just makes these tests more > > expensive for no gain what so ff'ing ever. > > Backups are generally considered a good idea, but in this case, I'd >