Re: [BUG][PATCH] audit: audit_log_start running on auditd should not stop

2013-10-23 Thread Gao feng
On 10/24/2013 03:55 AM, Richard Guy Briggs wrote: > On Tue, Oct 15, 2013 at 02:30:34PM +0800, Gao feng wrote: >> Hi Toshiyuki-san, > > Toshiuki and Gao, > >> On 10/15/2013 12:43 PM, Toshiyuki Okajima wrote: >>> The backlog cannot be consumed when audit_log_start is running on auditd >>> even if a

[PATCH] audit: remove useless code in audit_enable

2013-10-23 Thread Gao feng
Since kernel parameter is operated before initcall, so the audit_initialized must be AUDIT_UNINITIALIZED or DISABLED in audit_enable. Signed-off-by: Gao feng --- kernel/audit.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/kernel/audit.c b/kernel/audit.c inde

Re: [PATCH] audit: change pid to portid for audit_reply

2013-10-23 Thread Gao feng
On 10/24/2013 03:20 AM, Richard Guy Briggs wrote: > On Wed, Oct 23, 2013 at 07:25:23PM +0800, Gao feng wrote: >> The "pid" is not a suitable name for netlink port, >> change it to "portid". > > That is already in the works: > https://www.redhat.com/archives/linux-audit/2013-August/msg00023.h

[PATCH] audit: Add cmdline to taskinfo output

2013-10-23 Thread William Roberts
>From 0a8623b8f9fa625da81364cf3b87d2799171f83e Mon Sep 17 00:00:00 2001 From: William Roberts Date: Tue, 22 Oct 2013 14:23:27 -0700 Subject: [PATCH] audit: Add cmdline to taskinfo output On some devices, the cmdline and task info vary. For instance, on Android, the cmdline is set to the package n

Re: [BUG][PATCH] audit: audit_log_start running on auditd should not stop

2013-10-23 Thread Richard Guy Briggs
On Tue, Oct 15, 2013 at 02:30:34PM +0800, Gao feng wrote: > Hi Toshiyuki-san, Toshiuki and Gao, > On 10/15/2013 12:43 PM, Toshiyuki Okajima wrote: > > The backlog cannot be consumed when audit_log_start is running on auditd > > even if audit_log_start calls wait_for_auditd to consume it. > > The

Re: [PATCH] audit: change pid to portid for audit_reply

2013-10-23 Thread Richard Guy Briggs
On Wed, Oct 23, 2013 at 07:25:23PM +0800, Gao feng wrote: > The "pid" is not a suitable name for netlink port, > change it to "portid". That is already in the works: https://www.redhat.com/archives/linux-audit/2013-August/msg00023.html https://lkml.org/lkml/2013/8/20/630 May I add

[PATCH] audit: change pid to portid for audit_reply

2013-10-23 Thread Gao feng
The "pid" is not a suitable name for netlink port, change it to "portid". more information, please see commit 15e473046cb6e5d18a4d0057e61d76315230382b Signed-off-by: Gao feng --- kernel/audit.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/kernel/audit.c b