Re: [PATCH 5/5] audit: change the type of oldloginuid from kuid_t to unsigned long

2013-11-02 Thread Gao feng
On 11/02/2013 01:00 PM, Richard Guy Briggs wrote: On Fri, Nov 01, 2013 at 07:34:46PM +0800, Gao feng wrote: The type of oldloginuid should be unsigned long. Can you say why unsigned long rather than int returned from audit_get_sessionid() or unsigned int expected by

[PATCH 5/5] audit: change the type of oldloginuid from kuid_t to unsigned long

2013-11-01 Thread Gao feng
The type of oldloginuid should be unsigned long. Signed-off-by: Gao feng gaof...@cn.fujitsu.com --- kernel/auditsc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/auditsc.c b/kernel/auditsc.c index ceb396f..9f871ad 100644 --- a/kernel/auditsc.c +++

Re: [PATCH 5/5] audit: change the type of oldloginuid from kuid_t to unsigned long

2013-11-01 Thread Richard Guy Briggs
On Fri, Nov 01, 2013 at 07:34:46PM +0800, Gao feng wrote: The type of oldloginuid should be unsigned long. Can you say why unsigned long rather than int returned from audit_get_sessionid() or unsigned int expected by audit_log_set_loginuid()? Kees: For that matter, why does