Re: [PATCH v2.1] audit: Only use the syscall slowpath when syscall audit rules exist

2014-02-04 Thread Oleg Nesterov
On 02/03, Andy Lutomirski wrote: +void audit_inc_n_rules() +{ + struct task_struct *p, *g; + unsigned long flags; + + read_lock_irqsave(tasklist_lock, flags); Confused... read_lock(tasklist) doesn't need to disable irqs. (ftrace does this for no reason too, perhaps I should

Re: [PATCH v2 1/6] audit: Enable arm64 support

2014-02-04 Thread Richard Guy Briggs
On 14/02/03, Richard Guy Briggs wrote: On 14/02/03, AKASHI Takahiro wrote: Richard, Takahiro, Takahiro, On 01/30/2014 07:36 AM, Richard Guy Briggs wrote: On 14/01/29, Richard Guy Briggs wrote: On 14/01/27, AKASHI Takahiro wrote: [To audit maintainers] On 01/23/2014 11:18 PM,

Re: [PATCH v3 2/3] arm64: Add audit support

2014-02-04 Thread Will Deacon
On Mon, Feb 03, 2014 at 06:56:29AM +, AKASHI Takahiro wrote: On AArch64, audit is supported through generic lib/audit.c and compat_audit.c, and so this patch adds arch specific definitions required. Signed-off-by: AKASHI Takahiro takahiro.aka...@linaro.org --- arch/arm64/Kconfig

Re: [PATCH v2.1] audit: Only use the syscall slowpath when syscall audit rules exist

2014-02-04 Thread Andy Lutomirski
On Tue, Feb 4, 2014 at 8:50 AM, Oleg Nesterov o...@redhat.com wrote: On 02/03, Andy Lutomirski wrote: +void audit_inc_n_rules() +{ + struct task_struct *p, *g; + unsigned long flags; + + read_lock_irqsave(tasklist_lock, flags); Confused... read_lock(tasklist) doesn't need to

Re: [PATCH v3 1/3] arm64: Add regs_return_value() in syscall.h

2014-02-04 Thread Will Deacon
On Mon, Feb 03, 2014 at 06:56:28AM +, AKASHI Takahiro wrote: This macro, regs_return_value, is used mainly for audit to record system call's results, but may also be used in test_kprobes.c. Signed-off-by: AKASHI Takahiro takahiro.aka...@linaro.org Acked-by: Will Deacon

Re: [PATCH v2.1] audit: Only use the syscall slowpath when syscall audit rules exist

2014-02-04 Thread Oleg Nesterov
On 02/04, Andy Lutomirski wrote: On Tue, Feb 4, 2014 at 8:50 AM, Oleg Nesterov o...@redhat.com wrote: On 02/03, Andy Lutomirski wrote: +void audit_inc_n_rules() +{ + struct task_struct *p, *g; + unsigned long flags; + + read_lock_irqsave(tasklist_lock, flags);

Re: [PATCH v2.1] audit: Only use the syscall slowpath when syscall audit rules exist

2014-02-04 Thread Andy Lutomirski
On Tue, Feb 4, 2014 at 11:11 AM, Oleg Nesterov o...@redhat.com wrote: On 02/04, Andy Lutomirski wrote: On Tue, Feb 4, 2014 at 8:50 AM, Oleg Nesterov o...@redhat.com wrote: On 02/03, Andy Lutomirski wrote: Sorry, forgot to mention: where is this mythical for_each_process_thread? In Linus's